feat: owner review 2 phase 5c: originals, local render, clean-up and the workspace settings #18

Merged
Alby96 merged 42 commits from review2-p5c into main 2026-11-04 20:03:58 +01:00
Owner

Owner review 2, R8, phase 5c: originals in the workspace, local render, clean-up, moving the workspace, and the full Settings › Workspace page.

What changes

  • Originals: Open in workspace offers Originals besides Proxies, for this PC's library or a server. The project menu gains Copy originals… and Proxies only…, each behind a plan. An original is deleted only once its bytes are checked against the home; otherwise it goes to the workspace's trash.
  • Local render (workspace-render, job kind 21): renders from the workspace's originals into exports/, saving a version first (Version on render). Send render (workspace-send, 22) files the render home with its project and version: into this PC's library, or to a server, which records them and refuses a mismatch (422 project_mismatch). The Export step shows Not sent with Send again.
  • Clean-up: the workspace-cleanup schedule runs daily at 04:30. It applies Clean after (30 days), then Size limit (100 GB), to projects in step with their home only, and only to their media. Removed copies and originals wait in the workspace's trash until Empty… (typed count).
  • Move the workspace (workspace-move, 23): a plan, then a rename on the same drive or a hash-verified copy across drives. A journal makes it resumable, and Resume appears in Settings. Jobs follow the project to the new folder.
  • Settings › Workspace: Folder (Change…, Move…), Size limit, Default media, Sync, Version on render, Kept versions, Clean after, Open project, Trash.
  • Pause metered transfers now also holds downloads and the workspace's server copies and sends.
  • Translations: 184 new strings in all 38 languages. Docs (DECISIONS, BRIEF, CHANGELOG, STATUS, ARCHITECTURE, request files) are updated.

Review

  • One adversarial round across six dimensions (safety, jobs, compatibility, UI, integration, tests): 35 findings, 32 confirmed and fixed (compat-2 in part), then a checker pass that fixed one more.
  • The main safety fixes:
    • originals are judged by their bytes, never by the media index;
    • trash entries are staged until whole;
    • jobs are gated during a move;
    • export paths are contained.
  • Remaining known limitations are listed in the CHANGELOG.

How to try it

  1. Install the desktop from this release (and the server image chronos-server:0.1.0-rc.11 for the server provenance).
  2. Edit › Open in workspace › Originals, then Export › Local render. The render shows Not sent until Send render files it home.
  3. Settings › Workspace: change Size limit or Clean after, try Move… to another folder, and look at Trash.

Checks

  • dotnet build -c Release: 0 warnings.
  • i18n check: 4632 keys, 38 cultures, 0 warnings. xaml-lint and package-guard OK.
  • Core, Data, Server and App suites run locally (App without the classes that hang on this PC).
  • Screenshot baselines: 8 screens recaptured on this PC (jobs-scheduled*, jobs-schedule-editor*, settings-rendering*, settings-workspace*).

🤖 Generated with Claude Code

Owner review 2, R8, phase 5c: originals in the workspace, local render, clean-up, moving the workspace, and the full Settings › Workspace page. ## What changes - **Originals:** *Open in workspace* offers *Originals* besides *Proxies*, for this PC's library or a server. The project menu gains *Copy originals…* and *Proxies only…*, each behind a plan. An original is deleted only once its bytes are checked against the home; otherwise it goes to the workspace's trash. - **Local render** (`workspace-render`, job kind 21): renders from the workspace's originals into `exports/`, saving a version first (*Version on render*). **Send render** (`workspace-send`, 22) files the render home with its project and version: into this PC's library, or to a server, which records them and refuses a mismatch (422 `project_mismatch`). The Export step shows *Not sent* with *Send again*. - **Clean-up:** the `workspace-cleanup` schedule runs daily at 04:30. It applies *Clean after* (30 days), then *Size limit* (100 GB), to projects in step with their home only, and only to their media. Removed copies and originals wait in the workspace's trash until *Empty…* (typed count). - **Move the workspace** (`workspace-move`, 23): a plan, then a rename on the same drive or a hash-verified copy across drives. A journal makes it resumable, and *Resume* appears in Settings. Jobs follow the project to the new folder. - **Settings › Workspace:** Folder (Change…, Move…), Size limit, Default media, Sync, Version on render, Kept versions, Clean after, Open project, Trash. - *Pause metered transfers* now also holds downloads and the workspace's server copies and sends. - **Translations:** 184 new strings in all 38 languages. Docs (DECISIONS, BRIEF, CHANGELOG, STATUS, ARCHITECTURE, request files) are updated. ## Review - One adversarial round across six dimensions (safety, jobs, compatibility, UI, integration, tests): 35 findings, 32 confirmed and fixed (compat-2 in part), then a checker pass that fixed one more. - The main safety fixes: - originals are judged by their bytes, never by the media index; - trash entries are staged until whole; - jobs are gated during a move; - export paths are contained. - Remaining known limitations are listed in the CHANGELOG. ## How to try it 1. Install the desktop from this release (and the server image `chronos-server:0.1.0-rc.11` for the server provenance). 2. Edit › Open in workspace › *Originals*, then Export › *Local render*. The render shows *Not sent* until *Send render* files it home. 3. Settings › Workspace: change *Size limit* or *Clean after*, try *Move…* to another folder, and look at *Trash*. ## Checks - `dotnet build -c Release`: 0 warnings. - `i18n check`: 4632 keys, 38 cultures, 0 warnings. `xaml-lint` and `package-guard` OK. - Core, Data, Server and App suites run locally (App without the classes that hang on this PC). - Screenshot baselines: 8 screens recaptured on this PC (`jobs-scheduled*`, `jobs-schedule-editor*`, `settings-rendering*`, `settings-workspace*`). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Alby96 added 40 commits 2026-11-04 18:08:33 +01:00
The owner's Uploader could not connect: the panel showed the container's
listening ports (8080/8443) as if clients used them, the public ports were
only environment variables (CHRONOS_PUBLIC_HTTP_PORT not even in the Unraid
template), and the clients mapped a bare host to 443, where another service
answered.

- Public HTTP/HTTPS ports are settings (server.json, or locked by
  CHRONOS_PUBLIC_*) and apply at once; ServerSettingsDto gains appended
  PublicHttpPort, PublicHttpsPort and InContainer members.
- In a container the listening ports are fixed by the template: locked in the
  panel, and saved values from earlier versions are ignored with a warning.
- Settings > Network and TLS shows the client address with a Copy button; the
  discovery tooltip says a container needs network type Host.
- ChronosAddress (shared by Chronos and the Uploader): no scheme and no port is
  https on 8443, https:// keeps 443, a typed port is kept, IPv6 is bracketed.
- GetInfoAsync throws NotChronosServerException for answers that are not a
  Chronos server; another service's certificate is never offered for trust
  and no credentials are sent to it. Both clients name the address asked.
- Unraid template, compose file, user guide, README, BRIEF, DECISIONS,
  CHANGELOG (with an Unraid upgrade note) and ARCHITECTURE updated; en/it
  strings added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review fixes on top of the public ports change (owner review 3):

- Settings > Network and TLS: opened over HTTPS, the client address uses the port
  the page came through (a container's 8443 published as 8444 with Public HTTPS
  port still empty showed the wrong 8443), and a "Use <port>" button fills that
  port in. Saving a Public HTTPS port other than the page's asks first, since the
  HTTPS redirect follows it at once and a typo would lock the panel's link out.
- GetInfoAsync tells Chronos from other services by stricter rules on both the
  trusted and the untrusted-certificate path: any redirect, any answer that is not
  JSON, more than 1 MB, or an error without the X-Chronos-Api header is not
  Chronos. Another service's certificate is no longer offered for trust after a
  cross-scheme redirect, an error page or a JSON 401/403/404, and a JSON 401 over
  HTTP no longer reads as a wrong password.
- The HTTP port typed without a scheme (TLS to a plain HTTP port) now gives the
  not-Chronos error instead of "the server did not answer".
- The Uploader's certificate question names the address with its port.
- A link-local IPv6 address with a zone index is refused instead of losing it.
- In a container, the first save of the settings removes HttpPort/HttpsPort from
  server.json, so the start-up warning stops; the warning says so.
- Guide, README, compose and template: with network type Host the mappings do
  nothing and CHRONOS_HTTP_PORT / CHRONOS_HTTPS_PORT move the listening ports off
  ones another service uses; the template overview is back to two sentences.
- BRIEF, DECISIONS and CHANGELOG updated; en/it strings added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The identity check reads Chronos's error body to tell it from another
service; GetInfoAsync then read it again and threw ObjectDisposedException.
The identity now carries the parsed error and GetInfoAsync throws it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner chose to capture the baselines on the development PC (owner
review 3, R2): 156 screens go to tests/visual/baselines and CI no longer
pushes a ci-screenshots branch. While --capture freezes AppClock, free
space, a server's latency and the last sync are fixed sample values; they
moved the Server and Import screens past the diff tolerance at random.
The 22 new or changed Admin strings are translated into the 36 other
languages, and the request file records the owner's text and answers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge remote-tracking branch 'origin/main' into review3-ports
CI / Build and test (pull_request) Successful in 11m22s
CI / Windows tests and installer (pull_request) Skipped
CI / YAML check (pull_request) Successful in 7s
CI / PostgreSQL 16 integration (pull_request) Successful in 10m51s
CI / PostgreSQL 17 integration (pull_request) Successful in 10m55s
CI / Docker image (pull_request) Successful in 1m33s
917cddde41
Owner review 2, phase 5b (R8): a server is a project home. A workspace can
list a sequence's projects, make, rename and delete them, read their
versions and push new ones through /api/v1/sequences/{sid}/projects. The
endpoints run on the archive's ProjectService exactly as a desktop's archive
does (sidecars first, then the index, under the sequence's lease), so no
version is stored apart and a desktop sharing the archive sees the same
projects.

- Protocol: project, version, create, rename, version page, push answer
  (outcome, stored version, head, plus code and message on 409/422) and
  home frames DTOs, the projectChanged event, the "projects" capability and
  the ChronosClient calls; a push returns its outcome without throwing on
  409 or 422. ProjectWire maps them to and from the model for both sides.
- Server: Read lists and reads, Edit makes, renames and pushes, Delete (the
  sequence's owner, the project's maker or an admin) deletes; refusals with
  stable codes, 503 while the sequence is busy, offline or moved; the
  pushing account becomes the version's author; creations, renames and
  deletions audited, pushes logged.
- ProjectService tells the host what each call changed, compared under the
  lease, so projectChanged also follows Main's external versions; a Main
  version mirrored into the settings sends sequenceChanged too, for older
  clients. ProjectCatchUp takes settings a PATCH, an analysis or a
  conversion wrote into Main at once, for sequences that have a Main.
- Renders of a project version: POST /jobs checks the project and version
  against the sequence and pins a project alone to its head; render nodes
  get the version's settings placed on the frames they claim; the render
  records the project and version.
- Admin panel: the sequence page lists its projects (Main marked, head,
  last change, versions on demand) with Rename and Delete for the others,
  live on projectChanged. It edits no settings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner review 2, R8, phase 5b (client part), ported onto the final phase 5a.
A Chronos Server with the "projects" capability is now the home of
workspace projects. A server sequence is edited in the workspace like a
local one, not inside the library, and its versions sync with the server
"like git".

- Data: ServerProjectHome is an IProjectHome over ChronosClient.
  - These are HomeUnavailableException, so the workspace shows Offline: a
    server out of reach, an expired sign-in, a 503 (lease, offline archive,
    projects_unreadable), a 409 folder_in_use, and a server without projects.
  - 404 sequence/project/version and refused names are ProjectException;
    other refusals keep their meaning.
  - A deleted project's head is 404 project, so final 5a's HeadAsync NotFound
    rule reads it as Gone. The original 5b's IsLiveAsync and
    WorkspaceStatus.Gone are dropped. IProjectHome gains rename and delete.
- Data: WorkspaceJobs.CopyFromServer downloads into the workspace, through
  the desktop's session, the proxies of one frames version (or the
  thumbnails standing in for them), with the aliases of the server's
  conversions. It is rebuilt on final 5a's copy handler:
  - the copy:frame:fv:folder checkpoint, EnsureSpace (from the server's proxy
    sizes), WritingMedia, and the cancelled-copy clean-up;
  - the editor's current file is never overwritten;
  - each file is hashed as it arrives and checked on disk, four at a time.
  It never writes this PC's archive. Originals are still refused until 5c.
- Data: SyncAgent passes on the server's projectChanged events, and after a
  lost event stream it reports that changes may have been missed.
- App: SyncHost gives the server home over one session client. The Server
  screen offers Open in workspace, disabled with its reason on older
  servers, whose sequences keep opening with proxies.
- App: Edit opens or checks out server projects with final 5a's refusals:
  unreadable copies, a disabled damaged or newer Main, a refused folder. The
  "sequence left the index" refusal now applies only to projects of this
  PC's archive.
- App: the picker and the chip follow projectChanged (Server newer, Not on
  server). Every state, conflict, delete, remove and failure text uses its
  ".Server" form when one exists (WorkspaceText.ForHome). That includes 5a's
  newer-format conflict, the save conflict, the taken-values toast, Gone and
  version-too-large.
- App: a render of a server project first offers to send what is not on the
  server, then renders the version the server holds. Offline, Gone, Damaged
  and missing media hold the render. Analyses and renders run as server jobs
  (ServerJobs, shared with RemoteSequenceSource).
- Pruning keeps final 5a's rule: a version is pruned only after HoldsAsync
  reads it back.
- Strings in en and it; ARCHITECTURE, DECISIONS and CHANGELOG.

Tests:
- ServerProjectHome error mapping, using a fake handler.
- Against the in-process server:
  - two workspaces on one project: fast-forward, replay and merge, keep mine,
    take server, save both, restore;
  - the copy job verifying, resuming and following new frames;
  - a project deleted on the server (Gone from its head; a push sends
    nothing);
  - an offline server.
- SyncAgent project events.
- App tests for the host, the project menu and renders of a server home.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The projects table sits in a min-width-0 host so fitColumns can drop columns.
A live refresh re-reads only the changed, expanded projects and keeps as many
versions as were shown (Load more included). Version pages ask for the summary
form, so the panel no longer downloads settings it never shows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The agent told "changes may have been missed" as soon as the stream dropped,
so a workspace re-read before the server's events could reach it again and
missed changes made in between. The signal now waits for the reconnected
stream and the refresh that follows it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- An unplaced sequence (no photos) lists no projects and refuses to create one
  with sequence_empty, instead of writing sidecars at the archive root.
- A push accepts a full-size version; a 413 is reported as too_large.
- Version pages are capped in bytes and say when more follow; the summary form
  leaves settings out; server homes page on.
- Deleting by its maker needs the same account, not just the same username.
- A settings PATCH writes project.json under the sequence lease, so Main's
  later birth no longer wipes it.
- Reconcile, read-only catch-up and a Main flip publish projectChanged.
- Server homes read the frames stamp and check a version is really stored.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each behavioural fix of the previous commit gets a test that fails without it:
an empty sequence writes nothing and refuses projects, a 24 MiB version is
stored and one over the limit is too_large, a page of large versions stops
short and a server home pages on, a reused username deletes nothing, a PATCH
made after project.json stays Main's head, HoldsAsync is false for a missing
file or a deleted project, and a full rescan tells the rename it found.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A pull and the server's renamed event write the home's name into the copy, so
a rename made on the server reaches the workspace. A copy from a server marks
a thumbnail taken for a missing proxy before moving it into place; a resumed
run reads the marker and fetches the proxy the server has now, instead of
recording the thumbnail as one. Tests also cover the frames stamp (frames read
only when it moves), an older server's copy refusal and a viewer's 403 push.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An account without Edit is offered Open with proxies on a server that keeps
projects and checks nothing out, since it could never push. The editor of a
server's workspace project connects with the sign-in in use at each call, so a
project opened signed out renders once signed in; SyncHost tells every session
start and stop so workspace projects read their state again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Phase 5b had only module rows and the review's DECISIONS and CHANGELOG lines.
The brief now describes the server home as the code does after the review
fixes: the projects API, projectChanged, the capability, the settings PATCH
under the lease, renders of a project version, the panel's Projects section,
and the desktop's server projects (open, copy, sync, chip, renders, viewers).

DECISIONS gains the phase's own rows; the 5b rows are dated 2026-10-26 like
the other review-2 phases, and three 5a rows are marked partly superseded.
CHANGELOG, STATUS, the request's 5b row and ARCHITECTURE follow the code
(frames stamp, stored reads, the .thumb marker, followed renames, the
editor's sign-in).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts:
#	docs/BRIEF.md
#	docs/CHANGELOG.md
#	docs/DECISIONS.md
#	docs/requests/2026-10-26-owner-review-2.md
#	i18n/en/Server.resx
#	i18n/it/Server.it.resx
Before phase 5b the server's settings PATCH wrote the index alone, and every
desktop edit of a linked sequence arrives as one, so an upgraded server holds
sequences whose index settings are newer than their project.json. Main's birth
read project.json first and mirrored it over the index; sequenceChanged then
carried the loss to the desktops' linked copies.

ArchiveServiceOptions.IndexSettingsMayLead, set by the server, keeps both: Main
is born with project.json's settings as version 1 and the index's as version 2,
in force and mirrored (on a read-only archive both go to the index only). A Main
the sidecars already hold, met with no mirror known, keeps index settings that
none of its versions hold as an External version below what project.json gives
(the head again as a Restore, a merge, or the file's). The desktop is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The name follow after a pull caught only the home's own exceptions, so a 403
or any other error from the home's list (or a bundle in use) made a pull that
had already pulled and replayed report a failure. It is now logged as a
warning and the name is followed at the next pull; a cancellation still passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The capture's data folder lives in the machine's temporary folder, so 8
baselines showed %TEMP% and the user name and differed on any other machine.
AppEnvironment.Shown now shows a capture's folders as a sample user's
(C:\Users\Studio\AppData\Local\Chronos, the sample archive as D:\ChronosArchive)
in Settings > Storage, Workspace and Advanced, the Rebuild index dialog and the
cache's Clear confirmation; AppEnvironment.Actual maps a typed path back, so the
capture still writes only to its temporary folder. Two captures with different
TEMP folders are identical.

On the Server screen the row actions column is at least 400 px wide, so a
remote row's three actions (an older server's disabled Open in workspace after
Open with proxies and Download originals, as BRIEF 12.7 asks) fit one 40 px
line at the capture size instead of wrapping.

Baselines recaptured: server, server-sync, server-conflict, server-signedout
(column layout; the disabled action of phase 5b), settings-storage,
settings-workspace, settings-advanced and archive-rebuild (sample paths), light
and dark.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DECISIONS: IndexSettingsMayLead (Main's birth and meeting on a server keep the
index's settings), the name follow that never fails a pull, the capture's
sample paths and the Server actions column; the rows on the Main meeting, the
settings PATCH and the name follow point to them. CHANGELOG: the fix wording
is now true for servers upgraded from an earlier release, with an upgrade note;
BRIEF's Main mirror rule and STATUS follow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs(i18n): translate the phase 5b strings and split the changelog by release
CI / Build and test (pull_request) Successful in 8m15s
CI / Windows tests and installer (pull_request) Skipped
CI / YAML check (pull_request) Successful in 10s
CI / PostgreSQL 16 integration (pull_request) Successful in 8m46s
CI / PostgreSQL 17 integration (pull_request) Successful in 9m51s
CI / Docker image (pull_request) Successful in 1m45s
31df8beb9a
The 119 new phase 5b strings are translated into the 36 machine-translated
languages. The changelog separates what shipped in 0.1.0-rc.9 (ports and
baselines) from the unreleased phase 5b work, and the index settings decision
names the rare cases where a newer project.json is kept as version 1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Phase 5c (owner review 2, R8) is built by six packages in parallel. This
commit settles everything they share, so each one touches its own files:

- job kinds WorkspaceRender (21), WorkspaceSend (22) and WorkspaceMove (23)
  with their wire names, default priorities, notices and parameter records;
  their handlers are registered as skeletons that throw until their
  package lands
- WorkspaceJobOptions and a new CreateHandlers overload; the earlier ones
  stay and default the options
- originals in the media index (an index of phase 5b reads as proxies
  only), their file names, and the exports/renders.json ledger of local
  renders, written atomically
- the optional project and version of an uploaded render
- the workspace settings (size limit, default media, version on render,
  clean-up age, project to open) and when each project was opened, which
  Reset and Import keep and Export leaves out
- WorkspaceHost split into partial files, with stubs for usage, trash and
  the folder move, removal hooks for unsent renders and last originals,
  and a guard that holds work while the workspace moves
- every new string of the phase in English and Italian, with tooltips

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Phase 5c P5. The page now holds every workspace setting in the plan's
order: the folder with Open, Change… and Move… (bound to
WorkspaceFolderChange.MoveAsync, disabled while a move runs) and what
the folder takes of its drive; Size limit and Clean after, presets then
No limit / Never; Default media and Open project as radio choices;
Sync automatically; Version on render; Kept versions; and Trash, which
shows its entries and size and empties it only after its plan and the
typed entry count (WorkspaceHost.PlanTrashAsync / EmptyTrashAsync),
telling a changed trash apart in a toast.

WorkspaceSettingsRows reaches the workspace through
WorkspaceSettingsServices, so the rows are tested without a shell;
Reset restores every row but keeps the folder and what the workspace
remembers. The page's search finds the new rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Phase 5c P3. A render made in a workspace must reach its home with the project
and version it was rendered from, and transfers with a server must respect a
metered connection, downloads into the workspace included.

- WorkspaceSendJobHandler: per unsent ledger entry, hash the file again
  (missing or changed: marked failed, file left in place), push the named
  version first when the home lacks it (failure fails the job, entry pending),
  then file it in this PC's archive (staged copy read back against its SHA-256,
  project and version checked against the sequence) or upload it to the server
  with ProjectId/ProjectVersionId; mark it sent. Idempotent by render id. A send
  to a server waits while HoldTransfers says so.
- SyncTransfers: extract FileRenderAsync, the lease-held filing of a staged
  render into a sequence's exports, shared by GetExportsAsync and the send.
- ISyncConnector.ProjectHome (default null; SyncHost already implements it) so
  the send can push a version to a server home.
- Server: RenderUploads checks the project fields at start and completion
  (422 project_mismatch) and records them; RenderDto carries them.
- UploadHold also pauses WorkspaceCopy and WorkspaceSend jobs naming a server;
  Server screen checkbox reads "Pause metered transfers".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Settings › Workspace › Change only pointed Edit at another folder and left
every project behind. Moving a workspace to a bigger or faster disk now
carries its projects along, without ever putting work at risk:

- a plan first: projects, files, bytes, free space at the target, whether
  folders are renamed (one volume) or copied (another), projects with work
  not at their home as a warning; refused for the folder itself or one
  inside it, a target holding a workspace or a same-id folder, a target
  inside a library, too little room, or a workspace job still pending
- the WorkspaceMove job checks the plan's fingerprint again, journals the
  move in <from>/.move.json, renames each entry on one volume, and across
  volumes copies each file to a .part, hashes both sides and only then
  renames it into place; the source goes only after every entry is
  verified and the desktop switched to the target
- a failure before the switch is undone (renamed entries go back, copies
  are removed) so the source stays the workspace; a pause or a closed
  program goes on from the journal; a user cancel undoes it
- while a move waits, runs or its journal is in the folder in use, opens,
  checkouts, copies, saves, syncs and another folder are refused, and a
  journal left at start is offered again with Resume
- the setting names the new folder only once the move verified everything

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Phase 5c P4. The workspace no longer grows without bound: a daily
workspace-cleanup system schedule (04:30, catch-up) removes the media of
projects in step with their home that were not opened for Clean after,
and the size limit removes the least recently used after each copy.
Each project kept is logged with its reason (open in Edit, not in step,
home offline, jobs pending, renders not sent, unreadable, just copied).

- WorkspaceCleaner: cleans under the project's lease, re-checking every
  condition; the originals the home no longer holds go to the workspace
  trash, never away. The media index is marked Cleaned, so the project
  reads as MediaRemoved and opening it copies the media again.
- WorkspaceTrash: lists entries with a fingerprint, and empties only the
  plan the user confirmed (refused when the trash changed since).
- Trash dialog view model and view: Erase is enabled only after the user
  types the number of entries.
- Removing a copy counts the unsent renders and the last originals. Send
  first queues the renders' sending and refuses the removal until they
  are sent.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Phase 5c P1. A workspace copy of kind "originals" now copies each frame's
original beside its proxy, so a later local render has full-quality input:
streamed into a .part file, hashed as written, checked against the home's
SHA-256, renamed and read back. Archive and server homes both work, a stopped
copy resumes (originals: checkpoint), and the space check counts the
originals. A frame whose original is gone, damaged or refused keeps its proxy
and the job says how many; the copy does not fail. Stale originals are
deleted only when the home holds the same SHA-256, otherwise moved to the
workspace's trash.

Proxies only... plans first (every original hashed against the home's
frames), asks for an explicit confirmation, rewrites the media to proxies
before it touches a file, refuses a plan that changed since, and trashes what
the home no longer holds instead of deleting it.

Edit: Open in workspace offers Originals (the settings' default, disabled
when the drive lacks room) with the originals' size for archive and server
homes; Settings > Workspace > Open project picks Last used, Main or asks
which; each open is recorded for the clean-up. The project menu gains Copy
originals... and Proxies only..., refused while changes are unsaved or jobs
of the sequence run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A workspace project that holds its originals now renders locally
(JobKind.WorkspaceRender), so the full-resolution render no longer
waits on the home. This holds also when the home is a server.

- The handler reads its inputs under the project's lease. It refuses
  proxies-only media, and it refuses frames without an original,
  saying how many lack one. It renders into exports/ with unique
  names and a resumable checkpoint.
- Each output gets a ledger entry: SHA-256, the render id from
  RenderJobHandler.RenderId, and the version, recorded only when
  versions/ holds it and its hash verifies.
- After rendering, the handler queues a WorkspaceSend follow-up for
  the outputs it recorded. A cancel leaves no partial file.
- The editor routes Originals media to the local engine even for a
  server home, and lists those jobs beside the server's. It treats
  WorkspaceRender like Render for the toast and the reload, says
  "Sent home" when a send ends, and shows unsent ledger renders as
  "Not sent".
- Version on render saves a changed project as a version noted
  "Render" before it renders, and sends it with Sync automatically.
  With the setting off, the render behaves as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The local render, the send home, the clean-up, the settings page and the
folder move were built apart; together they left gaps:

- A local render to an image sequence writes a folder, which the send
  took for a missing file. The archive home now files the folder whole
  (checked by its listing hash, as the render recorded it) and the
  clean-up removes a sent folder; a server, which takes one file per
  render, refuses it with Errors.Workspace.SendSequence.
- Rename, delete and Remove local copy are refused while the folder is
  being moved, so no project folder changes under the move.
- Settings > Workspace shows the folder, usage, Move... and Change...
  again when a move ends (WorkspaceHost.MoveEnded).
- Empty... uses the Settings typed confirmation; the separate trash
  dialog, never shown, is removed. The move plan counts unsent renders
  with the clean-up's helper.
- Tests: the follow-up send now runs in the render tests; an end-to-end
  archive-home test (originals, version on render, local render, send
  with project and version, clean-up) and an image-sequence send test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Originals are now judged by their bytes, never by the media index: a removal
or clean-up hashes every file under media/originals and deletes it only when
the home holds that SHA-256; every other file, named or not, goes to the
workspace trash. Trash entries are filled under a staging name that Empty
never lists. A ledger can only name files inside exports/.

Jobs follow the workspace: a copy, render or send resolves the folder that
holds its project now (a moved workspace, a retry after a move) and waits
while a move has not switched yet. A clean-up failure after the switch is a
warning that keeps the journal for a later resume; entries that changed
since they were copied are kept, and a same-volume rename refused across
volumes falls back to copy and verify.

Sends map a replayed version by content hash, or go with the project only,
and note an old server that drops provenance. The media index (format 2) and
project file (format 3) refuse older readers while they hold originals.
Metered connections also hold sync downloads and server copies. The editor
gains Send again, the Settings page can resume a stopped move, the disabled
tooltips say why, and unused strings are pruned.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A move that switched to the folder in use but left part of its old folder
showed Resume and a "resume it first" tooltip on Change… and Move…, yet both
stayed enabled because no journal lies in the folder in use. Choosing another
folder then would hide the Resume for good and leave the old folder's copy
on disk. Change… and Move… now wait whenever a stopped move is found.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The scheduled list gains Workspace clean-up, the priority queue lists the
three workspace job kinds and Settings › Workspace has all its rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DECISIONS, BRIEF, CHANGELOG, STATUS, ARCHITECTURE and the request files now
describe the workspace originals, local render and send, clean-up, trash
and move as built and reviewed; the 5b entries move under rc.10. The 184
new strings are translated into the 36 machine-translated languages.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge origin/main (5b squash, same tree as 31df8beb) into review2-p5c
CI / Build and test (pull_request) Failing after 1m52s
CI / PostgreSQL 16 integration (pull_request) Skipped
CI / PostgreSQL 17 integration (pull_request) Skipped
CI / Docker image (pull_request) Skipped
CI / Windows tests and installer (pull_request) Skipped
CI / YAML check (pull_request) Successful in 6s
e65d10ead2
Alby96 added 1 commit 2026-11-04 18:39:37 +01:00
style: apply dotnet format whitespace to the phase 5c files
CI / Build and test (pull_request) Successful in 8m52s
CI / PostgreSQL 16 integration (pull_request) Successful in 9m21s
CI / Docker image (pull_request) Successful in 1m48s
CI / YAML check (pull_request) Successful in 7s
CI / Windows tests and installer (pull_request) Skipped
CI / PostgreSQL 17 integration (pull_request) Successful in 8m59s
99ae344c0d
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Alby96 added 1 commit 2026-11-04 19:26:36 +01:00
fix(workspace): a copy cancelled just before its commit never commits
CI / Build and test (pull_request) Successful in 8m56s
CI / Windows tests and installer (pull_request) Skipped
CI / YAML check (pull_request) Successful in 8s
CI / PostgreSQL 16 integration (pull_request) Successful in 9m46s
CI / PostgreSQL 17 integration (pull_request) Successful in 9m56s
CI / Docker image (pull_request) Successful in 1m35s
bc90e5a244
A cancel landing while the copy's last query was in flight (PostgreSQL
answers a finished query anyway) went unseen: the copy took the freed
project lease, committed media.json and ended Done over Cancelled, so its
clean-up never ran. Both commit points now check the token under the lease.
Seen once in CI's PostgreSQL 17 run of
ACancelledFirstCopyRemovesTheMediaItWroteOnceItStopped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Alby96 merged commit db389a54f2 into main 2026-11-04 20:03:58 +01:00
Alby96 deleted branch review2-p5c 2026-11-04 20:04:00 +01:00
Sign in to join this conversation.