fix(rtl): sizes, speeds and times left read in the language's direction and fit their column
With sizes in the language's units, the left-to-right number cells of the Import
tables and the Jobs speed and time-left columns put the unit after the number on
screen, so an Arabic or Hebrew reader met the unit first ("18,6 كيلوبايت"), and the
fixed column cut the longer word off. These cells and their headers now follow the
reading direction at the end of the cell, and the Import size columns size to their
content; bare numbers (percentages) stay left-to-right islands.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
This commit is contained in:
5 files changed
+28
-23
No files matched your search
+2
-1
@@ -123,7 +123,8 @@ commits follow Conventional Commits (release notes are generated from them by `T
|
|||||||
Import session table now follow at once.
|
Import session table now follow at once.
|
||||||
- Right-to-left: in meta lines a number after a Latin field ("Canon EOS R5 · 2 h") joined the Latin run and split
|
- Right-to-left: in meta lines a number after a Latin field ("Canon EOS R5 · 2 h") joined the Latin run and split
|
||||||
its own field; fields are now separated with right-to-left marks (left-to-right ones in the preview's frame data).
|
its own field; fields are now separated with right-to-left marks (left-to-right ones in the preview's frame data).
|
||||||
Charts no longer switch to Arabic-Indic digits after Arabic words. Desktop file sizes use the language's units.
|
Charts no longer switch to Arabic-Indic digits after Arabic words. Desktop file sizes use the language's units;
|
||||||
|
table cells holding a size, speed or time left read in the language's direction and fit their column.
|
||||||
- CI: a full artifact storage failed jobs whose checks had passed; uploads no longer fail a job, artifacts expire in
|
- CI: a full artifact storage failed jobs whose checks had passed; uploads no longer fail a job, artifacts expire in
|
||||||
days, and screenshots reach their branch through the cache.
|
days, and screenshots reach their branch through the cache.
|
||||||
- Release workflow: signing and the public-repository publish never ran (step conditions cannot read the step's own
|
- Release workflow: signing and the public-repository publish never ran (step conditions cannot read the step's own
|
||||||
|
|||||||
@@ -238,6 +238,7 @@ One line per decision: date · decision · alternative · reason.
|
|||||||
| 2026-10-06 | The regression test fills its server's log with about 2 MB up front, then logs one line about every 1 ms through the server's FileLoggerProvider only, on a LongRunning thread | A tight logging loop through ILoggerFactory (my first two versions) | The engine log sink is process-wide, so a console or file-lock flood stalled another test's job engine. The throttled version still reproduces the bug in 10 of 10 runs against the old endpoint. |
|
| 2026-10-06 | The regression test fills its server's log with about 2 MB up front, then logs one line about every 1 ms through the server's FileLoggerProvider only, on a LongRunning thread | A tight logging loop through ILoggerFactory (my first two versions) | The engine log sink is process-wide, so a console or file-lock flood stalled another test's job engine. The throttled version still reproduces the bug in 10 of 10 runs against the old endpoint. |
|
||||||
| 2026-10-06 | Heartbeat test: count the claims the server answered with a DelegatingHandler, then wait for a later beat with a 30 s deadline | Keep the sleeps and widen the 400 ms window | It removes the timing assumption both ways (a false failure on a slow runner, and a false pass on the claim's own touch). It also proves no claim moved the beat. |
|
| 2026-10-06 | Heartbeat test: count the claims the server answered with a DelegatingHandler, then wait for a later beat with a 30 s deadline | Keep the sleeps and widen the 400 ms window | It removes the timing assumption both ways (a false failure on a slow runner, and a false pass on the claim's own touch). It also proves no claim moved the beat. |
|
||||||
| 2026-10-11 | Fields of a meta line are joined with `Loc.Separator`: " · " in left-to-right languages, " · " between right-to-left marks in right-to-left ones (`Loc.SeparatorOf(culture)` for texts built in another language) | Unicode isolates (FSI/PDI) around each field, or a left-to-right island for every meta line | WPF's bidi predates the isolates; without a strong right-to-left character before it, a number after a Latin field ("Canon EOS R5 · 2 h") joins the Latin run (rule W7) and splits its own field; islands would read the fields in left-to-right order. |
|
| 2026-10-11 | Fields of a meta line are joined with `Loc.Separator`: " · " in left-to-right languages, " · " between right-to-left marks in right-to-left ones (`Loc.SeparatorOf(culture)` for texts built in another language) | Unicode isolates (FSI/PDI) around each field, or a left-to-right island for every meta line | WPF's bidi predates the isolates; without a strong right-to-left character before it, a number after a Latin field ("Canon EOS R5 · 2 h") joins the Latin run (rule W7) and splits its own field; islands would read the fields in left-to-right order. |
|
||||||
|
| 2026-10-12 | Table cells holding a value with the language's unit (sizes, speeds, times left) follow the reading direction at the end of the cell, like their header, and size columns fit their content; bare numbers (percentages, counts) stay left-to-right islands, right-aligned | Every number cell left to right | Once sizes use the language's units, a left-to-right cell put the unit after the number on screen, so Arabic and Hebrew readers met the unit first ("18,6 كيلوبايت"), and the longer words were cut off. |
|
||||||
| 2026-10-12 | Fields shown in a left-to-right island are joined with `Loc.IslandSeparator` (" · " between left-to-right marks in right-to-left languages); charts format text with European digits | The reading-direction separator everywhere; the culture's digit substitution in charts | In the preview's frame data a localized time ends in a right-to-left mark ("6:03:41 م"), so the next field's number read as part of it and swapped places with the dot; with the UI culture, chart text after Arabic words drew Arabic-Indic digits while every text block shows European ones. |
|
| 2026-10-12 | Fields shown in a left-to-right island are joined with `Loc.IslandSeparator` (" · " between left-to-right marks in right-to-left languages); charts format text with European digits | The reading-direction separator everywhere; the culture's digit substitution in charts | In the preview's frame data a localized time ends in a right-to-left mark ("6:03:41 م"), so the next field's number read as part of it and swapped places with the dot; with the UI culture, chart text after Arabic words drew Arabic-Indic digits while every text block shows European ones. |
|
||||||
| 2026-10-11 | `LocalizedViewModel.OnLanguageChanged` is the hook for texts kept in objects: the editor makes its tabs' charts, Auto chips, markers and info line again; Jobs refreshes rows, chips and the job bar; Archive reads again; Import rebuilds its session table and device list | Re-create every section after a language switch, or ask for a restart | BRIEF §16 switches language without restart; a running job's bar line and an open editor's legend otherwise stayed in the old language until their next change. |
|
| 2026-10-11 | `LocalizedViewModel.OnLanguageChanged` is the hook for texts kept in objects: the editor makes its tabs' charts, Auto chips, markers and info line again; Jobs refreshes rows, chips and the job bar; Archive reads again; Import rebuilds its session table and device list | Re-create every section after a language switch, or ask for a restart | BRIEF §16 switches language without restart; a running job's bar line and an open editor's legend otherwise stayed in the old language until their next change. |
|
||||||
| 2026-10-11 | Desktop sizes use the `Common.Size.*` formats, like the Setup and the Uploader | Hard-coded B, KB, MB, GB, TB, PB | Several languages write the units in their own script or words (КБ, bayt, كيلوبايت); every UI string is a resource. |
|
| 2026-10-11 | Desktop sizes use the `Common.Size.*` formats, like the Setup and the Uploader | Hard-coded B, KB, MB, GB, TB, PB | Several languages write the units in their own script or words (КБ, bayt, كيلوبايت); every UI string is a resource. |
|
||||||
|
|||||||
@@ -135,12 +135,8 @@
|
|||||||
<Setter Property="HorizontalAlignment" Value="Left" />
|
<Setter Property="HorizontalAlignment" Value="Left" />
|
||||||
</Style>
|
</Style>
|
||||||
|
|
||||||
<!-- Numbers stay right-aligned in tables in both directions. -->
|
<!-- Sizes carry the language's unit ("18,6 كيلوبايت"): they read in its direction, at the end of the cell like their header. -->
|
||||||
<Style x:Key="Text.CellNumberLtr" TargetType="TextBlock" BasedOn="{StaticResource Text.CellNumber}">
|
<Style x:Key="Text.HeaderEnd" TargetType="TextBlock" BasedOn="{StaticResource Text.Header}">
|
||||||
<Setter Property="FlowDirection" Value="LeftToRight" />
|
|
||||||
</Style>
|
|
||||||
<Style x:Key="Text.HeaderNumber" TargetType="TextBlock" BasedOn="{StaticResource Text.Header}">
|
|
||||||
<Setter Property="FlowDirection" Value="LeftToRight" />
|
|
||||||
<Setter Property="TextAlignment" Value="Right" />
|
<Setter Property="TextAlignment" Value="Right" />
|
||||||
</Style>
|
</Style>
|
||||||
|
|
||||||
@@ -482,14 +478,14 @@
|
|||||||
<Grid.ColumnDefinitions>
|
<Grid.ColumnDefinitions>
|
||||||
<ColumnDefinition Width="Auto" MinWidth="110" SharedSizeGroup="SessionTime" />
|
<ColumnDefinition Width="Auto" MinWidth="110" SharedSizeGroup="SessionTime" />
|
||||||
<ColumnDefinition Width="0.85*" MinWidth="70" />
|
<ColumnDefinition Width="0.85*" MinWidth="70" />
|
||||||
<ColumnDefinition Width="0.6*" MinWidth="56" />
|
<ColumnDefinition Width="Auto" MinWidth="56" SharedSizeGroup="SessionSize" />
|
||||||
<ColumnDefinition Width="0.9*" MinWidth="64" />
|
<ColumnDefinition Width="0.9*" MinWidth="64" />
|
||||||
<ColumnDefinition Width="1.6*" MinWidth="150" />
|
<ColumnDefinition Width="1.6*" MinWidth="150" />
|
||||||
<ColumnDefinition Width="Auto" SharedSizeGroup="SessionAction" />
|
<ColumnDefinition Width="Auto" SharedSizeGroup="SessionAction" />
|
||||||
</Grid.ColumnDefinitions>
|
</Grid.ColumnDefinitions>
|
||||||
<TextBlock Style="{StaticResource Text.Header}" Text="{l:Loc Import.Session.Column.Session}" />
|
<TextBlock Style="{StaticResource Text.Header}" Text="{l:Loc Import.Session.Column.Session}" />
|
||||||
<TextBlock Grid.Column="1" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Session.Column.Frames}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="1" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Session.Column.Frames}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="2" Style="{StaticResource Text.HeaderNumber}" Text="{l:Loc Import.Session.Column.Size}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="2" Style="{StaticResource Text.HeaderEnd}" Text="{l:Loc Import.Session.Column.Size}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="3" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Session.Column.Camera}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="3" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Session.Column.Camera}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="4" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Session.Column.Sequence}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="4" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Session.Column.Sequence}" Margin="10,0,0,0" />
|
||||||
</Grid>
|
</Grid>
|
||||||
@@ -501,14 +497,14 @@
|
|||||||
<Grid.ColumnDefinitions>
|
<Grid.ColumnDefinitions>
|
||||||
<ColumnDefinition Width="Auto" MinWidth="110" SharedSizeGroup="SessionTime" />
|
<ColumnDefinition Width="Auto" MinWidth="110" SharedSizeGroup="SessionTime" />
|
||||||
<ColumnDefinition Width="0.85*" MinWidth="70" />
|
<ColumnDefinition Width="0.85*" MinWidth="70" />
|
||||||
<ColumnDefinition Width="0.6*" MinWidth="56" />
|
<ColumnDefinition Width="Auto" MinWidth="56" SharedSizeGroup="SessionSize" />
|
||||||
<ColumnDefinition Width="0.9*" MinWidth="64" />
|
<ColumnDefinition Width="0.9*" MinWidth="64" />
|
||||||
<ColumnDefinition Width="1.6*" MinWidth="150" />
|
<ColumnDefinition Width="1.6*" MinWidth="150" />
|
||||||
<ColumnDefinition Width="Auto" SharedSizeGroup="SessionAction" />
|
<ColumnDefinition Width="Auto" SharedSizeGroup="SessionAction" />
|
||||||
</Grid.ColumnDefinitions>
|
</Grid.ColumnDefinitions>
|
||||||
<TextBlock Style="{StaticResource Text.Cell}" Text="{Binding Row.TimeText}" ToolTip="{Binding Row.TimeText}" />
|
<TextBlock Style="{StaticResource Text.Cell}" Text="{Binding Row.TimeText}" ToolTip="{Binding Row.TimeText}" />
|
||||||
<TextBlock Grid.Column="1" Style="{StaticResource Text.Cell}" Text="{Binding Row.FramesText}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="1" Style="{StaticResource Text.Cell}" Text="{Binding Row.FramesText}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="2" Style="{StaticResource Text.CellNumberLtr}" Text="{Binding Row.SizeText}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="2" Style="{StaticResource Text.CellNumber}" Text="{Binding Row.SizeText}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="3" Style="{StaticResource Text.Cell}" Text="{Binding Row.CameraText}" Margin="10,0,0,0" ToolTip="{Binding Row.CameraText}" />
|
<TextBlock Grid.Column="3" Style="{StaticResource Text.Cell}" Text="{Binding Row.CameraText}" Margin="10,0,0,0" ToolTip="{Binding Row.CameraText}" />
|
||||||
<DockPanel Grid.Column="4" Margin="10,0,0,0">
|
<DockPanel Grid.Column="4" Margin="10,0,0,0">
|
||||||
<TextBlock x:Name="Target" DockPanel.Dock="Right" Text="{l:Loc Import.Session.NewShort}" Foreground="{DynamicResource Brush.Accent}"
|
<TextBlock x:Name="Target" DockPanel.Dock="Right" Text="{l:Loc Import.Session.NewShort}" Foreground="{DynamicResource Brush.Accent}"
|
||||||
@@ -658,13 +654,13 @@
|
|||||||
<ColumnDefinition Width="1.2*" MinWidth="140" />
|
<ColumnDefinition Width="1.2*" MinWidth="140" />
|
||||||
<ColumnDefinition Width="1.8*" MinWidth="180" />
|
<ColumnDefinition Width="1.8*" MinWidth="180" />
|
||||||
<ColumnDefinition Width="0.8*" MinWidth="90" />
|
<ColumnDefinition Width="0.8*" MinWidth="90" />
|
||||||
<ColumnDefinition Width="0.5*" MinWidth="64" />
|
<ColumnDefinition Width="Auto" MinWidth="64" SharedSizeGroup="PlanSize" />
|
||||||
<ColumnDefinition Width="Auto" SharedSizeGroup="PlanAction" />
|
<ColumnDefinition Width="Auto" SharedSizeGroup="PlanAction" />
|
||||||
</Grid.ColumnDefinitions>
|
</Grid.ColumnDefinitions>
|
||||||
<TextBlock Style="{StaticResource Text.Header}" Text="{l:Loc Import.Details.Column.Source}" />
|
<TextBlock Style="{StaticResource Text.Header}" Text="{l:Loc Import.Details.Column.Source}" />
|
||||||
<TextBlock Grid.Column="1" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Details.Column.Destination}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="1" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Details.Column.Destination}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="2" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Details.Column.Action}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="2" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Details.Column.Action}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="3" Style="{StaticResource Text.HeaderNumber}" Text="{l:Loc Import.Session.Column.Size}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="3" Style="{StaticResource Text.HeaderEnd}" Text="{l:Loc Import.Session.Column.Size}" Margin="10,0,0,0" />
|
||||||
</Grid>
|
</Grid>
|
||||||
<ListBox x:Name="PlanRows" Grid.Row="3" ItemsSource="{Binding Rows}" ItemContainerStyle="{StaticResource ListBoxItem.PlanRow}" AutomationProperties.Name="{l:Loc Import.Details.Title}"
|
<ListBox x:Name="PlanRows" Grid.Row="3" ItemsSource="{Binding Rows}" ItemContainerStyle="{StaticResource ListBoxItem.PlanRow}" AutomationProperties.Name="{l:Loc Import.Details.Title}"
|
||||||
KeyboardNavigation.TabNavigation="Continue" ScrollViewer.VerticalScrollBarVisibility="Visible">
|
KeyboardNavigation.TabNavigation="Continue" ScrollViewer.VerticalScrollBarVisibility="Visible">
|
||||||
@@ -680,14 +676,14 @@
|
|||||||
<ColumnDefinition Width="1.2*" MinWidth="140" />
|
<ColumnDefinition Width="1.2*" MinWidth="140" />
|
||||||
<ColumnDefinition Width="1.8*" MinWidth="180" />
|
<ColumnDefinition Width="1.8*" MinWidth="180" />
|
||||||
<ColumnDefinition Width="0.8*" MinWidth="90" />
|
<ColumnDefinition Width="0.8*" MinWidth="90" />
|
||||||
<ColumnDefinition Width="0.5*" MinWidth="64" />
|
<ColumnDefinition Width="Auto" MinWidth="64" SharedSizeGroup="PlanSize" />
|
||||||
<ColumnDefinition Width="Auto" SharedSizeGroup="PlanAction" />
|
<ColumnDefinition Width="Auto" SharedSizeGroup="PlanAction" />
|
||||||
</Grid.ColumnDefinitions>
|
</Grid.ColumnDefinitions>
|
||||||
<TextBlock x:Name="Source" Style="{StaticResource Text.Cell}" Text="{Binding SourceText}" ToolTip="{Binding Source}" />
|
<TextBlock x:Name="Source" Style="{StaticResource Text.Cell}" Text="{Binding SourceText}" ToolTip="{Binding Source}" />
|
||||||
<TextBlock x:Name="Destination" Grid.Column="1" Style="{StaticResource Text.CellPath}" Text="{Binding DestinationText}" Margin="10,0,0,0"
|
<TextBlock x:Name="Destination" Grid.Column="1" Style="{StaticResource Text.CellPath}" Text="{Binding DestinationText}" Margin="10,0,0,0"
|
||||||
ToolTip="{Binding Destination}" />
|
ToolTip="{Binding Destination}" />
|
||||||
<TextBlock x:Name="Action" Grid.Column="2" Style="{StaticResource Text.Cell}" Text="{Binding ActionText}" Margin="10,0,0,0" />
|
<TextBlock x:Name="Action" Grid.Column="2" Style="{StaticResource Text.Cell}" Text="{Binding ActionText}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="3" Style="{StaticResource Text.CellNumberLtr}" Text="{Binding SizeText}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="3" Style="{StaticResource Text.CellNumber}" Text="{Binding SizeText}" Margin="10,0,0,0" />
|
||||||
<Button x:Name="Split" Grid.Column="4" Style="{StaticResource Button.RowAction}" Margin="10,0,4,0" Content="{l:Loc Import.Details.Split}"
|
<Button x:Name="Split" Grid.Column="4" Style="{StaticResource Button.RowAction}" Margin="10,0,4,0" Content="{l:Loc Import.Details.Split}"
|
||||||
Command="{Binding DataContext.SplitCommand, RelativeSource={RelativeSource AncestorType=UserControl}}" CommandParameter="{Binding}"
|
Command="{Binding DataContext.SplitCommand, RelativeSource={RelativeSource AncestorType=UserControl}}" CommandParameter="{Binding}"
|
||||||
ToolTip="{l:Loc Tooltips.Import.Split}" AutomationProperties.Name="{Binding SplitName}" Visibility="Hidden" />
|
ToolTip="{l:Loc Tooltips.Import.Split}" AutomationProperties.Name="{Binding SplitName}" Visibility="Hidden" />
|
||||||
|
|||||||
@@ -19,9 +19,12 @@
|
|||||||
<Setter Property="TextAlignment" Value="Right" />
|
<Setter Property="TextAlignment" Value="Right" />
|
||||||
<Setter Property="FlowDirection" Value="LeftToRight" />
|
<Setter Property="FlowDirection" Value="LeftToRight" />
|
||||||
</Style>
|
</Style>
|
||||||
<Style x:Key="Text.HeaderNumber" TargetType="TextBlock" BasedOn="{StaticResource Text.Header}">
|
<!-- Speeds and times left carry the language's unit ("2 د"): they read in its direction, at the end of the cell like their header. -->
|
||||||
|
<Style x:Key="Text.MutedEnd" TargetType="TextBlock" BasedOn="{StaticResource Text.Muted}">
|
||||||
|
<Setter Property="TextAlignment" Value="Right" />
|
||||||
|
</Style>
|
||||||
|
<Style x:Key="Text.HeaderEnd" TargetType="TextBlock" BasedOn="{StaticResource Text.Header}">
|
||||||
<Setter Property="TextAlignment" Value="Right" />
|
<Setter Property="TextAlignment" Value="Right" />
|
||||||
<Setter Property="FlowDirection" Value="LeftToRight" />
|
|
||||||
</Style>
|
</Style>
|
||||||
<Style x:Key="ProgressBar.Job" TargetType="ProgressBar" BasedOn="{StaticResource {x:Type ProgressBar}}">
|
<Style x:Key="ProgressBar.Job" TargetType="ProgressBar" BasedOn="{StaticResource {x:Type ProgressBar}}">
|
||||||
<Style.Triggers>
|
<Style.Triggers>
|
||||||
@@ -123,8 +126,8 @@
|
|||||||
<TextBlock Grid.Column="1" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.Kind}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="1" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.Kind}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="2" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.Target}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="2" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.Target}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="3" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.Progress}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="3" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.Progress}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="4" Style="{StaticResource Text.HeaderNumber}" Text="{l:Loc Jobs.Column.Speed}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="4" Style="{StaticResource Text.HeaderEnd}" Text="{l:Loc Jobs.Column.Speed}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="5" Style="{StaticResource Text.HeaderNumber}" Text="{l:Loc Jobs.Column.Left}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="5" Style="{StaticResource Text.HeaderEnd}" Text="{l:Loc Jobs.Column.Left}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="6" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.Where}" Margin="16,0,0,0" />
|
<TextBlock Grid.Column="6" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.Where}" Margin="16,0,0,0" />
|
||||||
<TextBlock Grid.Column="7" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.State}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="7" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.State}" Margin="10,0,0,0" />
|
||||||
</Grid>
|
</Grid>
|
||||||
@@ -165,8 +168,8 @@
|
|||||||
AutomationProperties.Name="{Binding AccessibleName}" />
|
AutomationProperties.Name="{Binding AccessibleName}" />
|
||||||
<TextBlock Grid.Column="1" Style="{StaticResource Text.MutedNumber}" Text="{Binding PercentText}" />
|
<TextBlock Grid.Column="1" Style="{StaticResource Text.MutedNumber}" Text="{Binding PercentText}" />
|
||||||
</Grid>
|
</Grid>
|
||||||
<TextBlock Grid.Column="4" Style="{StaticResource Text.MutedNumber}" Text="{Binding SpeedText}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="4" Style="{StaticResource Text.MutedEnd}" Text="{Binding SpeedText}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="5" Style="{StaticResource Text.MutedNumber}" Text="{Binding LeftText}" Margin="10,0,0,0" />
|
<TextBlock Grid.Column="5" Style="{StaticResource Text.MutedEnd}" Text="{Binding LeftText}" Margin="10,0,0,0" />
|
||||||
<TextBlock Grid.Column="6" Style="{StaticResource Text.Muted}" Text="{Binding WhereText}" Margin="16,0,0,0" />
|
<TextBlock Grid.Column="6" Style="{StaticResource Text.Muted}" Text="{Binding WhereText}" Margin="16,0,0,0" />
|
||||||
<!-- A new state is announced with its job; progress ticks are not. -->
|
<!-- A new state is announced with its job; progress ticks are not. -->
|
||||||
<ui:StatusGlyph Grid.Column="7" Kind="{Binding StateKind}" Text="{Binding StateText}" ToolTip="{Binding StateToolTip}"
|
<ui:StatusGlyph Grid.Column="7" Kind="{Binding StateKind}" Text="{Binding StateText}" ToolTip="{Binding StateToolTip}"
|
||||||
|
|||||||
@@ -144,9 +144,13 @@ public sealed class ImportScreenSmokeTests
|
|||||||
foreach (var template in app.FindAll<TextBox>().Where(t => EditBehavior.GetField(t) is { } f && (f == import.FolderTemplate || f == import.FileTemplate)))
|
foreach (var template in app.FindAll<TextBox>().Where(t => EditBehavior.GetField(t) is { } f && (f == import.FolderTemplate || f == import.FileTemplate)))
|
||||||
Assert.Equal(FlowDirection.LeftToRight, template.FlowDirection, "name templates read left to right");
|
Assert.Equal(FlowDirection.LeftToRight, template.FlowDirection, "name templates read left to right");
|
||||||
Assert.Equal(FlowDirection.LeftToRight, TextFor(app, import.NamePreview).FlowDirection, "the name preview reads left to right");
|
Assert.Equal(FlowDirection.LeftToRight, TextFor(app, import.NamePreview).FlowDirection, "the name preview reads left to right");
|
||||||
|
// A size carries the language's unit, so it reads in the language's direction, whole, at the end of its cell.
|
||||||
var size = TextFor(app, import.Sessions[0].Row.SizeText);
|
var size = TextFor(app, import.Sessions[0].Row.SizeText);
|
||||||
Assert.Equal(FlowDirection.LeftToRight, size.FlowDirection);
|
Assert.Equal(FlowDirection.RightToLeft, size.FlowDirection);
|
||||||
Assert.Equal(TextAlignment.Right, size.TextAlignment, "numbers stay right-aligned");
|
Assert.Equal(TextAlignment.Right, size.TextAlignment);
|
||||||
|
var shown = size.ActualWidth + size.Margin.Left + size.Margin.Right;
|
||||||
|
size.Measure(new Size(double.PositiveInfinity, double.PositiveInfinity));
|
||||||
|
Assert.True(shown >= size.DesiredSize.Width - 0.5, $"the size column fits the whole size ({shown:0.#} < {size.DesiredSize.Width:0.#})");
|
||||||
Assert.Contains("←", import.Sessions[0].Row.TimeText);
|
Assert.Contains("←", import.Sessions[0].Row.TimeText);
|
||||||
await app.ExpectAsync<ImportView>("import-plan-ar");
|
await app.ExpectAsync<ImportView>("import-plan-ar");
|
||||||
|
|
||||||
|
|||||||
Reference in new issue
Block a user