From 2b6093ef58da99b301b75a3630f336dbd1a3bbbc Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 12 Oct 2026 00:20:35 +0000 Subject: [PATCH] fix(rtl): sizes, speeds and times left read in the language's direction and fit their column MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With sizes in the language's units, the left-to-right number cells of the Import tables and the Jobs speed and time-left columns put the unit after the number on screen, so an Arabic or Hebrew reader met the unit first ("18,6 كيلوبايت"), and the fixed column cut the longer word off. These cells and their headers now follow the reading direction at the end of the cell, and the Import size columns size to their content; bare numbers (percentages) stay left-to-right islands. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC --- docs/CHANGELOG.md | 3 ++- docs/DECISIONS.md | 1 + src/Titano.App/Sections/ImportView.xaml | 24 ++++++++----------- src/Titano.App/Sections/JobsView.xaml | 15 +++++++----- .../Import/ImportScreenSmokeTests.cs | 8 +++++-- 5 files changed, 28 insertions(+), 23 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index b8adaa8e..4db189fe 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -123,7 +123,8 @@ commits follow Conventional Commits (release notes are generated from them by `T Import session table now follow at once. - Right-to-left: in meta lines a number after a Latin field ("Canon EOS R5 · 2 h") joined the Latin run and split its own field; fields are now separated with right-to-left marks (left-to-right ones in the preview's frame data). - Charts no longer switch to Arabic-Indic digits after Arabic words. Desktop file sizes use the language's units. + Charts no longer switch to Arabic-Indic digits after Arabic words. Desktop file sizes use the language's units; + table cells holding a size, speed or time left read in the language's direction and fit their column. - CI: a full artifact storage failed jobs whose checks had passed; uploads no longer fail a job, artifacts expire in days, and screenshots reach their branch through the cache. - Release workflow: signing and the public-repository publish never ran (step conditions cannot read the step's own diff --git a/docs/DECISIONS.md b/docs/DECISIONS.md index 18df9138..08d0e22f 100644 --- a/docs/DECISIONS.md +++ b/docs/DECISIONS.md @@ -238,6 +238,7 @@ One line per decision: date · decision · alternative · reason. | 2026-10-06 | The regression test fills its server's log with about 2 MB up front, then logs one line about every 1 ms through the server's FileLoggerProvider only, on a LongRunning thread | A tight logging loop through ILoggerFactory (my first two versions) | The engine log sink is process-wide, so a console or file-lock flood stalled another test's job engine. The throttled version still reproduces the bug in 10 of 10 runs against the old endpoint. | | 2026-10-06 | Heartbeat test: count the claims the server answered with a DelegatingHandler, then wait for a later beat with a 30 s deadline | Keep the sleeps and widen the 400 ms window | It removes the timing assumption both ways (a false failure on a slow runner, and a false pass on the claim's own touch). It also proves no claim moved the beat. | | 2026-10-11 | Fields of a meta line are joined with `Loc.Separator`: " · " in left-to-right languages, " · " between right-to-left marks in right-to-left ones (`Loc.SeparatorOf(culture)` for texts built in another language) | Unicode isolates (FSI/PDI) around each field, or a left-to-right island for every meta line | WPF's bidi predates the isolates; without a strong right-to-left character before it, a number after a Latin field ("Canon EOS R5 · 2 h") joins the Latin run (rule W7) and splits its own field; islands would read the fields in left-to-right order. | +| 2026-10-12 | Table cells holding a value with the language's unit (sizes, speeds, times left) follow the reading direction at the end of the cell, like their header, and size columns fit their content; bare numbers (percentages, counts) stay left-to-right islands, right-aligned | Every number cell left to right | Once sizes use the language's units, a left-to-right cell put the unit after the number on screen, so Arabic and Hebrew readers met the unit first ("18,6 كيلوبايت"), and the longer words were cut off. | | 2026-10-12 | Fields shown in a left-to-right island are joined with `Loc.IslandSeparator` (" · " between left-to-right marks in right-to-left languages); charts format text with European digits | The reading-direction separator everywhere; the culture's digit substitution in charts | In the preview's frame data a localized time ends in a right-to-left mark ("6:03:41 م"), so the next field's number read as part of it and swapped places with the dot; with the UI culture, chart text after Arabic words drew Arabic-Indic digits while every text block shows European ones. | | 2026-10-11 | `LocalizedViewModel.OnLanguageChanged` is the hook for texts kept in objects: the editor makes its tabs' charts, Auto chips, markers and info line again; Jobs refreshes rows, chips and the job bar; Archive reads again; Import rebuilds its session table and device list | Re-create every section after a language switch, or ask for a restart | BRIEF §16 switches language without restart; a running job's bar line and an open editor's legend otherwise stayed in the old language until their next change. | | 2026-10-11 | Desktop sizes use the `Common.Size.*` formats, like the Setup and the Uploader | Hard-coded B, KB, MB, GB, TB, PB | Several languages write the units in their own script or words (КБ, bayt, كيلوبايت); every UI string is a resource. | diff --git a/src/Titano.App/Sections/ImportView.xaml b/src/Titano.App/Sections/ImportView.xaml index 9d80c554..aceccfb0 100644 --- a/src/Titano.App/Sections/ImportView.xaml +++ b/src/Titano.App/Sections/ImportView.xaml @@ -135,12 +135,8 @@ - - - @@ -482,14 +478,14 @@ - + - + @@ -501,14 +497,14 @@ - + - + - + - + @@ -680,14 +676,14 @@ - + - +