fix(rtl): sizes, speeds and times left read in the language's direction and fit their column

With sizes in the language's units, the left-to-right number cells of the Import
tables and the Jobs speed and time-left columns put the unit after the number on
screen, so an Arabic or Hebrew reader met the unit first ("18,6 كيلوبايت"), and the
fixed column cut the longer word off. These cells and their headers now follow the
reading direction at the end of the cell, and the Import size columns size to their
content; bare numbers (percentages) stay left-to-right islands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
This commit is contained in:
Claude committed 2026-10-12 00:20:35 +00:00
1 parent 3241b4710d
commit 2b6093ef58
5 files changed
+28 -23

No files matched your search

+10 -14
View File
@@ -135,12 +135,8 @@
<Setter Property="HorizontalAlignment" Value="Left" />
</Style>
<!-- Numbers stay right-aligned in tables in both directions. -->
<Style x:Key="Text.CellNumberLtr" TargetType="TextBlock" BasedOn="{StaticResource Text.CellNumber}">
<Setter Property="FlowDirection" Value="LeftToRight" />
</Style>
<Style x:Key="Text.HeaderNumber" TargetType="TextBlock" BasedOn="{StaticResource Text.Header}">
<Setter Property="FlowDirection" Value="LeftToRight" />
<!-- Sizes carry the language's unit ("18,6 كيلوبايت"): they read in its direction, at the end of the cell like their header. -->
<Style x:Key="Text.HeaderEnd" TargetType="TextBlock" BasedOn="{StaticResource Text.Header}">
<Setter Property="TextAlignment" Value="Right" />
</Style>
@@ -482,14 +478,14 @@
<Grid.ColumnDefinitions>
<ColumnDefinition Width="Auto" MinWidth="110" SharedSizeGroup="SessionTime" />
<ColumnDefinition Width="0.85*" MinWidth="70" />
<ColumnDefinition Width="0.6*" MinWidth="56" />
<ColumnDefinition Width="Auto" MinWidth="56" SharedSizeGroup="SessionSize" />
<ColumnDefinition Width="0.9*" MinWidth="64" />
<ColumnDefinition Width="1.6*" MinWidth="150" />
<ColumnDefinition Width="Auto" SharedSizeGroup="SessionAction" />
</Grid.ColumnDefinitions>
<TextBlock Style="{StaticResource Text.Header}" Text="{l:Loc Import.Session.Column.Session}" />
<TextBlock Grid.Column="1" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Session.Column.Frames}" Margin="10,0,0,0" />
<TextBlock Grid.Column="2" Style="{StaticResource Text.HeaderNumber}" Text="{l:Loc Import.Session.Column.Size}" Margin="10,0,0,0" />
<TextBlock Grid.Column="2" Style="{StaticResource Text.HeaderEnd}" Text="{l:Loc Import.Session.Column.Size}" Margin="10,0,0,0" />
<TextBlock Grid.Column="3" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Session.Column.Camera}" Margin="10,0,0,0" />
<TextBlock Grid.Column="4" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Session.Column.Sequence}" Margin="10,0,0,0" />
</Grid>
@@ -501,14 +497,14 @@
<Grid.ColumnDefinitions>
<ColumnDefinition Width="Auto" MinWidth="110" SharedSizeGroup="SessionTime" />
<ColumnDefinition Width="0.85*" MinWidth="70" />
<ColumnDefinition Width="0.6*" MinWidth="56" />
<ColumnDefinition Width="Auto" MinWidth="56" SharedSizeGroup="SessionSize" />
<ColumnDefinition Width="0.9*" MinWidth="64" />
<ColumnDefinition Width="1.6*" MinWidth="150" />
<ColumnDefinition Width="Auto" SharedSizeGroup="SessionAction" />
</Grid.ColumnDefinitions>
<TextBlock Style="{StaticResource Text.Cell}" Text="{Binding Row.TimeText}" ToolTip="{Binding Row.TimeText}" />
<TextBlock Grid.Column="1" Style="{StaticResource Text.Cell}" Text="{Binding Row.FramesText}" Margin="10,0,0,0" />
<TextBlock Grid.Column="2" Style="{StaticResource Text.CellNumberLtr}" Text="{Binding Row.SizeText}" Margin="10,0,0,0" />
<TextBlock Grid.Column="2" Style="{StaticResource Text.CellNumber}" Text="{Binding Row.SizeText}" Margin="10,0,0,0" />
<TextBlock Grid.Column="3" Style="{StaticResource Text.Cell}" Text="{Binding Row.CameraText}" Margin="10,0,0,0" ToolTip="{Binding Row.CameraText}" />
<DockPanel Grid.Column="4" Margin="10,0,0,0">
<TextBlock x:Name="Target" DockPanel.Dock="Right" Text="{l:Loc Import.Session.NewShort}" Foreground="{DynamicResource Brush.Accent}"
@@ -658,13 +654,13 @@
<ColumnDefinition Width="1.2*" MinWidth="140" />
<ColumnDefinition Width="1.8*" MinWidth="180" />
<ColumnDefinition Width="0.8*" MinWidth="90" />
<ColumnDefinition Width="0.5*" MinWidth="64" />
<ColumnDefinition Width="Auto" MinWidth="64" SharedSizeGroup="PlanSize" />
<ColumnDefinition Width="Auto" SharedSizeGroup="PlanAction" />
</Grid.ColumnDefinitions>
<TextBlock Style="{StaticResource Text.Header}" Text="{l:Loc Import.Details.Column.Source}" />
<TextBlock Grid.Column="1" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Details.Column.Destination}" Margin="10,0,0,0" />
<TextBlock Grid.Column="2" Style="{StaticResource Text.Header}" Text="{l:Loc Import.Details.Column.Action}" Margin="10,0,0,0" />
<TextBlock Grid.Column="3" Style="{StaticResource Text.HeaderNumber}" Text="{l:Loc Import.Session.Column.Size}" Margin="10,0,0,0" />
<TextBlock Grid.Column="3" Style="{StaticResource Text.HeaderEnd}" Text="{l:Loc Import.Session.Column.Size}" Margin="10,0,0,0" />
</Grid>
<ListBox x:Name="PlanRows" Grid.Row="3" ItemsSource="{Binding Rows}" ItemContainerStyle="{StaticResource ListBoxItem.PlanRow}" AutomationProperties.Name="{l:Loc Import.Details.Title}"
KeyboardNavigation.TabNavigation="Continue" ScrollViewer.VerticalScrollBarVisibility="Visible">
@@ -680,14 +676,14 @@
<ColumnDefinition Width="1.2*" MinWidth="140" />
<ColumnDefinition Width="1.8*" MinWidth="180" />
<ColumnDefinition Width="0.8*" MinWidth="90" />
<ColumnDefinition Width="0.5*" MinWidth="64" />
<ColumnDefinition Width="Auto" MinWidth="64" SharedSizeGroup="PlanSize" />
<ColumnDefinition Width="Auto" SharedSizeGroup="PlanAction" />
</Grid.ColumnDefinitions>
<TextBlock x:Name="Source" Style="{StaticResource Text.Cell}" Text="{Binding SourceText}" ToolTip="{Binding Source}" />
<TextBlock x:Name="Destination" Grid.Column="1" Style="{StaticResource Text.CellPath}" Text="{Binding DestinationText}" Margin="10,0,0,0"
ToolTip="{Binding Destination}" />
<TextBlock x:Name="Action" Grid.Column="2" Style="{StaticResource Text.Cell}" Text="{Binding ActionText}" Margin="10,0,0,0" />
<TextBlock Grid.Column="3" Style="{StaticResource Text.CellNumberLtr}" Text="{Binding SizeText}" Margin="10,0,0,0" />
<TextBlock Grid.Column="3" Style="{StaticResource Text.CellNumber}" Text="{Binding SizeText}" Margin="10,0,0,0" />
<Button x:Name="Split" Grid.Column="4" Style="{StaticResource Button.RowAction}" Margin="10,0,4,0" Content="{l:Loc Import.Details.Split}"
Command="{Binding DataContext.SplitCommand, RelativeSource={RelativeSource AncestorType=UserControl}}" CommandParameter="{Binding}"
ToolTip="{l:Loc Tooltips.Import.Split}" AutomationProperties.Name="{Binding SplitName}" Visibility="Hidden" />
+9 -6
View File
@@ -19,9 +19,12 @@
<Setter Property="TextAlignment" Value="Right" />
<Setter Property="FlowDirection" Value="LeftToRight" />
</Style>
<Style x:Key="Text.HeaderNumber" TargetType="TextBlock" BasedOn="{StaticResource Text.Header}">
<!-- Speeds and times left carry the language's unit ("2 د"): they read in its direction, at the end of the cell like their header. -->
<Style x:Key="Text.MutedEnd" TargetType="TextBlock" BasedOn="{StaticResource Text.Muted}">
<Setter Property="TextAlignment" Value="Right" />
</Style>
<Style x:Key="Text.HeaderEnd" TargetType="TextBlock" BasedOn="{StaticResource Text.Header}">
<Setter Property="TextAlignment" Value="Right" />
<Setter Property="FlowDirection" Value="LeftToRight" />
</Style>
<Style x:Key="ProgressBar.Job" TargetType="ProgressBar" BasedOn="{StaticResource {x:Type ProgressBar}}">
<Style.Triggers>
@@ -123,8 +126,8 @@
<TextBlock Grid.Column="1" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.Kind}" Margin="10,0,0,0" />
<TextBlock Grid.Column="2" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.Target}" Margin="10,0,0,0" />
<TextBlock Grid.Column="3" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.Progress}" Margin="10,0,0,0" />
<TextBlock Grid.Column="4" Style="{StaticResource Text.HeaderNumber}" Text="{l:Loc Jobs.Column.Speed}" Margin="10,0,0,0" />
<TextBlock Grid.Column="5" Style="{StaticResource Text.HeaderNumber}" Text="{l:Loc Jobs.Column.Left}" Margin="10,0,0,0" />
<TextBlock Grid.Column="4" Style="{StaticResource Text.HeaderEnd}" Text="{l:Loc Jobs.Column.Speed}" Margin="10,0,0,0" />
<TextBlock Grid.Column="5" Style="{StaticResource Text.HeaderEnd}" Text="{l:Loc Jobs.Column.Left}" Margin="10,0,0,0" />
<TextBlock Grid.Column="6" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.Where}" Margin="16,0,0,0" />
<TextBlock Grid.Column="7" Style="{StaticResource Text.Header}" Text="{l:Loc Jobs.Column.State}" Margin="10,0,0,0" />
</Grid>
@@ -165,8 +168,8 @@
AutomationProperties.Name="{Binding AccessibleName}" />
<TextBlock Grid.Column="1" Style="{StaticResource Text.MutedNumber}" Text="{Binding PercentText}" />
</Grid>
<TextBlock Grid.Column="4" Style="{StaticResource Text.MutedNumber}" Text="{Binding SpeedText}" Margin="10,0,0,0" />
<TextBlock Grid.Column="5" Style="{StaticResource Text.MutedNumber}" Text="{Binding LeftText}" Margin="10,0,0,0" />
<TextBlock Grid.Column="4" Style="{StaticResource Text.MutedEnd}" Text="{Binding SpeedText}" Margin="10,0,0,0" />
<TextBlock Grid.Column="5" Style="{StaticResource Text.MutedEnd}" Text="{Binding LeftText}" Margin="10,0,0,0" />
<TextBlock Grid.Column="6" Style="{StaticResource Text.Muted}" Text="{Binding WhereText}" Margin="16,0,0,0" />
<!-- A new state is announced with its job; progress ticks are not. -->
<ui:StatusGlyph Grid.Column="7" Kind="{Binding StateKind}" Text="{Binding StateText}" ToolTip="{Binding StateToolTip}"