AppEnvironment now carries AppPaths.SyncedFolder: when the per-user data
folder itself lies in a OneDrive sync root, Titano still starts (nowhere
is safer), logs it and shows the error toast "Data inside OneDrive" with
Open, instead of the false "Data kept outside OneDrive". The latter now
needs PortableSyncRoot (renamed from the old SyncedFolder meaning).
A portable copy now in a OneDrive folder whose .\data still holds an
index or settings.json gets that folder named in the log and in a toast
("Earlier data unused", with Open). Nothing is moved or deleted.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
83 lines
4.4 KiB
C#
83 lines
4.4 KiB
C#
using System.IO;
|
|
using Titano.App.Infrastructure;
|
|
using Titano.Core.Windows.Shell;
|
|
using Titano.Testing;
|
|
|
|
namespace Titano.App.Tests.Infrastructure;
|
|
|
|
/// <summary>BRIEF §6.2: the client's data folder, which is never inside a folder OneDrive synchronises.</summary>
|
|
public sealed class AppEnvironmentTests(TestContext context)
|
|
{
|
|
[Test]
|
|
public void APortableCopyInOneDriveKeepsItsDataInTheUserFolderAndSaysSo()
|
|
{
|
|
var oneDrive = context.CreateTempDirectory("onedrive");
|
|
var app = Directory.CreateDirectory(Path.Combine(oneDrive, "Desktop", "Titano")).FullName;
|
|
File.WriteAllText(Path.Combine(app, PortableMode.MarkerFileName), "");
|
|
var local = context.CreateTempDirectory("local");
|
|
|
|
var environment = AppEnvironment.From(AppPaths.Resolve(app, local, [oneDrive]));
|
|
|
|
Assert.Equal(Path.Combine(local, "Titano", "titano.db"), environment.DatabasePath);
|
|
Assert.True(environment.IsPortable, "still a portable copy: updates fetch the portable zip, no sign-in entry");
|
|
Assert.Equal<string?>(oneDrive, environment.PortableSyncRoot);
|
|
Assert.Null(environment.SyncedFolder);
|
|
Assert.Null(environment.EarlierPortableData);
|
|
Assert.True(Directory.Exists(environment.LogDirectory));
|
|
Assert.False(Directory.Exists(Path.Combine(app, "data")), "nothing is written into the synchronised folder");
|
|
|
|
// Elsewhere (a USB stick) a portable copy keeps its data beside it.
|
|
var stick = context.CreateTempDirectory("stick");
|
|
File.WriteAllText(Path.Combine(stick, PortableMode.MarkerFileName), "");
|
|
var beside = AppEnvironment.From(AppPaths.Resolve(stick, local, [oneDrive]));
|
|
Assert.Equal(Path.Combine(stick, "data"), beside.DataDirectory);
|
|
Assert.Null(beside.PortableSyncRoot);
|
|
Assert.Null(beside.SyncedFolder);
|
|
}
|
|
|
|
[Test]
|
|
public void TheDataAPortableCopyKeptInOneDriveBeforeIsNamedAndLeftAlone()
|
|
{
|
|
var oneDrive = context.CreateTempDirectory("onedrive");
|
|
var app = Directory.CreateDirectory(Path.Combine(oneDrive, "Documents", "Titano")).FullName;
|
|
File.WriteAllText(Path.Combine(app, PortableMode.MarkerFileName), "");
|
|
// An earlier version kept its index and settings beside the program.
|
|
var earlier = Directory.CreateDirectory(Path.Combine(app, "data")).FullName;
|
|
File.WriteAllText(Path.Combine(earlier, "settings.json"), "{}");
|
|
File.WriteAllBytes(Path.Combine(earlier, "titano.db"), [1, 2, 3]);
|
|
var local = context.CreateTempDirectory("local");
|
|
|
|
var environment = AppEnvironment.From(AppPaths.Resolve(app, local, [oneDrive]));
|
|
|
|
Assert.Equal<string?>(earlier, environment.EarlierPortableData);
|
|
Assert.Equal(Path.Combine(local, "Titano"), environment.DataDirectory);
|
|
Assert.SequenceEqual(new byte[] { 1, 2, 3 }, File.ReadAllBytes(Path.Combine(earlier, "titano.db")));
|
|
Assert.Equal("{}", File.ReadAllText(Path.Combine(earlier, "settings.json")));
|
|
|
|
// A data folder with neither (logs only) holds nothing the user would miss.
|
|
File.Delete(Path.Combine(earlier, "settings.json"));
|
|
File.Delete(Path.Combine(earlier, "titano.db"));
|
|
Directory.CreateDirectory(Path.Combine(earlier, "logs"));
|
|
Assert.Null(AppEnvironment.From(AppPaths.Resolve(app, local, [oneDrive])).EarlierPortableData);
|
|
}
|
|
|
|
[Test]
|
|
public void AUserFolderOneDriveSynchronisesIsReportedNotHidden()
|
|
{
|
|
// Nowhere is safe: Titano starts all the same, and the folder that is synchronised is named for the warning.
|
|
var oneDrive = context.CreateTempDirectory("onedrive");
|
|
var local = Directory.CreateDirectory(Path.Combine(oneDrive, "AppData", "Local")).FullName;
|
|
|
|
var installed = AppEnvironment.From(AppPaths.Resolve(context.CreateTempDirectory("app"), local, [oneDrive]));
|
|
Assert.Equal<string?>(oneDrive, installed.SyncedFolder);
|
|
Assert.Null(installed.PortableSyncRoot);
|
|
Assert.True(Directory.Exists(installed.LogDirectory));
|
|
|
|
// A portable copy in that OneDrive has nowhere safe either: its data is not said to be kept outside it.
|
|
var app = Directory.CreateDirectory(Path.Combine(oneDrive, "Desktop", "Titano")).FullName;
|
|
File.WriteAllText(Path.Combine(app, PortableMode.MarkerFileName), "");
|
|
var portable = AppEnvironment.From(AppPaths.Resolve(app, local, [oneDrive]));
|
|
Assert.Equal<(string?, string?)>((oneDrive, oneDrive), (portable.SyncedFolder, portable.PortableSyncRoot));
|
|
}
|
|
}
|