Second fix round of owner review 2, phase 3 (engine, server, desktop).
- A photo never hashed whose original is missing can be deleted again: it goes
into its trash record without a file and without a tombstone (nothing is left
to name), stays listed until Empty erases it, and a restore keeps it with the
reason "no file". FrameDeleteBlock.Unhashable now blocks only a present
original that cannot be read; the API answers it as 409 photo_unreadable
naming the photo, and every block has its own code and message.
- Deleting a whole sequence first settles an interrupted photo deletion,
restore or ingest of it (ReadLocked under its lease), so no journal or half
entry travels into the sequence's trash entry; it refuses while a restore
into it waits for its busy entry.
- FrameTrash.Settle takes the photo entry's lease and leaves the journal for
later while the entry is busy (an emptying), so it never races EraseAsync;
meanwhile no other restore writes its journal over it and scans do not adopt
its files.
- The hashes computed for frames that stay (to find a twin of a deleted photo)
go into the sidecar and index, and only a frame whose first and last 64 KiB
match a deleted photo's is read whole.
- A restore into a new sequence rewrites its record after each photo filed, so
a crash or a database failure never leaves filed photos listed.
- An upload completion no longer has a window before the commit: the ingest
checks the sidecar's tombstones under the sequence lease a deletion takes
(IngestRequest.RefuseRemoved), unless the upload asked to bring it back.
- A restore reports each kept photo with its reason (no longer matches its
record, could not be moved back, already in the sequence, had no file); the
desktop line and the API message say so in en and it, and the tooltip holds
the whole sentence. The desktop tells TrashMismatchException by its type.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 1858f1f450a35fb8383ede8d80ce5f8de9b7ceac)