feat: owner review 2 phase 1 (:latest, Unraid array space, Settings with About, whole-folder import) #9

Merged
Alby96 merged 27 commits from claude/owner-review-2-p1 into main 2026-10-27 01:10:05 +01:00
Owner

Owner review 2, phase 1 (docs/requests/2026-10-26-owner-review-2.md):

  • R1 :latest follows the highest stable release, or the highest pre-release while no stable release exists. The new Chronos.Tools release-channels decides by SemVer 2.0 precedence across every page of releases. A tag that cannot decide warns and moves nothing. Bad tags are refused before anything is built.
  • R2 Unraid array space:
    • CHRONOS_SPACE_PATH and the template's Array view (/mnt/user0/<share> → /space, read-only);
    • the dashboard shows the space volume, plus the write volume (cache) when it differs, and names the file system from /proc/self/mountinfo;
    • completing an upload, a render upload or a node result checks the archive volume first (507).
  • R4 Settings drawn as a toothed gear, in the desktop, the Uploader and the panel. The panel docks Settings at the foot of the sidebar; on short windows the pages above it scroll.
  • R5 About is the last part of Settings, on the desktop and in the panel. #/about opens it. The rail and sidebar lose an entry.
  • R9 Import › Folder… › Group › Whole folder: one sequence per format, cameras and pauses ignored, titled after the folder, resumable. Desktop only.

How it was checked:

  • Five packages built in parallel.
  • One adversarial review round: 19 confirmed findings fixed, each fix checked.
  • Strings in all 38 languages.
  • Local results: Release build with 0 warnings; tests green (Core 1200, Data 413, Server 178, Tools 60, App 622 with this PC's usual exclusions, Core.Windows 78); i18n, xaml-lint, package-guard and format all clean.
  • The panel was tried by hand on a local server.

After the merge: tag v0.1.0-rc.3, which publishes the installers and chronos-server:0.1.0-rc.3 + :latest.

🤖 Generated with Claude Code

Owner review 2, phase 1 (`docs/requests/2026-10-26-owner-review-2.md`): - **R1** `:latest` follows the highest stable release, or the highest pre-release while no stable release exists. The new `Chronos.Tools release-channels` decides by SemVer 2.0 precedence across every page of releases. A tag that cannot decide warns and moves nothing. Bad tags are refused before anything is built. - **R2** Unraid array space: - `CHRONOS_SPACE_PATH` and the template's *Array view* (`/mnt/user0/<share>` → `/space`, read-only); - the dashboard shows the space volume, plus the write volume (cache) when it differs, and names the file system from `/proc/self/mountinfo`; - completing an upload, a render upload or a node result checks the archive volume first (507). - **R4** Settings drawn as a toothed gear, in the desktop, the Uploader and the panel. The panel docks Settings at the foot of the sidebar; on short windows the pages above it scroll. - **R5** About is the last part of Settings, on the desktop and in the panel. `#/about` opens it. The rail and sidebar lose an entry. - **R9** Import › Folder… › Group › *Whole folder*: one sequence per format, cameras and pauses ignored, titled after the folder, resumable. Desktop only. How it was checked: - Five packages built in parallel. - One adversarial review round: 19 confirmed findings fixed, each fix checked. - Strings in all 38 languages. - Local results: Release build with 0 warnings; tests green (Core 1200, Data 413, Server 178, Tools 60, App 622 with this PC's usual exclusions, Core.Windows 78); i18n, xaml-lint, package-guard and format all clean. - The panel was tried by hand on a local server. After the merge: tag `v0.1.0-rc.3`, which publishes the installers and `chronos-server:0.1.0-rc.3` + `:latest`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Alby96 added 26 commits 2026-10-26 23:52:27 +01:00
The owner's second review (2026-10-26) with its interpretation R1-R12, the
answers to the questions and the phase plan; also fills in owner review 1's
phase 3b row, whose state and commit were left as placeholders.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only pre-releases (v0.1.0-rc.1, rc.2) are published, and :latest followed the highest stable release only, so the
Unraid template and the compose file, which pull :latest, found no image while :nightly was pushed every night.

The new Chronos.Tools command release-channels reads the published releases (stable and pre-releases), ignores drafts
and tags that are not SemVer, counts the tag itself as published and compares by SemVer 2.0 precedence. It prints
latest (the public releases repository: highest stable release only) and image_latest (:latest: the highest stable
release, or the highest pre-release while none is stable). Re-publishing an older tag never rolls either back.
release.yml uses it in place of curl|grep|sort -V; the image job pushes :latest on image_latest. README, the public
README, the compose file and ARCHITECTURE explain :latest, :<version> and :nightly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On Unraid the archive is a user share (FUSE shfs), which reports the share's
primary storage, often the cache, while the mover sends the photos to the
array: the admin panel showed the cache's free space (owner review 2, R2).

- New option SpacePath (server.json) / CHRONOS_SPACE_PATH: the admin panel
  shows that folder's volume; empty, or a folder that cannot be measured, falls
  back to the archive's volume (one warning, at start, not per request).
- VolumeSpace measures folders (DriveInfo; the path root on Windows) and reads
  the filesystem type and mount from /proc/self/mountinfo on Linux (longest
  mount point on segment boundaries, octal escapes, optional fields, the top of
  stacked mounts), since DriveFormat calls an shfs share only "fuse". It is an
  injectable service, so tests simulate a full volume; the /data checks use it.
- ArchiveStatsDto keeps FreeBytes/CapacityBytes for the shown volume and gains
  optional trailing members: the write volume's figures (when a space path is
  in use and they differ), the filesystem type and UsesSpacePath.
- Admin panel (dashboard and archive): a tooltip on the storage figures names
  the volume and its filesystem and, on an shfs share without a space path,
  says they are the primary storage and to map the array view to /space; a
  "Write volume" line shows the archive's own volume when it differs.
- Completing an upload, a render upload or a render node's result checks the
  archive volume for its size plus the 64 MiB reserve before the staging copy
  and answers 507 insufficient_storage, the upload still receiving.
- Diagnostics list the archive and space volumes with filesystem and mount.
- Unraid template: optional read-only "Array view" /space (default
  /mnt/user0/Timelapse) and "Space path" CHRONOS_SPACE_PATH=/space; compose and
  the releases README describe the same as an option.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner review 2, R9: Import › Folder… gains a "Group" choice for picked
folders: Sessions (as before) or Whole folder. A whole folder, with its
subfolders when Subfolders is on, becomes one sequence per file format;
camera bodies and pauses are ignored, while RAW+JPEG of the same shots
stays two sequences so no frame is ever doubled. Only the user's splits
break it, and Merge joins a split part back.

The planner implements it (ImportOptions.Grouping, Core, Linux-tested):
the session key is "folder-" plus a hash of this PC's name, the full
path and the format, so an interrupted or repeated import continues the
same sequence; the default title is the folder's name. The plan shows
one row per format with the format and the number of cameras. Cards and
drives always import by sessions; the choice is not part of a card
profile and a folder starts on Sessions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner review 2 (R4, R5): the Settings icon, a circle with rays, read as a sun,
and the web panel's sidebar spent an entry on About.

- branding/ui-icons/icons.py draws Settings as a toothed gear (8 teeth, centre
  hole) with a new gear() helper and now also writes the web admin's icons.js,
  so both programs and the panel share one path; it writes UTF-8 with LF on
  every OS (on Windows it wrote Icons.xaml in the ANSI code page).
- The panel's menu has a top group (Dashboard, Users, Archive, Jobs, Logs) and
  Settings docked at its foot above the account; collapsed, narrow and RTL
  layouts keep working.
- About (version, API, database, uptime) is the last, read-only group of
  Settings; pages/about.js is gone and #/about opens Settings on that group.
  The server name and the fingerprint rows are dropped there: the Server and
  Network groups already show them on the same page.
- Admin.Nav.About(.Tip), Admin.About.Name and Admin.About.Fingerprint are
  removed (pruned in every culture); Admin.Settings.About is new (en, it).
- DESIGN.md and the admin mockups follow; the tests read both menu groups and
  check that About is folded into Settings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The owner asked to fold the About section into Settings to save room in the
side rail (owner review 2, R5). The rail now docks Settings alone at the
bottom; About is the last Settings page with this copy's identity: version,
build, runtime, system, licence link, third-party notice and, outside English,
the machine-translation notice with its review link.

Nothing is offered twice inside Settings: the update check, its notice and the
releases link live on Updates, the data folder and the diagnostics bundle on
Advanced, so About's duplicate buttons and its own diagnostics code are gone.
AboutViewModel stays as a plain helper owned by the shell (Chronos.App.About),
which keeps every Shell.About binding and the update check on start.

SectionKey.About, AboutView and the rail strings are removed (orphans pruned
from every culture, which also re-sorts two Setup tooltip keys); the capture,
the smoke tests, DESIGN, ARCHITECTURE, the desktop mockups and the docs that
pointed at About follow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The About entry of the Settings search always listed "Translation" among its
keywords, and its tooltip named the translation, but that row shows only
outside English. In English a search for "Translation" left About alone in the
list and selected a page without such a row. The page's search words are now
read at each search, so the keyword follows the language while Settings is
open, and the tooltip no longer names a row that may be hidden.

Also drop About from the doc comments of the update notice and the
diagnostics bundle: since owner review 2, R5 only Settings › Updates and
Settings › Advanced offer them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Unraid share tooltip told users only to map the share's array view to
/space. With CHRONOS_SPACE_PATH unset (the shipped docker-compose file, or a
template whose Space path was cleared) the server never looks at /space, so
following the tip changed nothing. The tip (en, it) and BRIEF 14.8 now also
say to set CHRONOS_SPACE_PATH=/space; the English text was shortened to stay
within the 200-character tooltip budget.

A render node completing its result on a full archive volume answers 507
before the upload moves to Committing, but no test covered that path. The new
VolumeSpaceTests case checks that the upload keeps receiving with its chunks
and the node keeps the job, then that the same call succeeds once there is
room.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The release step decided :latest and the releases repository's content
after the Gitea release was already public, and could then fail or decide
wrongly (owner review 2, phase 1 review):

- Re-publishing v0.1.0-rc.1 or rc.2 builds Chronos.Tools from the tag,
  which has no release-channels: the step failed after publishing and the
  image job never ran. Any failure to decide (a tag older than the
  command, an unreadable page, a body that is not a list) now warns and
  moves no channel, so the version's image is still pushed.
- Only the first page (50, newest first) of releases was read, and
  pre-releases now share it with stable ones: 50 pre-releases after a
  stable release hid it and moved :latest to a pre-release. The workflow
  reads every page up to the first empty one (at most 100) and
  release-channels takes one --releases file per page (Args.GetAll).
- The Version step accepted tags release-channels refuses (v01.2.0), which
  then failed only after publishing. It now uses release-channels' SemVer
  2.0 pattern without +BUILD, and a test keeps the two in step.

BRIEF §19.3, DECISIONS, CHANGELOG and README step 5 say so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Settings waited for /server/dashboard (archive statistics, volume space) before it drew,
so a large archive or a slow mount kept the whole form empty for About's two rows. The
form now draws as soon as /server/settings answers; database and uptime show a dash and
fill in when the dashboard answers, without a redraw, so focus and edits stay. They stay
off /server/info, which is anonymous.

In the wide layout the sidebar never scrolled, so on short windows the docked Settings
entry and the account were cut off. The page list above them now scrolls, with room for
the focus rings, and the whole sidebar scrolls only when even the docked part does not
fit, expanded and collapsed alike; the narrow top bar is unchanged.

The bug report form now points at admin panel > Settings > About, since About is no
longer a sidebar entry.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A whole folder imported again to the server sent its folder name as the
sequence title on every run, undoing a rename made on the server. The
sink now sends a typed title as before, but the folder's default name
only to a sequence that has no title yet (it reads the sequence first).
The archive already applied a title only when it created the sequence.

A session that ends on another day, as a whole folder often does,
showed only its first date ("28/09/2026 · 18:02 → 18:05"), which read
as a few minutes on one day. Its plan row and Show plan heading now
show both dates, from two new invariant resources (with the
right-to-left arrow).

The Gap and Minimum boxes now show their tooltip while disabled, so the
reason Whole folder turns them off reaches them, not only the Sessions
check box. Doc comments that said a merge needs the same camera now
mention the whole-folder rule.

Tests: a server whole-folder import run twice keeps the server's rename
and still applies a typed title; multi-day time text in both reading
directions; and the Import view model's Group rules (folder only, cards
planned by sessions, switching drops splits, tooltips say why).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The scrolling page list could shrink to its padding, hiding every link below about
255 px of height; it now keeps one link's height and the sidebar scrolls past that,
without a horizontal scrollbar. The panel test pins the About rows that fill in late.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Machine translated with each language's glossary, as the other strings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs: changelog section and status for 0.1.0-rc.3
CI / Build and test (pull_request) Successful in 9m5s
CI / Windows tests and installer (pull_request) Skipped
CI / YAML check (pull_request) Successful in 25s
CI / PostgreSQL 16 integration (pull_request) Successful in 11m4s
CI / PostgreSQL 17 integration (pull_request) Failing after 11m18s
CI / Docker image (pull_request) Successful in 2m8s
6ec91dcf33
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Alby96 added 1 commit 2026-10-27 00:41:49 +01:00
test(server): scale the job waits by the CI time factor
CI / Build and test (pull_request) Successful in 5m35s
CI / Windows tests and installer (pull_request) Skipped
CI / YAML check (pull_request) Successful in 4s
CI / PostgreSQL 16 integration (pull_request) Successful in 4m13s
CI / PostgreSQL 17 integration (pull_request) Successful in 4m8s
CI / Docker image (pull_request) Successful in 1m29s
92dba8665a
RenderJobsThatCannotBeReadNeverStopTheEngine timed out on the shared runner
(PostgreSQL 17) while the upload's background jobs ran first: the 15 s wait was
the one job wait not scaled by CHRONOS_TEST_TIME_FACTOR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Alby96 merged commit 1f089888e8 into main 2026-10-27 01:10:05 +01:00
Sign in to join this conversation.