Files
Alby96andClaude Opus 5.5 7e4a3b481d
CI / Build and test (push) Successful in 9m15s
CI / Windows tests and installer (push) Skipped
CI / YAML check (push) Successful in 6s
Release / Build, test and publish (push) Successful in 15m35s
CI / PostgreSQL 16 integration (push) Successful in 7m26s
CI / PostgreSQL 17 integration (push) Successful in 6m47s
CI / Docker image (push) Successful in 59s
Release / Server image (push) Successful in 1m24s
feat: owner review 2 phase 4a: Reorganize sequences after import (#12)
- Reorganize… on the web panel and the desktop: folder, file and title templates applied to existing sequences, with a dry run and an explicit Apply that runs as a job.
- One naming rule (FrameNaming) for import, upload and Reorganize.
- Crash-safe plan and file journals, held plans, stale-plan refusal; exports move with their folder.
- Writers refuse a folder another program moved or gave to another sequence.
- Server: POST /api/v1/archive/reorganize with a bounded plan cache; template rules.
- Phase 3 docs and translations merged; strings in all 38 languages.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Alberto Balbo <alberto.balbo.96@gmail.com>
2026-10-27 21:58:39 +01:00

245 lines
12 KiB
C#
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
using System.Collections.Specialized;
using System.Windows;
using System.Windows.Controls;
using System.Windows.Input;
using System.Windows.Media;
using Chronos.App.Archiving;
using Chronos.App.Infrastructure;
using Chronos.App.Library;
using Chronos.App.Sections;
using Chronos.App.Shell;
using Chronos.App.Tests.Windows;
using Chronos.Core.Localization;
using Chronos.Core.Model;
using Chronos.Testing;
using Chronos.Ui.Controls;
using Chronos.Ui.Visuals;
namespace Chronos.App.Tests.Library;
/// <summary>
/// The Library's new states of <c>--capture</c> (<see cref="LibraryScenes"/>) on the sample index while signed in to the
/// sample server, rendered in both themes in the real main window: the timeline, a selection with the whole mass actions
/// bar and its delete dry run, the server's sequences as remote cards, saved views and Save view, and the archive's trash.
/// </summary>
[WindowsOnly]
[Serial]
[Timeout(300_000)]
public sealed class LibraryScreenSmokeTests
{
[Test]
public Task EveryLibrarySceneRendersInBothThemes() => ScreenHost.RunAsync(async () =>
{
await using var app = await ScreenSmokeTests.SampleApp.StartAsync();
await app.Sample.FillAsync();
await app.Shell.Services.Server.RestoreAsync();
await app.Shell.Services.Sync.RefreshAsync();
var library = app.Shell.Library;
await LibraryScenes.ShowAsync(app.Shell, "timeline");
Assert.True(library.IsTimeline, "the timeline shows its bands");
Assert.True(library.IsGrid, "the cards stay under the bands");
Assert.Equal(2, library.TimelineBands.Count, "one band per year, 2026 and 2025, the server's sequences included");
Assert.True(library.TimelineBand >= 0 && library.TimelineSlot >= 0, "the chosen month is outlined");
Assert.True(library.IsYearFiltered, "a month narrows the Library to its year");
await app.ExpectAsync<LibraryView>("library-timeline", waitForThumbnails: true);
var bands = Assert.NotNull(app.FindAll<TimelineBands>().FirstOrDefault(t => t.IsVisible && t.ActualHeight > 0), "the bands are drawn");
Assert.True(bands.Focusable, "the keyboard reaches the months");
// Without the mouse: Enter on the month under the keyboard narrows the Library to its year.
library.ClearFiltersCommand.Execute(null);
await library.RefreshAsync();
Assert.Equal(-1, library.TimelineBand);
bands.Focus();
Press(bands, Key.Enter);
await library.RefreshAsync();
Assert.True(library.TimelineBand >= 0 && library.TimelineSlot >= 0, "Enter chose a month");
Assert.True(library.IsYearFiltered, "the year filter follows the band");
await LibraryScenes.ShowAsync(app.Shell, "mass");
Assert.Equal(LibraryScenes.MassSelection, library.SelectionCount);
await app.ExpectAsync<LibraryView>("library-mass", waitForThumbnails: true);
foreach (var command in new[] { library.AnalyseCommand, library.ProxiesCommand, library.VerifyCommand, library.TagCommand, library.ReorganizeCommand,
library.ExportListCommand, library.DeleteCommand })
Assert.True(ButtonFor(app, command).IsEnabled, "the bar's archive actions work on sequences of this PC");
Assert.True(library.CanRate);
var request = Assert.NotNull(await LibraryScenes.DeleteRequestAsync(app.Shell), "the dry run moves something");
Assert.True(request.IsDestructive);
Assert.NotNull(request.TypedConfirmation);
var dialog = new ConfirmDialog(request) { WindowStartupLocation = WindowStartupLocation.Manual, Left = -20000, Top = -20000, ShowActivated = false };
dialog.Show();
try
{
dialog.UpdateLayout();
var action = Find<Button>(dialog).Single(b => Equals(b.Content, request.ActionText));
Assert.False(action.IsEnabled, "Delete waits for the typed confirmation");
Find<TextBox>(dialog).Single(t => t.IsVisible).Text = request.TypedConfirmation;
Assert.True(action.IsEnabled, "typing the count enables Delete");
}
finally
{
dialog.Close();
}
// The sample dialogs cancel every confirmation: the delete dialog closes and nothing moves.
var selected = library.SelectedItems().Select(i => i.Id).ToList();
Assert.False(await library.DeleteAsync(selected));
Assert.Null(library.Dialog, "the delete dialog closes once it is answered");
foreach (var id in selected) Assert.NotNull(await app.Services.Database!.Sequences.GetAsync(id));
var first = library.Items.First(i => i.IsSelected);
Assert.True(library.AnalyseItemCommand.CanExecute(first) && library.RenderItemCommand.CanExecute(first), "the quick actions run on this PC's engine");
await LibraryScenes.ShowAsync(app.Shell, "remote");
Assert.True(library.ShowsOrigin, "signed in, the origin filter shows");
Assert.Equal(2, library.Items.Count, "the two sequences only on the sample server");
Assert.True(library.Items.All(i => i.IsRemote));
Assert.True(library.IsSingleSelection);
Assert.False(library.DeleteCommand.CanExecute(null), "a remote card has nothing here to delete");
Assert.True(library.DownloadCommand.CanExecute(null), "its originals can come here");
Assert.False(library.RevealCommand.CanExecute(null), "a remote card has no folder here");
Assert.Equal(Loc.L("Library.Blocked.ServerOnly"), library.RevealToolTip);
await app.ExpectAsync<LibraryView>("library-remote");
Assert.True(library.Years.Count > 1, "the server's years are choices too");
library.ClearFiltersCommand.Execute(null);
await library.RefreshAsync();
Assert.True(library.HasViews, "the sample saved two views");
library.ViewChoices.Single(v => v.Label == "Nikon Z 8").Command.Execute(null);
await library.RefreshAsync();
Assert.True(library.IsViewActive);
Assert.True(library.Items.Count > 0 && library.Items.All(i => i.Sequence.CameraModel == "NIKON Z 8"));
await LibraryScenes.ShowAsync(app.Shell, "viewname");
var naming = Assert.NotNull(library.Dialog as ViewNameDialogViewModel, "Save view asks a name");
Assert.True(naming.SaveCommand.CanExecute(null), "the status filter's label is a free name");
Assert.False(library.IsContentEnabled, "the screen behind a dialog takes no input");
await app.ExpectAsync<LibraryView>("library-viewname");
naming.CloseCommand.Execute(null);
Assert.Null(library.Dialog);
await ArchiveScenes.ShowAsync(app.Shell, "trash");
var trash = Assert.NotNull(app.Shell.Archive.Dialog as TrashDialogViewModel, "Maintenance › Trash… opens the trash");
Assert.Equal(2, trash.Rows.Count, "the sample's deleted sequence and photos");
Assert.True(trash.HasRows);
await app.ExpectAsync<ArchiveView>("archive-trash-sample");
trash.CloseCommand.Execute(null);
});
[Test]
public Task ADeletedSequenceComesBackFromTheArchiveTrash() => ScreenHost.RunAsync(async () =>
{
await using var app = await ScreenSmokeTests.SampleApp.StartAsync();
await app.Sample.FillAsync();
await LibraryScenes.ShowAsync(app.Shell, "mass");
var db = app.Services.Database!;
var archives = app.Services.Archives!;
// What Delete runs once confirmed: the movable part of the selection goes to the archive's trash.
var plan = await archives.PlanDeleteAsync([.. app.Shell.Library.SelectedItems().Select(i => i.Id)]);
var moved = Assert.NotNull(plan.Steps.FirstOrDefault(), "the selection holds a sequence no job works on").Sequence;
Assert.NotEmpty(plan.Blocked);
await archives.DeleteAsync(plan);
Assert.Null(await db.Sequences.GetAsync(moved.Id));
app.Shell.Navigate(SectionKey.Archive);
await app.Shell.Archive.LoadAsync();
Assert.True(app.Shell.Archive.DeleteSetCommand.CanExecute(null), "the mass operations bar offers Delete…");
await app.Shell.Archive.OpenTrashAsync();
var trash = Assert.NotNull(app.Shell.Archive.Dialog as TrashDialogViewModel);
var row = trash.Rows.Single();
Assert.Equal(moved.Id, row.Entry.SequenceId);
await app.ExpectAsync<ArchiveView>("archive-trash");
row.RestoreCommand.Execute(null);
for (var i = 0; i < 100 && await db.Sequences.GetAsync(moved.Id) is null; i++) await Task.Delay(50);
var restored = Assert.NotNull(await db.Sequences.GetAsync(moved.Id), "Restore brings the sequence back into the index");
Assert.Equal(moved.Folder, restored.Folder);
Assert.True(trash.IsEmpty);
trash.CloseCommand.Execute(null);
});
/// <summary>A language switch makes the timeline's month readouts again, as it does the filters (BRIEF §16).</summary>
[Test]
public Task TheTimelineReadoutsFollowALanguageSwitch() => ScreenHost.RunAsync(async () =>
{
await using var app = await ScreenSmokeTests.SampleApp.StartAsync();
await app.Sample.FillAsync();
await app.Shell.Services.Server.RestoreAsync();
await app.Shell.Services.Sync.RefreshAsync();
var library = app.Shell.Library;
await LibraryScenes.ShowAsync(app.Shell, "timeline");
var english = Readout(library);
try
{
UiLanguage.Apply("it");
var italian = Readout(library);
Assert.NotEqual(english, italian, "the month readouts follow the language");
}
finally
{
UiLanguage.Apply("en");
}
Assert.Equal(english, Readout(library), "and come back with it");
static string Readout(LibraryViewModel library) => library.TimelineBands[0].ToolTips!.First(t => !string.IsNullOrEmpty(t))!;
});
/// <summary>
/// A remote card's Analyse posted to a server whose certificate changed since sign-in: the pin refuses it before
/// anything is sent, and the error toast says so (it used to escape the action unreported).
/// </summary>
[Test]
public Task APostRefusedByThePinnedCertificateSaysSo() => ScreenHost.RunAsync(async () =>
{
using var server = new UntrustedTlsEndpoint();
await using var app = await ScreenSmokeTests.SampleApp.StartAsync();
await app.Sample.FillAsync();
app.Services.Settings.ServerUrl = server.Address.ToString();
await app.Shell.Services.Server.RestoreAsync();
var actions = new LibraryActions(app.Shell);
Assert.True(actions.CanPost, "signed in to the endpoint (the sample's own certificate was trusted at sign-in)");
var toasts = new List<Toast>();
NotifyCollectionChangedEventHandler collect = (_, e) => toasts.AddRange(e.NewItems?.OfType<Toast>() ?? []);
app.Shell.PendingToasts.CollectionChanged += collect;
try
{
var remote = new Sequence
{
Id = Guid.CreateVersion7(),
ArchiveId = Guid.Empty,
Folder = "Harbour",
Title = "Harbour sunset",
Origin = SequenceOrigin.Server,
SyncState = SyncState.RemoteOnly,
};
await actions.AnalyseAsync([remote]);
}
finally
{
app.Shell.PendingToasts.CollectionChanged -= collect;
}
var toast = Assert.Contains(toasts, t => t.Title == Loc.L("Library.Post.Failed"));
Assert.Equal(Loc.L("Server.Error.Untrusted"), toast.Message);
Assert.True(toast.IsError);
});
private static void Press(UIElement target, Key key) =>
target.RaiseEvent(new KeyEventArgs(Keyboard.PrimaryDevice, PresentationSource.FromVisual(target)!, 0, key) { RoutedEvent = Keyboard.KeyDownEvent });
private static Button ButtonFor(ScreenSmokeTests.SampleApp app, ICommand command) =>
Assert.NotNull(app.FindAll<Button>().FirstOrDefault(b => ReferenceEquals(b.Command, command) && b.IsVisible), "a visible button bound to the command");
private static List<T> Find<T>(DependencyObject root)
where T : DependencyObject
{
var found = new List<T>();
for (var i = 0; i < VisualTreeHelper.GetChildrenCount(root); i++)
{
var child = VisualTreeHelper.GetChild(root, i);
if (child is T match) found.Add(match);
found.AddRange(Find<T>(child));
}
return found;
}
}