Commit Graph
23 Commits
Author SHA1 Message Date
Alby96 5aeb6aa787 Add comprehensive tests for EditSection functionality in the Windows application
- Implement tests for picker behavior, including loading sequences, searching, and handling empty libraries.
- Validate sequence opening via Enter key and double-click actions.
- Ensure proper handling of unsaved edits and sequence deletion scenarios.
- Verify accessibility features for picker rows across different languages.
- Introduce a dialog counting mechanism to manage unsaved edit confirmations.
2026-10-19 12:10:42 +02:00
Alby96andClaude Opus 5.5 4ea44bb917 feat: wider rail and admin sidebar that collapse to icons
Owner review 1, phase 3a (docs/requests/2026-10-15-owner-review-1.md, R1).

The desktop rail is 200 px wide, so the section names fit in every
language, and collapses to 48 px of icons with its ≡ button or Ctrl+B.
Collapsed, each icon's tooltip names its section before saying what it is
for, while screen readers keep the name and the description. The choice is
written to the settings file the moment it changes (nothing else restarts)
and survives Settings › Reset all and Import; Ctrl+B waits behind the
first-run dialog like Ctrl+1…6, and a held key toggles once.

The admin panel's sidebar is 256 px and collapses to icons the same way,
with its own ≡ button or Ctrl+B (on the physical key where the layout's B
types no Latin letter, so Cyrillic, Greek, Hebrew and Arabic layouts work).
The choice is kept in the browser, for the page when the browser refuses
storage, and the tables fit their columns again after each toggle. At
900 px and below it stays the top bar and Ctrl+B stays the browser's.

The wider rail leaves 49-72 px less for every screen at the 1200 px
minimum. Six adversarial review rounds found what that cut, and in every
shipped language no action is cut off now: the Jobs columns share their
width (Target and Progress give way first, Kind/Where/State capped on wide
windows), the editor's preview tools take a second line, a server job's
Cancel has its own header column, the Archive tree keeps a year's label,
the Import rows and result, the certificates and cache rows and the frame
table fit. Headers, titles and cells that may be shortened end in an
ellipsis and show their text in their tooltip; state tooltips start with
the state, and their explanations were reworded not to repeat it (a queued
job "waits for its turn", jobs running one at a time). The crop-result
tool sits beside Crop mask, disabled with its reason while the mask is
off. Tests check these rows in all 38 languages at 1200 px; the App test
program now shuts WPF down in order, so its exit no longer crashes after
every test passed.

Phase 3 lands as two commits: R7 (the Edit section) edits the same shell
files and follows. Also updates BRIEF (12.1, 14.8, 24), DECISIONS,
CHANGELOG, STATUS, the request file, DESIGN and the mockups; every new or
reworded string is in all 38 languages.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-16 21:50:48 +02:00
Claude 827b224ee3 fix(editor): read inserted frames before a render embeds the project
A render queued before the editor had seen frames inserted under it (a sync
download, an import of earlier photos, a scan without an event) embedded the
project's positions in the old frame order. Render now checks first that the
frames read are still the sequence's (ISequenceSource.FramesCurrentAsync: the
row's frames version on this PC, the manifest on a server). On this PC the
sequence is read again and the positions follow the frames; a server
sequence whose frames changed turns outdated and the render is not queued.

Reads of the sequence no longer overlap: a read waits for the one under way,
saves that meet new frames read them through the same slot, and they save
the project as it is once its positions followed. The frame on screen stays
on its photo when frames are inserted or removed before it.

Tests: the event-loss test waits for the listener's subscription before
dropping the stream, and the conflict tests flush once more after the
choice when a retry started before it was still failing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-12 19:59:45 +00:00
Claude 740e56464c fix(jobs): leave a followed render's toast to the editor and bound Open on large jobs
The Jobs screen's flush could take a render's end before the editor that
followed it had seen it, and announce it without the output file. It now
yields while the open editor follows that render (FollowsRender); an editor
closed in between still says it once, without the output.

Open on a job over more sequences than a Library page (a maintenance run over
a whole archive) now opens the Library as it is instead of looking every
target up and paging through the list to select them all. Selecting many
cards (Open's selection, Clear selection) counts the selection once instead
of once per card over every card.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-12 16:21:19 +00:00
Claude 789c2dae3e fix(jobs): announce every finished render once and open every target
A finished render's toast is claimed once (JobsViewModel.ClaimRenderToast):
the editor that followed the render to its end says it with its output,
also when the sequence cannot be read again (then without Show in
folder) or the editor closed meanwhile; any other render is said by the
Jobs screen. Before, the Jobs screen stayed silent whenever an editor had
the sequence open, so a failed reload or a render the editor did not
follow ended without a completion toast.

Open on a job over several sequences (toast, Windows notification, Jobs
row) shows the Library with every one of them selected, clearing a
search or filter that hides one and reading pages until each is listed,
instead of opening the first in the editor.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-12 15:53:58 +00:00
Claude 4850af2443 fix(app): keep the editor's own save errors and gate an unread archive
- Editor: a failed save showed what the server or the archive layer would say
  for the exception's type, so the editor's own sentences were lost: frames
  changed on the server or settings changed elsewhere read "The server does not
  answer", a read-only account or a gone sequence "Something went wrong". These
  failures are now EditorException (an IOException; ProxiesOutdatedException
  derives from it) and the toast shows their sentence as it is. A project
  written by a newer Titano is reported with the same sentence as a corrupt one
  instead of the parser's English text.
- Library: a job posted to a server whose certificate changed since sign-in
  threw out of the action unreported; the pin's refusal now reaches the error
  toast ("The certificate was not trusted").
- Archive: picking another archive forced it offline until it was read, so the
  rebuild dialog called it offline with the previous archive's count, and
  disabled commands said the archive must be online. What was read is now kept
  apart from availability: until the picked archive is read, Rebuild and the
  online commands wait and say so, health fixes and search results of the
  previous archive are cleared, and a running search is cancelled.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-12 11:09:04 +00:00
Claude 579ffd446d fix(i18n): plural forms for every text that counts
Findings, advisor reasons and a few UI texts put a count before a plural noun
without plural forms, so English and Italian read "1 frames are black". Each
such key is now a plural stem (.one/.other) whose count is its first argument;
findings and reasons, which travel as data, resolve through the new Loc.Text,
which picks the form from that argument (a fraction takes "other"), so stored
deep reports and project reasons keep their keys and arguments. Texts with two
or more counts (job log lines, "frames with a capture time: 12 of 300") read as
labels, which agree with no number. A single exposure change gets its own
finding instead of "1 exposure changes, typically 0 frames apart".

The converted and reworded keys leave the 36 other catalogs until they are
translated again; the dead plain Shell.JobBar.Ready goes too. `i18n check` now
fails on an English text that counts a noun without plural forms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-12 10:13:46 +00:00
Claude f7a7506fe7 fix(app): say why an action failed in localized words, not exception text
Error toasts showed the exception's own message, often technical English from
.NET or the OS, under a translated title. The editor's failed save, a job posted
to the server from the Library, and the card check or delete after an import now
say why in one catalog sentence: what the server answered or that it does not
answer, that the card left, is locked or a file could not be read, and the
archive causes of ArchiveFailures for a local save. The details stay in the log.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-12 10:13:34 +00:00
Claude 3241b4710d fix(rtl): the preview's frame data keeps its fields in order; charts keep European digits
The right-to-left separator broke the frame data over the preview, a left-to-right
island: after the localized time ("6:03:41 م") the shutter's number read as part
of the previous field and swapped places with the dot. Fields shown in such an
island now use Loc.IslandSeparator, with left-to-right marks in right-to-left
languages. Charts formatted text with the UI culture's digit substitution, so a
number after Arabic words came out in Arabic-Indic digits there only; they now
draw European digits like every text block. The direction marks in source are
written as escapes instead of invisible characters.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-12 00:16:56 +00:00
Claude 0a513fb213 fix(i18n): texts kept by view models follow a language switch; right-to-left meta lines keep their fields
A language switch re-read computed properties only: the job bar of a running job,
the Jobs rows, the editor's chart legends and summaries, Auto chips, markers and
info line, the Archive figures and the Import session table kept the old language
until their next change. LocalizedViewModel gains OnLanguageChanged, where each of
them makes those texts again.

Meta lines joined their fields with a plain " · ": in Arabic or Hebrew a number
after a Latin field ("Canon EOS R5 · 2 h") joined the Latin run and split its own
field. Loc.Separator puts right-to-left marks around the dot in right-to-left
languages and is used for every such line. Desktop file sizes use the Common.Size
formats, as the Setup and the Uploader do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-11 23:47:03 +00:00
Claude e4a0314fa7 fix(editor): optimise lines point the reading way; failed saves and jobs are errors
EditorText.Change picks Editor.Optimise.ChangeRtl ('{0}: {1} ← {2}',
invariant) in right-to-left languages, as Import.Session.TimeRtl and
Jobs.Target.RenderRtl do. A failed save and a failed server job raise error
toasts; a cancelled job stays a notice.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-06 20:56:08 +00:00
Claude 712bf9417f merge: remote editor after the review (server jobs, stale proxies, conflict prompt, read-only accounts)
Resolved: the export plan keeps the remote editor's version counter and the
integration branch's ran flag; the capture runs the Save-both copies scene, then
the Arabic scenes, and the remote editor scenes after the sync ones.
Dropped the translations of Archive.Adopt.Copy and Tooltips.Editor.Frames.Hero,
whose English changed; DECISIONS gains the three branches' decisions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-06 20:33:54 +00:00
Claude bda8e1fec2 feat(editor): settings both sides changed on the server ask before anything is overwritten
BRIEF §14.5 asks for an explicit conflict prompt when both sides changed. A save
of a server sequence that meets settings someone changed to other values on the
server now stops (the change stays pending) and the editor asks: Keep mine saves
the editor's values over the server's, Take server (the safe default) shows the
server's values as one undoable step, so Ctrl+Z brings the editor's back. Both
first take in what only the server changed. Settings changed on one side only
still merge silently; a reload after an analysis never merges over a conflicting
pending change. The Export "Sync" box moves under Save to so neither is cut in
longer languages.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-06 08:02:30 +00:00
Claude 31c1a2d9c6 refactor(editor): the open sequence's jobs in their own type; restore undo as an object
WIP of the interrupted fix stage.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-06 07:49:27 +00:00
Claude 757695f037 fix(editor): server jobs, stale proxies and read-only accounts in the remote editor
- A server sequence whose cached frames are no longer the server's (a load, a 409
  merge or a frames change event finds other frame ids) turns read-only and says
  why; opening it, or a sequence without cached proxies, queues the proxy
  download and opens it when done. Signed out reads "Connect to the server".
- Server jobs show queued, running (with a bar), paused and analysing glyphs in
  the header with Cancel; a failed or cancelled one raises a toast with Retry.
  Progress alone no longer refreshes the whole editor.
- The server job list is read by state and kind to its last page; "Add to queue"
  sets the job's priority; the event listener survives any failure and always
  releases its frames and connection.
- An account that may render but not edit picks the preset to render without
  changing the project; preset cards and their batch boxes say why they wait.
- Export tab of a server sequence: no local encoder, notices or folder; no Jobs
  history link. Sync at 12 px beside a folder that keeps 96 px and trims.
- Restore's Undo puts back the project from before the restore, only while that
  restore is the editor's last change.
- Export "Sync" of a render that ends while the session is down is queued for the
  saved session's server; skips are logged; sync follows the engine before it
  starts.
- Capture: sequence-remote-export, -running and -readonly, and
  sequence-export-copies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-05 22:15:34 +00:00
Claude 9cbfaae10d feat(editor): accounts without the Edit right open server sequences read-only
The Server screen offers Open with proxies to viewers; the editor now shows the
sequence with every change disabled and the reason in the tooltips, the session
refuses edits, undo and Optimise, and the source refuses to store a change.
Render says when the account may not render on the server. The event listener
stops cleanly when the editor closes and a late progress event no longer
brings a finished job back to running.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-03 16:43:47 +00:00
Claude 51fb84700e fix(editor): a server sequence's analyses and renders say where they run
Analyse no longer points to the Jobs screen for a server job, the Render and
Batch tooltips name the server and its one job per preset, a server that does
not answer in time is reported after a job, the Export Sync send logs any
failure and follows a replaced job engine, and job states use the wire names.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-03 16:37:33 +00:00
Claude a3781e26a0 fix(editor): read the proxy cache off the UI thread; the Sync gate is known before the job list
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-03 11:51:11 +00:00
Claude 2ff3a6503b feat(editor): open server sequences with proxies, hero frame to the index, export sync and saved copies
Server sequences that are not in the local index open through a RemoteSequenceSource:
proxies from the cache, project from the server's settings with their version (a 409
merges again), analysis report from the server, analyses and renders posted as server
jobs (one per preset) and followed through the server's events. Set hero now reaches the
index (SequenceEdit.HeroFrameId) so the Library card shows it. The Export tab gains the
Sync option (remembered in the project) and restores "Save both" copies through undo.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-03 11:38:11 +00:00
Claude 6e01995f7e fix(editor): a superseded export plan or estimate never replaces the current one
Undo and redo bring back the same project instance, so a cancelled planning
request passed the 'still current' check and published an empty plan (Render
disabled) or blank preset estimates. Only requests that ran now publish.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-03 11:19:30 +00:00
Claude 25e85aee57 fix(app): editor review fixes for saving, undo, preview, commands and layout
- Undo/redo snapshots take outside changes (advice, merged edits) on Replace;
  a drag, click or key press ends a merged run; Reset to Auto is its own step.
- A failed save stays pending and is retried with backoff; closing or switching
  asks before discarding it; the local source throws unless the index took it.
- Opening a sequence survives any failure; the window title follows the editor;
  the job bar hides when idle in the editor.
- Render, Add to queue and Batch re-read their state; disabled commands say why;
  Analyse is disabled while queued and announces its cost and Ctrl+Shift+A.
- Preview: 1:1 and wheel zoom render the source's own pixels, the view keeps its
  place across resolutions, crop mask result mode, unreadable frames say so,
  labelled tools, keyboard focus on open, tools hidden on Export lose their effect.
- Preparation re-solves from measured series (no re-decode per slider step) with
  a half-precision frame cache.
- Exposure flicker and waveform charts, Time plan chart, Camera crop margins,
  sortable frame table, wrapped findings, responsive preset cards, render-done
  follow-up, Jobs history filtered on the sequence.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-03 10:36:50 +00:00
Claude b2b36d5c57 test(app): editor sample for --capture and a Windows smoke test of every section
SampleData.FillEditorAsync writes a synthetic harbour sunset of real JPEG
frames with Exif (flicker, two exposure steps, white-balance drift, a
horizon), scans, deep-analyses and advises it, so --capture writes
sequence-<tab>-<theme>.png for every editor section. EditorViewModel
.WhenIdleAsync lets capture and tests wait for the preview, corrections,
plan, estimates and thumbnails in flight.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-02 17:35:53 +00:00
Claude f6ad822fbb feat(app): editor view models for every section, preset cards and render actions
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-02 17:14:48 +00:00