test(core): project settings keep defaults for members missing from partial JSON
The source-generated deserialiser sets every init-only member it does not find to null/false/0, so a partial project (API edit, older file) lost its sections and defaults. FromJson lays the JSON over the default project. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
This commit is contained in:
1 file changed
+30
@@ -59,6 +59,36 @@ public sealed class ProjectSettingsTests
|
||||
public void NewerVersionIsRefused() =>
|
||||
Assert.Throws<InvalidDataException>(() => ProjectSettings.FromJson("{\"version\": 99}"));
|
||||
|
||||
[Test]
|
||||
public void MissingMembersKeepTheirDefaults()
|
||||
{
|
||||
var defaults = new ProjectSettings().ToJson();
|
||||
Assert.Equal(defaults, ProjectSettings.FromJson("{}").ToJson());
|
||||
Assert.Equal(defaults, ProjectSettings.FromJson("null").ToJson());
|
||||
|
||||
// An API client's partial edit: one manual value, a section given as null, keys in another casing.
|
||||
var partial = ProjectSettings.FromJson(
|
||||
"""{ "Exposure": { "deflicker": { "isAuto": false, "manual": false } }, "motion": null, "export": { "preset": { "isAuto": false, "manual": "4k-hevc" } } }""");
|
||||
Assert.False(partial.Exposure.Deflicker.Resolve(true));
|
||||
Assert.True(partial.Exposure.HolyGrail.IsAuto);
|
||||
Assert.Equal(0.9, partial.Exposure.HighlightKnee);
|
||||
Assert.True(partial.Motion.Stabilize.IsAuto);
|
||||
Assert.Equal("4k-hevc", partial.Export.Preset.Resolve("1080p-h264"));
|
||||
Assert.Equal("{date} {title} - {preset}", partial.Export.NameTemplate);
|
||||
Assert.SequenceEqual(new[] { 0.0, 1.0 }, partial.Timing.RemapCurve.Select(p => p.X));
|
||||
Assert.Equal(9, partial.Stack.Length);
|
||||
Assert.Equal(ProjectSettings.CurrentVersion, partial.Version);
|
||||
|
||||
// An explicit null clears a nullable value; arrays are replaced, not merged.
|
||||
var cleared = ProjectSettings.FromJson("""{ "exposure": { "highlightKnee": null }, "timing": { "remapCurve": [ { "x": 0, "y": 0.5 } ] } }""");
|
||||
Assert.Null(cleared.Exposure.HighlightKnee);
|
||||
Assert.Equal(1, cleared.Timing.RemapCurve.Count);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void ProjectMustBeAnObject() =>
|
||||
Assert.Throws<System.Text.Json.JsonException>(() => ProjectSettings.FromJson("[1, 2]"));
|
||||
|
||||
[Test]
|
||||
public void BuiltInPresetIdsAreUnique() =>
|
||||
Assert.Equal(ExportPresets.BuiltIn.Count, ExportPresets.BuiltIn.Select(p => p.Id).Distinct().Count());
|
||||
|
||||
Reference in new issue
Block a user