fix(render): report an unreadable playback rate instead of ignoring it
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
This commit is contained in:
2 files changed
+12
-1
No files matched your search
@@ -205,8 +205,10 @@ public sealed class RenderPlan
|
||||
var n = captureTimes.Count;
|
||||
var timing = project.Timing;
|
||||
var mode = ProjectValues.Get(timing.Mode, TimingMode.Constant);
|
||||
var playback = FrameRateText.TryParse(timing.FrameRate.Resolve(string.Empty), out var rate) ? rate.Value : frameRate.Value;
|
||||
var warnings = new List<string>();
|
||||
var playbackText = timing.FrameRate.Resolve(string.Empty);
|
||||
var playback = FrameRateText.TryParse(playbackText, out var rate) ? rate.Value : frameRate.Value;
|
||||
if (playbackText.Length > 0 && rate.Numerator == 0) warnings.Add("Export.Plan.FrameRateIgnored");
|
||||
|
||||
var excluded = new bool[n];
|
||||
foreach (var i in project.ExcludedFrames)
|
||||
|
||||
@@ -173,6 +173,15 @@ public sealed class RenderPlanTests
|
||||
Assert.Approximately(0.1 * 60, bad.Frames[0].SourcePosition, 1e-9);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void AnUnreadablePlaybackRateFallsBackToTheOutputRate()
|
||||
{
|
||||
var plan = RenderPlan.Build(Regular(10), Timing(TimingMode.Constant, playback: "fast"), new Rational(25, 1));
|
||||
Assert.Contains("Export.Plan.FrameRateIgnored", plan.Warnings);
|
||||
Assert.Equal(10, plan.SlotCount);
|
||||
Assert.Equal(25.0, plan.PlaybackRate);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void EverythingExcludedGivesAnEmptyPlan()
|
||||
{
|
||||
|
||||
Reference in new issue
Block a user