From a0c2b1b28c82b4ad00f03598f9bf268d877a23ca Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 2 Oct 2026 11:33:43 +0000 Subject: [PATCH] fix(render): report an unreadable playback rate instead of ignoring it Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC --- src/Titano.Core/Render/RenderPlan.cs | 4 +++- tests/Titano.Core.Tests/Render/RenderPlanTests.cs | 9 +++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/Titano.Core/Render/RenderPlan.cs b/src/Titano.Core/Render/RenderPlan.cs index 1d388930..6ddc6c1b 100644 --- a/src/Titano.Core/Render/RenderPlan.cs +++ b/src/Titano.Core/Render/RenderPlan.cs @@ -205,8 +205,10 @@ public sealed class RenderPlan var n = captureTimes.Count; var timing = project.Timing; var mode = ProjectValues.Get(timing.Mode, TimingMode.Constant); - var playback = FrameRateText.TryParse(timing.FrameRate.Resolve(string.Empty), out var rate) ? rate.Value : frameRate.Value; var warnings = new List(); + var playbackText = timing.FrameRate.Resolve(string.Empty); + var playback = FrameRateText.TryParse(playbackText, out var rate) ? rate.Value : frameRate.Value; + if (playbackText.Length > 0 && rate.Numerator == 0) warnings.Add("Export.Plan.FrameRateIgnored"); var excluded = new bool[n]; foreach (var i in project.ExcludedFrames) diff --git a/tests/Titano.Core.Tests/Render/RenderPlanTests.cs b/tests/Titano.Core.Tests/Render/RenderPlanTests.cs index e42f70f0..26758d9a 100644 --- a/tests/Titano.Core.Tests/Render/RenderPlanTests.cs +++ b/tests/Titano.Core.Tests/Render/RenderPlanTests.cs @@ -173,6 +173,15 @@ public sealed class RenderPlanTests Assert.Approximately(0.1 * 60, bad.Frames[0].SourcePosition, 1e-9); } + [Test] + public void AnUnreadablePlaybackRateFallsBackToTheOutputRate() + { + var plan = RenderPlan.Build(Regular(10), Timing(TimingMode.Constant, playback: "fast"), new Rational(25, 1)); + Assert.Contains("Export.Plan.FrameRateIgnored", plan.Warnings); + Assert.Equal(10, plan.SlotCount); + Assert.Equal(25.0, plan.PlaybackRate); + } + [Test] public void EverythingExcludedGivesAnEmptyPlan() {