ci: artifact uploads no longer fail jobs whose checks passed; short retention
The repository's artifact storage filled up (screenshots were kept the default 90 days, Windows programs 14), and every upload then failed its job although all tests had passed. Uploads of test results, screenshots, Windows programs and perf results now continue on error; test results are kept 7 days, the Windows programs 3, the screenshots one day (the screenshots job reads them right away and the ci-screenshots branch keeps the latest set), the release hand-off 3. The Docker builds no longer store a build-record artifact nobody reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
This commit is contained in:
4 files changed
+19
-1
No files matched your search
@@ -123,29 +123,36 @@ jobs:
|
||||
dotnet publish src/Titano.Server/Titano.Server.csproj -c Release -r win-x64 --self-contained \
|
||||
-p:PublishSingleFile=true -o out/publish/Titano.Server
|
||||
|
||||
# Artifacts are conveniences: a full artifact storage quota must not fail a job whose checks passed, and short
|
||||
# retention keeps the storage from filling up again.
|
||||
- name: Upload test results
|
||||
if: always()
|
||||
continue-on-error: true
|
||||
uses: actions/upload-artifact@v4
|
||||
with:
|
||||
name: test-results-${{ matrix.os }}
|
||||
path: out/junit/
|
||||
if-no-files-found: ignore
|
||||
retention-days: 7
|
||||
|
||||
- name: Upload screenshots
|
||||
if: runner.os == 'Windows' && always()
|
||||
continue-on-error: true
|
||||
uses: actions/upload-artifact@v4
|
||||
with:
|
||||
name: screenshots
|
||||
path: out/screenshots/
|
||||
if-no-files-found: ignore
|
||||
retention-days: 1 # read once by the screenshots job below; the ci-screenshots branch keeps the latest set
|
||||
|
||||
- name: Upload Windows programs
|
||||
if: runner.os == 'Windows'
|
||||
continue-on-error: true
|
||||
uses: actions/upload-artifact@v4
|
||||
with:
|
||||
name: titano-win-x64-${{ github.sha }}
|
||||
path: out/publish/
|
||||
retention-days: 14
|
||||
retention-days: 3
|
||||
|
||||
screenshots:
|
||||
name: Screenshots branch
|
||||
@@ -205,11 +212,13 @@ jobs:
|
||||
run: dotnet run --project tests/Titano.Server.Tests -c Release -- --junit out/junit/server-pg${{ matrix.pg }}.xml
|
||||
- name: Upload test results
|
||||
if: always()
|
||||
continue-on-error: true
|
||||
uses: actions/upload-artifact@v4
|
||||
with:
|
||||
name: test-results-pg${{ matrix.pg }}
|
||||
path: out/junit/
|
||||
if-no-files-found: ignore
|
||||
retention-days: 7
|
||||
|
||||
docker:
|
||||
name: Docker image
|
||||
@@ -231,6 +240,8 @@ jobs:
|
||||
- uses: docker/setup-buildx-action@v3
|
||||
- name: Build image
|
||||
uses: docker/build-push-action@v6
|
||||
env:
|
||||
DOCKER_BUILD_RECORD_UPLOAD: "false" # no build-record artifact: nothing reads it
|
||||
with:
|
||||
context: .
|
||||
file: deploy/docker/Dockerfile
|
||||
|
||||
@@ -26,6 +26,8 @@ jobs:
|
||||
id: image
|
||||
run: echo "name=ghcr.io/${GITHUB_REPOSITORY_OWNER,,}/titano-server" >> "$GITHUB_OUTPUT"
|
||||
- uses: docker/build-push-action@v6
|
||||
env:
|
||||
DOCKER_BUILD_RECORD_UPLOAD: "false" # no build-record artifact: nothing reads it
|
||||
with:
|
||||
context: .
|
||||
file: deploy/docker/Dockerfile
|
||||
|
||||
@@ -68,6 +68,7 @@ jobs:
|
||||
|
||||
- name: Upload results
|
||||
if: always()
|
||||
continue-on-error: true # the timings are also in the job summary
|
||||
uses: actions/upload-artifact@v4
|
||||
with:
|
||||
name: perf-results
|
||||
@@ -75,3 +76,4 @@ jobs:
|
||||
out/junit/
|
||||
out-perf.log
|
||||
if-no-files-found: ignore
|
||||
retention-days: 30
|
||||
@@ -171,6 +171,7 @@ jobs:
|
||||
with:
|
||||
name: release-windows
|
||||
if-no-files-found: error
|
||||
retention-days: 3 # hand-off to the publish job; the GitHub release keeps the files
|
||||
path: |
|
||||
out/release/
|
||||
out/release-notes.md
|
||||
@@ -198,6 +199,8 @@ jobs:
|
||||
id: image
|
||||
run: echo "name=ghcr.io/${GITHUB_REPOSITORY_OWNER,,}/titano-server" >> "$GITHUB_OUTPUT"
|
||||
- uses: docker/build-push-action@v6
|
||||
env:
|
||||
DOCKER_BUILD_RECORD_UPLOAD: "false" # no build-record artifact: nothing reads it
|
||||
with:
|
||||
context: .
|
||||
file: deploy/docker/Dockerfile
|
||||
|
||||
Reference in new issue
Block a user