Owner review 2, R9: Import › Folder… gains a "Group" choice for picked folders: Sessions (as before) or Whole folder. A whole folder, with its subfolders when Subfolders is on, becomes one sequence per file format; camera bodies and pauses are ignored, while RAW+JPEG of the same shots stays two sequences so no frame is ever doubled. Only the user's splits break it, and Merge joins a split part back. The planner implements it (ImportOptions.Grouping, Core, Linux-tested): the session key is "folder-" plus a hash of this PC's name, the full path and the format, so an interrupted or repeated import continues the same sequence; the default title is the folder's name. The plan shows one row per format with the format and the number of cameras. Cards and drives always import by sessions; the choice is not part of a card profile and a folder starts on Sessions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
129 lines
6.5 KiB
C#
129 lines
6.5 KiB
C#
using System.Text.Json;
|
|
using System.Text.Json.Serialization;
|
|
using Chronos.App.Import;
|
|
using Chronos.Core.Import;
|
|
using Chronos.Core.Model;
|
|
using Chronos.Data.Archiving;
|
|
using Chronos.Testing;
|
|
|
|
namespace Chronos.App.Tests.Import;
|
|
|
|
public sealed class ImportChoicesTests
|
|
{
|
|
[Test]
|
|
public void ACardProfileRoundTripsThroughTheForm()
|
|
{
|
|
var profile = new CardProfile
|
|
{
|
|
FolderTemplate = "{year}/{title}",
|
|
FileTemplate = "{name}",
|
|
SessionGapMinutes = 30,
|
|
MinimumSessionFrames = 4,
|
|
IncludeSubfolders = false,
|
|
VerifyCopies = false,
|
|
Duplicates = DuplicatePolicy.ImportAgain,
|
|
AfterImport = AfterImport.DeleteImported,
|
|
Eject = false,
|
|
DeepAnalysis = false,
|
|
};
|
|
var choices = ImportChoices.FromProfile(profile);
|
|
Assert.True(choices.SplitSessions);
|
|
Assert.Equal(30, choices.GapMinutes);
|
|
Assert.Equal(profile, choices.ToProfile());
|
|
}
|
|
|
|
[Test]
|
|
public void SessionsOffIsRememberedAsAZeroGapAndNeverSplits()
|
|
{
|
|
var off = new ImportChoices { SplitSessions = false, GapMinutes = 20 };
|
|
Assert.Equal(0, off.ToProfile().SessionGapMinutes);
|
|
Assert.Equal(TimeSpan.MaxValue, off.ToOptions().SessionGap);
|
|
var back = ImportChoices.FromProfile(off.ToProfile());
|
|
Assert.False(back.SplitSessions);
|
|
Assert.Equal(new CardProfile().SessionGapMinutes, back.GapMinutes);
|
|
Assert.Equal(TimeSpan.FromMinutes(20), (off with { SplitSessions = true }).ToOptions().SessionGap);
|
|
}
|
|
|
|
[Test]
|
|
public void OptionsCarryTheFormAndTheTypedTitles()
|
|
{
|
|
var titles = new Dictionary<string, string> { ["k"] = "Harbour" };
|
|
var options = new ImportChoices { MinimumFrames = 0, Duplicates = DuplicatePolicy.ImportAgain, VerifyCopies = false }.ToOptions(titles);
|
|
Assert.Equal(1, options.MinimumSessionFrames);
|
|
Assert.Equal(DuplicatePolicy.ImportAgain, options.Duplicates);
|
|
Assert.False(options.VerifyCopies);
|
|
Assert.Equal("Harbour", options.Titles["k"]);
|
|
}
|
|
|
|
[Test]
|
|
public void OnlyGroupingAndNamingChoicesNeedANewPlan()
|
|
{
|
|
var a = new ImportChoices();
|
|
Assert.False((a with { Duplicates = DuplicatePolicy.ImportAgain, VerifyCopies = false, Eject = false, AfterImport = AfterImport.FormatCard }).NeedsNewPlan(a));
|
|
Assert.False((a with { SplitSessions = false, GapMinutes = 5 }).NeedsNewPlan(a with { SplitSessions = false }));
|
|
Assert.True((a with { GapMinutes = 5 }).NeedsNewPlan(a));
|
|
Assert.True((a with { MinimumFrames = 2 }).NeedsNewPlan(a));
|
|
Assert.True((a with { FileTemplate = "{name}" }).NeedsNewPlan(a));
|
|
Assert.True((a with { Destination = ImportDestinationKind.Folder }).NeedsNewPlan(a));
|
|
Assert.True((a with { IncludeSubfolders = false }).NeedsNewPlan(a));
|
|
Assert.False((a with { FolderPath = @"D:\Shoots" }).NeedsNewPlan(a), "the folder path is not used for the archive");
|
|
var folder = a with { Destination = ImportDestinationKind.Folder, FolderPath = @"D:\Shoots" };
|
|
Assert.True((folder with { FolderPath = @"E:\Backup" }).NeedsNewPlan(folder));
|
|
Assert.False((folder with { FolderPath = @"d:\shoots" }).NeedsNewPlan(folder), "paths compare without case");
|
|
Assert.False(a.TitlesChangeNames);
|
|
Assert.True((a with { FolderTemplate = "{year}/{Title:upper}" }).TitlesChangeNames);
|
|
}
|
|
|
|
[Test]
|
|
public void ACardFollowsItsCameraProfileWhenItJoinedItOrHasNoSettingsYet()
|
|
{
|
|
var shared = new CardProfile { SessionGapMinutes = 90 };
|
|
var defaults = new CardProfile { SessionGapMinutes = 45 };
|
|
var own = Card("Canon", "Canon EOS R5", new CardProfile { SessionGapMinutes = 20 }, daysAgo: 30);
|
|
var fresh = Card("Canon", "Canon EOS R5", null, daysAgo: 0);
|
|
var camera = new CameraProfile("Canon", "Canon EOS R5", shared, []);
|
|
|
|
Assert.Equal(new ResolvedProfile(shared, true), CameraProfiles.Resolve(fresh, camera, defaults), "a new card of a known camera needs no setup");
|
|
Assert.Equal(new ResolvedProfile(defaults, false), CameraProfiles.Resolve(fresh, null, defaults));
|
|
Assert.Equal(20, CameraProfiles.Resolve(own, camera, defaults).Profile.SessionGapMinutes, "a card with its own settings keeps them");
|
|
Assert.False(CameraProfiles.Resolve(own, camera, defaults).FollowsCamera);
|
|
Assert.Equal(new ResolvedProfile(shared, true), CameraProfiles.Resolve(own, camera.With(own.Id), defaults), "a card that joined follows the shared rules");
|
|
|
|
var joined = camera.With(own.Id).With(own.Id).With(fresh.Id);
|
|
Assert.SequenceEqual([own.Id, fresh.Id], joined.Cards);
|
|
Assert.SequenceEqual([fresh.Id], joined.Without(own.Id).Cards);
|
|
}
|
|
|
|
[Test]
|
|
public void TheGroupingTravelsToThePlannerButNeverIntoACardProfile()
|
|
{
|
|
var whole = new ImportChoices { Grouping = ImportGrouping.WholeFolder };
|
|
Assert.Equal(ImportGrouping.WholeFolder, whole.ToOptions().Grouping);
|
|
Assert.Equal(ImportGrouping.Sessions, new ImportChoices().ToOptions().Grouping, "a source starts with its sessions");
|
|
Assert.True(whole.NeedsNewPlan(new ImportChoices()), "the grouping changes which photos form which sequence");
|
|
Assert.Equal(ImportGrouping.Sessions, ImportChoices.FromProfile(whole.ToProfile()).Grouping, "a card always imports by sessions");
|
|
}
|
|
|
|
[Test]
|
|
public void SplitsAndMergesTravelToThePlanner()
|
|
{
|
|
var options = new ImportChoices().ToOptions(null, new HashSet<string> { "DCIM/100CANON/IMG_0005.CR2" }, new HashSet<string> { "DCIM/100CANON/IMG_0009.CR2" });
|
|
Assert.True(options.SplitBefore.Contains("DCIM/100CANON/IMG_0005.CR2"));
|
|
Assert.True(options.MergeAt.Contains("DCIM/100CANON/IMG_0009.CR2"));
|
|
Assert.Empty(new ImportChoices().ToOptions().SplitBefore);
|
|
}
|
|
|
|
private static MediaCard Card(string make, string model, CardProfile? profile, int daysAgo) => new()
|
|
{
|
|
Id = Guid.CreateVersion7(),
|
|
Identity = Guid.NewGuid().ToString("N"),
|
|
CameraMake = make,
|
|
CameraModel = model,
|
|
ProfileJson = profile is null ? null : JsonSerializer.Serialize(profile, StoredProfile),
|
|
LastSeen = DateTimeOffset.UtcNow.AddDays(-daysAgo),
|
|
};
|
|
|
|
/// <summary>How the card repository stores a profile (camel case, enum names).</summary>
|
|
private static readonly JsonSerializerOptions StoredProfile = new() { PropertyNamingPolicy = JsonNamingPolicy.CamelCase, Converters = { new JsonStringEnumConverter() } };
|
|
}
|