- A refused password draws the Error border over the password box, so it stays visible while the box has focus (the shared template paints its focus border over the box's own). - Enter in the settings panel no longer triggers the sign-in form's default button underneath. - Queue rows the list has not realized are named by their file name; the retry arrow is not mirrored. - CI's Screenshots step also runs Titano.Setup.exe --capture. - Smoke test: the password box shows no error before use; Sign in is the default only outside the panel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
201 lines
8.5 KiB
C#
201 lines
8.5 KiB
C#
using System.Windows;
|
|
using System.Windows.Automation;
|
|
using System.Windows.Automation.Peers;
|
|
using System.Windows.Controls;
|
|
using System.Windows.Input;
|
|
using System.Windows.Media;
|
|
using System.Windows.Threading;
|
|
using Titano.App.Infrastructure;
|
|
using Titano.App.Tests.Windows;
|
|
using Titano.Core.Localization;
|
|
using Titano.Testing;
|
|
using Titano.Ui.Controls;
|
|
using Titano.Ui.Theming;
|
|
using Titano.Uploader.DesignTime;
|
|
using Titano.Uploader.Shell;
|
|
using Titano.Uploader.Uploads;
|
|
|
|
namespace Titano.App.Tests.Uploader;
|
|
|
|
/// <summary>
|
|
/// The uploader window on the <c>--capture</c> sample data, shown off screen: icon-only buttons and queue rows are
|
|
/// named for screen readers, rows take keyboard focus, no field shows an error before use, disabled controls say
|
|
/// why, and in a right-to-left language the window mirrors while paths, file names and the media glyph do not.
|
|
/// </summary>
|
|
[WindowsOnly]
|
|
[Serial]
|
|
[Timeout(120_000)]
|
|
public sealed class UploaderScreenSmokeTests
|
|
{
|
|
[Test]
|
|
public Task EveryScreenIsNamedFocusableAndCalm() => ScreenHost.RunAsync(async () =>
|
|
{
|
|
UiLanguage.Apply("en");
|
|
using var screen = await UploaderScreen.OpenAsync();
|
|
var vm = screen.ViewModel;
|
|
|
|
screen.Sample.ShowConnect();
|
|
await screen.SettleAsync();
|
|
Assert.Equal(FlowDirection.LeftToRight, screen.Window.FlowDirection);
|
|
Assert.False(vm.Connect.HasErrors, "the address is not marked before a sign-in");
|
|
Assert.Null(vm.Connect.PasswordError);
|
|
Assert.Null(vm.Connect.ErrorText);
|
|
foreach (var box in screen.Visible<TextBox>())
|
|
Assert.False(Validation.GetHasError(box), $"{AutomationProperties.GetName(box)} shows an error before use");
|
|
Assert.False(screen.Named<Border>("PasswordErrorRing").IsVisible, "the password box shows no error before use");
|
|
screen.AssertIconButtonsNamed("connect");
|
|
|
|
// Enter signs in from the form, not from the settings panel drawn over it.
|
|
var signIn = screen.Visible<Button>().Single(b => Equals(b.Content, Loc.L("Uploader.Connect.SignIn")));
|
|
Assert.True(signIn.IsDefault, "Enter signs in");
|
|
vm.IsSettingsOpen = true;
|
|
await screen.SettleAsync();
|
|
Assert.False(signIn.IsDefault, "Enter in the settings panel does not sign in");
|
|
vm.IsSettingsOpen = false;
|
|
await screen.SettleAsync();
|
|
|
|
screen.Sample.ShowQueue();
|
|
await screen.SettleAsync();
|
|
screen.AssertIconButtonsNamed("queue");
|
|
Assert.Equal(Loc.L("Uploader.Queue.List"), AutomationProperties.GetName(screen.Named<ListBox>("ItemList")));
|
|
var rows = screen.Visible<ListBoxItem>();
|
|
Assert.NotEmpty(rows);
|
|
foreach (var row in rows)
|
|
{
|
|
Assert.True(row.Focusable, "queue rows take keyboard focus");
|
|
var item = (UploadItem)row.DataContext;
|
|
var name = UIElementAutomationPeer.CreatePeerForElement(row)?.GetName();
|
|
Assert.Contains(item.FileName, name);
|
|
Assert.Contains(UploadStateTextConverter.Text(item.State), name);
|
|
}
|
|
Assert.Contains(rows, r => r.DataContext == vm.CurrentItem);
|
|
Assert.NotNull(vm.FirstFailed());
|
|
Assert.NotNull(vm.FailedText);
|
|
Assert.True(screen.Named<Button>("FailedLink").IsVisible, "the failure count is a link to the failed file");
|
|
|
|
// Disabled controls say why; the settings panel keeps Tab inside it.
|
|
Assert.Equal(Loc.L("Tooltips.Uploader.SequenceDisabled"), vm.SequenceToolTip);
|
|
Assert.Equal(Loc.L("Tooltips.Uploader.Pause"), vm.PauseToolTip);
|
|
Assert.Equal(Loc.L("Tooltips.Uploader.Stop"), vm.StopToolTip);
|
|
Assert.Equal(KeyboardNavigationMode.Cycle, KeyboardNavigation.GetTabNavigation(screen.Named<Border>("SettingsPanel")));
|
|
|
|
vm.IsSettingsOpen = true;
|
|
await screen.SettleAsync();
|
|
screen.AssertIconButtonsNamed("settings");
|
|
vm.IsSettingsOpen = false;
|
|
});
|
|
|
|
[Test]
|
|
public Task TheWindowMirrorsForRightToLeftLanguages() => ScreenHost.RunAsync(async () =>
|
|
{
|
|
UiLanguage.Apply("ar");
|
|
try
|
|
{
|
|
using var screen = await UploaderScreen.OpenAsync();
|
|
screen.Sample.ShowQueue();
|
|
await screen.SettleAsync();
|
|
Assert.Equal(FlowDirection.RightToLeft, screen.Window.FlowDirection);
|
|
|
|
// File names, paths and addresses read left to right in every language.
|
|
var fileNames = screen.Visible<ListBoxItem>().Select(r => ((UploadItem)r.DataContext).FileName).ToHashSet();
|
|
var islands = screen.Visible<TextBlock>()
|
|
.Where(t => fileNames.Contains(t.Text) || t.Text.Contains('\\') || t.Text.StartsWith("https://", StringComparison.Ordinal))
|
|
.ToList();
|
|
Assert.NotEmpty(islands);
|
|
foreach (var text in islands) Assert.Equal(FlowDirection.LeftToRight, text.FlowDirection, text.Text);
|
|
// Media glyphs (pause, play) are not mirrored.
|
|
var pause = screen.Visible<Button>().Single(b => AutomationProperties.GetName(b) == screen.ViewModel.PauseLabel);
|
|
Assert.Equal(FlowDirection.LeftToRight, pause.FlowDirection);
|
|
|
|
screen.Sample.ShowConnect();
|
|
await screen.SettleAsync();
|
|
Assert.Equal(FlowDirection.LeftToRight, screen.Named<TextBox>("AddressBox").FlowDirection);
|
|
var mark = screen.Visible<BrandMarkIcon>().Single(m => m.ActualWidth >= 48);
|
|
Assert.Equal(FlowDirection.LeftToRight, mark.FlowDirection);
|
|
}
|
|
finally
|
|
{
|
|
UiLanguage.Apply("en");
|
|
}
|
|
});
|
|
|
|
/// <summary>A <see cref="MainWindow"/> on <see cref="SampleData"/>, shown off screen like <c>--capture</c>.</summary>
|
|
private sealed class UploaderScreen : IDisposable
|
|
{
|
|
private UploaderScreen(SampleData sample, MainViewModel viewModel, MainWindow window)
|
|
{
|
|
Sample = sample;
|
|
ViewModel = viewModel;
|
|
Window = window;
|
|
}
|
|
|
|
public SampleData Sample { get; }
|
|
public MainViewModel ViewModel { get; }
|
|
public MainWindow Window { get; }
|
|
|
|
public static async Task<UploaderScreen> OpenAsync()
|
|
{
|
|
ThemeManager.Apply(AppTheme.Dark);
|
|
var sample = new SampleData();
|
|
var vm = sample.CreateViewModel();
|
|
var window = new MainWindow(vm, sample.Settings)
|
|
{
|
|
WindowStartupLocation = WindowStartupLocation.Manual,
|
|
Left = -20000,
|
|
Top = -20000,
|
|
Width = 760,
|
|
Height = 700,
|
|
ShowActivated = false,
|
|
ShowInTaskbar = false,
|
|
};
|
|
window.Show();
|
|
var screen = new UploaderScreen(sample, vm, window);
|
|
await screen.SettleAsync();
|
|
return screen;
|
|
}
|
|
|
|
public async Task SettleAsync()
|
|
{
|
|
Window.UpdateLayout();
|
|
// Bindings, templates and the work the window defers to the dispatcher (scrolling, focus).
|
|
await Window.Dispatcher.InvokeAsync(() => { }, DispatcherPriority.ApplicationIdle);
|
|
await Task.Delay(30);
|
|
await Window.Dispatcher.InvokeAsync(() => { }, DispatcherPriority.ApplicationIdle);
|
|
Window.UpdateLayout();
|
|
}
|
|
|
|
public List<T> Visible<T>()
|
|
where T : FrameworkElement => [.. All<T>(Window).Where(e => e.IsVisible)];
|
|
|
|
public T Named<T>(string name)
|
|
where T : FrameworkElement => All<T>(Window).Single(e => e.Name == name);
|
|
|
|
/// <summary>DESIGN §4: an icon-only button carries an accessible name (and a tooltip).</summary>
|
|
public void AssertIconButtonsNamed(string screen)
|
|
{
|
|
foreach (var button in Visible<Button>().Where(b => b.Content is null))
|
|
{
|
|
Assert.False(string.IsNullOrWhiteSpace(AutomationProperties.GetName(button)), $"{screen}: an icon-only button has no name");
|
|
Assert.True(button.ToolTip is not null, $"{screen}: {AutomationProperties.GetName(button)} has no tooltip");
|
|
}
|
|
}
|
|
|
|
public void Dispose()
|
|
{
|
|
Window.Close();
|
|
ViewModel.Dispose();
|
|
}
|
|
|
|
private static IEnumerable<T> All<T>(DependencyObject node)
|
|
where T : DependencyObject
|
|
{
|
|
for (var i = 0; i < VisualTreeHelper.GetChildrenCount(node); i++)
|
|
{
|
|
var child = VisualTreeHelper.GetChild(node, i);
|
|
if (child is T match) yield return match;
|
|
foreach (var nested in All<T>(child)) yield return nested;
|
|
}
|
|
}
|
|
}
|
|
}
|