Owner review 2, R6: the web panel manages the library without editing it, so the engine and the server must delete single photos safely, keep them out of sync afterwards, and let an administrator restore or finally erase the trash. - Migration 0008: frame_removals (tombstones by sequence and SHA-256, reason, replacement); the sidecar gains "removed" (omitted when empty) and frames a reserved "source"; the indexer writes the tombstones on every sync, so a rebuild keeps them, and drops a hero frame that is gone. - FrameTrash: dry run (busy, frames changed, offline, would empty), delete under the sequence lease with a write-ahead journal that the next writer undoes after a crash, files to trash/photos/<seq>-<time>/originals with a record, sidecar without the frames plus tombstones, index sync clearing analyses, thumbnails and proxies, proxies renamed to follow their frames, follow-up jobs. Restore re-hashes every file, keeps mismatches in the trash, puts the same frame records back and drops their tombstones, or files the photos into a new sequence through the ingest when theirs is gone. - Project positions on vanished photos are translated by photo and wait as pending frames, so they come back with a restore. - Trash entries have a kind (sequence, photos, replaced); emptying is a dry run with a fingerprint and a new EmptyTrash job (18) that erases exactly the planned entries, refuses a stale plan and erases replaced originals only while their replacements still hash right. - Sync honours tombstones: nothing one side deleted is offered back, local files are never deleted, replaced photos count as their replacement; the server answers an upload of a tombstoned SHA-256 as already there. - Server: sequence thumbnail, photo delete, bulk delete/retag/jobs, trash list/restore/empty endpoints with their error messages; a verify of sequences now targets their archive (POST /jobs failed before). - Desktop trash dialog lists photo entries and empties the trash after a typed confirmation through the same job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 35bb56690a1d69eae57153d036e1409201cd73f7)
248 lines
12 KiB
C#
248 lines
12 KiB
C#
using System.Text;
|
|
using System.Text.Json;
|
|
using Chronos.Core.Archiving;
|
|
using Chronos.Core.Imaging;
|
|
using Chronos.Core.IO;
|
|
using Chronos.Core.Model;
|
|
using Chronos.Testing;
|
|
|
|
namespace Chronos.Core.Tests.Archiving;
|
|
|
|
[Category("archive")]
|
|
public sealed class ManifestStoreTests(TestContext context)
|
|
{
|
|
private static SequenceManifest Sample() => new()
|
|
{
|
|
Id = Guid.CreateVersion7(),
|
|
Title = "Harbour sunset",
|
|
Camera = new SidecarCamera { Make = "Canon", Model = "Canon EOS R5", Serial = "0431" },
|
|
Lens = "RF24-70mm F2.8 L IS USM",
|
|
Frames =
|
|
[
|
|
new SidecarFrame
|
|
{
|
|
Id = Guid.CreateVersion7(), I = 0, File = "originals/2026-09-28_18-02-11_0001.CR2", Original = "IMG_0001.CR2", Size = 25_000_000,
|
|
Sha256 = new string('a', 64), CapturedAt = new DateTime(2026, 9, 28, 18, 2, 11, 250), UtcOffset = 120,
|
|
TimeSource = TimestampSource.ExifOriginal, Exposure = 1.0 / 250, FNumber = 8, Iso = 100, Focal = 24, Bias = -0.3, Wb = 0,
|
|
Orientation = 6, W = 8192, H = 5464, Format = ImageFileFormat.Cr2, PreviewOffset = 1234, PreviewLength = 567_890,
|
|
Flags = FrameFlags.Excluded,
|
|
},
|
|
],
|
|
Tags = ["sunset", "harbour"],
|
|
Rating = 4,
|
|
Notes = "Windy",
|
|
Status = SequenceStatus.ThumbsBuilt | SequenceStatus.Verified,
|
|
Versions = new ManifestVersions { Settings = 3, Frames = 7 },
|
|
CreatedBy = "alberto",
|
|
Created = new DateTimeOffset(2026, 9, 28, 20, 0, 0, TimeSpan.Zero),
|
|
UpdatedAt = new DateTimeOffset(2026, 9, 29, 8, 0, 0, TimeSpan.Zero),
|
|
VerifiedAt = new DateTimeOffset(2026, 9, 30, 8, 0, 0, TimeSpan.Zero),
|
|
SessionKeys = ["card-1234abcd-20260928-180211"],
|
|
};
|
|
|
|
private string SidecarPath() => Path.Combine(context.CreateTempDirectory(), ".chronos", "sequence.json");
|
|
|
|
private static string Canonical(SequenceManifest m) => JsonSerializer.Serialize(m, ArchiveJson.Default.SequenceManifest);
|
|
|
|
[Test]
|
|
public void SequenceSidecarRoundTripsEveryField()
|
|
{
|
|
var path = SidecarPath();
|
|
var original = Sample();
|
|
ManifestStore.WriteSequence(path, original);
|
|
var read = ManifestStore.ReadSequence(path);
|
|
Assert.Equal(Canonical(original), Canonical(read));
|
|
Assert.Equal(original.Frames[0], read.Frames[0] with { Extra = original.Frames[0].Extra });
|
|
var json = File.ReadAllText(path);
|
|
foreach (var field in new[] { "\"i\":", "\"file\":", "\"sha256\":", "\"capturedAt\":", "\"fNumber\":", "\"w\":", "\"previewOffset\":", "\"flags\":" })
|
|
Assert.Contains(field, json);
|
|
}
|
|
|
|
[Test]
|
|
public void TombstonesAndConversionSourcesRoundTripWhileASidecarWithoutThemStaysAsItWas()
|
|
{
|
|
var path = SidecarPath();
|
|
var plain = Sample();
|
|
ManifestStore.WriteSequence(path, plain);
|
|
var before = File.ReadAllText(path);
|
|
Assert.False(before.Contains("\"removed\"", StringComparison.Ordinal), "no tombstones, no field");
|
|
Assert.False(before.Contains("\"source\"", StringComparison.Ordinal), "an original has no source");
|
|
|
|
var at = new DateTimeOffset(2026, 10, 27, 10, 0, 0, TimeSpan.Zero);
|
|
var changed = plain with
|
|
{
|
|
Removed =
|
|
[
|
|
new RemovedPhoto { Sha256 = new string('b', 64), Reason = RemovalReason.Deleted, At = at },
|
|
new RemovedPhoto { Sha256 = new string('c', 64), Replacement = new string('d', 64), Reason = RemovalReason.Replaced, At = at },
|
|
],
|
|
Frames =
|
|
[
|
|
plain.Frames[0] with
|
|
{
|
|
Source = new FrameSource { Sha256 = new string('e', 64), Format = ImageFileFormat.Cr2, File = "originals/IMG_0001.CR2", Size = 25_000_000 },
|
|
},
|
|
],
|
|
};
|
|
ManifestStore.WriteSequence(path, changed);
|
|
var read = ManifestStore.ReadSequence(path);
|
|
|
|
Assert.Equal(Canonical(changed), Canonical(read));
|
|
Assert.Equal(RemovalReason.Replaced, Assert.NotNull(read.Removed)[1].Reason);
|
|
Assert.Equal(new string('d', 64), read.Removed[1].Replacement);
|
|
Assert.Equal(ImageFileFormat.Cr2, Assert.NotNull(read.Frames[0].Source).Format);
|
|
var json = File.ReadAllText(path);
|
|
foreach (var field in new[] { "\"removed\":", "\"replacement\":", "\"reason\":\"Replaced\"", "\"at\":", "\"source\":" }) Assert.Contains(field, json);
|
|
}
|
|
|
|
[Test]
|
|
public void ASidecarBeingReadIsReplacedOnceTheReaderIsDone()
|
|
{
|
|
// A thumbnail pass reads a sidecar without a lease while an upload commits to it (owner review 1). Windows refuses
|
|
// to rename over a file someone has open, so the write tries again for a moment instead of failing the upload.
|
|
var path = SidecarPath();
|
|
var first = Sample();
|
|
ManifestStore.WriteSequence(path, first);
|
|
// The reader runs on its own thread, so it lets go on time however busy the thread pool is.
|
|
using var opened = new ManualResetEventSlim();
|
|
string? read = null;
|
|
var reader = new Thread(() =>
|
|
{
|
|
using var reading = new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.Read | FileShare.Delete);
|
|
opened.Set();
|
|
Thread.Sleep(150);
|
|
using var old = new StreamReader(reading);
|
|
read = old.ReadToEnd();
|
|
});
|
|
reader.Start();
|
|
Assert.True(opened.Wait(TimeSpan.FromSeconds(10)), "the reader opened the sidecar");
|
|
ManifestStore.WriteSequence(path, first with { Title = "Rooftop" });
|
|
reader.Join();
|
|
Assert.Contains("Harbour sunset", read);
|
|
Assert.Equal("Rooftop", ManifestStore.ReadSequence(path).Title);
|
|
Assert.Contains("Rooftop", AtomicFile.ReadAllText(path));
|
|
}
|
|
|
|
[Test]
|
|
public void UnknownFieldsAndEnumValuesFromANewerBuildAreReadAndKept()
|
|
{
|
|
var path = SidecarPath();
|
|
Directory.CreateDirectory(Path.GetDirectoryName(path)!);
|
|
var id = Guid.CreateVersion7();
|
|
var frameId = Guid.CreateVersion7();
|
|
File.WriteAllText(path, $$"""
|
|
{
|
|
"schemaVersion": 1, "id": "{{id}}", "title": "Comet", "futureBlock": { "a": [1, 2] },
|
|
"camera": { "make": "Nikon", "sensorTemp": 31 },
|
|
"frames": [ { "id": "{{frameId}}", "i": 0, "file": "x.nef", "size": 10, "format": "Nef2030", "timeSource": "Atomic",
|
|
"flags": 4096, "aiScore": 0.9 } ],
|
|
"status": 1024, "versions": { "settings": 1, "frames": 2, "renders": 5 },
|
|
}
|
|
""");
|
|
var read = ManifestStore.ReadSequence(path);
|
|
Assert.Equal(id, read.Id);
|
|
Assert.Equal(ImageFileFormat.Unknown, read.Frames[0].Format);
|
|
Assert.Equal(TimestampSource.Unknown, read.Frames[0].TimeSource);
|
|
Assert.Equal((FrameFlags)4096, read.Frames[0].Flags);
|
|
|
|
ManifestStore.WriteSequence(path, read with { Title = "Comet 2026" });
|
|
var json = File.ReadAllText(path);
|
|
foreach (var kept in new[] { "futureBlock", "sensorTemp", "aiScore", "renders", "4096", "1024" }) Assert.Contains(kept, json);
|
|
Assert.Equal("Comet 2026", ManifestStore.ReadSequence(path).Title);
|
|
}
|
|
|
|
[Test]
|
|
public void ANewerSchemaIsReadableButNeverRewritten()
|
|
{
|
|
var path = SidecarPath();
|
|
ManifestStore.WriteSequence(path, Sample());
|
|
var newer = ManifestStore.ReadSequence(path) with { SchemaVersion = SequenceManifest.CurrentSchemaVersion + 1 };
|
|
var before = File.ReadAllBytes(path);
|
|
Assert.Throws<NewerFormatException>(() => ManifestStore.WriteSequence(path, newer));
|
|
Assert.BytesEqual(before, File.ReadAllBytes(path));
|
|
}
|
|
|
|
[Test]
|
|
public void DamagedJsonIsReportedAsInvalidData()
|
|
{
|
|
var path = SidecarPath();
|
|
Directory.CreateDirectory(Path.GetDirectoryName(path)!);
|
|
File.WriteAllText(path, "{ \"id\": ");
|
|
Assert.Throws<InvalidDataException>(() => ManifestStore.ReadSequence(path));
|
|
File.WriteAllText(path, "{ \"title\": \"no id\" }");
|
|
Assert.Throws<InvalidDataException>(() => ManifestStore.ReadSequence(path));
|
|
}
|
|
|
|
[Test]
|
|
public void ACrashDuringAWriteLeavesThePreviousSidecarIntact()
|
|
{
|
|
var path = SidecarPath();
|
|
var first = Sample();
|
|
ManifestStore.WriteSequence(path, first);
|
|
// Simulated crash: the next version was half written to the temporary sibling and never renamed.
|
|
var torn = AtomicFile.TempPathFor(path);
|
|
File.WriteAllBytes(torn, Encoding.UTF8.GetBytes(Canonical(first with { Title = "Lost" })[..40]));
|
|
|
|
Assert.Equal(Canonical(first), Canonical(ManifestStore.ReadSequence(path)));
|
|
ManifestStore.WriteSequence(path, first with { Title = "Second" });
|
|
Assert.Equal("Second", ManifestStore.ReadSequence(path).Title);
|
|
Assert.FileExists(torn);
|
|
Assert.Equal(2, Directory.GetFiles(Path.GetDirectoryName(path)!).Length);
|
|
}
|
|
|
|
[Test]
|
|
public void CreatingASidecarClaimsTheFolderOnce()
|
|
{
|
|
var path = SidecarPath();
|
|
Directory.CreateDirectory(Path.GetDirectoryName(path)!);
|
|
var a = Sample();
|
|
var b = Sample();
|
|
Assert.True(ManifestStore.TryCreateSequence(path, a));
|
|
Assert.False(ManifestStore.TryCreateSequence(path, b));
|
|
Assert.Equal(a.Id, ManifestStore.ReadSequence(path).Id);
|
|
Assert.Count(1, Directory.GetFiles(Path.GetDirectoryName(path)!));
|
|
}
|
|
|
|
[Test]
|
|
public void ArchiveManifestRoundTripsAndKeepsUnknownFields()
|
|
{
|
|
var path = Path.Combine(context.CreateTempDirectory(), "archive.json");
|
|
File.WriteAllText(path, $$"""
|
|
{ "schemaVersion": 1, "id": "{{Guid.CreateVersion7()}}", "name": "Main", "created": "2026-10-02T09:00:00+00:00",
|
|
"layoutTemplates": { "folder": "{year}/{title}", "file": "{n:00000}" }, "proxyPolicy": { "longEdge": 2560, "quality": 90 },
|
|
"syncPolicy": "mirror" }
|
|
""");
|
|
var read = ManifestStore.ReadArchive(path);
|
|
Assert.Equal("{year}/{title}", read.LayoutTemplates.Folder);
|
|
Assert.Equal(2560, read.ProxyPolicy.LongEdge);
|
|
ManifestStore.WriteArchive(path, read with { Name = "Studio" });
|
|
Assert.Contains("syncPolicy", File.ReadAllText(path));
|
|
Assert.Equal("Studio", ManifestStore.ReadArchive(path).Name);
|
|
}
|
|
|
|
[Test]
|
|
public void TheThumbnailSizeIsTheArchivesOwnAndDefaultsTo320()
|
|
{
|
|
// An archive.json written before the thumbnail policy existed reads with the BRIEF §8.5 default.
|
|
var path = Path.Combine(context.CreateTempDirectory(), "archive.json");
|
|
File.WriteAllText(path, $$"""
|
|
{ "schemaVersion": 1, "id": "{{Guid.CreateVersion7()}}", "name": "Main", "created": "2026-10-02T09:00:00+00:00" }
|
|
""");
|
|
var read = ManifestStore.ReadArchive(path);
|
|
Assert.Equal((320, 80), (read.ThumbnailPolicy.LongEdge, read.ThumbnailPolicy.Quality));
|
|
|
|
ManifestStore.WriteArchive(path, read with { ThumbnailPolicy = read.ThumbnailPolicy with { LongEdge = 480 } });
|
|
Assert.Contains("\"thumbnailPolicy\"", File.ReadAllText(path));
|
|
Assert.Equal(480, ManifestStore.ReadArchive(path).ThumbnailPolicy.LongEdge);
|
|
File.WriteAllText(path, $$"""
|
|
{ "schemaVersion": 1, "id": "{{Guid.CreateVersion7()}}", "name": "Main", "thumbnailPolicy": { "longEdge": 240 } }
|
|
""");
|
|
Assert.Equal((240, 80), (ManifestStore.ReadArchive(path).ThumbnailPolicy.LongEdge, ManifestStore.ReadArchive(path).ThumbnailPolicy.Quality));
|
|
|
|
Assert.True(ThumbnailPolicy.IsValidLongEdge(160) && ThumbnailPolicy.IsValidLongEdge(1024));
|
|
Assert.False(ThumbnailPolicy.IsValidLongEdge(100) || ThumbnailPolicy.IsValidLongEdge(2048));
|
|
Assert.True(ProxyPolicy.IsValidLongEdge(ProxyPolicy.Disabled) && ProxyPolicy.IsValidLongEdge(ProxyPolicy.FullSize) && ProxyPolicy.IsValidLongEdge(1920));
|
|
Assert.False(ProxyPolicy.IsValidLongEdge(100) || ProxyPolicy.IsValidLongEdge(10_000));
|
|
}
|
|
}
|