Phase 4b review, codec findings. A Replace makes the converted file the photo, so a conversion must not lose what the original held, and the dry run must promise only what the job will do. - Linear DNG from a conversion is scene-referred: the pixels are stored in linear ProPhoto primaries (colours outside sRGB stay positive) and divided by the power of two that brings their peak under the white level (at most 4 stops), with BaselineExposure giving it back and ColorMatrix1/ForwardMatrix1 describing that space. Highlights a RAW develops above 1 and its wide-gamut colours now read back as written. Exports keep the clipped linear-sRGB DNG. - A conversion reads with the managed decoders first for every format they read natively (RAWs developed at float precision, as on the server) and with WIC only for what they cannot. A RAW only WIC's Raw Image Extension develops (8 bits) is refused for TIFF-16 and linear DNG and planned out as "eight_bit"; JPEG still converts it. Providers say so through IImageDecoderProvider.DevelopsRawAt8Bits. - The original's colour space is kept: a JPEG (APP2) or TIFF (tag 34675) carries its ICC profile, with the values unchanged; a linear DNG gets the values converted through a matrix/TRC profile; a gray profile converts to sRGB. Exif Adobe RGB (uncalibrated + R03) and HEIF nclx P3 get an in-house profile. A space nothing here can keep (CMYK, a lookup-table profile into a DNG, uncalibrated without R03, HDR nclx) is planned out as "color_profile". New in-house ICC parser/writer and header reader for JPEG, PNG, TIFF, HEIF/AVIF and WebP. - The planner asks every file, whatever tier was recorded (unknown before the light analysis, or by another host), with the conversion's decoders, headers only and eight at a time; a RAW the server cannot develop is "convert_on_pc" in the plan instead of failing its sequence. Photos a target cannot hold (a JPEG side above 65535, more samples than one buffer) are planned out as "too_large", and an overflow fails its photo rather than the job. - A photo that fails reads in the job log as one catalog sentence by cause (Archive.Convert.Failed.*), the file named once; the exception's English text goes to the diagnostics log only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 0ca1e91ea09946d7a55f45695ee58e1a0ff5f779)
104 lines
6.1 KiB
C#
104 lines
6.1 KiB
C#
using Chronos.Core.Codecs.Icc;
|
||
using Chronos.Core.Codecs.Tiff;
|
||
using Chronos.Core.Imaging;
|
||
using Chronos.Core.Mathematics;
|
||
using Chronos.Core.Tests.Conversion;
|
||
using Chronos.Testing;
|
||
|
||
namespace Chronos.Core.Tests.Codecs;
|
||
|
||
/// <summary>ICC profiles (owner review 2, R7): parsed, synthesized for the spaces a marker names, and read from each container.</summary>
|
||
public sealed class IccProfileTests
|
||
{
|
||
[Test]
|
||
public void TheSynthesizedProfilesAreMatrixShapersOfTheirSpace()
|
||
{
|
||
var adobe = IccProfile.AdobeRgb;
|
||
Assert.True(adobe.IsMatrixShaper && adobe.IsRgb && !adobe.IsSrgb);
|
||
Assert.Equal("Compatible with Adobe RGB (1998)", adobe.Description);
|
||
// Colorants add up to the D50 PCS white.
|
||
var white = adobe.Colorants!.Value * new Vector3D(1, 1, 1);
|
||
Assert.Approximately(0.9642, white.X, 2e-4);
|
||
Assert.Approximately(1.0, white.Y, 2e-4);
|
||
Assert.Approximately(0.8249, white.Z, 2e-4);
|
||
// Adobe RGB → linear sRGB: red reaches 1.398 with green −0.398, blue stays put but borrows from green.
|
||
var m = adobe.ToLinearRec709();
|
||
Assert.Approximately(1.3982, m.M11, 2e-3);
|
||
Assert.Approximately(-0.3982, m.M12, 2e-3);
|
||
Assert.Approximately(1.0, m.M22, 2e-3);
|
||
Assert.Approximately(-0.0429, m.M32, 2e-3);
|
||
Assert.Approximately(1.0429, m.M33, 2e-3);
|
||
var neutral = m * new Vector3D(1, 1, 1);
|
||
Assert.Approximately(1, neutral.X, 1e-9);
|
||
Assert.Approximately(1, neutral.Y, 1e-9);
|
||
Assert.Approximately(1, neutral.Z, 1e-9);
|
||
// Its gamma 563/256, written as a u8Fixed8 curve.
|
||
Assert.Approximately(Math.Pow(0.5, 563 / 256.0), adobe.Curves![0].Evaluate(0.5), 1e-12);
|
||
|
||
var p3 = IccProfile.DisplayP3;
|
||
Assert.True(p3.IsMatrixShaper);
|
||
// The sRGB curve, tabulated in 1024 entries.
|
||
for (var v = 0.0; v <= 1; v += 0.05) Assert.Approximately(ColorSpace.SrgbToLinear(v), p3.Curves![1].Evaluate(v), 2e-5);
|
||
// P3's own green is outside sRGB: negative red and blue in Rec.709.
|
||
var green = p3.ToLinearRec709() * new Vector3D(0, 1, 0);
|
||
Assert.Approximately(-0.2246, green.X, 3e-3);
|
||
Assert.Approximately(1.0421, green.Y, 3e-3);
|
||
Assert.Approximately(-0.0786, green.Z, 3e-3);
|
||
|
||
Assert.Null(IccProfile.Parse(new byte[200]));
|
||
Assert.Null(IccProfile.Parse(adobe.Data[..131]));
|
||
}
|
||
|
||
[Test]
|
||
public void ParametricCurvesFollowTheirFunctions()
|
||
{
|
||
// para function 3 with the sRGB parameters (as Apple's Display P3 profile writes it).
|
||
byte[] tag = [.. "para"u8, 0, 0, 0, 0, 0, 3, 0, 0, .. Fixed(2.4), .. Fixed(1 / 1.055), .. Fixed(0.055 / 1.055), .. Fixed(1 / 12.92), .. Fixed(0.04045)];
|
||
var curve = IccCurve.Parse(tag)!;
|
||
foreach (var v in new[] { 0.0, 0.02, 0.04045, 0.3, 0.75, 1.0 }) Assert.Approximately(ColorSpace.SrgbToLinear(v), curve.Evaluate(v), 2e-5);
|
||
Assert.Approximately(Math.Pow(0.5, 1.8), IccCurve.Parse([.. "para"u8, 0, 0, 0, 0, 0, 0, 0, 0, .. Fixed(1.8)])!.Evaluate(0.5), 1e-4);
|
||
Assert.Approximately(0.25, IccCurve.Parse([.. "curv"u8, 0, 0, 0, 0, 0, 0, 0, 0])!.Evaluate(0.25), 1e-12);
|
||
Assert.Approximately(0.5, IccCurve.Parse([.. "curv"u8, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0x80, 0, 0xFF, 0xFF])!.Evaluate(0.5), 1e-4);
|
||
Assert.Null(IccCurve.Parse([.. "para"u8, 0, 0, 0, 0, 0, 9, 0, 0]));
|
||
|
||
static byte[] Fixed(double v)
|
||
{
|
||
var b = new byte[4];
|
||
System.Buffers.Binary.BinaryPrimitives.WriteInt32BigEndian(b, (int)Math.Round(v * 65536));
|
||
return b;
|
||
}
|
||
}
|
||
|
||
[Test]
|
||
public void EachContainerSaysItsColourSpace()
|
||
{
|
||
using var scene = ColorFixtures.Scene();
|
||
var p3 = IccProfile.DisplayP3.Data;
|
||
SourceColor Read(byte[] file, ImageFileFormat format) => SourceColor.Read(new MemoryStream(file), format);
|
||
|
||
// Untagged and sRGB files are sRGB.
|
||
Assert.Same(SourceColor.Untagged, Read(ColorFixtures.Jpeg(scene), ImageFileFormat.Jpeg));
|
||
Assert.Same(SourceColor.Untagged, Read(ColorFixtures.Jpeg(scene, exifTiff: ColorFixtures.Exif(1, "R98")), ImageFileFormat.Jpeg));
|
||
// An embedded profile, byte for byte: JPEG APP2 (one chunk, or several), PNG iCCP, TIFF tag 34675, HEIF prof.
|
||
Assert.BytesEqual(p3, Read(ColorFixtures.Jpeg(scene, p3), ImageFileFormat.Jpeg).Profile!.Data);
|
||
var large = ColorFixtures.Large();
|
||
Assert.BytesEqual(large, Read(ColorFixtures.Jpeg(scene, large), ImageFileFormat.Jpeg).Profile!.Data);
|
||
Assert.BytesEqual(p3, Read(ColorFixtures.Png(scene, p3), ImageFileFormat.Png).Profile!.Data);
|
||
Assert.BytesEqual(p3, Read(TiffWriter.Write(scene, new TiffWriteOptions { IccProfile = p3 }), ImageFileFormat.Tiff).Profile!.Data);
|
||
Assert.BytesEqual(p3, Read(ColorFixtures.Heif(ColorFixtures.Nclx(1, 13), ColorFixtures.Prof(p3)), ImageFileFormat.Heif).Profile!.Data);
|
||
// A grid whose tiles carry the profile, not the grid item.
|
||
Assert.BytesEqual(p3, Read(ColorFixtures.Heif(2, ColorFixtures.Prof(p3)), ImageFileFormat.Heif).Profile!.Data);
|
||
// A camera's Adobe RGB marker (uncalibrated, Interop R03) names Adobe RGB, in a JPEG and in a TIFF.
|
||
Assert.Same(IccProfile.AdobeRgb, Read(ColorFixtures.Jpeg(scene, exifTiff: ColorFixtures.Exif(0xFFFF, "R03")), ImageFileFormat.Jpeg).Profile);
|
||
// nclx: BT.709 is sRGB, P3 primaries Display P3, BT.2020 or PQ unknown.
|
||
Assert.Same(SourceColor.Untagged, Read(ColorFixtures.Heif(ColorFixtures.Nclx(1, 13)), ImageFileFormat.Heif));
|
||
Assert.Same(IccProfile.DisplayP3, Read(ColorFixtures.Heif(ColorFixtures.Nclx(12, 13)), ImageFileFormat.Heif).Profile);
|
||
Assert.True(Read(ColorFixtures.Heif(ColorFixtures.Nclx(9, 16)), ImageFileFormat.Heif).IsUnknown);
|
||
// Uncalibrated without R03, or a profile that does not parse: a space nothing here describes.
|
||
Assert.True(Read(ColorFixtures.Jpeg(scene, exifTiff: ColorFixtures.Exif(0xFFFF)), ImageFileFormat.Jpeg).IsUnknown);
|
||
Assert.True(Read(ColorFixtures.Jpeg(scene, new byte[300]), ImageFileFormat.Jpeg).IsUnknown);
|
||
// RAWs say nothing here: their decoders give Rec.709.
|
||
Assert.Same(SourceColor.Untagged, Read([1, 2, 3], ImageFileFormat.Cr2));
|
||
}
|
||
}
|