Owner review 1, phase 2 (docs/requests/2026-10-15-owner-review-1.md, R2). Jobs now run one at a time on the desktop and on the server. Parallelism (Settings > Rendering, TITANO_PARALLELISM) is how many photos the running job processes at once: thumbnail and proxy passes draw that many photos together and still write the pack and checkpoints in frame order, decode tiers are probed that many at a time, the deep analysis measures that many frames and a render decodes that many ahead. Wherever originals are developed whole (TIFF, PNG, RAW without a usable preview), fewer run at once within the memory budget, which the running job now has whole; the server's frame window is sized to the host instead of 1 GiB. A new job waits its turn and pausing the running job starts the next one. An optional priority queue gives each job kind a level (renders, imports and downloads high, verifies and proxies low by default): a queued job of a higher level pauses the running one without asking, and that job goes back to the queue with its checkpoint and resumes by itself afterwards. Jobs of the same level, and a job's own follow-ups, never interrupt it. The Jobs screen and the admin panel show the parallelism and the queue; Settings > Rendering and the admin panel's Settings set them, at once. TITANO_WORKERS and the Workers key of server.json still set the parallelism (1 to 64, with a warning at start for the variable). Titano.Tools gains i18n prune, which removed the renamed keys from the 36 machine-translated languages; the new strings are translated in all 38. Found while testing: uploads and imports failed when a pass read the sidecar while they wrote it (atomic writes now retry the rename while a reader holds the file, and never for a read-only one), and taking a lease just released while another process read it failed on Windows (the create now waits for the reader). Five adversarial review rounds checked the phase before this commit. Also updates BRIEF (12.8, 14.6, 14.8, 14.9, 24), DECISIONS, CHANGELOG, ARCHITECTURE, STATUS, the request file and the compose/Unraid templates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
138 lines
5.8 KiB
C#
138 lines
5.8 KiB
C#
using System.Text.Json;
|
|
using Titano.Core.Archiving;
|
|
using Titano.Testing;
|
|
|
|
namespace Titano.Core.Tests.Archiving;
|
|
|
|
[Category("archive")]
|
|
public sealed class LeaseFileTests(TestContext context)
|
|
{
|
|
private static void WriteRecord(string path, LeaseRecord record) =>
|
|
File.WriteAllBytes(path, JsonSerializer.SerializeToUtf8Bytes(record, ArchiveJson.Default.LeaseRecord));
|
|
|
|
[Test]
|
|
public void ALeaseIsExclusiveUntilReleased()
|
|
{
|
|
var locks = context.CreateTempDirectory();
|
|
using (var a = LeaseFile.TryAcquire(locks, "seq-1", "server"))
|
|
{
|
|
Assert.NotNull(a);
|
|
Assert.Null(LeaseFile.TryAcquire(locks, "seq-1", "client"));
|
|
using var other = LeaseFile.TryAcquire(locks, "seq-2", "client");
|
|
Assert.NotNull(other);
|
|
}
|
|
using var b = LeaseFile.TryAcquire(locks, "seq-1", "client");
|
|
Assert.NotNull(b);
|
|
Assert.Equal("client", LeaseFile.Read(LeaseFile.PathFor(locks, "seq-1"))!.Owner);
|
|
}
|
|
|
|
[Test]
|
|
public void ALeaseReleasedWhileAReaderHoldsItIsTakenOnceTheReaderLetsGo()
|
|
{
|
|
// Found under load while testing owner review 1: on Windows the released file stays pending deletion while a reader
|
|
// has it open, and creating the name answers "access denied" meanwhile instead of succeeding or saying "taken".
|
|
var locks = context.CreateTempDirectory();
|
|
var held = LeaseFile.TryAcquire(locks, "seq-1", "server")!;
|
|
var path = LeaseFile.PathFor(locks, "seq-1");
|
|
using var opened = new ManualResetEventSlim();
|
|
var reader = new Thread(() =>
|
|
{
|
|
using var reading = new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite | FileShare.Delete);
|
|
opened.Set();
|
|
Thread.Sleep(30);
|
|
});
|
|
reader.Start();
|
|
Assert.True(opened.Wait(TimeSpan.FromSeconds(10)), "the reader opened the lease");
|
|
held.Dispose();
|
|
using var taken = LeaseFile.TryAcquire(locks, "seq-1", "client");
|
|
reader.Join();
|
|
Assert.NotNull(taken);
|
|
Assert.Equal("client", LeaseFile.Read(path)!.Owner);
|
|
}
|
|
|
|
[Test]
|
|
public void AnExpiredLeaseOfACrashedHolderIsTakenOver()
|
|
{
|
|
var locks = context.CreateTempDirectory();
|
|
var past = DateTimeOffset.UtcNow.AddMinutes(-10);
|
|
WriteRecord(LeaseFile.PathFor(locks, "seq-1"), new LeaseRecord("dead", "crashed", "pc", 1, past, past.AddMinutes(2)));
|
|
using var lease = LeaseFile.TryAcquire(locks, "seq-1", "survivor");
|
|
Assert.NotNull(lease);
|
|
Assert.Equal("survivor", LeaseFile.Read(LeaseFile.PathFor(locks, "seq-1"))!.Owner);
|
|
Assert.Count(1, Directory.GetFiles(locks));
|
|
}
|
|
|
|
[Test]
|
|
public async Task AHeldLeaseIsRenewedPastItsDuration()
|
|
{
|
|
var locks = context.CreateTempDirectory();
|
|
using var lease = LeaseFile.TryAcquire(locks, "seq-1", "server", TimeSpan.FromMilliseconds(300));
|
|
Assert.NotNull(lease);
|
|
await Task.Delay(900);
|
|
Assert.True(lease.IsHeld);
|
|
Assert.Greater((LeaseFile.Read(lease.Path)!.Expires - DateTimeOffset.UtcNow).TotalMilliseconds, 0);
|
|
Assert.Null(LeaseFile.TryAcquire(locks, "seq-1", "client", TimeSpan.FromMilliseconds(300)));
|
|
}
|
|
|
|
[Test]
|
|
public void AFreshEmptyLeaseFileIsNotStaleButAnOldOneIs()
|
|
{
|
|
var locks = context.CreateTempDirectory();
|
|
var path = LeaseFile.PathFor(locks, "seq-1");
|
|
File.WriteAllBytes(path, []);
|
|
Assert.Null(LeaseFile.TryAcquire(locks, "seq-1", "client"));
|
|
File.SetLastWriteTimeUtc(path, DateTime.UtcNow.AddHours(-1));
|
|
using var lease = LeaseFile.TryAcquire(locks, "seq-1", "client");
|
|
Assert.NotNull(lease);
|
|
}
|
|
|
|
[Test]
|
|
public void ALostLeaseIsDetectedAndNotDeletedByItsFormerHolder()
|
|
{
|
|
var locks = context.CreateTempDirectory();
|
|
var lease = LeaseFile.TryAcquire(locks, "seq-1", "slow");
|
|
Assert.NotNull(lease);
|
|
var now = DateTimeOffset.UtcNow;
|
|
WriteRecord(lease.Path, new LeaseRecord("thief", "other", "pc", 2, now, now.AddMinutes(2)));
|
|
Assert.False(lease.Renew());
|
|
Assert.False(lease.IsHeld);
|
|
lease.Dispose();
|
|
Assert.Equal("thief", LeaseFile.Read(LeaseFile.PathFor(locks, "seq-1"))!.Token);
|
|
}
|
|
|
|
[Test]
|
|
public async Task WaitingForABusyLeaseTimesOutWithItsHolder()
|
|
{
|
|
var locks = context.CreateTempDirectory();
|
|
using var held = LeaseFile.TryAcquire(locks, "seq-1", "server");
|
|
var error = await Assert.ThrowsAsync<LeaseUnavailableException>(() =>
|
|
LeaseFile.AcquireAsync(locks, "seq-1", "client", TimeSpan.FromMilliseconds(200)));
|
|
Assert.Equal("server", error.Holder!.Owner);
|
|
}
|
|
|
|
[Test]
|
|
public async Task WaitingForALeaseSucceedsOnceItIsReleased()
|
|
{
|
|
var locks = context.CreateTempDirectory();
|
|
var held = LeaseFile.TryAcquire(locks, "seq-1", "server")!;
|
|
var waiting = LeaseFile.AcquireAsync(locks, "seq-1", "client", TimeSpan.FromSeconds(10));
|
|
await Task.Delay(100);
|
|
held.Dispose();
|
|
using var lease = await waiting;
|
|
Assert.Equal("client", lease.Record.Owner);
|
|
}
|
|
|
|
[Test]
|
|
public void CleanupRemovesOnlyStaleLeasesAndItsDryRunNothing()
|
|
{
|
|
var locks = context.CreateTempDirectory();
|
|
var past = DateTimeOffset.UtcNow.AddMinutes(-10);
|
|
WriteRecord(LeaseFile.PathFor(locks, "dead"), new LeaseRecord("t", "crashed", "pc", 1, past, past.AddMinutes(1)));
|
|
using var live = LeaseFile.TryAcquire(locks, "live", "server");
|
|
Assert.SequenceEqual(["dead"], LeaseFile.CleanupStale(locks, dryRun: true));
|
|
Assert.Count(2, Directory.GetFiles(locks));
|
|
Assert.SequenceEqual(["dead"], LeaseFile.CleanupStale(locks, dryRun: false));
|
|
Assert.SequenceEqual([LeaseFile.PathFor(locks, "live")], Directory.GetFiles(locks));
|
|
}
|
|
}
|