A pull onto a newer Chronos's settings made the editor throw: ProjectHistory.Replace rebased every undo and redo snapshot through ProjectMerge, which refuses to merge a newer format when both sides changed, so any non-empty undo stack broke the reload after a sync that had succeeded. Replace now drops the steps instead when either side (or a step) is of a newer format: the project is shown read-only and undo never brings back values from before the newer settings. The media learnt the home's hashes and conversion aliases only inside a replay, so a status or Save version before that compared a SHA-named base with photo-named media and read a false Modified or saved a version that only re-keyed photos. Now: - ProjectContent.SameChoices also compares the texts as placed on the frames, hashed or not (Bound), so status and commit without a home agree with the base; - a status asked of the home teaches the media its names (written under the lease, or when the lease is free), and so does a checkout of a project already here; - WorkspaceStatus.MediaOutdated reports frames moved at the home, or names the media could not learn yet, and the project menu offers Update media for it (tooltip text updated in en and it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
175 lines
7.4 KiB
C#
175 lines
7.4 KiB
C#
using Chronos.App.Editor;
|
|
using Chronos.Core.Project;
|
|
using Chronos.Data.Projects;
|
|
using Chronos.Testing;
|
|
|
|
namespace Chronos.App.Tests.Editor;
|
|
|
|
public sealed class ProjectHistoryTests
|
|
{
|
|
private static ProjectSettings WithOffset(ProjectSettings p, double ev) => p with { Exposure = p.Exposure with { ExposureOffsetEv = ev } };
|
|
|
|
[Test]
|
|
public void UndoAndRedoWalkTheSnapshots()
|
|
{
|
|
var start = new ProjectSettings();
|
|
var history = new ProjectHistory(start);
|
|
var changes = 0;
|
|
history.Changed += () => changes++;
|
|
|
|
Assert.True(history.Apply(WithOffset(start, 0.5)));
|
|
Assert.True(history.Apply(WithOffset(history.Current, 1.0)));
|
|
Assert.Equal(1.0, history.Current.Exposure.ExposureOffsetEv);
|
|
|
|
Assert.True(history.Undo());
|
|
Assert.Equal(0.5, history.Current.Exposure.ExposureOffsetEv);
|
|
Assert.True(history.Undo());
|
|
Assert.Equal(0.0, history.Current.Exposure.ExposureOffsetEv);
|
|
Assert.False(history.Undo(), "nothing left to undo");
|
|
Assert.True(history.CanRedo);
|
|
|
|
Assert.True(history.Redo());
|
|
Assert.Equal(0.5, history.Current.Exposure.ExposureOffsetEv);
|
|
Assert.Equal(5, changes);
|
|
}
|
|
|
|
[Test]
|
|
public void ANewEditClearsRedo()
|
|
{
|
|
var history = new ProjectHistory(new ProjectSettings());
|
|
history.Apply(WithOffset(history.Current, 0.5));
|
|
history.Undo();
|
|
history.Apply(WithOffset(history.Current, -0.5));
|
|
Assert.False(history.CanRedo);
|
|
Assert.False(history.Redo());
|
|
}
|
|
|
|
[Test]
|
|
public void EditsWithTheSameKeyAreOneStep()
|
|
{
|
|
var history = new ProjectHistory(new ProjectSettings());
|
|
for (var i = 1; i <= 10; i++) history.Apply(WithOffset(history.Current, i / 10.0), "Exposure.Offset");
|
|
history.Apply(history.Current with { HeroFrame = 3 }, "Frames.Hero");
|
|
|
|
Assert.True(history.Undo());
|
|
Assert.Equal(1.0, history.Current.Exposure.ExposureOffsetEv, "the hero step undone");
|
|
Assert.True(history.Undo());
|
|
Assert.Equal(0.0, history.Current.Exposure.ExposureOffsetEv, "the whole drag undone in one step");
|
|
Assert.False(history.CanUndo);
|
|
}
|
|
|
|
[Test]
|
|
public void AnEditThatChangesNothingIsNotAStep()
|
|
{
|
|
var history = new ProjectHistory(new ProjectSettings());
|
|
Assert.False(history.Apply(new ProjectSettings()), "equal values, even as a new instance");
|
|
Assert.False(history.CanUndo);
|
|
}
|
|
|
|
[Test]
|
|
public void ReplaceAdoptsWithoutAnUndoStep()
|
|
{
|
|
var history = new ProjectHistory(new ProjectSettings());
|
|
history.Apply(WithOffset(history.Current, 0.5));
|
|
history.Replace(history.Current with { HeroFrame = 7 });
|
|
Assert.Equal(7, history.Current.HeroFrame);
|
|
Assert.True(history.Undo());
|
|
Assert.Equal(0.0, history.Current.Exposure.ExposureOffsetEv);
|
|
Assert.Equal(7, history.Current.HeroFrame, "undo reverts the user's step, not the adopted change");
|
|
Assert.False(history.CanUndo);
|
|
Assert.True(history.Redo());
|
|
Assert.Equal(0.5, history.Current.Exposure.ExposureOffsetEv);
|
|
Assert.Equal(7, history.Current.HeroFrame);
|
|
}
|
|
|
|
[Test]
|
|
public void AdviceAdoptedLaterSurvivesUndoAndRedo()
|
|
{
|
|
var start = new ProjectSettings();
|
|
var history = new ProjectHistory(start);
|
|
history.Apply(start with { Camera = start.Camera with { OffsetY = 0.1 } });
|
|
history.Apply(history.Current with { HeroFrame = 4 });
|
|
history.Undo();
|
|
// An analysis fills the advice of a setting the user never touched; the redo step and the undo step both take it.
|
|
var advised = history.Current with { Exposure = history.Current.Exposure with { Deflicker = history.Current.Exposure.Deflicker.WithAdvice(true, "Advisor.Reason.Deflicker.On") } };
|
|
history.Replace(advised);
|
|
|
|
Assert.True(history.Undo());
|
|
Assert.Equal(0.0, history.Current.Camera.OffsetY);
|
|
Assert.True(history.Current.Exposure.Deflicker.HasAdvice, "the advice is not undone");
|
|
Assert.True(history.Redo());
|
|
Assert.True(history.Redo());
|
|
Assert.Equal(4, history.Current.HeroFrame);
|
|
Assert.True(history.Current.Exposure.Deflicker is { HasAdvice: true, IsAuto: true });
|
|
}
|
|
|
|
[Test]
|
|
public void AValueBothChangedUndoesToTheUsersOwnStep()
|
|
{
|
|
var start = new ProjectSettings();
|
|
var history = new ProjectHistory(start);
|
|
history.Apply(start with { HeroFrame = 3 });
|
|
history.Replace(history.Current with { HeroFrame = 9 });
|
|
Assert.True(history.Undo());
|
|
Assert.Null(history.Current.HeroFrame, "the user's step reverts the value it set");
|
|
}
|
|
|
|
[Test]
|
|
public void SettingsOfANewerChronosAdoptedDropTheStepsInsteadOfMergingThem()
|
|
{
|
|
var newer = ProjectSettings.FromJson("""{ "version": 2, "exposure": { "exposureOffsetEv": 1.5 }, "grade": { "look": "film" } }""", allowNewer: true);
|
|
// The workspace's merge throws as ProjectMerge does where both sides changed and one is a newer Chronos's.
|
|
foreach (var merge in new Func<ProjectSettings, ProjectSettings, ProjectSettings, ProjectSettings>?[]
|
|
{ null, (basis, ours, theirs) => ProjectMerge.MergeWithConflicts(basis, ours, theirs).Merged })
|
|
{
|
|
var history = new ProjectHistory(new ProjectSettings(), merge: merge);
|
|
history.Apply(WithOffset(history.Current, 0.3));
|
|
history.Apply(history.Current with { HeroFrame = 2 });
|
|
history.Undo();
|
|
Assert.True(history.CanUndo && history.CanRedo);
|
|
var changes = 0;
|
|
history.Changed += () => changes++;
|
|
|
|
// A pull took the newer settings (nothing of the editor's waited): shown as they are, read-only.
|
|
history.Replace(newer);
|
|
Assert.True(history.Current.IsNewerFormat);
|
|
Assert.Equal(1.5, history.Current.Exposure.ExposureOffsetEv);
|
|
Assert.False(history.CanUndo, "no step brings back this Chronos's values over a newer one's");
|
|
Assert.False(history.CanRedo);
|
|
Assert.False(history.Undo());
|
|
Assert.Equal(1, changes);
|
|
|
|
// Back to this Chronos's format (a Save both took another project): nothing is merged into the newer settings either.
|
|
history.Replace(WithOffset(new ProjectSettings(), 0.6));
|
|
Assert.Equal(0.6, history.Current.Exposure.ExposureOffsetEv);
|
|
Assert.False(history.CanUndo);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void EndingARunMakesTheNextEditANewStep()
|
|
{
|
|
var history = new ProjectHistory(new ProjectSettings());
|
|
history.Apply(WithOffset(history.Current, 0.2), "Exposure.Offset");
|
|
history.Apply(WithOffset(history.Current, 0.4), "Exposure.Offset");
|
|
history.EndRun();
|
|
history.Apply(WithOffset(history.Current, 0.6), "Exposure.Offset");
|
|
|
|
Assert.True(history.Undo());
|
|
Assert.Equal(0.4, history.Current.Exposure.ExposureOffsetEv, "the second drag is its own step");
|
|
Assert.True(history.Undo());
|
|
Assert.Equal(0.0, history.Current.Exposure.ExposureOffsetEv);
|
|
}
|
|
|
|
[Test]
|
|
public void TheOldestStepsAreDroppedBeyondCapacity()
|
|
{
|
|
var history = new ProjectHistory(new ProjectSettings(), capacity: 3);
|
|
for (var i = 1; i <= 5; i++) history.Apply(history.Current with { HeroFrame = i });
|
|
var undone = 0;
|
|
while (history.Undo()) undone++;
|
|
Assert.Equal(3, undone);
|
|
Assert.Equal(2, history.Current.HeroFrame);
|
|
}
|
|
}
|