Files
Chronos/tests/Titano.App.Tests/Uploader/ConnectViewModelTests.cs
T
Claude 1187c36d66 fix(uploader): follow right-to-left languages, name and reach every control by keyboard
Uploader:
- Mirror the main window, the confirmation dialog and the tray menu for ar/he/fa/ur; keep paths, addresses,
  file names, the fingerprint, the brand mark and media glyphs left to right.
- Queue rows take keyboard focus, are named "file · state" for screen readers, and Enter retries a failed
  file; a "✕ n failed" link jumps to the first failure; the list follows the upload near its top.
- Focus moves into the settings panel (Tab cycles inside) and back to the gear, to Browse after sign-in and
  to the refused field after a failed one; activity changes and sign-in errors are announced.
- A wrong address or password marks its field (error border, message in the tooltip); Retry only where it
  can help; session-ended toasts offer Sign in; the form stays visible while its own sign-in runs.
- Watch chips and the add button wrap and shorten long paths; target choices wrap with their fields; the
  settings panel uses the side-panel width with wrapping labels; disabled controls say why.
- The window opens at 760x700 (min 630 high) so the per-file list shows five rows; --capture adds an
  Arabic pass.

Setup:
- Every stage has a default and a cancel button (safe action first), the keyboard moves to the new
  default and outcomes are announced; the title-bar Close is disabled while files are written.
- "Remove my data" measures the user data folder and shows the plan (largest entries, total) before
  Uninstall can run; the tooltip names backups and the uploader queue.
- Folder field before Browse in Tab order; paths and file names left to right; disabled tooltips say why.

Both: byte units come from the language (Common.Size.*).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-03 17:14:54 +00:00

204 lines
7.3 KiB
C#

using System.ComponentModel;
using Titano.Core.Localization;
using Titano.Protocol;
using Titano.Testing;
using Titano.Uploader.Server;
using Titano.Uploader.Shell;
using Titano.Uploader.Uploads;
namespace Titano.App.Tests.Uploader;
/// <summary>
/// The sign-in form puts each failure where DESIGN §4 wants it: a refused address or password marks that field
/// (message in its tooltip), other failures are one sentence, with Retry only where trying again can help.
/// </summary>
public sealed class ConnectViewModelTests
{
private const string Fingerprint = "AB:CD";
[Test]
public void NoFieldShowsAnErrorBeforeSigningIn()
{
var form = Form(new FakeSession());
Assert.False(form.HasErrors);
Assert.Empty(form.GetErrors(nameof(ConnectViewModel.Address)));
Assert.Null(form.PasswordError);
Assert.Null(form.ErrorText);
Assert.False(form.CanRetry);
Assert.Equal(Loc.L("Tooltips.Uploader.ServerAddress"), form.AddressToolTip);
Assert.Equal(Loc.L("Tooltips.Uploader.Password"), form.PasswordToolTip);
}
[Test]
public void AnInvalidAddressMarksTheServerFieldUntilItChanges()
{
var form = Form(new FakeSession(SignInResult.InvalidAddress));
var changed = new List<string?>();
form.ErrorsChanged += (_, e) => changed.Add(e.PropertyName);
form.SignInCommand.Execute(null);
var message = Loc.L("Uploader.Connect.Error.InvalidAddress");
Assert.True(form.HasErrors);
Assert.SequenceEqual([message], form.GetErrors(nameof(ConnectViewModel.Address)).Cast<string>());
Assert.Equal(message, form.AddressToolTip);
Assert.Contains(nameof(ConnectViewModel.Address), changed);
Assert.Null(form.ErrorText, "a field error is not repeated under the form");
Assert.False(form.CanRetry);
form.Address = "https://nas.local:9443";
Assert.False(form.HasErrors);
Assert.Equal(Loc.L("Tooltips.Uploader.ServerAddress"), form.AddressToolTip);
}
[Test]
public void AServerThatIsNotTitanoMarksTheServerField()
{
var form = Form(new FakeSession(SignInResult.NotTitano));
form.SignInCommand.Execute(null);
Assert.Equal(Loc.L("Uploader.Connect.Error.NotTitano"), form.AddressError);
Assert.Null(form.ErrorText);
}
[Test]
public void AWrongPasswordMarksThePasswordFieldUntilTheUserTypes()
{
var form = Form(new FakeSession(SignInResult.BadCredentials));
form.SignInCommand.Execute(null);
var message = Loc.L("Uploader.Connect.Error.BadCredentials");
Assert.Equal(message, form.PasswordError);
Assert.Equal(message, form.PasswordToolTip);
Assert.False(form.HasErrors, "the address is not in question");
Assert.Null(form.ErrorText);
Assert.False(form.CanRetry, "the same password would fail again");
form.Password = "another";
Assert.Null(form.PasswordError);
}
[Theory]
[Case(SignInResult.Unreachable, "Uploader.Connect.Error.Unreachable")]
[Case(SignInResult.Failed, "Uploader.Connect.Error.Failed")]
public void FailuresThatMayPassOfferRetry(SignInResult result, string key)
{
var form = Form(new FakeSession(result));
form.SignInCommand.Execute(null);
Assert.Equal(Loc.L(key), form.ErrorText);
Assert.True(form.CanRetry);
Assert.False(form.HasErrors);
Assert.Null(form.PasswordError);
}
[Test]
public void ADeclinedCertificateIsReportedWithoutRetry()
{
var session = new FakeSession(SignInResult.Untrusted);
var form = Form(session, trust: false);
form.SignInCommand.Execute(null);
Assert.Equal(Loc.L("Uploader.Connect.Error.Untrusted"), form.ErrorText);
Assert.False(form.CanRetry);
Assert.Equal(1, session.Attempts);
Assert.Null(session.Trusted);
}
[Test]
public void ATrustedCertificateSignsInAgainAndClearsEveryError()
{
var session = new FakeSession(SignInResult.BadCredentials, SignInResult.Untrusted, SignInResult.Success);
var form = Form(session, trust: true);
form.SignInCommand.Execute(null);
Assert.NotNull(form.PasswordError);
form.SignInCommand.Execute(null);
Assert.Equal(Fingerprint, session.Trusted);
Assert.Equal(3, session.Attempts);
Assert.Null(form.PasswordError);
Assert.Null(form.ErrorText);
Assert.False(form.HasErrors);
}
[Test]
public void TheFormSaysWhileItsOwnSignInRuns()
{
var session = new FakeSession(SignInResult.Unreachable);
var form = Form(session);
session.During = () => Assert.True(form.IsSigningIn, "signing in while the request runs");
form.SignInCommand.Execute(null);
Assert.Equal(1, session.Attempts);
Assert.False(form.IsSigningIn);
}
private static ConnectViewModel Form(FakeSession session, bool trust = false) =>
new(session, new FakeDialogs(trust), "https://nas.local:8443/", "alberto") { Password = "secret" };
/// <summary>Answers each sign-in with the next scripted result, moving through SigningIn as the real session does.</summary>
private sealed class FakeSession(params SignInResult[] results) : IServerSession
{
private ConnectionState _state = ConnectionState.SignedOut;
public event PropertyChangedEventHandler? PropertyChanged;
public event EventHandler<ServerProblem>? SessionEnded
{
add { }
remove { }
}
public int Attempts { get; private set; }
public string? Trusted { get; private set; }
public Action? During { get; set; }
public ConnectionState State => _state;
public string? Address => "https://nas.local:8443/";
public string? Username => "alberto";
public long QuotaBytes => 0;
public long UsedBytes => 0;
public int BandwidthLimit { get; set; }
public Task<(SignInResult Result, string? Fingerprint)> SignInAsync(string address, string username, string password, CancellationToken ct)
{
var result = results[Math.Min(Attempts, results.Length - 1)];
Attempts++;
SetState(ConnectionState.SigningIn);
During?.Invoke();
SetState(result == SignInResult.Success ? ConnectionState.Connected : ConnectionState.SignedOut);
return Task.FromResult<(SignInResult, string?)>((result, result == SignInResult.Untrusted ? Fingerprint : null));
}
public void Trust(string fingerprint) => Trusted = fingerprint;
public Task SignOutAsync() => Task.CompletedTask;
public Task RefreshAsync() => Task.CompletedTask;
public Task<IReadOnlyList<SequenceDto>> ListSequencesAsync(CancellationToken ct) => Task.FromResult<IReadOnlyList<SequenceDto>>([]);
private void SetState(ConnectionState state)
{
_state = state;
PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(nameof(State)));
}
}
private sealed class FakeDialogs(bool trust) : IUploaderDialogs
{
public IReadOnlyList<string> PickFiles() => [];
public string? PickFolder() => null;
public string? PickWatchFolder() => null;
public bool ConfirmTrust(string address, string fingerprint) => trust;
public bool ConfirmDeleteAfterUpload() => false;
}
}