GET /api/v1/archive/settings refreshes the served archive from archive.json first, so the admin form (which saves every field) starts from a desktop's change made since the last poll instead of writing the old templates back. ServerArchive.RefreshAsync replaces the served archive only when the refresh registered a change, and only through a compare-and-swap against the archive it read, so a poll racing an admin's PUT no longer puts the pre-edit row back for ten minutes. RefreshSettingsAsync now ignores an archive.json a newer Titano wrote, as documented, instead of registering what this version reads of it. AppServicesTests now points the folder at an archive the index does not list first, and checks that the archive no longer chosen gets no scan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
157 lines
7.5 KiB
C#
157 lines
7.5 KiB
C#
using System.IO;
|
||
using Titano.App.Infrastructure;
|
||
using Titano.App.Tests.Uploader;
|
||
using Titano.Core.Model;
|
||
using Titano.Data;
|
||
using Titano.Data.Archiving;
|
||
using Titano.Testing;
|
||
|
||
namespace Titano.App.Tests.Infrastructure;
|
||
|
||
public sealed class AppServicesTests
|
||
{
|
||
/// <summary>Dialogs that answer like a user who cancels everything.</summary>
|
||
private sealed class NoDialogs : IAppDialogs
|
||
{
|
||
public string? PickFolder(string title, string? initialFolder = null) => null;
|
||
public string? PickJsonFile(string title) => null;
|
||
public bool Confirm(ConfirmRequest request) => false;
|
||
public bool SignIn(string server, string? username, Func<string, string, Task<string?>> signIn) => false;
|
||
}
|
||
|
||
[Test]
|
||
[WindowsOnly]
|
||
public void ExitStopsPollingAndTheEngineWhileTheUiThreadWaits()
|
||
{
|
||
var environment = AppEnvironment.ForCapture();
|
||
try
|
||
{
|
||
SingleThreadedContext.Run(async () =>
|
||
{
|
||
var root = Path.Combine(environment.DataDirectory, "archive");
|
||
await using (var setup = await TitanoDatabase.OpenAsync(DatabaseOptions.Sqlite(Path.Combine(environment.DataDirectory, "setup.db"))))
|
||
await new ArchiveService(setup).CreateAsync(root, "Exit");
|
||
var services = new AppServices(environment, new AppSettings { Language = "en", LastArchivePath = root }, () => { }, new NoDialogs());
|
||
await services.OpenAsync(environment.DatabasePath);
|
||
// The archive was reopened and its first rescan queued: polling now waits for the next one.
|
||
var until = DateTime.UtcNow + TimeSpan.FromSeconds(30);
|
||
while ((await services.Database!.Jobs.ListAsync(null, JobKind.Scan)).Items.Count == 0)
|
||
{
|
||
Assert.True(DateTime.UtcNow < until, "no rescan queued");
|
||
await Task.Delay(50);
|
||
}
|
||
|
||
// App.OnExit blocks the UI thread until the services stop: nothing they await may continue on it.
|
||
Assert.True(services.DisposeAsync().AsTask().Wait(TimeSpan.FromSeconds(10)), "services stopped");
|
||
});
|
||
}
|
||
finally
|
||
{
|
||
environment.DeleteCaptureData();
|
||
}
|
||
}
|
||
|
||
/// <summary>BRIEF §7: polling follows the archive folder, also one chosen after the start (first run, Settings, relink).</summary>
|
||
[Test]
|
||
[WindowsOnly]
|
||
public void RescansFollowTheArchiveFolderChosenAfterTheStart()
|
||
{
|
||
var environment = AppEnvironment.ForCapture();
|
||
try
|
||
{
|
||
SingleThreadedContext.Run(async () =>
|
||
{
|
||
// The first run: the index opens before any archive folder is set.
|
||
var settings = new AppSettings { Language = "en" };
|
||
var services = new AppServices(environment, settings, () => { }, new NoDialogs());
|
||
try
|
||
{
|
||
await services.OpenAsync(environment.DatabasePath);
|
||
Assert.Null(await services.RescanAsync());
|
||
// The rescans run all the same: Settings › Archive › Rescan every reaches them.
|
||
settings.ScanIntervalMinutes = 30;
|
||
services.SaveSettings();
|
||
Assert.Equal<TimeSpan?>(TimeSpan.FromMinutes(30), services.PollingPeriod);
|
||
|
||
// The first-run dialog creates an archive: the next rescan is of it.
|
||
var firstRoot = Path.Combine(environment.DataDirectory, "first");
|
||
await services.ArchiveSetup.CreateAsync(firstRoot);
|
||
var first = Assert.NotNull(await services.RescanAsync());
|
||
Assert.Equal("first", first.Name);
|
||
|
||
// Settings › Archive moves to another archive, which the index lists after the first one: the next rescan
|
||
// is of the archive at the folder, no longer of the first one.
|
||
var other = Path.Combine(environment.DataDirectory, "zeta");
|
||
await new ArchiveService(services.Database!).CreateAsync(other, "zeta");
|
||
Assert.Equal("first", (await services.Database!.Archives.ListAsync())[0].Name);
|
||
async Task<int> ScansOfAsync(Guid archiveId) =>
|
||
(await services.Database!.Jobs.ListAsync(null, JobKind.Scan)).Items.Count(j => j.TargetIds.Contains(archiveId));
|
||
var scansOfFirst = await ScansOfAsync(first.Id);
|
||
settings.LastArchivePath = other;
|
||
services.SaveSettings();
|
||
var rescanned = Assert.NotNull(await services.RescanAsync());
|
||
Assert.Equal("zeta", rescanned.Name);
|
||
Assert.True(await ScansOfAsync(rescanned.Id) > 0, "the archive at the folder is rescanned");
|
||
Assert.Equal(scansOfFirst, await ScansOfAsync(first.Id));
|
||
|
||
// And back: the folder decides, whatever the order of the index.
|
||
settings.LastArchivePath = firstRoot;
|
||
services.SaveSettings();
|
||
Assert.Equal(first.Id, (await services.RescanAsync())?.Id);
|
||
}
|
||
finally
|
||
{
|
||
Assert.True(services.DisposeAsync().AsTask().Wait(TimeSpan.FromSeconds(10)), "services stopped");
|
||
}
|
||
});
|
||
}
|
||
finally
|
||
{
|
||
environment.DeleteCaptureData();
|
||
}
|
||
}
|
||
|
||
/// <summary>BRIEF §6.2: a restore staged in Settings › Advanced recovers an index that no longer opens.</summary>
|
||
[Test]
|
||
[WindowsOnly]
|
||
public void AStagedRestoreRecoversAnIndexThatNoLongerOpens()
|
||
{
|
||
var environment = AppEnvironment.ForCapture();
|
||
try
|
||
{
|
||
SingleThreadedContext.Run(async () =>
|
||
{
|
||
await using (var db = await TitanoDatabase.OpenAsync(DatabaseOptions.Sqlite(environment.DatabasePath)))
|
||
{
|
||
await db.Archives.UpsertAsync(new Archive { Id = Guid.CreateVersion7(), Name = "Kept", RootPath = @"C:\Kept", Created = DateTimeOffset.UtcNow });
|
||
var backup = await db.BackupAsync(environment.BackupDirectory, DatabaseBackups.Keep);
|
||
await DatabaseBackups.StageRestoreAsync(backup, environment.DatabasePath);
|
||
}
|
||
// The index is damaged beyond opening ("file is not a database").
|
||
File.Delete(environment.DatabasePath + "-wal");
|
||
File.Delete(environment.DatabasePath + "-shm");
|
||
await File.WriteAllBytesAsync(environment.DatabasePath, [.. Enumerable.Repeat((byte)0x5A, 8192)]);
|
||
|
||
var services = new AppServices(environment, new AppSettings { Language = "en" }, () => { }, new NoDialogs());
|
||
try
|
||
{
|
||
await services.OpenAsync(environment.DatabasePath);
|
||
|
||
Assert.Null(services.OpenError);
|
||
Assert.Equal(StagedRestoreResult.Restored, services.StagedRestore);
|
||
Assert.SequenceEqual(["Kept"], (await services.Database!.Archives.ListAsync()).Select(a => a.Name));
|
||
Assert.False(DatabaseBackups.HasStagedRestore(environment.DatabasePath));
|
||
}
|
||
finally
|
||
{
|
||
Assert.True(services.DisposeAsync().AsTask().Wait(TimeSpan.FromSeconds(10)), "services stopped");
|
||
}
|
||
});
|
||
}
|
||
finally
|
||
{
|
||
environment.DeleteCaptureData();
|
||
}
|
||
}
|
||
}
|