Second review of owner review 2, phase 4a (Reorganize), cross-cutting findings.
- A second index of the archive (a desktop sharing a server's archive, or a folder moved by
hand) moved the sequence row at its next scan but left renders.output_path at the old
folder: the export answered 404 there. The scan now rebases the render rows in the same
transaction when it finds a sequence in another folder.
- The rebase covers every render of the archive under the old folder: the sequence's own
exports always, and another sequence's export saved inside it (through the Export folder
picker) when its file moved with the folder. That check keeps the exports of a sequence
that took the old folder since (a later Reorganize on the other index) where they are. A
change of case only counts as a move.
- The desktop now tells an open editor after each Reorganize step
(ArchiveServiceOptions.SequenceChanged -> AppServices.SequenceReorganized), and the editor
reads its sequence again where it is now, so frames no longer decode blank until the next
save. LocalSequenceSource.LoadAsync also requires the same folder on both row reads, so a
move that commits during the frame listing is never taken as current.
- Writers that wrote without the lease, or trusted a row another index had moved, could
create the old folder again. A proxy sent by a client is now filed under the sequence's
lease into the folder the index has then, and a gone sequence or folder answers 404
(sequence_busy 503 after the lease wait). The server files a render a client or render
node sends under the lease (ArchiveService.UnderLeaseAsync). "Save both" keeps its copy
under the lease. The proxy pass holds the thumbnail lease, as the thumbnail pass does. The
deep analysis opens its checkpoint under the sequence lock only while the folder is still
there, and a pass whose folder another process moved records nothing (the job logs
Advisor.Log.FramesChangedElsewhere). Editor saves and sync applies refuse when the folder
is gone.
- ARCHITECTURE.md no longer claims more than this: a render of another process whose folder
moves while it runs is still not stopped.
- ArchiveVerifier.FlushAsync: corrected the comment. A move keeps each file's stamp, so only a
check that found the file missing no longer applies.
Tests cover the scan path with a later swap into the vacated folder, another sequence's
export inside a moving folder, a photo deletion refused when the folder moved while it
waited for the lease, proxies sent and made after a move, Save both during a move, a deep
analysis whose folder another index moved, a render filed after a move on the server, and
an open editor reloaded by a Move job.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit c857b98f795b22956c060f1c5acf4d94b6d1c994)