The audit retention in force ignored the audit clean-up's steps: with the
audit step unticked nothing was deleted, yet Settings › Logs still showed the
age limit. It is now 0 without that step, and setting a limit (Settings › Logs
or CHRONOS_AUDIT_RETENTION_DAYS at start) ticks the step again, so a saved or
fixed retention always takes effect. While the variable fixes a limit above 0,
an edit that drops the step is 409 setting_locked like turning the schedule off.
The admin panel's Scheduled tab disables what the variable fixes (the row's
switch, the form's Enabled and audit step, the age limit) with the locked
tooltip, and points a setting_locked refusal at the field actually refused.
The Copies kept tooltips now say the backups folder keeps as many copies as
the backup schedule that keeps the most; the LastDone and Newest comments
state the real first-copy rule; Keep audit is documented last-writer-wins.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner review 2, phase 2 review findings (scheduler core).
- Log.Write caught only IOException. Microsoft.Extensions.Logging wraps
provider failures in an AggregateException, so a log line that could not
be written (in tests: the process-wide sink of a stopped server whose log
folder was gone) escaped JobEngine.RunAsync's catch before the failure was
stored: the job stayed running and the worker faulted. This was the cause
of the intermittent JobApiTests/ArchiveModuleTests failures. Log.Write now
drops any non-fatal sink failure, TeeLogSink keeps a line from the other
sinks, FileLogSink drops a line it cannot write and reopens the file at the
next one, and LoggerSink drops what the providers throw. The scheduler's
loop relies on the same guarantee.
- The daily backup loop (RunDailyAsync, IsDue, Interval, CheckInterval) had
no caller since the index-backup schedule replaced it; it is removed and
the DatabaseBackups summary describes the schedule.
- The first copy after the upgrade no longer waits a day (or for 03:00):
SystemSchedule.LastDone seeds a new row due at once when its work was last
done a period or more before, and both hosts pass the newest copy in the
backups folder for index-backup.
- Back up now (Settings and Archive), the copy kept before a restore and a
backup job that keeps fewer prune to the largest Copies kept of the backup
schedules (DatabaseBackups.KeptAsync), not a fixed three. The four
tooltips that promised three daily copies are reworded (en, it) and their
stale translations deleted.
- New tests for the scheduler loop itself: a tick, Wake, a pass that threw,
and dispose during a pass.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit c5ad0c4c3f636129afe5dd1ce039185516da5621)
Settings › Logs › Keep audit showed ServerOptions.AuditRetentionDays, a second
copy of the audit clean-up schedule's age limit. Edits made on Jobs › Scheduled
never reached it, so the panel could say "kept forever" while entries were
being deleted every night. Saving 0 there then changed nothing, because the
endpoint only compared against the stale option value.
- GET and PUT /server/settings now report the schedule's limit in force (0
while the schedule is off). Saving compares against that value. A value sent
back unchanged leaves the server.json reset default and the env lock alone. A
new value sets the schedule and becomes the reset default.
- ApplyAgeAsync also turns the schedule on when it already holds the days but
is off.
- CHRONOS_AUDIT_RETENTION_DAYS is now applied before the scheduler's first
pass, through a new Scheduler.StartAsync overload with a beforeFirstPass hook.
Before, a missed 04:30 run was caught up at start with the stale days, which
could delete entries the variable says to keep. While the variable fixes a
limit above 0, turning the schedule off is a 409 setting_locked.
- Corrected the comments in SchedulerHost, ServerOptions, ServerSettingsStore,
LogSettingsDto, the header of settings.js and ARCHITECTURE.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 490ed286e9f32745174b13b1963d6ec91955196b)
Settle what the R10 scheduler and R11 log packages left open when they were
integrated (owner review 2, phase 2).
- Audit retention has one source of truth, the audit-cleanup schedule's age
limit. AuditRetentionDays defaults to 0 (the audit log is kept forever, so
an upgrade deletes nothing; the schedule is seeded off) and accepts 0-3650,
what a schedule's age limit takes. Saving Settings › Logs › Keep audit sets
the schedule's limit (on with a limit, off at 0) without a restart;
CHRONOS_AUDIT_RETENTION_DAYS locks it and Reset goes back to it.
- Both hosts scan right after start again, as their polling did: the server
after the scheduler starts, the desktop once the archive was reopened and
again when an unplugged one is back. Scheduler.RunSystemNowAsync runs the
archive-scan schedule when it is enabled and has not run since the start,
and skips while its scan is pending.
- Desktop scans follow Settings › Analysis › After a scan at every run: a scan
schedule without its own deep parameter asks the host
(IScheduleHost.DeepAnalysisAfterScan), the archive-scan schedule no longer
freezes the setting, and the editor offers deep only for analyses, so the
setting's tooltip stays true.
- The server's upload clean-up runs every 6 hours instead of every 30
minutes, to keep the job history readable; idle uploads still expire after
UploadRetentionHours.
- The Unraid template and docker-compose leave CHRONOS_LOG_LEVEL empty or
commented out, and say that setting it locks both log levels, so the admin
panel can change them.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner review 2, R10: every timer that queues work becomes a visible schedule,
so the server and the desktop need one shared engine to run them.
- Migration 0007: schedules table (system rows keyed by system_key) and
jobs.schedule_id; Job.ScheduleId, JobDto.ScheduleId, JobRepository
HasPendingAsync / ListPendingTargetsAsync / ListByScheduleAsync.
- ScheduleRepository: seeding that keeps user edits, reset, compare-and-set
claim of a run (one winner across processes), outcomes.
- Scheduling: in-house recurrence (every/daily/weekly/monthly, DST gap moves
forward, ambiguous time runs once), ScheduleActions resolving scan, verify,
thumbnails, proxies, analysis, maintenance, backup, cleanup, duplicates and
orphans into archive jobs, IScheduleHost, and the Scheduler loop (catch-up,
clock going back, run now, CRUD as API v1 DTOs).
- New job kinds Backup (16) and Cleanup (17) with handlers, shared clean-up
steps (job history, audit log, trash report that never deletes) and host
steps through ArchiveServiceOptions; read-only Duplicates and Orphans report
handlers, so the server can run those kinds too.
- JobEngine no longer purges history at start: the housekeeping schedule's
job-history step does; JobEngine.CanRun and an EnqueueAsync with scheduleId.
- Protocol DTOs for schedules; job kind names in en and it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit eb0edd2483a493db7c6945d5b494461cabb2a4ad)