Commit Graph
3 Commits
Author SHA1 Message Date
Claude 180bfc623a test(setup): prune a real stopped service whose program is gone, and leave another folder's
The service steps were only checked against in-memory records and registry copies. On an elevated runner the test
registers two throwaway demand-start services through the Service Control Manager, one starting a program of the
install folder and one of another folder, and checks that setup finds only the first, prunes it, and leaves the
second registered.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-12 11:50:29 +00:00
Claude 067e8ca062 fix(setup): change only what starts a program setup installed; Server only inside Program Files
Services, sign-in entries and shortcuts are matched against the full paths of the files the install log or the
payload lists, never against everything under the install folder: an install into a shared folder such as D:\Apps
or /DIR="C:\Program Files" no longer stops, starts or deletes other vendors' services or removes their Run values.
The elevated step now takes the names the unelevated setup found (/SERVICES=... /NAMES=...) and reads each service
again, acting only when it still starts a program of the folder's log or of its own payload (or, for Prune, a
program of the folder that is gone).

Programs are asked to close before any service is touched. On uninstall the services are deleted only once the
programs have closed, just before the files go; a failed install or uninstall starts again the services it
stopped, and after an upgrade setup starts exactly the services it stopped, whatever their start type.

The Server component installs only for all users in a folder inside Program Files. In the window a custom folder
outside it is invalid while the Server is selected, with a tooltip saying why; silent mode refuses it. An upgrade
of an installation elsewhere cannot add the Server, and one it carried is dropped with its service.

Sign-in entries use StartupCommand (the same file as on fix/shell-notify) and are removed by
SetupRegistry.DeleteStartupEntries only when the client's or the Uploader's value starts a program the install log
lists; an upgrade that drops a program removes its entry too. StartupEntries is gone.

A shortcut that starts another product's existing copy is still left alone but now logged; uninstalling the
product it starts hands it to another product of the same scope that lists it and has the same program, so the
Uploader that stays keeps its shortcuts. Another registered Titano installation whose folder or log cannot be read
now counts as using every program's data, so "Remove my data" never offers it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-12 11:41:30 +00:00
Claude 4f6bbfba5d fix(setup): handle install-folder services, startup entries, shared shortcuts and data
- Windows services whose program lies in the install folder (Titano.Server
  --install-service) are found in the registry and, through the Service
  Control Manager, stopped before files are replaced (they join the
  "programs running" prompt), started again after an upgrade that stopped
  them, deleted when an upgrade drops their program and on uninstall. An
  unelevated setup runs that step in an elevated copy (/SERVICES=...).
- The Server component installs for all users only (manifest allUsersOnly):
  choosing it moves a new install to Program Files and disables "Just me"
  with the reason; a per-user install cannot take it.
- Uninstall removes every HKCU Run value that starts a program in the folder
  (the Uploader's "Start with Windows").
- A shortcut that already starts an existing program elsewhere is neither
  retargeted nor logged, and a logged shortcut is deleted only while it
  still starts a program of this folder, so the two products no longer
  remove each other's "Titano Uploader" shortcuts.
- "Remove my data" lists and deletes only the data of this product's
  programs that no other installed Titano product uses (the desktop app and
  the Uploader share %LOCALAPPDATA%\Titano and its logs folder).
- The .titano file type is named in setup's language (Setup.FileType.*).

Setup tests run in Titano.App.Tests on Windows CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
2026-10-12 10:29:16 +00:00