fix(phase4): close the owner review 1 phase 4 findings

Routing sizes render jobs from the resolved preset, and the node wait
applies the same routing as the claim, so a re-routed job neither keeps a
stale size nor waits for a node that will never take it. Settings an older
server cannot read stay on this side for the remote editor, archive sync
and workspace push, and the reason is shown where it applies. A turn on
one side and a framing on the other merge as one conflict.

Orientation and framing fixes: an out-of-range crop turns with the content
it shows, the aspect text transposes exactly, the Rotation row counts
turns as shown on screen, and Reset framing undoes the orientation press
by press, so keyframes and aspect stay on their content. The advisor
places the horizon in the view as shown. A look at zero strength is
cleared and no longer reaches the motion vectors.

Preview changes: the middle button pans, a press inside a box with no
slack pans while zoomed, the selected box shows a ring, and screen readers
hear when the crop value changes. Tooltips in en and it updated; stale
translations of changed tooltips removed so they fall back to English.

Test changes: the pinned hash is OS-independent, and the tautological
encoder and warning assertions became real checks. Added a non-screen
test of the Straighten slider binding.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Alby96andClaude Opus 5.5 committed 2026-11-04 21:40:07 +01:00
1 parent 4e21aaa548
commit eeaddc2d14
83 files changed
+823 -270

No files matched your search

@@ -181,7 +181,21 @@ public sealed class RenderNodeTests(TestContext context)
Assert.True(await Availability().AwaitsNodeAsync(queued with { Created = DateTimeOffset.UtcNow }, parameters, context.Cancellation), "a node may be reconnecting");
Assert.False(await Availability().AwaitsNodeAsync(job, parameters, context.Cancellation), "only a node of format 1 is online");
Assert.True(await Availability().AwaitsNodeAsync(job, parameters with { RequiredSettingsFormat = 1 }, context.Cancellation), "it renders a job of format 1");
Assert.True(await Availability().AwaitsNodeAsync(job, parameters with { RequiredSettingsFormat = 1, SettingsJson = null }, context.Cancellation),
"it renders a job of format 1");
Assert.False(await Availability().AwaitsNodeAsync(job, parameters with { RequiredSettingsFormat = 1 }, context.Cancellation),
"a job queued as format 1 whose settings route it to format 2 is never claimed by that node, so it does not wait for it");
// Queued as format 1 on the sequence's own settings, which then took a turn: the claim skips the older node, and so
// does the wait, so the server's own engine takes the job.
var plain = (await server.Database.Jobs.GetAsync((await JobApiTests.CreateAsync(editor, "render", sequence, H264Job(1920, 1080))).Id))!;
var plainParameters = ProcessingJobs.ReadRender(plain.ParametersJson).Parameters;
var waited = plain with { Created = DateTimeOffset.UtcNow - TimeSpan.FromSeconds(61) };
Assert.Equal(1, plainParameters.RequiredSettingsFormat);
Assert.True(await Availability().AwaitsNodeAsync(waited, plainParameters, context.Cancellation), "plain settings: the older node renders it");
var row = (await server.Database.Sequences.GetAsync(sequence))!;
await server.Database.Sequences.EditAsync(sequence, new SequenceEdit { SettingsJson = turned }, row.SettingsVersion);
Assert.False(await Availability().AwaitsNodeAsync(waited, plainParameters, context.Cancellation), "the turn needs a node of format 2");
using (var registered = await editor.PostAsJsonAsync("/api/v1/nodes/register", new RegisterNodeRequest("studio-pc", [new NodeEncoder("h264", "NVENC", true, false)],
4096, 4096, SettingsFormat: 2), ProtocolJson.Default.RegisterNodeRequest))
await registered.ExpectAsync(HttpStatusCode.OK);
@@ -335,7 +349,8 @@ public sealed class RenderNodeTests(TestContext context)
}
private static string H264Job(int width, int height) => JsonSerializer.Serialize(
new RenderJobParameters("H.264", """{"preset":{"isAuto":false,"manual":"4k-h264"}}""", "h264", width, height, UseProxies: false, null),
new RenderJobParameters("H.264", $$$"""{"preset":{"isAuto":false,"manual":"4k-h264"},"overrides":{"width":{{{width}}},"height":{{{height}}}}}""", "h264", width, height,
UseProxies: false, null),
ProtocolJson.Default.RenderJobParameters);
/// <summary>Render job parameters <paramref name="parametersJson"/> with <paramref name="settingsJson"/> embedded.</summary>