fix(phase4): close the owner review 1 phase 4 findings
Routing sizes render jobs from the resolved preset, and the node wait applies the same routing as the claim, so a re-routed job neither keeps a stale size nor waits for a node that will never take it. Settings an older server cannot read stay on this side for the remote editor, archive sync and workspace push, and the reason is shown where it applies. A turn on one side and a framing on the other merge as one conflict. Orientation and framing fixes: an out-of-range crop turns with the content it shows, the aspect text transposes exactly, the Rotation row counts turns as shown on screen, and Reset framing undoes the orientation press by press, so keyframes and aspect stay on their content. The advisor places the horizon in the view as shown. A look at zero strength is cleared and no longer reaches the motion vectors. Preview changes: the middle button pans, a press inside a box with no slack pans while zoomed, the selected box shows a ring, and screen readers hear when the crop value changes. Tooltips in en and it updated; stale translations of changed tooltips removed so they fall back to English. Test changes: the pinned hash is OS-independent, and the tautological encoder and warning assertions became real checks. Added a non-screen test of the Straighten slider binding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
4e21aaa548
commit
eeaddc2d14
83 files changed
+823
-270
No files matched your search
@@ -630,6 +630,17 @@ public sealed class RenderJobTests(TestContext context)
|
||||
var split = ProcessingJobs.Split(posted, 6000, 4000, portrait);
|
||||
Assert.SequenceEqual([(2160, 3840, 2), (1080, 1920, 2)], split.Select(p => (p.Width, p.Height, p.RequiredSettingsFormat)));
|
||||
Assert.Equal(split[0], ProcessingJobs.Routed(split[0], portrait, 6000, 4000), "a size already adapted stays");
|
||||
// The sequence's settings change between posting and routing: the size comes from the preset again, never from the
|
||||
// size a newer client already adapted (2160×2160 for 1:1 would adapt to 2160×1215 for 16:9).
|
||||
var square = new ProjectSettings { Camera = new CameraSettings { Aspect = new Auto<string>().WithManual("1:1") } };
|
||||
var wide = new ProjectSettings { Camera = new CameraSettings { Aspect = new Auto<string>().WithManual("16:9") } };
|
||||
var squared = Read(ProcessingJobs.Render(sequence, uhd, 6000, 4000, square));
|
||||
Assert.Equal((2160, 2160), (squared.Width, squared.Height));
|
||||
var rerouted = ProcessingJobs.Routed(squared, wide, 6000, 4000);
|
||||
Assert.Equal((3840, 2160), (rerouted.Width, rerouted.Height), "the preset's box adapted to the new aspect");
|
||||
var tall = Read(ProcessingJobs.Render(sequence, uhd, 6000, 4000, new ProjectSettings { Camera = new CameraSettings { Aspect = new Auto<string>().WithManual("4:5") } }));
|
||||
Assert.Equal((2160, 2700), (tall.Width, tall.Height));
|
||||
Assert.Equal((3840, 2160), (ProcessingJobs.Routed(tall, wide, 6000, 4000).Width, ProcessingJobs.Routed(tall, wide, 6000, 4000).Height));
|
||||
Assert.Equal((3840, 2160, 1), ProcessingJobs.Split(posted, 6000, 4000).Select(p => (p.Width, p.Height, p.RequiredSettingsFormat)).First(),
|
||||
"settings that cannot be read keep the size the job was posted with");
|
||||
// What the desktop asks of a server before a render: the highest format of the export and its batch.
|
||||
|
||||
Reference in new issue
Block a user