fix(phase4): close the owner review 1 phase 4 findings
Routing sizes render jobs from the resolved preset, and the node wait applies the same routing as the claim, so a re-routed job neither keeps a stale size nor waits for a node that will never take it. Settings an older server cannot read stay on this side for the remote editor, archive sync and workspace push, and the reason is shown where it applies. A turn on one side and a framing on the other merge as one conflict. Orientation and framing fixes: an out-of-range crop turns with the content it shows, the aspect text transposes exactly, the Rotation row counts turns as shown on screen, and Reset framing undoes the orientation press by press, so keyframes and aspect stay on their content. The advisor places the horizon in the view as shown. A look at zero strength is cleared and no longer reaches the motion vectors. Preview changes: the middle button pans, a press inside a box with no slack pans while zoomed, the selected box shows a ring, and screen readers hear when the crop value changes. Tooltips in en and it updated; stale translations of changed tooltips removed so they fall back to English. Test changes: the pinned hash is OS-independent, and the tautological encoder and warning assertions became real checks. Added a non-screen test of the Straighten slider binding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
4e21aaa548
commit
eeaddc2d14
83 files changed
+823
-270
No files matched your search
@@ -286,6 +286,22 @@ public sealed class ServerHomeTests(TestContext context)
|
||||
await menu.SyncAsync();
|
||||
Assert.Equal(before, host.Store.Find(projectId)!.ReadBundle().Workspace!.Base!.VersionId, "nothing was sent");
|
||||
|
||||
// Saved as a version with the turn, then turned back: the working state is of the base format, but the version
|
||||
// waiting to be sent is not. Sync stays disabled, and the workspace itself never sends it (Send first, Delete,
|
||||
// Resolve reach the host without the menu's gate), saying why.
|
||||
await host.SaveVersionAsync(projectId, null, bed.Ct);
|
||||
Assert.True(session.Edit(p => p with { Camera = p.Camera with { Rotate = 0 } }));
|
||||
Assert.True(await session.FlushAsync());
|
||||
await menu.RefreshAsync();
|
||||
Assert.Equal(ProjectSettings.BaseVersion, session.Project.WrittenFormat);
|
||||
Assert.Equal(2, menu.Status!.UnpushedFormat);
|
||||
Assert.Equal(Loc.L("Tooltips.Server.NeedsNewerServer"), menu.PushBlockedReason);
|
||||
Assert.False(menu.SyncCommand.CanExecute(null));
|
||||
var refused = await Assert.ThrowsAsync<WorkspaceSyncException>(() => host.SyncAsync(projectId, bed.Ct));
|
||||
Assert.True(refused.HomeReadsOlderFormat);
|
||||
Assert.Equal(Loc.L("Tooltips.Server.NeedsNewerServer"), WorkspaceText.Failure(refused, server: true));
|
||||
Assert.Equal(before, host.Store.Find(projectId)!.ReadBundle().Workspace!.Base!.VersionId, "nothing was sent");
|
||||
|
||||
// A server of this format takes it.
|
||||
server.SettingsFormat = ProjectSettings.CurrentVersion;
|
||||
Assert.Null(menu.PushBlockedReason);
|
||||
|
||||
Reference in new issue
Block a user