fix(phase4): close the owner review 1 phase 4 findings

Routing sizes render jobs from the resolved preset, and the node wait
applies the same routing as the claim, so a re-routed job neither keeps a
stale size nor waits for a node that will never take it. Settings an older
server cannot read stay on this side for the remote editor, archive sync
and workspace push, and the reason is shown where it applies. A turn on
one side and a framing on the other merge as one conflict.

Orientation and framing fixes: an out-of-range crop turns with the content
it shows, the aspect text transposes exactly, the Rotation row counts
turns as shown on screen, and Reset framing undoes the orientation press
by press, so keyframes and aspect stay on their content. The advisor
places the horizon in the view as shown. A look at zero strength is
cleared and no longer reaches the motion vectors.

Preview changes: the middle button pans, a press inside a box with no
slack pans while zoomed, the selected box shows a ring, and screen readers
hear when the crop value changes. Tooltips in en and it updated; stale
translations of changed tooltips removed so they fall back to English.

Test changes: the pinned hash is OS-independent, and the tautological
encoder and warning assertions became real checks. Added a non-screen
test of the Straighten slider binding.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Alby96andClaude Opus 5.5 committed 2026-11-04 21:40:07 +01:00
1 parent 4e21aaa548
commit eeaddc2d14
83 files changed
+823 -270

No files matched your search

@@ -65,6 +65,30 @@ public sealed class RemoteSequenceSourceTests(TestContext context)
}
}
/// <summary>
/// Owner review 1, phase 4: an older server (format 1) stores whatever settings it is sent and then fails every render of
/// them, so a turn or a look is never sent to it; an edit of the base format still is.
/// </summary>
[Test]
public async Task SettingsAnOlderServerCannotReadAreNotSent()
{
var (source, api, _) = Open(serverFormat: ProjectSettings.BaseVersion);
await using (source)
{
var content = await source.LoadAsync(context.Cancellation);
var turned = content.Project with { Camera = content.Project.Camera with { Rotate = 90 } };
var refused = await Assert.ThrowsAsync<EditorException>(() => source.SaveProjectAsync(turned, content.Project, context.Cancellation));
Assert.Equal(Loc.L("Tooltips.Server.NeedsNewerServer"), refused.Message);
var look = content.Project with { Look = new LookSettings { Filter = "sepia" } };
await Assert.ThrowsAsync<EditorException>(() => source.SaveProjectAsync(look, content.Project, context.Cancellation));
Assert.Empty(api.Edits);
var brighter = content.Project with { Exposure = content.Project.Exposure with { ExposureOffsetEv = 0.5 } };
await source.SaveProjectAsync(brighter, content.Project, context.Cancellation);
Assert.Count(1, api.Edits);
}
}
[Test]
public async Task SavesSendTheVersionTheyWereMadeFrom()
{
@@ -574,12 +598,12 @@ public sealed class RemoteSequenceSourceTests(TestContext context)
}
private (RemoteSequenceSource Source, FakeRemoteSequenceApi Api, RemoteSequence Remote) Open(int frames = 6, int cached = int.MaxValue,
bool readOnly = false) =>
Open(EditorFixture.Sequence(frames), cached, readOnly);
bool readOnly = false, int serverFormat = ProjectSettings.CurrentVersion) =>
Open(EditorFixture.Sequence(frames), cached, readOnly, serverFormat);
/// <summary>A server sequence whose first <paramref name="cached"/> proxies are on this PC (synthetic JPEGs).</summary>
private (RemoteSequenceSource Source, FakeRemoteSequenceApi Api, RemoteSequence Remote) Open(SyntheticSequence sunset, int cached = int.MaxValue,
bool readOnly = false)
bool readOnly = false, int serverFormat = ProjectSettings.CurrentVersion)
{
var folder = context.CreateTempDirectory("proxies");
var sequence = new Sequence
@@ -603,7 +627,7 @@ public sealed class RemoteSequenceSourceTests(TestContext context)
}
var remote = new RemoteSequence(Server, sequence, frames, files);
var api = new FakeRemoteSequenceApi(sequence, [.. frames.Select(f => f.Id)]) { SettingsJson = new ProjectSettings().ToJson() };
return (new RemoteSequenceSource(remote, api, DecoderFactory.CreateClient(null), readOnly), api, remote);
return (new RemoteSequenceSource(remote, api, DecoderFactory.CreateClient(null), readOnly, serverFormat), api, remote);
}
/// <summary>Someone on the server sets the exposure offset to 0.3 and moves the framing.</summary>