From ee1ba9a4adb83aec22a60cee90eedbbccbaf8fd3 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 2 Oct 2026 10:26:21 +0000 Subject: [PATCH] test(packaging): cover malformed manifests with a valid hash Invalid JSON, missing or null required fields, an unknown format version, an unsafe product name and an empty component list are all reported as corrupt. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC --- .../Titano.Core.Tests/Packaging/PackagingFixture.cs | 6 ++++-- .../Packaging/PayloadIntegrityTests.cs | 13 +++++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/tests/Titano.Core.Tests/Packaging/PackagingFixture.cs b/tests/Titano.Core.Tests/Packaging/PackagingFixture.cs index 94109aee..704841eb 100644 --- a/tests/Titano.Core.Tests/Packaging/PackagingFixture.cs +++ b/tests/Titano.Core.Tests/Packaging/PackagingFixture.cs @@ -109,10 +109,12 @@ internal sealed class PackagingFixture(TestContext context) BinaryPrimitives.ReadInt32LittleEndian(image.AsSpan(0x3C)) + 4 + 20 + 112 + 4 * 8; /// Assembles an installer by hand from a manifest and data region, bypassing the writer's checks. - public string Craft(PayloadManifest manifest, byte[] data, string name = "crafted.exe") + public string Craft(PayloadManifest manifest, byte[] data, string name = "crafted.exe") => Craft(manifest.ToJsonBytes(), data, name); + + /// Same with raw manifest bytes, which need not be valid JSON; the footer hash always matches them. + public string Craft(byte[] json, byte[] data, string name = "crafted.exe") { var stub = CraftStub; - var json = manifest.ToJsonBytes(); using var ms = new MemoryStream(); ms.Write(stub); ms.Write(json); diff --git a/tests/Titano.Core.Tests/Packaging/PayloadIntegrityTests.cs b/tests/Titano.Core.Tests/Packaging/PayloadIntegrityTests.cs index a9ba9231..512782dc 100644 --- a/tests/Titano.Core.Tests/Packaging/PayloadIntegrityTests.cs +++ b/tests/Titano.Core.Tests/Packaging/PayloadIntegrityTests.cs @@ -142,6 +142,19 @@ public sealed class PayloadIntegrityTests(TestContext context) Assert.Equal(PayloadError.UnsafePath, Assert.Throws(() => PayloadReader.Open(installer)).Error); } + [Theory] + [Case("not json at all")] + [Case("{\"formatVersion\":1,\"version\":\"1.0\"}")] + [Case("{\"formatVersion\":1,\"product\":null,\"version\":\"1.0\"}")] + [Case("{\"formatVersion\":2,\"product\":\"Titano\",\"version\":\"1.0\",\"components\":[{\"id\":\"Titano\",\"displayName\":\"Titano\"}]}")] + [Case("{\"formatVersion\":1,\"product\":\"..\",\"version\":\"1.0\",\"components\":[{\"id\":\"Titano\",\"displayName\":\"Titano\"}]}")] + [Case("{\"formatVersion\":1,\"product\":\"Titano\",\"version\":\"1.0\",\"components\":[]}")] + public void MalformedManifestWithMatchingHashIsCorrupt(string json) + { + var installer = _fx.Craft(System.Text.Encoding.UTF8.GetBytes(json), []); + Assert.Equal(PayloadError.Corrupt, Assert.Throws(() => PayloadReader.Open(installer)).Error); + } + [Test] public void DeclaredSizeBeyondTheDeflateLimitIsRejectedUpFront() {