test(decode): wait for the read-ahead before the demand loads that must meet it
CI / Build and test (pull_request) Successful in 10m39s
CI / Windows tests and installer (pull_request) Skipped
CI / YAML check (pull_request) Successful in 13s
CI / PostgreSQL 16 integration (pull_request) Successful in 9m55s
CI / PostgreSQL 17 integration (pull_request) Successful in 10m33s
CI / Docker image (pull_request) Successful in 53s

ADemandLoadWaitsForTheReadAheadOfADevelopingWindow counted on the
read-ahead starting on the thread pool before the next frames were
asked for. On a busy runner it had not begun, only the four demanded
frames were decoded, and the rc.8 release and main's PostgreSQL 16 job
failed on 'Decodes > 4'. The test now waits, within the CI time budget,
until the read-ahead develops a frame of its own; the one-development
limit it checks is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Alby96andClaude Opus 5.5 committed 2026-11-04 10:12:43 +01:00
1 parent 9b24cf74fc
commit e7c59a026b
1 file changed
+11 -1
@@ -118,7 +118,17 @@ public sealed class DecodeParallelismTests
await using (var source = new SequenceFrameSource(frames, frames.LightFrames(), new ImageDecoder([decoder]), window))
{
Assert.Equal(1, source.DevelopingLimit(1920, DecodePurpose.Render));
foreach (var index in new[] { 0, 2, 4, 6 })
using (await source.GetFrameAsync(0, 1920, DecodePurpose.Render, CancellationToken.None)) { }
// The read-ahead starts on the thread pool; on a busy runner it may not have begun before the next frames are
// asked for, and then nothing would race. Wait until it develops a frame of its own, so the demand loads below
// always meet a developing read-ahead.
var started = DateTime.UtcNow;
while (decoder.Decodes < 2)
{
Assert.True(DateTime.UtcNow - started < TimeSpan.FromSeconds(TestTiming.Budget(10)), "the read-ahead never started");
await Task.Delay(5);
}
foreach (var index in new[] { 2, 4, 6 })
using (await source.GetFrameAsync(index, 1920, DecodePurpose.Render, CancellationToken.None)) { }
}
Assert.Equal(1, decoder.Peak);