fix: logging never fails a job, one backup retention, first copy after the upgrade
Owner review 2, phase 2 review findings (scheduler core). - Log.Write caught only IOException. Microsoft.Extensions.Logging wraps provider failures in an AggregateException, so a log line that could not be written (in tests: the process-wide sink of a stopped server whose log folder was gone) escaped JobEngine.RunAsync's catch before the failure was stored: the job stayed running and the worker faulted. This was the cause of the intermittent JobApiTests/ArchiveModuleTests failures. Log.Write now drops any non-fatal sink failure, TeeLogSink keeps a line from the other sinks, FileLogSink drops a line it cannot write and reopens the file at the next one, and LoggerSink drops what the providers throw. The scheduler's loop relies on the same guarantee. - The daily backup loop (RunDailyAsync, IsDue, Interval, CheckInterval) had no caller since the index-backup schedule replaced it; it is removed and the DatabaseBackups summary describes the schedule. - The first copy after the upgrade no longer waits a day (or for 03:00): SystemSchedule.LastDone seeds a new row due at once when its work was last done a period or more before, and both hosts pass the newest copy in the backups folder for index-backup. - Back up now (Settings and Archive), the copy kept before a restore and a backup job that keeps fewer prune to the largest Copies kept of the backup schedules (DatabaseBackups.KeptAsync), not a fixed three. The four tooltips that promised three daily copies are reworded (en, it) and their stale translations deleted. - New tests for the scheduler loop itself: a tick, Wake, a pass that threw, and dispose during a pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit c5ad0c4c3f636129afe5dd1ce039185516da5621)
This commit is contained in:
1 parent
422f33d5f3
commit
e384564784
59 files changed
+668
-264
No files matched your search
@@ -74,6 +74,32 @@ public sealed class ArchiveModuleTests(TestContext context)
|
||||
Assert.Equal(server.Database.SchemaVersion, summary.SchemaVersion);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The first start after the upgrade: the daily loop copied at start once the newest copy was a day old, so the index
|
||||
/// backup schedule is seeded due then (copied in the first pass) instead of waiting for 03:00.
|
||||
/// </summary>
|
||||
[Test]
|
||||
public async Task TheFirstStartCopiesTheIndexWhenTheNewestCopyIsADayOld()
|
||||
{
|
||||
string? backups = null;
|
||||
await using var server = await TestServer.StartAsync(context, options =>
|
||||
{
|
||||
backups = Path.Combine(options.DataPath, Chronos.Data.DatabaseBackups.DirectoryName);
|
||||
Directory.CreateDirectory(backups);
|
||||
File.WriteAllText(Path.Combine(backups, $"chronos-{DateTime.UtcNow.AddDays(-7):yyyyMMdd-HHmmss}-000.db"), "copy");
|
||||
}, ArchiveModule.Register);
|
||||
|
||||
var schedule = Assert.NotNull(await server.Database.Schedules.GetBySystemKeyAsync(ServerScheduleHost.IndexBackup, context.Cancellation));
|
||||
Assert.Equal("queued", schedule.LastOutcome);
|
||||
var path = Assert.NotNull(((Chronos.Data.Sqlite.SqliteDatabase)server.Database.Database).Path);
|
||||
var until = DateTime.UtcNow + TimeSpan.FromSeconds(TestTiming.Budget(30));
|
||||
while (Chronos.Data.DatabaseBackups.List(backups!, path).Count < 2)
|
||||
{
|
||||
Assert.True(DateTime.UtcNow < until, "no copy at the first start");
|
||||
await Task.Delay(50);
|
||||
}
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task PhotosAlreadyInTheArchiveAndAddedLaterAreIndexedByTheScanScheduleWithThumbnailsAndProxies()
|
||||
{
|
||||
|
||||
Reference in new issue
Block a user