docs: record the kit follow-up and test decisions; category charts in DESIGN §5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
This commit is contained in:
Claude committed 2026-10-06 22:25:20 +00:00
1 parent 01f301f970
commit c5c4f9adfe
2 files changed
+25 -3

No files matched your search

+23 -3
View File
@@ -71,7 +71,7 @@ One line per decision: date · decision · alternative · reason.
| 2026-10-02 | Job claim: `UPDATE … WHERE id = (SELECT … FOR UPDATE SKIP LOCKED) RETURNING` on PG; immediate transaction on SQLite. | Advisory locks | Exclusive under concurrency, as specified. |
| 2026-10-02 | One `JobEngine` in Titano.Data runs every long operation for both the client and the server: handlers per `JobKind`, progress persisted at most every 5 s, a failed persist (job no longer running) stops the handler, a shutdown leaves jobs running so the next start requeues them from their checkpoint. | Per-feature background loops | One queue, one cancel/pause/resume path and one crash-recovery rule everywhere. |
| 2026-10-02 | Job throughput is a moving average over windows of at least 2 s. | Average since start | ETA follows speed changes (cache warm-up, network) without jitter. |
| 2026-10-02 | Visual controls (card grid, filmstrip, charts, preview, curve editor) keep their layout and math in WPF-free classes; colours are theme brush keys re-resolved on theme switch; charts, filmstrip and preview never mirror in RTL. | Math inside controls / brush properties | Testable on Linux; view models hold no brushes; time axes and images must not flip. |
| 2026-10-02 | Visual controls (card grid, filmstrip, charts, preview, curve editor) keep their layout and math in WPF-free classes; colours are theme brush keys re-resolved on theme switch; filmstrip, preview and time-axis charts never mirror in RTL (category charts lay out from the reading side since 2026-10-06, inside an element that stays left to right). | Math inside controls / brush properties | Testable on Linux; view models hold no brushes; time axes and images must not flip. |
| 2026-10-02 | `VirtualizingWrapPanel` does its own keyboard navigation and recycling; the focused container is kept alive. | ListBox navigation | Direct targets, wrapping across rows; focus survives scrolling. |
| 2026-10-02 | Library card slot 236 × 208 with a 16:9 thumbnail. | Mockup's 150 px thumbnail | DESIGN §4 specifies 16:9. |
| 2026-10-02 | Uploader sessions: key = 8 hex chars of the source folder's SHA-256 + first-frame time; leading test shots (first group < 8 frames) join the next session; watch-folder files always use automatic sessions. | Group by time only | Simultaneous cameras stay apart; unattended files never land in a sequence chosen for a manual drop. |
@@ -163,8 +163,8 @@ One line per decision: date · decision · alternative · reason.
| 2026-10-06 | The nav rail's RadioButtons keep GroupName 'Rail' (the two lists live in separate item templates) but bind IsChecked one way. | Group by panel as the integration decision says | Panel grouping cannot span two ItemsControls. A one-way binding keeps a shared GroupName from writing another window's selection back into the shell, which is the case the integration rule exists for. |
| 2026-10-06 | Common.CurveReadout is invariant ('{0} → {1}'). | Translatable so RTL languages could use '←' | The curve readout is drawn in a left-to-right island (numbers on an LTR axis), where '←' would point the wrong way. |
| 2026-10-06 | Heatmap month labels: initials only when all 12 abbreviated names start with a cased letter and contain no digit, otherwise culture-formatted month numbers 1-12 | A localized resource list Archive.Chart.MonthInitials, or hard-coded per-culture overrides | Correct for every shipped and future culture with no translation work. It also avoids non-Gregorian month names (fa uses Persian months) and needs no fallback for languages not yet translated. |
| 2026-10-06 | Keep IsEnabled=False on the content behind a dialog and give ListBoxes a local template that does not repaint when disabled | IsHitTestVisible=False plus keyboard containment instead of disabling | Screen readers and access keys still treat the content as disabled. Rows and buttons dim themselves, so the list does not dim twice. |
| 2026-10-06 | Fix the chart-label contrast and invisible future months through token aliases scoped to the chart grid and the heatmap (Brush.TextFaint -> Color.TextMuted, Brush.Card -> Color.Stroke) | Edit BarChart/HeatmapStrip (owned by the shared group) or only report the defect | Smallest local equivalent that fixes a major contrast defect now, with no new colours. It follows theme switches through DynamicResource and becomes inert once the kit is fixed. |
| 2026-10-06 | Keep IsEnabled=False on the content behind a dialog and give ListBoxes a template that does not repaint when disabled (the kit's Template.ListBox since the follow-up) | IsHitTestVisible=False plus keyboard containment instead of disabling | Screen readers and access keys still treat the content as disabled. Rows and buttons dim themselves, so the list does not dim twice. |
| 2026-10-06 | (Superseded by the kit follow-up: the charts draw labels in TextMuted and empty cells in Stroke; the aliases are gone.) Fix the chart-label contrast and invisible future months through token aliases scoped to the chart grid and the heatmap (Brush.TextFaint -> Color.TextMuted, Brush.Card -> Color.Stroke) | Edit BarChart/HeatmapStrip (owned by the shared group) or only report the defect | Smallest local equivalent that fixes a major contrast defect now, with no new colours. It follows theme switches through DynamicResource and becomes inert once the kit is fixed. |
| 2026-10-06 | Index health duplicates line: after a duplicates search it shows the groups found (warning with a Mark copies fix); before any search it shows the flagged-copy count ('No copies flagged' / 'n duplicate frames' with Show) | Only reword the line to flagged copies, or hide it until a search has run | The line can never be a green tick while the Duplicates card lists groups, and it keeps the flagged-copy information that already existed. |
| 2026-10-06 | All orphan kinds use the Warning glyph (▲ amber) | Add a neutral/info StatusKind in the shared kit | Every orphan line is an actionable issue with a fix button, and Warning is readable in both themes without a kit change. |
| 2026-10-06 | Archive failures become a toast with the action's title, one localized cause sentence from ArchiveFailures.Cause and a Retry action that re-runs the same command; relink Retry re-opens the folder picker | Open logs as in Shell.ReportError, or retry with the same folder | BRIEF 0.2 rule 6 asks for one sentence plus one action. Retry fits these I/O failures. Re-picking the folder covers both 'drive is back' and 'wrong folder'. |
@@ -217,3 +217,23 @@ One line per decision: date · decision · alternative · reason.
| 2026-10-06 | Empty-state buttons: Clear search; Show all (filtered jobs); Scan (empty jobs, empty charts and format table); a Users link (no render nodes); Refresh (activity, audit) | Leave the sentences without a button | BRIEF §0.2.6 asks for one sentence plus one button; each one is the most useful next step |
| 2026-10-06 | Progress bars mirror in RTL (they fill from the reading start); charts keep a left-to-right axis; paths, templates, logs, IPs and fingerprints stay left to right | Mirror everything, or nothing | Follows the brief's RTL rules: time-axis charts and paths do not mirror, progress follows the reading direction |
| 2026-10-06 | The side panel width is clamp(300px, 26vw, 340px) | A fixed 340 px (mockup) or 320 px (DESIGN) | It keeps the mockup's 340 px at 1440 and gives the table about 28 px more at 1200 |
| 2026-10-06 | Mirror category charts by placing their contents with FromStart inside an element that stays FlowDirection=LeftToRight. This applies to horizontal BarChart rows (labels, bars, values, grid ticks) and StackedBar segments. | Let BarChart and StackedBar inherit RightToLeft so WPF mirrors the whole element. | With the element mirrored, text drawn by DrawText would come out mirrored, and every number label would need a counter-transform. FromStart is already how legends are placed, and the Arabic test's 'every DrawingElement is LTR' rule still holds. |
| 2026-10-06 | Vertical BarChart, HeatmapStrip, SeriesChart, TimelineBands, Filmstrip and CurveEditor stay left to right in RTL. | Mirror every chart that has categories. | The brief rule is that time axes stay LTR. Vertical bars and heatmaps run along days, years or months; horizontal bars and stacked shares have no time axis. |
| 2026-10-06 | Keyboard activation for BarChart, StackedBar and HeatmapStrip exists only while a handler is attached to the chart. Arrows move the item (heatmap in rows and columns, stacked bar by visual side), Home and End jump, Enter and Space activate. The item gets a 2 px Accent outline, a readout and the automation ItemStatus, and the element's system focus rectangle is off. | Gate only the hand cursor and leave the charts mouse-only. | A chart that does something on click but cannot be used from the keyboard fails WCAG 2.1.1. A chart nobody activates stays out of the tab order, as before. |
| 2026-10-06 | Detect handlers by recording the delegates added and removed through the CLR event accessors (TrackActivation). | Read the routed-event handler store by reflection, or add a public IsInteractive property. | The handler store is internal. Accessors cover XAML attributes and += in code. An extra property would duplicate what attaching the handler already says. |
| 2026-10-06 | Move the shared hover-readout, click, cursor and keyboard handling for item charts into DrawingElement as virtual item members (ItemCount, ItemAt, ItemBounds, ItemText, Navigate, Activate). | Copy the cursor and keyboard code into each of the three charts. | The three charts had the same mouse code; one implementation keeps cursor and keyboard behaviour consistent. Visuals without items (filmstrip, curve editor, series chart) are unaffected because the base does nothing when ItemCount is 0. |
| 2026-10-06 | The ListBox template is a keyed ControlTemplate (Template.ListBox). ListView is BasedOn a new template-less ListBox.Base, and the card grid style takes the template through DynamicResource. | Put the Template setter straight into the implicit ListBox style, which ListView was BasedOn. | ListView would then inherit a template without the GridView header row. Visuals.xaml cannot StaticResource into Controls.xaml. |
| 2026-10-06 | Empty heatmap cells use Brush.Stroke. | A new no-data token. | Stroke differs from the Card and Surface fills in both themes, the Archive workaround already used it, and DESIGN forbids new colours. |
| 2026-10-06 | SeriesChart tick labels and TimelineBands captions also move to TextMuted. | Change only BarChart and HeatmapStrip, as the item lists. | They are the same 11 px data labels, with the same AA failure (2.7:1 in light). Editor.html shows chart text in the muted colour. |
| 2026-10-06 | ShellViewModel.Notify takes an optional isError, and the Uploader's private ShowToast does the same. | A separate NotifyFailure method. | Some outcomes decide the flag at run time (format Failed versus Formatted, eject Ejected versus InUse or Failed, server job Failed versus Cancelled). One parameter handles those without branching at the call sites. |
| 2026-10-06 | Count as failures: refusals that leave the user's action undone (cache folder not owned, card changed before format, 'Choose a sequence first', conflict changed). Keep as notices: 'Nothing found', a cancelled server job and the editor's 'frames changed, read-only' toast. | Mark only exceptions as errors. | An assertive announcement fits anything the user asked for that did not happen. Empty results and cancellations the user asked for are not failures. |
| 2026-10-06 | Editor.Optimise.ChangeRtl copies the existing TimeRtl/RenderRtl pattern exactly ('{0}: {1} ← {2}', no bidi marks). | Put RLM marks around the arrow so values made of Latin letters keep their order. | The task fixed the value and the pattern. The Latin-run caveat applies to all three RTL keys and is reported as one remaining issue. |
| 2026-10-06 | TextBox.Number goes back to the default Padding. Import TextBox.Small (4,0) and the Import session-title box (8,0 at 26 px) stay compact. | Reset every override to the default. | The Number override (8,0) existed only to undo the old double padding. The other two are deliberately compact: four digits fit in 42 px, and 8 px plus the 2 px text margin lines up with the 26 px row buttons. |
| 2026-10-06 | Icon-only accessible names longer than three words (rail toggle, archive year expander) get new two-word keys. The sentence stays as the tooltip. | Keep binding the name to the tooltip. | The item asks for names of at most 3 words from a resource; the tooltip carries the explanation. |
| 2026-10-06 | The culture-switching optimise-line test lives in EditorSmokeTests ([Serial]), not EditorTextTests. | Keep it next to the other EditorText tests. | Test classes run in parallel, and switching Loc culture would race with English assertions in other classes. |
| 2026-10-06 | Fix the tests, not the sync engine: wait for the comparison an event starts to finish, signalled by SyncService.Changed, and assert on that settled state | Poll with a deadline until the final state holds (settings arrived AND error cleared), or make the engine's two writes atomic | The engine is correct: Changed is its documented end-of-comparison contract, and the Server screen reloads on it. Waiting for Changed is deterministic and keeps every assertion. A regression fails immediately, not after a 30 s timeout. It also checks that the state is consistent when Changed fires. Atomic writes are impossible across the index and project.json. |
| 2026-10-06 | KeepingProxiesOffline waits for the agent's own background download job to reach Done | Poll the row status until ProxiesOnly | Done is the engine's last write after the handler stored the cache and the link. Polling the status would turn the assertion into the wait condition. |
| 2026-10-06 | FailedComparisonsAreRetried waits for the agent's Changed raised with a non-null Snapshot (TaskCompletionSource with RunContinuationsAsynchronously) | Reorder the agent's writes so LastError is cleared before Snapshot is stored | Changed is the agent's contract, and SyncHost reads both values on it. Continuations must run off the agent loop, otherwise the test would end up disposing the agent from inside its own loop. |
| 2026-10-06 | Log download: reuse FileResponses.Serve (fixed-length, range-capable FileSlice) with the length listed at request time | Copy the log to a temp file first, or stream to EOF without a Content-Length | It reuses an existing facility, keeps Range resume working, has no extra I/O, and the response stays self-consistent while the logger keeps appending. |
| 2026-10-06 | The regression test fills its server's log with about 2 MB up front, then logs one line about every 1 ms through the server's FileLoggerProvider only, on a LongRunning thread | A tight logging loop through ILoggerFactory (my first two versions) | The engine log sink is process-wide, so a console or file-lock flood stalled another test's job engine. The throttled version still reproduces the bug in 10 of 10 runs against the old endpoint. |
| 2026-10-06 | Heartbeat test: count the claims the server answered with a DelegatingHandler, then wait for a later beat with a 30 s deadline | Keep the sleeps and widen the 400 ms window | It removes the timing assumption both ways (a false failure on a slow runner, and a false pass on the claim's own touch). It also proves no claim moved the beat. |
+2
View File
@@ -90,6 +90,8 @@ left/right, external link, start-aligned lines); `ui:Bidi.IsDirectional` overrid
as "next", a chevron on a left-to-right time axis). Every other glyph (clocks, media controls, the ▶ rendered
status) and the brand mark keep their drawn orientation. Photos, previews, charts, numbers, paths and
templates are left-to-right islands (`FlowDirection="LeftToRight"` on the smallest element holding them).
Category charts without a time axis (horizontal bars, stacked bars) still lay out from the reading side inside
their island: labels on the reading side, bars growing away from it; time axes and month grids never flip.
## 6. App icon (`branding/`)