Merge branch 'review2-p1-fix-import' into claude/owner-review-2-p1
This commit is contained in:
commit
b8fa04dc28
13 files changed
+181
-25
No files matched your search
+4
-2
@@ -815,8 +815,10 @@ player smoke test on Windows CI.
|
||||
per file format: camera bodies and pauses are ignored, formats are not (RAW+JPEG of the
|
||||
same shots stays two sequences, so no frame is doubled). Sessions, gap and minimum are
|
||||
then disabled, their tooltips saying why. The title defaults to the folder's name (a
|
||||
typed title wins; it also fills `{title}`). Each plan row shows the camera, or "n
|
||||
cameras", and the format; Split in Show plan cuts a part off, Merge joins it back. A folder
|
||||
typed title wins; it also fills `{title}`); a repeated import gives the folder's name
|
||||
only to a sequence without a title, so a rename made since survives. Each plan row shows
|
||||
the camera, or "n cameras", and the format, and both dates when its photos span several
|
||||
days; Split in Show plan cuts a part off, Merge joins it back. A folder
|
||||
starts on Sessions every time (folders have no profile); cards, drives and the admin
|
||||
panel have no Group choice.
|
||||
- Copy with hash while streaming; verify by re-reading destination; only then delete or
|
||||
|
||||
+3
-2
@@ -8,8 +8,8 @@ commits follow Conventional Commits (release notes are generated from them by `C
|
||||
### Added
|
||||
- Import › Folder…: **Group › Whole folder** imports the picked folder, with its subfolders when Subfolders is on, as
|
||||
one sequence per file format, whatever the cameras and pauses (RAW+JPEG stays two sequences). The title defaults to
|
||||
the folder's name, and an interrupted or repeated import of the folder continues the same sequence. Desktop only
|
||||
(owner review 2, R9).
|
||||
the folder's name, and an interrupted or repeated import of the folder continues the same sequence without renaming
|
||||
it. Desktop only (owner review 2, R9).
|
||||
- Server: `CHRONOS_SPACE_PATH` (`SpacePath` in `server.json`) makes the admin panel show the free space of that
|
||||
folder's volume instead of the archive's. The Unraid template maps the share's array view (`/mnt/user0/Timelapse`)
|
||||
read-only to `/space` (*Array view*), so the dashboard shows the array's free space, not the cache's (owner review 2,
|
||||
@@ -38,6 +38,7 @@ commits follow Conventional Commits (release notes are generated from them by `C
|
||||
(owner review 2, R4).
|
||||
|
||||
### Fixed
|
||||
- Import: a session that ends on another day shows both dates in its plan row and in Show plan, not only the first.
|
||||
- Server: completing an upload, a render upload or a render node's result now checks the archive volume's free space
|
||||
first. A full volume answers 507 `insufficient_storage` and the upload stays resumable, instead of the copy into
|
||||
staging failing (owner review 2, R2).
|
||||
|
||||
+1
-1
@@ -439,5 +439,5 @@ One line per decision: date · decision · alternative · reason.
|
||||
| 2026-10-26 | Admin panel menu in two groups: Dashboard, Users, Archive, Jobs and Logs from the top; Settings docked at the sidebar's foot above the account, or at the end of the top bar on narrow screens; on a short window only the pages above scroll, so Settings and the account stay in view. `pages/about.js` is gone: About is the last, read-only group of Settings (version, API version, database, uptime counting on from when it was read; the last two fill in when the admin dashboard answers, so the form never waits for its archive statistics, and they stay off the anonymous `/server/info`), without the server name and certificate fingerprint rows that the Server and Network groups already show. `#/about` opens Settings on that group (focus on its heading) and rewrites the address to `#/settings`. (Owner review 2, R4, R5.) | Keep About as a page; an About dialog from the account box; repeat the name and fingerprint rows in About | One sidebar entry less, as the owner asked. Repeated rows on one page are noise, and the name row was stale after a save. Old bookmarks keep working. |
|
||||
| 2026-10-26 | The Settings icon is an 8-tooth gear with a centre hole (outer radius 6.5, valleys on 4.6, teeth 0.6/0.85 half-width at tip/base, hole 1.7), drawn by `gear()` in `branding/ui-icons/icons.py`. The script now also writes the admin panel's `icons.js` (through a name map; the unused `about` icon dropped) and writes every file as UTF-8 with LF on every OS. (Owner review 2, R4.) | 6 teeth (crisper at 16 px but less familiar); wider hollow teeth (they merge at 16 px with 1.5 px strokes); radial stubs on a ring (close to the old sun); keep `icons.js` by hand | 8 narrow teeth close up into solid knobs at 16 px with open gaps, read as the usual settings gear at 20–32 px and stay distinct from Sun. One generator keeps the desktop and web paths identical. On Windows the script wrote `Icons.xaml` in the ANSI code page, garbling its header. |
|
||||
| 2026-10-26 | Desktop About becomes the last Settings page (`SettingsPage.About`); `SectionKey.About` and `AboutView` are gone and the rail keeps Settings alone at the bottom. `AboutViewModel` (now `Chronos.App.About`) stays a view model owned by the shell (`Shell.About`), not a section, so the Updates page's bindings and the update check on start are unchanged. The page shows identity only (version, build, runtime, system, licence, third-party notice, translation notice outside English) and has no Reset section; the Releases link moved to Updates › Latest version; About's own diagnostics bundle and Open data folder buttons are removed (Advanced has both). (Owner review 2, R5.) | Move `UpdateFlow` into `SettingsViewModel`; embed the old AboutView inside Settings; repeat the data folder, diagnostics and update rows on About | Smallest change that keeps every `Shell.About` binding and the update check on start; one place per action avoids duplicates inside Settings, and saving space is what the owner asked for. Nothing navigated to the About section, so no link needed redirecting. |
|
||||
| 2026-10-26 | Import › Folder… *Whole folder* (`ImportGrouping.WholeFolder`) makes one sequence per file format: camera bodies and pauses are ignored, formats are not; only the user's splits break it (the session splitter runs with no gap and a minimum of 1). The title defaults to the folder's name and fills `{title}`; a typed title wins. The plan row shows "Canon EOS R5 · CR3" or "2 cameras · JPEG", and a split part merges back into the part before it of the same format. Switching the grouping clears the user's splits and merges. (Owner review 2, R9.) | One sequence holding every file; one sequence per camera body | A folder shot RAW+JPEG would otherwise hold every instant twice, doubling the time-lapse; formats also decode and render differently. Bodies are ignored because the owner asked for the folder's sequence "in its entirety". |
|
||||
| 2026-10-26 | Import › Folder… *Whole folder* (`ImportGrouping.WholeFolder`) makes one sequence per file format: camera bodies and pauses are ignored, formats are not; only the user's splits break it (the session splitter runs with no gap and a minimum of 1). The title defaults to the folder's name and fills `{title}`; a typed title wins. A repeated import gives the folder's name only to a sequence without a title: the archive applies a title only when it creates the sequence, and a server import reads the sequence first and names it only when it has none, so a rename made on the server survives (a typed title is still set). The plan row shows "Canon EOS R5 · CR3" or "2 cameras · JPEG", with both dates when the photos span several days, and a split part merges back into the part before it of the same format. Switching the grouping clears the user's splits and merges. (Owner review 2, R9.) | One sequence holding every file; one sequence per camera body | A folder shot RAW+JPEG would otherwise hold every instant twice, doubling the time-lapse; formats also decode and render differently. Bodies are ignored because the owner asked for the folder's sequence "in its entirety". |
|
||||
| 2026-10-26 | A whole folder's session key is `folder-` + the first 16 hex digits of SHA-256 of "PC name, full path (trailing separator trimmed, upper-cased on Windows), format", plus `-yyyyMMdd-HHmmss` of the first photo for a part the user split off. The grouping is not stored in card profiles: a folder starts on Sessions, and cards and drives are always planned by sessions. (Owner review 2, R9.) | Hash of path and format only; remember the grouping per folder | The same key for the same folder lets an interrupted or repeated import continue its sequence through the existing session-key lookup. The server files client uploads by session key without user scope, so the same `D:\Photos\Trip` on two PCs must not land in one sequence; renaming the PC starts a new one (hash duplicate detection still prevents doubled frames). Folder sources have no profile today, so the simplest safe default applies. |
|
||||
Reference in new issue
Block a user