fix(sync): replace cached thumbnails once the server has the proxies
A proxy download caches a frame's thumbnail under its proxy name while the server has no proxy of it (HEIF until a client or render node sends one). The cache did not record which it was, so the thumbnail stayed there for good after the server's proxies arrived (V-29). - remote.json records each cached file's kind (proxy or thumbnail); a later proxy download replaces thumbnails, and files of caches written before kinds were kept, once the server offers the frame's proxy. - A cache filled with thumbnails while the server had no proxies counts as stale, so offline caches are fetched again when the proxies arrive. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
This commit is contained in:
4 files changed
+101
-30
No files matched your search
@@ -395,6 +395,28 @@ public sealed class SyncTransferTests(TestContext context)
|
||||
Assert.SequenceEqual([Sha(photos[2])], server.Camera.Keyframes.Select(k => remote.Frames[k.Frame].Sha256));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task ACachedThumbnailIsReplacedOnceTheServerHasTheProxy()
|
||||
{
|
||||
await using var f = await SyncFixture.CreateAsync(context);
|
||||
var remote = f.Remote.Add("Fog", f.NewPhotos(2), status: SequenceStatus.ThumbsBuilt);
|
||||
await f.RefreshAsync();
|
||||
var engine = await f.StartEngineAsync();
|
||||
var job = await f.Sync.EnqueueDownloadAsync(engine, f.Server, remote.Id, "Fog", SyncDownloadMode.Proxies, null);
|
||||
await f.Archive.WaitForAsync(job.Id, JobState.Done);
|
||||
Assert.True(Assert.NotNull(f.Sync.OpenRemote(f.Server, remote.Id)).Files.All(file => new FileInfo(file!).Length == 64), "thumbnails stand in");
|
||||
Assert.True((await f.EntryAsync("Fog")).Link!.ProxiesStale, "the cache is filled again once the server has proxies");
|
||||
|
||||
// Proxies arrive on the server (a client or render node sent them); the frames did not change.
|
||||
remote.Status |= SequenceStatus.ProxiesBuilt;
|
||||
job = await f.Sync.EnqueueDownloadAsync(engine, f.Server, remote.Id, "Fog", SyncDownloadMode.Proxies, null);
|
||||
await f.Archive.WaitForAsync(job.Id, JobState.Done);
|
||||
|
||||
var opened = Assert.NotNull(f.Sync.OpenRemote(f.Server, remote.Id));
|
||||
Assert.SequenceEqual(remote.Frames.Select(r => (long)r.Proxy.Length), opened.Files.Select(file => new FileInfo(file!).Length));
|
||||
Assert.False((await f.EntryAsync("Fog")).Link!.ProxiesStale);
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task TheServersRendersAreFetchedIntoTheLocalExports()
|
||||
{
|
||||
|
||||
Reference in new issue
Block a user