From ae41c956823b0fa876922b37e4f63f6f474bbaa7 Mon Sep 17 00:00:00 2001 From: Alberto Balbo Date: Wed, 4 Nov 2026 12:54:46 +0100 Subject: [PATCH] docs: record the phase 5b review fixes in DECISIONS and CHANGELOG Co-Authored-By: Claude Opus 5.5 --- docs/CHANGELOG.md | 8 ++++++++ docs/DECISIONS.md | 13 ++++++++++++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 4fe0ca83..036f813e 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -17,6 +17,14 @@ commits follow Conventional Commits (release notes are generated from them by `C not there yet. ### Fixed +- Server projects (review of phase 5b): a sequence without photos no longer writes projects at the archive's root + (*This sequence has no photos yet.*); a full-size version can be pushed and one too large is told so; version pages + are capped in size; a settings change sent to the server is no longer lost when Main is made later; deleting a + project as its maker needs the same account, not just the same name; renames, rescans and reconnects reach the + workspace; a status no longer downloads the server's frames each time; a resumed copy never keeps a thumbnail as a + proxy; an account without Edit opens server sequences with proxies; a project opened signed out renders once signed + in. The admin panel's projects table fits narrow windows, keeps the versions loaded with *Load more* on a live + refresh and no longer downloads settings it does not show. - Chronos and the Uploader could not reach a server in a container whose ports are published as other host ports (owner review 3). The admin panel's Settings › Network and TLS listed the container's ports (8080, 8443) as if clients used them. In a container it now shows them read-only as *Container HTTP port* and *Container HTTPS port*, diff --git a/docs/DECISIONS.md b/docs/DECISIONS.md index 839fc554..c2c7f6d7 100644 --- a/docs/DECISIONS.md +++ b/docs/DECISIONS.md @@ -635,4 +635,15 @@ One line per decision: date · decision · alternative · reason. | 2026-11-04 | Texts of a server's project are their key's `.Server` form when one exists (`WorkspaceText.ForHome`), else the key itself; the chip says *Server newer* and *Not on server*. | Format "the library" / "the server" into one text | Word order and articles differ by language; a missing form falls back to the library's text, never to a key. | | 2026-11-04 | A server's project renders what the server holds: before a render (`ProjectMenuViewModel.ReadyToRenderAsync`) unsaved or unsent work is offered to be saved and sent; Offline, Gone, Damaged or media removed hold the render. In step, the jobs name the version alone; out of step, the portable settings travel and only the project is recorded. An analysis's Auto values reaching Main at the server are taken by the next `projectChanged` (pushed) within 2 minutes, with Sync automatically. | Render the workspace's settings always | The server renders with its originals; only a version it holds can be named. | | 2026-11-04 | Edit opens a server's sequence as a workspace project when the server has the `projects` capability (`OpenServerWorkspaceAsync`), with final 5a's refusals (a copy this Chronos cannot read, a damaged or newer Main listed disabled, a workspace folder refused). The *sequence left the index* refusal applies only to projects of this PC's archive. An older server's sequences open with proxies as before. | Refuse every project whose sequence is not in the index | A server's sequence is never in this PC's index. | -| 2026-11-04 | `ServerProjectHome` gives no frames stamp: a status reads the server's frames each time. | Add a stamp to the API | Kept for later; the frames endpoint is small and the 5a rule (stamp unchanged → frames not read) falls back safely. | +| 2026-11-04 | `ServerProjectHome` reads the frames stamp from `GET …/projects/frames/stamp` (`ArchiveProjectHome.StampOfAsync` on the server), so a status downloads the server's frames only when the stamp moved. Supersedes "no frames stamp" of the first 5b port. | Read the frames each time | Review 5b: every status of every server project downloaded the whole frame list. | +| 2026-11-04 | A sequence without a folder (a server's sequence made before its first photo) keeps no projects: it lists none, `CreateAsync` and every other change refuse with `ProjectError.SequenceEmpty` (409 `sequence_empty`) before any lease or file, and the stored-version check answers false. The desktop says *This sequence has no photos yet.* | Make Main in the index only | Its folder is empty, so the sidecars and leases landed at the archive's root. | +| 2026-11-04 | A settings PATCH on the server writes the sequence's `project.json` under the sequence lease first (`ArchiveService.EditSettingsAsync`, 20 s wait), then the index; the file is put back when the index does not take the edit. Busy, offline and moved answer 503 (`sequence_busy`, `archive_offline`, `folder_moved`), a file in use 409 `folder_in_use`. A PATCH of title or tags alone stays index-only. | Make Main's birth prefer the index | 5a's Data tests make `project.json` win on the desktop; the PATCH was the one writer that left it behind. | +| 2026-11-04 | The push body limit is the version limit (64 MiB) plus 1 MiB; the client reads a 413 as `ProjectPushOutcomes.TooLarge` / `too_large`. Version pages stop once their settings add up to 4 Mi characters (always one version at least) and say `more`; `ServerProjectHome` pages on until it has what was asked. `summary=true` leaves the settings out (the admin panel). | One fixed page size | A page of 200 large versions was hundreds of MB. | +| 2026-11-04 | Deleting a project as its maker needs the same account: same username, and an account made no later than the project. | Store the maker's id | No schema change; a name reused by a newer account no longer inherits the rights. | +| 2026-11-04 | `projectChanged` is also told for a full rescan's reconcile and the read-only catch-up (compared around them, told after the lease), and a Main flip reads as `renamed`. | Tell only the API's own calls | Another PC's changes reached the workspaces only at their next read. | +| 2026-11-04 | `SyncAgent` tells "changes may have been missed" only once the event stream is open again (`ISyncRemote.EventsAsync(connected, ct)`) and the refresh after it ran. | Tell at the loss | Told before the stream was back, a workspace re-read too early and missed changes made in between. | +| 2026-11-04 | A server-side rename reaches the workspace copy: every pull and the `renamed` event write the home's name (and Main) into the bundle (`WorkspaceSync.FollowNameAsync`), errors ignored. | A new `IProjectHome.ProjectAsync` | `ListAsync` already answers; one call fewer to add to both homes. | +| 2026-11-04 | `ServerProjectHome.HoldsAsync` reads the version file back (`GET …/versions/{id}?stored=true`, `ProjectService.StoredAsync`), false when the file is missing or damaged, or the project deleted. | Trust the index row | Pruning a local version needs proof the server's file holds it. | +| 2026-11-04 | A copy from a server writes an empty `.thumb` marker before a thumbnail taken for a missing proxy is moved into place; a resumed run reads it (and downloads the proxy when the server has it now); the commit removes the markers. | Download again every file of unknown kind | A resume would fetch every frame again. | +| 2026-11-04 | An account without Edit is offered *Open with proxies* (read-only) on a server that keeps projects, never *Open in workspace*, and Edit checks nothing out for it; a copy the workspace already holds still opens, its pushes refused (403) as a refusal, not as Offline. | Check out read-only | A viewer's workspace copy could never be pushed. | +| 2026-11-04 | The editor of a server's workspace project connects with the sign-in in use at each use (`WorkspaceServerHome(connect, session)`): a sign-in, sign-out or new sign-in drops the old connection and its jobs. `SyncHost` tells each session start and stop as `ProjectChanged(server, null)`. | Rebuild the editor | A project opened signed out could not render after signing in. |