From 95dbf53569d4d2a1dbd930589a8d2ea2426f5da1 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 2 Oct 2026 10:41:41 +0000 Subject: [PATCH] ci: capture uploader screenshots; docs: record job engine, visuals and uploader decisions Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC --- .github/workflows/ci.yml | 18 +++++++++++------- docs/DECISIONS.md | 10 ++++++++++ src/Titano.Ui/Visuals/WrapLayout.cs | 16 ++++++++-------- 3 files changed, 29 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0e95bd97..951c33dd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -90,13 +90,17 @@ jobs: if: runner.os == 'Windows' run: | set +e - src/Titano.App/bin/Release/net10.0-windows/Titano.exe --capture out/screenshots 2> out/capture.log & - wait $! - code=$? - cat out/capture.log - count=$(ls out/screenshots/*.png 2>/dev/null | wc -l) - echo "capture exit code $code, $count screenshot(s)" - if [ "$count" -eq 0 ]; then echo "::warning title=Screenshots::Titano --capture produced no images (exit $code)"; fi + for exe in src/Titano.App/bin/Release/net10.0-windows/Titano.exe src/Titano.Uploader/bin/Release/net10.0-windows/Titano.Uploader.exe; do + name=$(basename "$exe" .exe) + before=$(ls out/screenshots/*.png 2>/dev/null | wc -l) + "$exe" --capture out/screenshots 2> "out/capture-$name.log" & + wait $! + code=$? + cat "out/capture-$name.log" + count=$(( $(ls out/screenshots/*.png 2>/dev/null | wc -l) - before )) + echo "$name capture exit code $code, $count screenshot(s)" + if [ "$count" -eq 0 ]; then echo "::warning title=Screenshots::$name --capture produced no images (exit $code)"; fi + done - name: Publish desktop programs (win-x64, self-contained single file) if: runner.os == 'Windows' diff --git a/docs/DECISIONS.md b/docs/DECISIONS.md index 07168acd..7f814c0d 100644 --- a/docs/DECISIONS.md +++ b/docs/DECISIONS.md @@ -69,3 +69,13 @@ One line per decision: date · decision · alternative · reason. | 2026-10-02 | Migrations: all pending ones in one transaction under `pg_advisory_xact_lock`. | One transaction per migration | Atomic and safe when several servers start together. | | 2026-10-02 | Case-insensitive search/sort via lower-cased `search_text`/`title_key` columns (and `COLLATE "C"` on PG). | ILIKE / NOCASE | Identical results on both dialects. | | 2026-10-02 | Job claim: `UPDATE … WHERE id = (SELECT … FOR UPDATE SKIP LOCKED) RETURNING` on PG; immediate transaction on SQLite. | Advisory locks | Exclusive under concurrency, as specified. | +| 2026-10-02 | One `JobEngine` in Titano.Data runs every long operation for both the client and the server: handlers per `JobKind`, progress persisted at most every 5 s, a failed persist (job no longer running) stops the handler, a shutdown leaves jobs running so the next start requeues them from their checkpoint. | Per-feature background loops | One queue, one cancel/pause/resume path and one crash-recovery rule everywhere. | +| 2026-10-02 | Job throughput is a moving average over windows of at least 2 s. | Average since start | ETA follows speed changes (cache warm-up, network) without jitter. | +| 2026-10-02 | Visual controls (card grid, filmstrip, charts, preview, curve editor) keep their layout and math in WPF-free classes; colours are theme brush keys re-resolved on theme switch; charts, filmstrip and preview never mirror in RTL. | Math inside controls / brush properties | Testable on Linux; view models hold no brushes; time axes and images must not flip. | +| 2026-10-02 | `VirtualizingWrapPanel` does its own keyboard navigation and recycling; the focused container is kept alive. | ListBox navigation | Direct targets, wrapping across rows; focus survives scrolling. | +| 2026-10-02 | Library card slot 236 × 208 with a 16:9 thumbnail. | Mockup's 150 px thumbnail | DESIGN §4 specifies 16:9. | +| 2026-10-02 | Uploader sessions: key = 8 hex chars of the source folder's SHA-256 + first-frame time; leading test shots (first group < 8 frames) join the next session; watch-folder files always use automatic sessions. | Group by time only | Simultaneous cameras stay apart; unattended files never land in a sequence chosen for a manual drop. | +| 2026-10-02 | Uploader: a watch file counts as processed only after the server confirms it; offline, rejected-token and changed-certificate failures do not use up the three retries; a changed certificate signs the user out. | Mark at enqueue / count every failure | Clearing the queue loses nothing; an outage does not exhaust a large batch; never upload to an unverified server. | +| 2026-10-02 | Delete-after-upload also requires size and write time unchanged since hashing. | Server confirmation alone | BRIEF rule 8. | +| 2026-10-02 | Uploader settings are an in-window panel; single instance via a per-session mutex and a current-user named pipe; native tray menu (`TrackPopupMenuEx`). | Dialog / WM_COPYDATA / WPF ContextMenu | §12.1 allows modals only for login and destructive confirmations; works while hidden in the tray; dismisses reliably. | +| 2026-10-02 | Network watch folders are polled (default 5 min); local folders every 60 s plus `FileSystemWatcher` hints. | Watcher everywhere | SMB change notifications are unreliable. | diff --git a/src/Titano.Ui/Visuals/WrapLayout.cs b/src/Titano.Ui/Visuals/WrapLayout.cs index 52a26cab..f1a01fd4 100644 --- a/src/Titano.Ui/Visuals/WrapLayout.cs +++ b/src/Titano.Ui/Visuals/WrapLayout.cs @@ -158,15 +158,15 @@ public readonly struct WrapLayout if (index + Columns <= last) return index + Columns; return RowOf(index) < Rows - 1 ? last : index; case WrapStep.PageUp: - { - var row = Math.Max(0, RowOf(index) - page); - return row * Columns + ColumnOf(index); - } + { + var row = Math.Max(0, RowOf(index) - page); + return row * Columns + ColumnOf(index); + } case WrapStep.PageDown: - { - var row = Math.Min(Rows - 1, RowOf(index) + page); - return Math.Min(last, row * Columns + ColumnOf(index)); - } + { + var row = Math.Min(Rows - 1, RowOf(index) + page); + return Math.Min(last, row * Columns + ColumnOf(index)); + } case WrapStep.First: return 0; case WrapStep.Last: