fix(editor): round the colour temperature to tens without a negative digit count
double.Round(x, -1) throws, so opening any analysed sequence with a white balance range failed in the Exposure tab's constructor and the editor never appeared. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
This commit is contained in:
2 files changed
+12
-1
No files matched your search
@@ -115,10 +115,13 @@ public sealed class ExposureTab : EditorTab
|
||||
{
|
||||
if (Editor.Session.Content.Deep is not { } deep) return (null, Loc.L("Tooltips.Editor.NotApplicable.NeedsAnalysis"));
|
||||
if (deep.WhiteBalance is { KelvinLow: { } low, KelvinHigh: { } high })
|
||||
return (Loc.L("Editor.Value.Kelvin", double.Round(low, -1).ToString("N0", Loc.Culture), double.Round(high, -1).ToString("N0", Loc.Culture)), null);
|
||||
return (Loc.L("Editor.Value.Kelvin", RoundToTens(low).ToString("N0", Loc.Culture), RoundToTens(high).ToString("N0", Loc.Culture)), null);
|
||||
return (null, Loc.L("Tooltips.Editor.NotApplicable.Kelvin"));
|
||||
}
|
||||
|
||||
/// <summary>Kelvin shown to the nearest ten (Math.Round takes no negative digit count).</summary>
|
||||
internal static double RoundToTens(double kelvin) => double.Round(kelvin / 10) * 10;
|
||||
|
||||
private void BuildChart()
|
||||
{
|
||||
var content = Editor.Session.Content;
|
||||
|
||||
@@ -11,6 +11,14 @@ public sealed class EditorTextTests
|
||||
{
|
||||
static EditorTextTests() => _ = EditorFixture.Sunset;
|
||||
|
||||
[Test]
|
||||
public void ColourTemperatureShowsToTheNearestTen()
|
||||
{
|
||||
Assert.Equal(5560.0, ExposureTab.RoundToTens(5557.2));
|
||||
Assert.Equal(3200.0, ExposureTab.RoundToTens(3203.9));
|
||||
Assert.Equal(12_000.0, ExposureTab.RoundToTens(11_998));
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void OptimiseReportsValuesAsTheControlsShowThem()
|
||||
{
|
||||
|
||||
Reference in new issue
Block a user