feat: remove the anonymous usage counts (owner review 4, R2)

The owner does not want Chronos to send data about its use, and nothing
ever sent the counts the consent promised. The first-run checkbox, the
Settings > General row, the AnonymousUsageCounts setting and its three
strings in every culture are gone; a settings file that still carries the
member loads and is saved without it. BRIEF §21, the EULA and the Welcome
mockup now say Chronos sends nothing about its use; the diagnostics
bundle stays, saved only locally.

Refs #30

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Alby96andClaude Opus 5.5 committed 2026-11-06 16:52:58 +01:00
1 parent fe50b87726
commit 8dc1b25d94
88 files changed
+36 -180

No files matched your search

@@ -409,15 +409,16 @@ public sealed class ShellNotificationTests
});
[Test]
public Task GeneralSettingsHoldStartupAndNotificationsButNoConsent() => ScreenHost.RunAsync(async () =>
public Task GeneralSettingsHoldStartupAndNotificationsAndNoUsageCounts() => ScreenHost.RunAsync(async () =>
{
// Monetization (BRIEF §21) ships disabled: the default build offers no usage counts consent.
// Monetization (BRIEF §21) ships disabled.
Assert.False(ProductFeatures.AdsEnabled);
// Chronos sends nothing about its use (owner review 4, R2): the first run asks no consent.
await using var app = await ScreenSmokeTests.SampleApp.StartAsync(firstRun: true);
var shell = app.Shell;
await app.ExpectAsync<WelcomeView>("welcome");
Assert.False(app.FindAll<CheckBox>().Any(c => c.IsVisible && Equals(c.Content, Loc.L("Settings.General.UsageCounts"))), "no consent on the first-run dialog");
Assert.False(app.FindAll<CheckBox>().Any(c => c.IsVisible), "no consent on the first-run dialog");
shell.CompleteWelcome();
var settings = shell.Settings;
@@ -427,7 +428,7 @@ public sealed class ShellNotificationTests
settings.Page = SettingsPage.General;
await app.ExpectAsync<SettingsView>("settings-general");
var boxes = app.FindAll<CheckBox>().Where(c => c.IsVisible).ToList();
Assert.False(boxes.Any(c => Equals(c.Content, Loc.L("Settings.General.UsageCounts"))), "no consent in Settings");
Assert.Equal(2, boxes.Count);
var start = boxes.Single(c => Equals(c.Content, Loc.L("Settings.General.StartWithWindows")));
Assert.Equal(Loc.L("Tooltips.Settings.StartWithWindows"), start.ToolTip);
var notify = boxes.Single(c => Equals(c.Content, Loc.L("Settings.General.OsNotifications")));
@@ -444,11 +445,11 @@ public sealed class ShellNotificationTests
// Reset section also returned the language to the system's.
UiLanguage.Apply("en");
// The search finds General by its new rows, not by the hidden consent.
// The search finds General by its rows, not by the removed usage counts.
settings.SearchText = Loc.L("Settings.General.Startup");
Assert.Contains(settings.VisiblePages, p => p.Page == SettingsPage.General);
settings.SearchText = Loc.L("Settings.General.Usage");
Assert.False(settings.VisiblePages.Any(p => p.Page == SettingsPage.General), "the hidden consent does not match");
settings.SearchText = "Usage counts";
Assert.False(settings.VisiblePages.Any(p => p.Page == SettingsPage.General), "no usage counts row");
settings.SearchText = string.Empty;
});