From 7fa49f1b5b6024e0a48517effc8b4aa1da420d16 Mon Sep 17 00:00:00 2001 From: Claude Date: Mon, 12 Oct 2026 15:51:46 +0000 Subject: [PATCH] docs: the screenshot diff is wired but not armed; one sign-in cleanup rule STATUS no longer claims every --capture screen is pixel-diffed: with no baseline committed the step compares nothing. Next steps now starts with accepting the first baselines from ci-screenshots. DECISIONS marks the folder-scoped Run cleanup row as superseded by the log-based rule and drops the branch-merge notes from that rule's row. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC --- docs/DECISIONS.md | 4 ++-- docs/STATUS.md | 17 +++++++++++------ 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/docs/DECISIONS.md b/docs/DECISIONS.md index 0b14ae86..17608e5a 100644 --- a/docs/DECISIONS.md +++ b/docs/DECISIONS.md @@ -286,7 +286,7 @@ One line per decision: date · decision · alternative · reason. | 2026-10-12 | A click on a Windows notification restores the window. It runs the toast's action only when the toast opts in (`Toast.RunsFromNotification`: card detected → Import, interrupted import → Resume, job finished → Open, navigation to Import or Jobs) and it is the only notification shown since the tray icon appeared | Run every toast's action; track which balloon was clicked | People click a notification to bring the window back, so a Cancel, Undo or Retry there would act before they read why; NIN_BALLOONUSERCLICK does not say which of several notifications was clicked. | | 2026-10-12 | Toasts also become Windows notifications while no Titano window is active, not only while the window is minimised or hidden; Settings › General › Notifications turns them off | Only when minimised, as BRIEF §12.1 words it | A window behind another program is as unseen as a minimised one; card prompts (§12.4) and job endings would expire unseen after 8 s. | | 2026-10-12 | Settings › General › Startup writes the HKCU Run value `Titano` = `"" --minimized`. The window starts minimised, and its first restore brings back the saved maximised state. The value counts as on only when it starts this executable; it is rewritten only when an update renamed the program in this copy's folder, and only the copy it starts removes it. Portable copies hide the row and write nothing to the registry | Scheduled task; one value per copy; rewrite the value at every start | The Run key is what Task Manager's Startup tab shows and turns off (as for the Uploader). One value cannot serve two copies, and a copy that merely starts must not take it over. Portable mode keeps everything under `.\data` (BRIEF §6.2). | -| 2026-10-12 | The uninstaller removes the client's and the Uploader's HKCU Run values when their command starts a program in the folder it removes (`StartupCommand` in Titano.Core is shared by the programs and Setup) | Leave them; remove them whatever they start | Windows would otherwise keep a sign-in entry that points at a deleted exe; another copy's entry is not this uninstaller's to remove. | +| 2026-10-12 | (Superseded by the sign-in entry cleanup row below: a value is removed only when it starts a program the install log lists.) The uninstaller removes the client's and the Uploader's HKCU Run values when their command starts a program in the folder it removes (`StartupCommand` in Titano.Core is shared by the programs and Setup) | Leave them; remove them whatever they start | Windows would otherwise keep a sign-in entry that points at a deleted exe; another copy's entry is not this uninstaller's to remove. | | 2026-10-12 | The editor's 1:1 view moves from Ctrl+1 to Ctrl+Shift+1 (tooltip key `Tooltips.Editor.Preview.OneToOne`). Ctrl+1…6 (number row and keypad) and Ctrl+, open the rail's sections and do nothing behind the first-run dialog | Change the rail's shortcuts instead | The rail tooltips already listed Ctrl+1…6 (BRIEF §12.1 "standard shortcuts, listed in tooltips"); section shortcuts must work everywhere, the 1:1 view only inside the editor. | | 2026-10-12 | Rail badges: Jobs counts running or paused jobs plus failures not yet seen on the Jobs screen (which also turn the idle taskbar button red). Server counts sync conflicts. Library counts the sequences of this PC flagged with warnings (the Warnings filter), recounted after analyses. Archive counts the index health lines that need attention, set when the Archive screen reads its figures | Badge running jobs only; read the archive figures at start for the Archive badge | BRIEF §12.1 asks for "badge counts (warnings, running jobs)", and DESIGN §4 defines the badge as the count of things needing attention. The Archive figures are a heavy read that the screen already does when it opens. | | 2026-10-12 | The taskbar button uses WPF's `Window.TaskbarItemInfo`, bound to the shell: the job bar's progress, an indeterminate bar while the total is unknown, and red while a failure waits unseen | `Titano.Core.Windows/Shell/TaskbarProgress` | WPF already wraps ITaskbarList3 for its windows, and a binding needs no window-handle plumbing. | @@ -325,7 +325,7 @@ One line per decision: date · decision · alternative · reason. | 2026-10-12 | Setup asks programs to close before touching any service. On install it stops the running services, then installs, then prunes services whose program is gone and starts exactly the ones it stopped, whatever their start type. On uninstall it deletes the services only once the programs have closed, just before the files go. Any failure after a stop starts those services again. | Stop or delete services first; start every automatic service after an upgrade | A program refusing to close left the Server stopped, or its service already deleted, and a failed upgrade left it down until reboot. An administrator's deliberately stopped service, or a running demand-start one, keeps its state. | | 2026-10-12 | User data ownership in %LOCALAPPDATA%\Titano: entries starting with `uploader` (also inside `logs`) are the Uploader's, everything else the desktop app's. 'Remove my data' offers only the data of the uninstalled product's components that no other registered Titano product (same Publisher) has. A product whose folder or log cannot be read now counts as using all of it. | Delete the whole folder; hide the option whenever another product is registered | The products share the folder. An offline drive or damaged log must not make a still-installed product's index or upload queue look orphaned. A stale entry only hides the option, which is the safe direction. | | 2026-10-12 | A shortcut that starts an existing program elsewhere is not created or retargeted, but it is logged. When the product it starts is uninstalled (or an upgrade drops it), the shortcut is pointed at the same program of another installation of the same scope whose log lists it, and only deleted when there is none. | Each product overwrites and deletes the shared 'Titano Uploader' shortcuts; distinct names per product | Both products ship the Uploader under the same shortcut name. The program that stays installed keeps its Start menu and desktop shortcuts, and neither uninstall touches the other's. | -| 2026-10-12 | Sign-in entry cleanup: SetupRegistry.DeleteStartupEntries removes the client's ('Titano') and the Uploader's ('Titano Uploader') Run values, named by Core/IO/StartupCommand (shared with fix/shell-notify), only when they start a program the install log lists. This happens on uninstall and on an upgrade that drops that program. When merging with fix/shell-notify, keep this branch's DeleteStartupEntries and its call. | Every Run value under the folder (first version); the folder-scoped variant of fix/shell-notify | One implementation after the merge. Nothing outside Titano's own value names and installed programs is touched, so a portable copy in a subfolder keeps its entry. | +| 2026-10-12 | Sign-in entry cleanup: SetupRegistry.DeleteStartupEntries removes the client's ('Titano') and the Uploader's ('Titano Uploader') Run values, named by Core/IO/StartupCommand, only when they start a program the install log lists. This happens on uninstall and on an upgrade that drops that program. | Every Run value under the folder (first version); the folder-scoped variant of fix/shell-notify | Nothing outside Titano's own value names and installed programs is touched, so a portable copy in a subfolder keeps its entry. | | 2026-10-12 | 'Maintenance release.' is written whenever no section or breaking entry was written, also under a title. | Test the output length | release.yml always passes a title, so the old check never fired (BRIEF §19.3). | | 2026-10-12 | A frame read from its proxy (an original this host cannot decode) records no decode tier: thumbnails drawn from the proxy, and renders or analyses that read it, leave the original's tier and flags as they are. | Record the proxy's tier | The tier describes the original on this host (BRIEF §8.2); a proxy that decodes says nothing about it, and its Undecodable flag must stay so renders keep reading the proxy. | | 2026-10-12 | *Reset all* also turns *Start with Windows* off; importing a settings file leaves it alone. | Keep the sign-in entry on reset | The entry belongs to this copy and lives in the registry, not in the settings file; its default is off, and a settings file from another PC says nothing about this copy. | diff --git a/docs/STATUS.md b/docs/STATUS.md index 786ae121..3bb856be 100644 --- a/docs/STATUS.md +++ b/docs/STATUS.md @@ -10,7 +10,7 @@ Phase plan: docs/BRIEF.md §22. Windows behaviour is verified on CI (`windows-la | 3 Library and Archive manager | Done: Library (virtualised grid and list, timeline with year bands, filters, saved views, quick actions, mass bar, *Delete…* into the archive's trash with a dry run, typed confirmation and Undo, cards for server-only sequences), Archive manager (tree, health, statistics charts, maintenance with *Trash…* and restore, verify, duplicates, orphans, adopt, mass rename and move with dry runs), Jobs, Settings, Welcome, Server and About. Gate measured on 500,000 photos: Library open 259 ms on SQLite and 181 ms on PostgreSQL on a new connection pool (warm OS cache; budget 1 s); every filter, search, sort and next page ≤ 6.4 ms (budget 200 ms). | | 4 Card import | Done: device detection, card pool and camera profiles, plan with sessions (merge and split), hash-verified copy, post-actions (verified delete, format behind a typed confirmation, eject), auto-import, Archive, Folder and Server destinations. Gate: import from a simulated card folder end to end in tests; delete and format refuse any photo the import did not verify; screenshots on `ci-screenshots`. | | 5 Analysis advisor | Done: light and deep analysis, reports and section charts, recommendations with localised reasons, sequence presets, Auto/manual controls and Optimise in the editor. Gate: golden recommendations for synthetic sequences; every reason key exists in `en` and `it` (`i18n check`); deep analysis streams with checkpoints and resumes after a restart. | -| 6 Engine, encoding, editor | Done: render pipeline, MP4/AVI/GIF/APNG/image sequences, Media Foundation H.264/HEVC/AV1 with managed fallbacks; the sequence editor (Frames, Exposure, Camera, Motion and Export tabs, preview tools, section charts, curve editor, undo/redo, batch export) for local and server sequences. Gate: self-test suite green; the in-house inspector validates the containers the tests write; the encoder in use is logged. Playback: MediaPlayer opens the Media Foundation output and a source reader decodes its first frame (Windows tests); every `--capture` screen is pixel-diffed against `tests/visual/baselines` (`screenshots diff`). | +| 6 Engine, encoding, editor | Done: render pipeline, MP4/AVI/GIF/APNG/image sequences, Media Foundation H.264/HEVC/AV1 with managed fallbacks; the sequence editor (Frames, Exposure, Camera, Motion and Export tabs, preview tools, section charts, curve editor, undo/redo, batch export) for local and server sequences. Gate: self-test suite green; the in-house inspector validates the containers the tests write; the encoder in use is logged. Playback: MediaPlayer opens the Media Foundation output and a source reader decodes its first frame (Windows tests). The pixel diff of every `--capture` screen against `tests/visual/baselines` (`screenshots diff`, BRIEF §20.2) is wired into CI but not armed: no baseline is committed yet, so the step compares nothing and only warns until the first baselines are accepted from `ci-screenshots` (Next steps). | | 7 Server, sync, uploader | Done: server (API, auth, uploads, jobs, render nodes, events, admin panel with light and dark themes, Windows service), Uploader, client sync (sync table, conflicts with *Save both*, proxies kept offline, metered pause), server sequences edited with proxies and rendered where the originals are, this PC as a render node. Gate covered in-process: a sequence uploaded from one PC downloads identically on another, interrupted uploads and downloads resume, server events update a PC, renders run on a node and on the server's managed fallback, jobs resume after a restart, sign-ins and administrative actions are audited. The run with two real PCs and the Uploader against the Docker server is part of the release test. | | 8 Release readiness | Release pipeline end to end (installers, portable and server zips, SHA256SUMS, release notes, optional signing, multi-arch GHCR image, public releases repository content), update check with verified download, scrubbed diagnostics bundles (desktop and server), performance gates, 38 cultures (`en`, `it` and 36 machine translations with glossaries and independent reviews), RTL pass (`ar`, `he`: mirrored windows, left-to-right islands for media, charts, numbers and paths; any right-to-left culture added later follows), accessibility pass (names, live regions, keyboard paths for charts and the curve editor). CI installs the packed installers silently on a clean `windows-latest` runner, runs the installed programs, upgrades in place and uninstalls (files, Add/Remove Programs, shortcuts, file type, user data kept, exit codes). Pending: a tagged pre-release published from CI, the interactive install on a real PC, Unraid template validation on a real server. | | 9 Monetization | Not started: requires explicit approval (§22). | @@ -18,7 +18,8 @@ Phase plan: docs/BRIEF.md §22. Windows behaviour is verified on CI (`windows-la ## Verification (2026-10-12) A full audit against the brief, `CLAUDE.md`, the UI kit, the tests and the Docker and client setups confirmed 71 -defects with independent verifiers; all are fixed (rows dated 2026-10-12 in DECISIONS and CHANGELOG). The Docker +defects with independent verifiers; all are fixed (rows dated 2026-10-12 in DECISIONS and CHANGELOG), except that the +new screenshot diff (BRIEF §20.2 visual regression) gates nothing until its first baselines are committed. The Docker image was built and run with PostgreSQL 17, a fresh archive folder and remapped ports; the client installers are installed, run, upgraded and removed on `windows-latest` by the `installer` CI job. @@ -52,8 +53,12 @@ src/Titano.App/bin/Release/net10.0-windows/Titano.exe --capture out/screenshots ## Next steps (Phase 8 gate) -1. Create the public repository (`/titano-releases`), add the `RELEASES_TOKEN` secret, push a `v0.x.y-rc.1` +1. Arm the screenshot diff: from the `ci-screenshots` commit of the first green `windows-latest` run at the current + HEAD, run `dotnet run --project src/Titano.Tools -- screenshots accept ` and commit the PNGs to + `tests/visual/baselines` (its README says how). From then on a visual change, or a screen without a baseline, + fails CI. +2. Create the public repository (`/titano-releases`), add the `RELEASES_TOKEN` secret, push a `v0.x.y-rc.1` tag and check the release, the public repository content and the GHCR image (set it public once). -2. On Windows: install, upgrade over the previous version, uninstall (with and without user data), silent mode. -3. Unraid: add the template repository, install with the official PostgreSQL template, reach the WebUI. -4. Native-speaker review of the machine translations where users report wording (`i18n export` per language). +3. On Windows: install, upgrade over the previous version, uninstall (with and without user data), silent mode. +4. Unraid: add the template repository, install with the official PostgreSQL template, reach the WebUI. +5. Native-speaker review of the machine translations where users report wording (`i18n export` per language).