feat: screenshot baselines from the development PC, fixed capture values, ports strings in all languages
The owner chose to capture the baselines on the development PC (owner review 3, R2): 156 screens go to tests/visual/baselines and CI no longer pushes a ci-screenshots branch. While --capture freezes AppClock, free space, a server's latency and the last sync are fixed sample values; they moved the Server and Import screens past the diff tolerance at random. The 22 new or changed Admin strings are translated into the 36 other languages, and the request file records the owner's text and answers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
2585b5d45f
commit
7273eec2bb
276 files changed
+893
-121
No files matched your search
@@ -35,6 +35,8 @@ commits follow Conventional Commits (release notes are generated from them by `C
|
||||
port*; the port descriptions say to enter the same host port there. LAN discovery's tooltip, the template and the
|
||||
user guide say that discovery leaves a container only with network type *Host*: on *Bridge*, type the client
|
||||
address.
|
||||
- The screenshot baselines (156 screens) are committed in `tests/visual/baselines`, captured on the development PC
|
||||
(owner review 3); CI no longer pushes its screenshots to the `ci-screenshots` branch, which is deleted.
|
||||
|
||||
### Upgrade note for Unraid
|
||||
- Edit the container: set *Repository* from `…/chronos-server:nightly` to `…/chronos-server:latest`, and set *Public
|
||||
|
||||
+4
-2
@@ -88,7 +88,7 @@ One line per decision: date · decision · alternative · reason.
|
||||
| 2026-10-02 | Automatic output stops at 4K UHD; no automatic stacking advice. | 8K / temporal-median denoise | 8K stays a manual choice; a median erases moving stars and stillness cannot be verified reliably. |
|
||||
| 2026-10-02 | Apply records a missing-data reason only where no advice exists; Optimise returns modules to Auto and only adds to the user's hero, exclusions, offset or output cap; a preset's own choices are stored as manual values, content-derived values stay Auto. | Overwrite | Manual values stay in force; re-analysis does not undo a chosen preset. |
|
||||
| 2026-10-02 | Advisor namespace is `Chronos.Core.Advice` (class `Advisor`). | `Chronos.Core.Advisor` | A class named like its namespace needed an alias in every `Chronos.Core.*` caller. |
|
||||
| 2026-10-02 | CI also force-pushes each same-repository PR run's screenshots as one commit to the `ci-screenshots` branch (separate job, only it has `contents: write`). | Artifact only | Artifacts need an authenticated download; a branch can be fetched with plain git for visual review. The branch never merges and holds a single commit. |
|
||||
| 2026-10-02 | (Superseded by the 2026-11-04 baselines row: the baselines are captured on the development PC and the `ci-screenshots` branch is gone.) CI also force-pushes each same-repository PR run's screenshots as one commit to the `ci-screenshots` branch (separate job, only it has `contents: write`). | Artifact only | Artifacts need an authenticated download; a branch can be fetched with plain git for visual review. The branch never merges and holds a single commit. |
|
||||
| 2026-10-02 | Export fps is the encoded grid; `Timing.FrameRate` is the playback rate (source frames per video second, default = export fps). Durations are quantised to output periods on rounded 90 kHz boundaries; whole frames are sampled at the period centre. | One fps / free durations | Presets keep their meaning, Interpolated can synthesise slow motion, AVI and image sequences stay exact. |
|
||||
| 2026-10-02 | Adaptive timing is proportional up to 3× the median interval; longer gaps show for 3 + log2(r/3) frames (max 5); pauses ≥ 20× median and ≥ 120 s become a 0.2 s cut. Interpolated fills gaps of up to 3 missing/excluded frames. | Fixed clamps | Bursts stay faithful and long gaps cannot stall the video. |
|
||||
| 2026-10-02 | A non-monotonic time-remap curve is repaired (sorted, clamped, made non-decreasing) with a warning; virtual-camera keyframes are keyed to source frame positions. | Reject the curve / output frame index | The remap is always monotone; keyframes stay on the content when timing or fps change. |
|
||||
@@ -265,7 +265,7 @@ One line per decision: date · decision · alternative · reason.
|
||||
| 2026-10-12 | Container entrypoint: an archive root that PUID:PGID cannot write is given to them (that folder only, `chown` without `-R`) when it is empty or owned by root, as Docker creates a missing bind source. Any other unwritable root, and any existing `.chronos` folder or subfolder they cannot write, stops the container with a one-line error and is never chowned. The data folder is `${CHRONOS_DATA_PATH:-/data}`. This amends the 2026-10-02 row '/archive only checked for write access'. | Recursive chown, or a warning followed by a crash loop | A fresh install never became healthy. The archive may hold terabytes, so its contents are never chowned. |
|
||||
| 2026-10-12 | Screenshot diff (`Chronos.Tools screenshots diff`): a pixel differs when one RGBA channel moves by more than 8 of 255; a screen fails when more than 0.05 % of its pixels differ, when its size changed, when it cannot be read, or when its baseline has no screenshot; differing pixels are drawn magenta over the faded baseline in `<screen>-diff.png` | Exact pixel equality; a perceptual metric (SSIM) | Anti-aliased edges move a few levels between runs; 0.05 % (about 650 pixels of 1440×900) absorbs the measured latency and last-sync time while a moved control, a new colour or a missing picture exceed it; a per-pixel rule is easy to explain and to check by eye in the diff image. |
|
||||
| 2026-10-12 | A screenshot without a baseline fails as soon as `tests/visual/baselines` holds any PNG; before the first baselines the step passes with a warning and a bold job-summary line saying it compared nothing | Always only warn; always fail; a `--require-baselines` switch in ci.yml | Warn-only left every screen, and any screen added later, ungated for good; failing before any baseline exists would keep CI red until a Windows run produced them; a rule that arms itself needs no switch to remember. |
|
||||
| 2026-10-12 | Baselines are accepted only from CI's `ci-screenshots` branch (`screenshots accept`), never from a local capture; the first set is accepted from the first green `windows-latest` run whose code captures at `SampleData.Now`, after the review-fix branches merge, so this change commits none | Commit the current `ci-screenshots` pictures now; capture locally | Fonts, scaling and time zone differ per machine and Linux cannot run the WPF capture; the current `ci-screenshots` commit (of 261ab46) predates the fixed clock, so its times and dates ("12:18 AM", sequences dated from the capture day) would fail every such screen, and parallel branches still change screens. |
|
||||
| 2026-10-12 | (Superseded by the 2026-11-04 baselines row: the baselines are captured on the development PC and the `ci-screenshots` branch is gone.) Baselines are accepted only from CI's `ci-screenshots` branch (`screenshots accept`), never from a local capture; the first set is accepted from the first green `windows-latest` run whose code captures at `SampleData.Now`, after the review-fix branches merge, so this change commits none | Commit the current `ci-screenshots` pictures now; capture locally | Fonts, scaling and time zone differ per machine and Linux cannot run the WPF capture; the current `ci-screenshots` commit (of 261ab46) predates the fixed clock, so its times and dates ("12:18 AM", sequences dated from the capture day) would fail every such screen, and parallel branches still change screens. |
|
||||
| 2026-10-12 | `--capture` runs on a fixed clock (`SampleData.Now`, 2026-10-02 10:18 UTC; `AppClock.Today` frozen for screens laid out around today), English formats and `Motion` off (indeterminate bars stand still) | Mask the changing regions per screen in the diff | The same code then draws the same pixels on any day, so the diff needs no masks; only a measured latency and the last sync time remain, a few dozen pixels. |
|
||||
| 2026-10-12 | Media Foundation playback (BRIEF §20.2) is checked by separate tests: MediaPlayer opens the software H.264 output (and the hardware HEVC Main10 output where an encoder and an HEVC decoder exist), skipped with the reason where Windows Media Player is missing or WPF reports it unusable; a Media Foundation source reader decodes the first frame to the encoded picture on every Windows with Media Foundation | One test that logs and passes without Windows Media Player; playback only in the manual release test | Windows Server runners may lack wmp.dll; a skip shows that the MediaPlayer layer did not run, and the source reader still proves the file decodes. |
|
||||
| 2026-10-12 | CI `installer` job on a clean `windows-latest`: packs 1.0.0 and 1.0.1 installers from the published programs and checks silent install, run, the Add/Remove Programs entry, shortcuts and the .chronos file type, upgrade in place (a file only in 1.0.0 must go, user data kept), the Uploader-only installer, uninstall and the documented exit codes (`.github/scripts/installer-test.ps1`) | Leave it to the manual release test | BRIEF §18 behaviour can only be proven by running the real installers; a clean runner is the closest thing to a user's PC. |
|
||||
@@ -624,3 +624,5 @@ One line per decision: date · decision · alternative · reason.
|
||||
| 2026-11-04 | In a container, the first save of the settings removes `HttpPort` and `HttpsPort` from `server.json` (also when nothing else changed); the start-up warning says so. | Remove them at load | Load only reads; the panel cannot edit locked ports, so without this the warning came back at every start. |
|
||||
| 2026-11-04 | Host networking: the guide, README and compose comments say the port mappings do nothing there, the server listens on the host's 8080/8443 and `CHRONOS_HTTP_PORT` / `CHRONOS_HTTPS_PORT` move it off ports another service uses (public ports empty). No template entries for them. | Advanced template entries *Listening HTTP/HTTPS port* | On Bridge such an entry would unmap the template's ports; Host users add a variable, which Unraid offers on every container. |
|
||||
| 2026-11-04 | `ChronosAddress` refuses a link-local IPv6 address with a zone index (`fe80::1%12`): *Invalid address*. | Keep the zone as `%25` | `Uri` and the connection would drop the zone, failing later with a less clear error; the LAN address or name works. |
|
||||
| 2026-11-04 | Screenshot baselines are captured on the development PC (Europe/Rome time zone) from a Release build and committed to `tests/visual/baselines` (156 screens, owner review 3, R2); CI no longer pushes its screenshots to a `ci-screenshots` branch, the branch is deleted, and the `windows` job's token is read-only. Until a Windows runner is registered (on that PC, or a new set accepted from the runner's PC), `screenshots diff` runs locally before a pull request that changes a screen. | Keep accepting from `ci-screenshots`; merge that branch | The owner chose it: no Windows runner exists, so CI never produced a set taken at `SampleData.Now`, and the old `ci-screenshots` commit predates the fixed clock; a branch that only CI writes and that never merges is noise once baselines live in `main`. |
|
||||
| 2026-11-04 | While `--capture` freezes `AppClock`, what the screens measure on the machine is shown as fixed sample values: free space 1.2 TB (`ArchiveLocations.FreeSpace` and the import plan's totals), a server latency of 12 ms, and the last sync comparison at the frozen moment taking 0.4 s. | Raise the diff tolerance; leave them measured | Measured, they moved the Server screens by 0.13–0.15 % (the latency's width shifts the rest of the status line) and the Import screens to the 0.05 % limit (the PC's free space), so baselines failed at random; a larger tolerance would hide real changes. |
|
||||
+4
-4
@@ -131,10 +131,10 @@ Phase 8 gate:
|
||||
7. Visibility: make the `BalboSoft` organisation (and its packages) public, or publish to a public `RELEASES_REPO`, so
|
||||
that people without an account can download releases, get update notices and pull the image.
|
||||
8. Windows runner: register an act_runner in host mode on a Windows PC (.NET SDK, Git for Windows, PowerShell 7) and
|
||||
set the repository variable `WINDOWS_RUNNER` to its label. Then arm the screenshot diff: from the `ci-screenshots`
|
||||
commit of the first green `windows` job of a pull request, run `dotnet run --project src/Chronos.Tools --
|
||||
screenshots accept <dir>` and commit the PNGs to `tests/visual/baselines` (its README says how). From then on a
|
||||
visual change, or a screen without a baseline, fails the `windows` job.
|
||||
set the repository variable `WINDOWS_RUNNER` to its label. The screenshot baselines in `tests/visual/baselines`
|
||||
were captured on the development PC (2026-11-04): register the runner on that PC, or accept a new set captured on
|
||||
the runner's PC (its README says how). From then on a visual change, or a screen without a baseline, fails the
|
||||
`windows` job.
|
||||
9. On Windows: install the latest pre-release's setup, upgrade over the previous version, uninstall (with and without
|
||||
user data), silent mode.
|
||||
10. Unraid: install the template as a user template (README › Server image, Compose and Unraid) with the official
|
||||
|
||||
@@ -74,7 +74,7 @@
|
||||
| 3 | R6 library on the panel, photo delete and trash (migration 0008), R3 web upload | done 2026-10-27, released as `v0.1.0-rc.5` (one adversarial review round and two fix rounds, 40 findings fixed; strings in all 38 languages; tried by hand in a browser): BRIEF §5, §7, §12.2, §12.5, §14.3, §14.4, §14.5, §14.8, §24; 24 DECISIONS rows dated 2026-10-26 (R6 photo trash layout, deletion journal and hidden pending record, restore journal and `.restoring` staging under the entry lease, restore rules and kept reasons, tombstones in sidecar and index, never-hashed photos hashed at deletion with the missing ones left without a tombstone as a known limitation, positions and follow-ups, Empty only as an explicit job with a fingerprint and never scheduled, trash API and audit, photo-delete permission and body limit, bulk limits of 1,000 a request and the verify fix, the upload tombstone checks and the explicit restore flag, sync tombstones and aliases, hidden dot files refused, Library navigation and the on-demand upload module, facets and covers, panel confirmations, CSV and grids, live refresh without job kinds, static files `no-cache` with ETag; R3 in-house SHA-256 worker, fail-closed self-test, no folder upload and `server/info` extensions, upload pacing and capture time, Cancel deletes and Close keeps); CHANGELOG [Unreleased] with the migration 0008 upgrade note and the known limitations; STATUS 8.3 | `9aa818ed` |
|
||||
| 4a | R7 Reorganize after import | done 2026-10-27, released as `v0.1.0-rc.6` (one adversarial review round and six fix rounds; strings in all 38 languages): BRIEF §5, §7, §7.1, §12.2, §12.5, §12.8, §13, §14.3, §14.5, §14.8, §24; 25 DECISIONS rows dated 2026-10-26 (R7 one naming rule `FrameNaming` for import, upload and Reorganize; what Reorganize renames and what stays whole; unique names in index order and XMP companions; the two-phase file journal; step order and checks under the leases; the fingerprint pinning file renames by digest; sequences still receiving photos; a sequence left inside a moving folder taken along; Reorganize as the `move` job with held plans; the whole-plan tally and errors; `sequenceChanged` `reorganized` and the editor reload; exports rebased with their folder; the rows of a sequence that took the old folder never follow; writers under the lease and render filing's 503; a folder another sequence holds refused by every writer; proxy lease batches; case-only and stable folders; template rules; rules held only to templates given anew; the server's plan cache; the reorganize API; panel selection and dialog; the desktop dialog and the Settings toast; render leftovers removed only where the sequence is; originals restored only where the sequence is), three earlier rows marked superseded; CHANGELOG [0.1.0-rc.6] with the template upgrade note and the known limitations; STATUS 8.3 | `7e4a3b48` |
|
||||
| 4b | R7 mass conversion | done 2026-11-02, released as `v0.1.0-rc.7` (one adversarial review round, 42 findings, and two fix rounds; strings in all 38 languages): BRIEF §5, §7, §8.1, §8.3, §8.7, §9, §12.2, §12.4, §12.5, §13, §14.3, §14.4, §14.5, §14.8, §14.9, §24; 26 DECISIONS rows dated 2026-10-26 (R7 conversion after import, import still byte for byte; Replace or New sequence at every run, never remembered; targets and the scene-referred archival DNG; the conversion's decoder order, managed first and no 16-bit file from an 8-bit RAW development; the TIFF reader's refusals; colour profiles carried, converted or refused; the converted files' Exif; a dry run that probes what it promises; exactly the confirmed photos, by digest and ids; the two-stage, resumable job; the purge of staging and journals; free space measured where the conversion writes; no conversion of the same sequences twice; New sequence holding the converted copies alone, saying what it lacks; the Replace swap; the replace journal decided by content; Undo by the job's own entries; replaced entries weighed against the archive on disk; every last copy named before the typed confirmation; sync aliases as equivalence classes; link by content, proxies and downloads following them; the ingest taking a replaced original as present; the plan cache shared with Reorganize; the convert API; the `convert` job kind; failure sentences by cause), four earlier rows marked superseded in part; CHANGELOG [0.1.0-rc.7] with the upgrade note and the known limitations; STATUS 8.3 | `efa87f68` |
|
||||
| 5a | R8 workspace and projects with a local home (migration 0009) | done 2026-11-03, to be released as `v0.1.0-rc.8` (one adversarial review round, 55 findings, and five fix rounds; strings in en and it, the 36 other languages still to translate): BRIEF §4.4, §5, §7, §12.2, §12.3, §12.6, §12.8, §14.5, §14.6, §24; 46 DECISIONS rows dated 2026-11-03 (R8 projects and versions in the index by migration 0009; the sidecars as the truth; the portable form with positions parked by photo and canonical text; placing by photo; unknown members kept; a newer settings format read only; project file format 2; the 64 MiB limits; Main mirroring the settings and `project.json`; the Main catch-up merge; a mirror never written over settings it has not taken in; deletion from the trash read first, late versions moved beside it; lost and behind records; one Main; push rules; `IProjectHome`; the workspace folder and its write order; versions set aside and pruned; conflicts and Save both naming; media learning names; the frames stamp; Gone and Damaged states; newer and damaged copies; Edit opening workspace projects; editor saves; sync; Kept versions; Remove local copy; Delete project; the workspace copy job and its cancel clean-up; renders with project and version; `.chronos` files; the picker; Settings › Workspace; texts; `IWorkspaceUi`; leases), five earlier rows marked superseded in part; CHANGELOG [0.1.0-rc.8] with the migration 0009 upgrade note and the known limitations; STATUS 8.3 | |
|
||||
| 5a | R8 workspace and projects with a local home (migration 0009) | done 2026-11-03, released as `v0.1.0-rc.8` on 2026-11-04 (one adversarial review round, 55 findings, and five fix rounds; strings in en and it, the 36 other languages still to translate): BRIEF §4.4, §5, §7, §12.2, §12.3, §12.6, §12.8, §14.5, §14.6, §24; 46 DECISIONS rows dated 2026-11-03 (R8 projects and versions in the index by migration 0009; the sidecars as the truth; the portable form with positions parked by photo and canonical text; placing by photo; unknown members kept; a newer settings format read only; project file format 2; the 64 MiB limits; Main mirroring the settings and `project.json`; the Main catch-up merge; a mirror never written over settings it has not taken in; deletion from the trash read first, late versions moved beside it; lost and behind records; one Main; push rules; `IProjectHome`; the workspace folder and its write order; versions set aside and pruned; conflicts and Save both naming; media learning names; the frames stamp; Gone and Damaged states; newer and damaged copies; Edit opening workspace projects; editor saves; sync; Kept versions; Remove local copy; Delete project; the workspace copy job and its cancel clean-up; renders with project and version; `.chronos` files; the picker; Settings › Workspace; texts; `IWorkspaceUi`; leases), five earlier rows marked superseded in part; CHANGELOG [0.1.0-rc.8] with the migration 0009 upgrade note and the known limitations; STATUS 8.3 | `9b24cf74` |
|
||||
| 5b | R8 server home | todo | |
|
||||
| 5c | R8 originals, local render, clean-up, Workspace settings | todo | |
|
||||
|
||||
|
||||
@@ -0,0 +1,47 @@
|
||||
# Owner review 3 (2026-11-04)
|
||||
|
||||
## Owner's text (verbatim, Italian)
|
||||
|
||||
> Ottimo! Ecco altre cose da sistemare:
|
||||
> * ho notato un problema di connessione tra l'uploader e il server. Il server non è configurato sulle porte
|
||||
> preimpostate, potrebbe essere questo il problema? Nelle impostazioni del server vedo che le porte indicate sono
|
||||
> sbagliate
|
||||
> * fai finire il branch degli screen nel branch principale
|
||||
> * elimina i branch vecchi o uniti se ritieni che non servono
|
||||
>
|
||||
> Inoltre verifica lo stato dell'applicazione e delle modifiche in corso, assicurandoti che sia stato tutto fatto e
|
||||
> pubblica la prima release ufficiale su Gitea.
|
||||
>
|
||||
> Alla fine individua il miglior modello di business per questa applicazione, come venderlo, a che prezzo, oppure
|
||||
> integrare la pubblicità o la condivisione di banda, mostrandomi in un elenco di vari modi di monetizzazione, il loro
|
||||
> guadagno previsto, la soddisfazione dell'utente e altri parametri che mi permettano di decidere qual è il miglior
|
||||
> modo di monetizzare questa applicazione, dicendomi anche quale implementeresti tu.
|
||||
|
||||
Two screenshots came with it: the Unraid template (repository `chronos-server:nightly`, network Bridge, host port 8087
|
||||
→ container 8080, host 8444 → container 8443, Public HTTPS port 8444) and the panel's Settings › Network and TLS
|
||||
(HTTP port 8080, HTTPS port 8443).
|
||||
|
||||
## Interpretation
|
||||
|
||||
| Id | Request | Working interpretation |
|
||||
|---|---|---|
|
||||
| R1 | Uploader cannot connect; the panel shows the wrong ports | The panel showed the ports the server listens on inside the container (8080/8443), not the host ports clients must use (8087/8444). The public HTTP port had no template entry, both clients turned a bare host into `https://host:443`, and on the owner's host 8443 is another service (it redirects to its sign-in page). Fix: public ports become panel settings (locked by `CHRONOS_PUBLIC_HTTP(S)_PORT`), the listening ports are read-only in a container, the panel shows the client address with a Copy button, the template gains Public HTTP port, both clients default to 8443 when no scheme and no port are typed, and an address that answers as another service gives a clear "not a Chronos server" error and is never offered for certificate trust. Bridge networking keeps LAN discovery inside Docker: the tooltip and the guide say so. |
|
||||
| R2 | The screenshots branch into `main` | `ci-screenshots` held screenshots taken on CI. The owner chose to capture them again on the development PC and commit them as `tests/visual/baselines` on `main`, then delete the branch. |
|
||||
| R3 | Delete old or merged branches | Old worktrees removed, local branches archived under `refs/archive/<name>` (recoverable), merged remote branches deleted. Kept: `main` and the branches of work not merged yet (phase 5b). |
|
||||
| R4 | Check the state and publish the first official release | The owner chose to finish everything first (owner review 2 phases 5b and 5c, owner review 1 phases 4–6, each with its release candidate), then publish `v1.0.0` as the first stable release. |
|
||||
| R5 | Business model | A comparison of monetization models (sales, prices, subscriptions, ads, bandwidth sharing, …) with expected revenue, user satisfaction and the other criteria, plus a recommendation. Delivered in the conversation; no code. |
|
||||
|
||||
## Questions and answers
|
||||
|
||||
| Question | Answer |
|
||||
|---|---|
|
||||
| What should the first official release contain? | Finish everything first: phases 5b and 5c, then owner review 1 phases 4–6, each with its release candidate; then `v1.0.0`. |
|
||||
| The screenshots branch: merge it, or capture again? | Capture again on this PC and commit them as `tests/visual/baselines`; then delete `ci-screenshots`. |
|
||||
|
||||
## Delivery plan
|
||||
|
||||
| Phase | Content | State | Commit |
|
||||
|---|---|---|---|
|
||||
| 1 | R1 ports, R2 baselines | in progress, to be released as `v0.1.0-rc.9` | |
|
||||
| 2 | R4 owner review 2 phases 5b and 5c | todo | |
|
||||
| 3 | R4 owner review 1 phases 4–6, then `v1.0.0` | todo | |
|
||||
Reference in new issue
Block a user