Merge branch 'review2-p1-fix-release' into claude/owner-review-2-p1
This commit is contained in:
commit
5dfd5f93cf
8 files changed
+129
-40
No files matched your search
+16
-12
@@ -1248,7 +1248,8 @@ third-party actions at all (amended 2026-10-23, R3).
|
||||
### 19.3 `release.yml` (tag `v*`, or manual re-publish of an existing tag; amended 2026-10-23, R3; amended 2026-10-26, R1)
|
||||
|
||||
Job `release`, in the SDK container: the version from the tag
|
||||
(`vMAJOR.MINOR.PATCH[-PRERELEASE]`) passed as `-p:ChronosVersion`, with
|
||||
(`vMAJOR.MINOR.PATCH[-PRERELEASE]`, SemVer 2.0 as `release-channels` reads it, checked
|
||||
before anything is built) passed as `-p:ChronosVersion`, with
|
||||
`-p:ChronosReleasesUrl` (the releases repository's address, §18); build and the Linux
|
||||
tests; self-contained single-file win-x64 publish of App and Uploader (ReadyToRun), Server
|
||||
and Setup (ReadyToRun), cross-compiled on Linux; `Chronos.Tools pe-check` (GUI subsystem,
|
||||
@@ -1260,17 +1261,20 @@ installers `Chronos-Setup-<ver>.exe` (components Chronos, Uploader, Server) and
|
||||
(`Chronos.Tools changelog` from Conventional Commits) and `SHA256SUMS`; the Gitea release
|
||||
made by `Chronos.Tools gitea-release` (a draft first, every file uploaded and its size
|
||||
verified, then published). Then `Chronos.Tools release-channels` decides what the tag moves
|
||||
(amended 2026-10-26, R1): it reads the target repository's published releases
|
||||
(`releases?draft=false&limit=50`), stable and pre-releases alike, ignores drafts and tags
|
||||
that are not `v` + SemVer 2.0, always counts the tag itself, takes a release Gitea flags as
|
||||
a pre-release for one, and compares by SemVer 2.0 precedence (not Gitea's
|
||||
`releases/latest`, which is the most recently created release; equal precedence counts as
|
||||
highest). `latest` is true for the highest stable release and moves the releases
|
||||
repository's content (§19.4); `image_latest` is true for the highest stable release or,
|
||||
while no stable release exists, the highest pre-release, and moves `:latest`. Re-publishing
|
||||
an older tag, or a pre-release once a stable release exists, moves neither. Then job
|
||||
`image`, in the runner's default image with the docker CLI and the host's daemon: it builds
|
||||
`linux/amd64` only (arm64 would need QEMU on the host) and pushes
|
||||
(amended 2026-10-26, R1): it reads every page of the target repository's published releases
|
||||
(`releases?draft=false&limit=50&page=<n>` up to the first empty page, at most 100), stable
|
||||
and pre-releases alike, ignores drafts and tags that are not `v` + SemVer 2.0, always counts
|
||||
the tag itself, takes a release Gitea flags as a pre-release for one, and compares by
|
||||
SemVer 2.0 precedence (not Gitea's `releases/latest`, which is the most recently created
|
||||
release; equal precedence counts as highest). `latest` is true for the highest stable
|
||||
release and moves the releases repository's content (§19.4); `image_latest` is true for
|
||||
the highest stable release or, while no stable release exists, the highest pre-release,
|
||||
and moves `:latest`. Re-publishing an older tag, or a pre-release once a stable release
|
||||
exists, moves neither. When the channels cannot be decided (a page unreadable or not a
|
||||
list, or a tag older than `release-channels`, whose own `Chronos.Tools` lacks it) the tag
|
||||
moves neither, with a warning. Then job `image`, in the runner's default image with the
|
||||
docker CLI and the host's daemon: it builds `linux/amd64` only (arm64 would need QEMU on
|
||||
the host) and pushes
|
||||
`gitea.encke-hake.ts.net/balbosoft/chronos-server:<ver>`, plus `:latest` when `image_latest`
|
||||
is true. Pushing needs the repository secret `REGISTRY_TOKEN`, an access token of a user who
|
||||
can write the owner's packages (scope "package: read and write"): the workflow's own token
|
||||
|
||||
+6
-2
@@ -20,13 +20,17 @@ commits follow Conventional Commits (release notes are generated from them by `C
|
||||
- Server diagnostics: the environment report lists the archive, space and data volumes with their free space, file
|
||||
system and mount.
|
||||
- `Chronos.Tools release-channels`: which channels a release tag moves (`latest=`, `image_latest=`), by SemVer 2.0
|
||||
precedence among the published releases.
|
||||
precedence among the published releases (every page of Gitea's list, one `--releases` file per page).
|
||||
|
||||
### Changed
|
||||
- Server image: `:latest` now follows the highest stable release, or the highest pre-release while no stable release
|
||||
exists, so the Unraid template and the compose file find an image from the first pre-release on. The public
|
||||
releases repository still follows stable releases only, and re-publishing an older tag never moves either back.
|
||||
`:nightly` stays the nightly build of `main`, for testing only (owner review 2, R1).
|
||||
When the release workflow cannot decide (the releases list unreadable, or a tag older than `release-channels` such
|
||||
as `v0.1.0-rc.2` published again) it warns and moves neither, and still pushes the version's image. `:nightly`
|
||||
stays the nightly build of `main`, for testing only (owner review 2, R1).
|
||||
- Release workflow: the tag must be SemVer 2.0 without build metadata (no leading zeros such as `v01.2.0`, no empty
|
||||
identifiers); any other tag is refused before anything is built.
|
||||
- Desktop: About is the last page of Settings and the rail keeps Settings alone at the bottom. *Check for updates*
|
||||
and the Releases link are on Settings › Updates; the data folder and the diagnostics bundle are on Settings ›
|
||||
Advanced only (About's own copies of those buttons are gone) (owner review 2, R5).
|
||||
|
||||
+2
-1
@@ -429,7 +429,8 @@ One line per decision: date · decision · alternative · reason.
|
||||
| 2026-10-23 | Update check: the client reads the published stable releases and takes the highest version, because Gitea's `releases/latest` is the most recently created release (a re-published older tag or a backport would become it); a pre-release build (`0.1.0-rc.1`) is offered the final release of its own version, which it used to call "up to date" forever; a 404 is a failed check, because Gitea answers 404 for a repository the client may not see (the `BalboSoft` organisation is private today) and that used to read as "up to date". The release workflow picks `:latest` the same way. `gitea-release` checks every file's size before it publishes, and when it replaces the files of a release clients can already see it removes the old `SHA256SUMS` first and uploads the new one last. (R2, R3; independent review of this change.) | Trust `releases/latest`; leave the pre-release rule as it was | The first release is a pre-release: its testers must be told when 0.1.0 is out; a download checked against the checksums of another build would be refused. |
|
||||
| 2026-10-23 | Timed tests (bulk insert, JPEG and RAW decode, resampler, light analysis, metadata robustness, scroll smoke, and the lease renewal test's timer periods) take their budget from `TestTiming.Budget`, stretched by `CHRONOS_TEST_TIME_FACTOR` (at least 1, default 1); ci.yml and release.yml set 3, perf.yml nothing. On the owner's runner, which shares its CPU and disks with Gitea and the server's other containers, the 100k-frame SQLite bulk insert took 10–19 s against 15 s from one run to the next. (R3.) | Raise the budgets; move the timed tests to perf.yml | The budgets stay what a developer's PC must meet and the weekly performance gates measure them unstretched; a CI run fails on a real regression, not on a busy host. |
|
||||
| 2026-10-23 | The update check builds the release page (`<repository>/releases/tag/<tag>`) and the download links (`<repository>/releases/download/<tag>/<name>`) from `ChronosReleasesUrl` and takes only the tags, names and sizes from Gitea's answer: Gitea writes `html_url` and `browser_download_url` with its ROOT_URL, the owner's being `http://192.168.30.23:3000`, so the first release's links were plain http on a LAN address and the https-only check ignored the release. Without a repository address (tests) the answer's links are used as before. (R2, after the first release.) | Ask the owner to set ROOT_URL to the public https name | The build already names the address its users reach; the client then works whatever Gitea's ROOT_URL is, and a ROOT_URL change stays the owner's choice. |
|
||||
| 2026-10-26 | The server image's `:latest` follows the highest stable release, or the highest pre-release while no stable release exists; the releases repository's content and the in-app update check still follow stable releases only. `Chronos.Tools release-channels --tag <tag> --releases <file.json>` prints both answers (`latest=`, `image_latest=`) from Gitea's releases list (`releases?draft=false&limit=50`, saved by curl) by SemVer 2.0 precedence: drafts and tags that are not `v` + strict SemVer 2.0 are ignored, the tag itself always counts, a release Gitea flags `prerelease` counts as one whatever its tag, build metadata is ignored and equal precedence counts as highest; a body that is not a JSON array (a sign-in page, an API error) stops the release (exit 2). It replaces curl + grep + `sort -V` in release.yml and the 2026-10-23 rule "`:latest` only for the highest stable version". (Owner review 2, R1.) | Point the Unraid template and compose at `:nightly` or a pinned `:<ver>`; push `:latest` for every pre-release; keep `sort -V` over all releases | With only pre-releases published (v0.1.0-rc.1, rc.2) `:latest` never existed, so the template and compose found no image. Users should get the newest release, not the untested nightly build of `main`. A pre-release published after a stable one, or an older tag re-published, must not move `:latest`. `sort -V` ranks `1.0.0-rc.1` above `1.0.0`, so it cannot compare pre-releases with stable releases. |
|
||||
| 2026-10-26 | The server image's `:latest` follows the highest stable release, or the highest pre-release while no stable release exists; the releases repository's content and the in-app update check still follow stable releases only. `Chronos.Tools release-channels --tag <tag> --releases <page.json> […]` prints both answers (`latest=`, `image_latest=`) from every page of Gitea's releases list (`releases?draft=false&limit=50&page=<n>`, saved by curl, one `--releases` per page) by SemVer 2.0 precedence: drafts and tags that are not `v` + strict SemVer 2.0 are ignored, the tag itself always counts, a release Gitea flags `prerelease` counts as one whatever its tag, build metadata is ignored and equal precedence counts as highest; a body that is not a JSON array (a sign-in page, an API error) is refused (exit 2), and the tag then moves no channel (next row). It replaces curl + grep + `sort -V` in release.yml and the 2026-10-23 rule "`:latest` only for the highest stable version". (Owner review 2, R1.) | Point the Unraid template and compose at `:nightly` or a pinned `:<ver>`; push `:latest` for every pre-release; keep `sort -V` over all releases | With only pre-releases published (v0.1.0-rc.1, rc.2) `:latest` never existed, so the template and compose found no image. Users should get the newest release, not the untested nightly build of `main`. A pre-release published after a stable one, or an older tag re-published, must not move `:latest`. `sort -V` ranks `1.0.0-rc.1` above `1.0.0`, so it cannot compare pre-releases with stable releases. |
|
||||
| 2026-10-26 | release.yml decides the channels after publishing, from every page of the releases list (`page=1, 2, …` up to the first empty page, at most 100); when it cannot (a page unreadable or not a JSON array, more pages, or a tag older than `release-channels`, such as `v0.1.0-rc.1` and `rc.2`, whose `Chronos.Tools` is built from the tag and lacks the command) it warns and the tag moves neither the releases repository nor `:latest`, while the image job still pushes `:<ver>`. The Version step checks the tag with release-channels' SemVer 2.0 pattern without `+BUILD` (no leading zeros, no empty identifiers), so a tag the command would refuse stops before anything is built or published. (Owner review 2, R1; review of phase 1.) | Fail the step; build `Chronos.Tools` from the workflow's own commit for this command; read one page | The release is already public when the channels are decided: failing then loses the image as well, while moving no channel is always safe, and a second build for two old tags costs minutes. Pre-releases now share Gitea's 50-a-page list with stable releases, so one page could hide the only stable release and move `:latest` to a pre-release. |
|
||||
| 2026-10-26 | The admin panel's free space comes from an optional space path (`SpacePath` in `server.json`, `CHRONOS_SPACE_PATH`): the Unraid template maps the share's array view `/mnt/user0/Timelapse` read-only to `/space` (*Array view*) and sets *Space path* to `/space` (advanced); empty means the archive's volume, as before. The archive's own volume, where uploads land, is shown apart as *Write volume*. `ArchiveStatsDto` keeps `FreeBytes`/`CapacityBytes` as the shown volume's figures and gains optional `WriteFreeBytes`, `WriteCapacityBytes`, `FileSystem` and `UsesSpacePath`. (Owner review 2, R2.) | Sum the array disks (`/mnt/disk*`) mapped into the container; read Unraid's emhttp state files; call Unraid's API | The container sees only what is mapped: one read-only mount of the same share's array view gives the array's figures with no host access, no external process and no Unraid-specific code. Only the server builds the stats and only the admin panel reads them, so the new members break no client. |
|
||||
| 2026-10-26 | The file system type and mount of a folder come from `/proc/self/mountinfo` on Linux: the longest mount point that is the folder or one of its parents, of mounts stacked there the last listed, octal escapes (`\040`) decoded; elsewhere `DriveInfo.DriveFormat`. (Owner review 2, R2.) | `DriveInfo.DriveFormat` alone; `findmnt` or `stat -f` | `DriveFormat` calls a FUSE mount only "fuse", never `fuse.shfs`, which is what tells an Unraid share apart; external processes are not allowed at runtime. |
|
||||
| 2026-10-26 | A space path that is missing or cannot be measured falls back to the archive's volume with one warning: at start, and again only after it has been measured in between. (Owner review 2, R2.) | Refuse to start; warn on every request | The template's default (`/space`) without the mapping must not stop the server or flood the log. |
|
||||
|
||||
Reference in new issue
Block a user