diff --git a/docs/BRIEF.md b/docs/BRIEF.md index eddcddf9..c4233ed1 100644 --- a/docs/BRIEF.md +++ b/docs/BRIEF.md @@ -694,8 +694,10 @@ player smoke test on Windows CI. └────┴─────────────────────────────────────────────────────────────────────────────┘ ``` -- Left navigation rail (prototype pattern): full names, collapsible to icons (state saved), - badge counts (warnings, running jobs), hover tooltip with section description. +- Left navigation rail (prototype pattern): full names in 200 px, collapsible to 48 px of + icons with ≡ or Ctrl+B (state saved at once; a collapsed icon's tooltip names its section + before describing it; amended 2026-10-16, R1), badge counts (warnings, running jobs), + hover tooltip with section description. - Fluent theme, system/dark/light, system accent; density "comfortable"; 8 px grid; one typeface (Segoe UI Variable, system fallback for CJK/Arabic/etc.). - Window chrome custom (dark title bar), min size 1200×760; per-monitor DPI. @@ -993,7 +995,10 @@ Pages: Login · Dashboard · Users (table; create/edit/disable/reset/roles/quota (path, templates, proxy policy, scan/rebuild/verify, stats) · Jobs (queue/history/nodes, cancel/retry) · Settings (server name, ports, TLS mode + fingerprint, discovery, jobs: parallelism and priority queue, limits, language, retention) · Logs (tail, download) · About. Same UI rules: tooltips only, light/ -dark, localised via `/api/v1/i18n`, keyboard accessible. +dark, localised via `/api/v1/i18n`, keyboard accessible. The sidebar is 256 px and collapses +to its icons with ≡ or Ctrl+B like the desktop rail, the choice kept in the browser and the +links' tooltips then naming their page; on narrow screens it stays the top bar (amended +2026-10-16, R1). ### 14.9 Configuration and Docker @@ -1327,6 +1332,7 @@ questions asked and the answers; DECISIONS rows give the reasons. |---|---|---|---| | 2026-10-16 | Owner review 1, R4 | §8.1, §8.2 | DNG decodes through the managed decoder (WIC only through the Raw Image Extension, never DNG); a GoPro DNG is GPR only when VC-5; analyses and previews take an adequate embedded preview by choice, renders decode natively. | | 2026-10-16 | Owner review 1, R2 | §12.8, §14.6, §14.8, §14.9 | Jobs run one at a time; the parallelism is photos the running job processes at once; an optional priority queue by job kind pauses lower jobs and resumes them by itself; `TITANO_PARALLELISM` (former `TITANO_WORKERS`) and `TITANO_PRIORITY_QUEUE`. | +| 2026-10-16 | Owner review 1, R1 | §12.1, §14.8 | The rail is 200 px and collapses to 48 px of icons with ≡ or Ctrl+B, their tooltips naming the sections, saved at once; the admin panel's sidebar is 256 px and collapses the same way, kept in the browser. | ## Appendix A — `CLAUDE.md` content (create verbatim in Phase 0, keep updated) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 00bf8376..701b232c 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -182,6 +182,14 @@ commits follow Conventional Commits (release notes are generated from them by `T - the Jobs screen shows "8 photos at once", and a Priority queue chip while the queue is on; the admin dashboard shows the parallelism; - `Titano.Tools i18n prune` removes from the translations the keys English no longer has. +- Owner review 1 (2026-10-16, R1): the rail is 200 px wide, so section names fit in every language, and collapses to + icons with ≡ or Ctrl+B; collapsed, an icon's tooltip names its section. The choice is saved at once and survives + Settings › *Reset all…* and *Import…*. The admin panel's sidebar is 256 px and collapses to icons the same way (≡ or + Ctrl+B in any keyboard layout, kept in the browser). Beside the wider rail at the 1200 px minimum no action is cut + off in any language: the Jobs table, the Archive tree, the Import plan and result, the trusted certificates, the + cache folder, the editor's header (a server job's Cancel always stays), preview tools (a second line when needed) + and frame table share their width differently; headers, titles and cells that may be shortened end in an ellipsis + and show their text in their tooltip. ### Deprecated - `TITANO_WORKERS` and the `Workers` key of `server.json` set the parallelism (photos the running job processes at @@ -189,6 +197,7 @@ commits follow Conventional Commits (release notes are generated from them by `T ### Fixed - Owner review 1 (2026-10-16, `docs/requests/2026-10-15-owner-review-1.md`): + - the App test program could crash on exit after every test had passed (WPF's binding cleanup racing the process's end); - thumbnail and proxy jobs over several sequences failed after 10–20 minutes with "TimeSpan overflowed" and then stayed Running; their progress now counts frames, a stalled job shows no time left, and a job's end is always recorded (R10); diff --git a/docs/DECISIONS.md b/docs/DECISIONS.md index 056b0be9..b6264a1d 100644 --- a/docs/DECISIONS.md +++ b/docs/DECISIONS.md @@ -411,3 +411,5 @@ One line per decision: date · decision · alternative · reason. | 2026-10-16 | Desktop: the Jobs toolbar shows "8 photos at once" (Settings › Rendering › Parallelism) and a Priority queue chip while the queue is on, instead of "Workers n / m"; Settings › Rendering lists the 16 job kinds with a level dropdown only while the queue is on; the Jobs list orders the queue with the engine's `JobPriorityQueue.ClaimsBefore`. The Jobs, Settings and Admin mockups follow in phase 6 with the rest of the review. | Keep the workers readout | One job runs at a time, so a count of busy workers says nothing. | | 2026-10-16 | `AtomicFile` tries the rename over the target again for some 1 s (15 attempts, 10 ms × n) while another handle holds it: a sharing or lock violation, or Windows' "access denied" for an open file that is neither read-only nor a folder (those, like a missing file, fail at once). Sidecars, ingest journals, index snapshots and `project.json` are read whole and at once with `AtomicFile.ReadAllBytes`/`ReadAllText` (sharing read and delete, never a writer in place; above 2 GB an `IOException`, as `File.ReadAllBytes`). Windows refuses `MoveFileEx` over an open file even when the reader shares deletion. | Rename with POSIX semantics (`SetFileInformationByHandle`, Windows interop in Core); take the sequence lease for every sidecar read | Readers hold these files for milliseconds; a lease per read would queue thumbnail passes behind uploads, and Core stays free of Windows interop. Found when the faster passes of phase 2 made an upload's commit fail in the server tests. | | 2026-10-16 | `LeaseFile.TryCreate` treats "access denied" on creating a lease as the name of a lease just released while a reader still holds it (pending deletion on Windows, since readers share deletion) and tries again for some 130 ms (8 attempts, 1 ms doubling), as it already did for the create-or-check race. | Return "held" at once; stop sharing deletion in readers | Returning "held" makes the caller wait its whole poll back-off for a name free milliseconds later, and readers must never block a release or a takeover. A real permission problem still fails after the short retry. Found when the phase 2 test runs hit it in `MassRenameTests` under load. | +| 2026-10-16 | The rail is 200 px (`Width.Rail`, was 128 growing to 200 with the language's longest name) and collapses to the 48 px icons (`Width.RailCollapsed`) with ≡ or Ctrl+B, a window key binding gated like Ctrl+1…6 (not behind the first-run dialog; a held key toggles once). A collapsed icon's tooltip is "Name · description" (`Tooltips.Nav.Collapsed`, invariant) so the section is named without its label, while screen readers keep the name and, as help text, the description alone. The state is written the moment it changes, through `AppServices.SavePreferences` (the settings file and nothing else: no render node restart, no engine wake), and Settings reset and import keep it, as they keep the window. The admin panel's sidebar is 256 px (was 220) and collapses to 56 px of icons with its own ≡ or Ctrl+B (matched on the physical B key when that key types no letter a–z, as in Cyrillic, Greek, Hebrew or Arabic layouts; Latin layouts keep their own Ctrl shortcuts), the choice kept in the browser (`localStorage` `titano.admin.sidebar`, like the theme; a browser that refuses storage keeps it for the page), the tables fitting their columns again after each toggle and the links' names kept for screen readers; at 900 px and below it stays the top bar, which shows icons only already, and Ctrl+B stays the browser's. Beside the wider rail at the 1200 px minimum, in every shipped language: the Jobs table's Kind, Where and State became star columns (minimums 90, 80, 116; at most 140, 140, 170, so on wide windows Target takes the rest, as in Jobs.html) and Target and Progress give way first (84, 104), so the row actions fit; a cut kind, place or header shows whole in its tooltip, and the state's tooltip starts with the state, as the sync table's does (the explanations after it were reworded not to repeat it, and "waiting for a worker" became "waits for its turn"); the trusted certificates row's server column and the cache folder's path give way first; the editor's preview tools wrap to a second line (6 px apart) instead of losing Play and Full screen, the crop-result tool always beside Crop mask and disabled while the mask is off (with its reason), so turning the mask on never moves the tools; the editor header gives the server job and its Cancel their own column, the title and the summary giving way first; the Archive tree keeps a year's label and lets its figures trim; the Import session rows, Show plan and the result line fit; the frame table's Time column holds every language's widest time and its header names trim with the name in the tooltip, header and rows sharing the actions column. Cells that can be cut repeat their text in their tooltip (Library list, Jobs, sync state, Settings encoder table and adapter, priority queue rows; `EmptyToNullConverter` so an empty cell shows none). Tests check, in all 38 languages at 1200 px: the Jobs row buttons, Settings' Clear and Forget, the Archive years, the Import rows and result, the frame table's times, the editor's tools and a server job's Cancel. (Owner review 1, R1.) | A width that follows the language; save the rail state at exit; keep the admin sidebar state per user on the server | The owner fixed 200 and 256 px so names fit in every language without a jumping rail; a crash or a forced shutdown no longer loses the choice; the server keeps no presentation state per user and the theme already lives in the browser. Found by the phase's review rounds: buttons and labels cut at 1200 px in some languages (Jobs row actions, Forget, Clear, the preview's Play, a remote job's Cancel, Merge, a year in the Archive tree), Ctrl+B behind the first-run dialog, and admin tables that kept their old fit. | +| 2026-10-16 | The App test program shuts the shared WPF dispatcher down in order (`WpfApplication.Shutdown`: `InvokeShutdown`, then a join of up to 10 s) after the runner finishes, instead of letting the process end under its background thread. (Owner review 1, R1.) | Leave the background STA thread to die with the process | The binding engine's cleanup then ran against a half-torn-down engine and crashed the exit (code 127) after every test had passed; the tests that walk 38 languages made it likely. | diff --git a/docs/STATUS.md b/docs/STATUS.md index f98ee2f3..4c7a13b7 100644 --- a/docs/STATUS.md +++ b/docs/STATUS.md @@ -13,7 +13,7 @@ Phase plan: docs/BRIEF.md §22. Windows behaviour is verified on CI (`windows-la | 6 Engine, encoding, editor | Done: render pipeline, MP4/AVI/GIF/APNG/image sequences, Media Foundation H.264/HEVC/AV1 with managed fallbacks; the sequence editor (Frames, Exposure, Camera, Motion and Export tabs, preview tools, section charts, curve editor, undo/redo, batch export) for local and server sequences. Gate: self-test suite green; the in-house inspector validates the containers the tests write; the encoder in use is logged. Playback: MediaPlayer opens the Media Foundation output and a source reader decodes its first frame (Windows tests). The pixel diff of every `--capture` screen against `tests/visual/baselines` (`screenshots diff`, BRIEF §20.2) is wired into CI but not armed: no baseline is committed yet, so the step compares nothing and only warns until the first baselines are accepted from `ci-screenshots` (Next steps). | | 7 Server, sync, uploader | Done: server (API, auth, uploads, jobs, render nodes, events, admin panel with light and dark themes, Windows service), Uploader, client sync (sync table, conflicts with *Save both*, proxies kept offline, metered pause), server sequences edited with proxies and rendered where the originals are, this PC as a render node. Gate covered in-process: a sequence uploaded from one PC downloads identically on another, interrupted uploads and downloads resume, server events update a PC, renders run on a node and on the server's managed fallback, jobs resume after a restart, sign-ins and administrative actions are audited. The run with two real PCs and the Uploader against the Docker server is part of the release test. | | 8 Release readiness | Release pipeline end to end (installers, portable and server zips, SHA256SUMS, release notes, optional signing, multi-arch GHCR image, public releases repository content), update check with verified download, scrubbed diagnostics bundles (desktop and server), performance gates, 38 cultures (`en`, `it` and 36 machine translations with glossaries and independent reviews), RTL pass (`ar`, `he`: mirrored windows, left-to-right islands for media, charts, numbers and paths; any right-to-left culture added later follows), accessibility pass (names, live regions, keyboard paths for charts and the curve editor). CI installs the packed installers silently on a clean `windows-latest` runner, runs the installed programs, upgrades in place and uninstalls (files, Add/Remove Programs, shortcuts, file type, user data kept, exit codes). Pending: a tagged pre-release published from CI, the interactive install on a real PC, Unraid template validation on a real server. | -| 8.1 Owner review 1 | In progress (request, answers and plan: `docs/requests/2026-10-15-owner-review-1.md`). Phase 1 done: stalled thumbnail and proxy jobs no longer fail and stay Running (frame-counted progress, bounded time left, final state always written); the editor's cancelled decodes stay in their tasks (no debugger stops in `WicDecoderProvider.cs`); WIC decodes RAW only through the Raw Image Extension and never DNG; GoPro DNGs converted by Adobe software are DNGs, developed natively for videos, read through their embedded preview for analyses and previews, and reclassified in existing archives by the next light analysis. Phase 2 done: jobs run one at a time on the desktop and the server; Parallelism is how many photos the running job processes at once (thumbnail and proxy passes, tier probes, deep analysis, render decodes); pausing the running job starts the next; an optional priority queue by job kind (Settings › Rendering, admin panel › Settings › Jobs, `TITANO_PRIORITY_QUEUE`) pauses lower jobs and resumes them by themselves; `TITANO_PARALLELISM` replaces `TITANO_WORKERS`. Next: phase 3, wider collapsible rail and the Edit section as a guided path. | +| 8.1 Owner review 1 | In progress (request, answers and plan: `docs/requests/2026-10-15-owner-review-1.md`). Phase 1 done: stalled thumbnail and proxy jobs no longer fail and stay Running (frame-counted progress, bounded time left, final state always written); the editor's cancelled decodes stay in their tasks (no debugger stops in `WicDecoderProvider.cs`); WIC decodes RAW only through the Raw Image Extension and never DNG; GoPro DNGs converted by Adobe software are DNGs, developed natively for videos, read through their embedded preview for analyses and previews, and reclassified in existing archives by the next light analysis. Phase 2 done: jobs run one at a time on the desktop and the server; Parallelism is how many photos the running job processes at once (thumbnail and proxy passes, tier probes, deep analysis, render decodes); pausing the running job starts the next; an optional priority queue by job kind (Settings › Rendering, admin panel › Settings › Jobs, `TITANO_PRIORITY_QUEUE`) pauses lower jobs and resumes them by themselves; `TITANO_PARALLELISM` replaces `TITANO_WORKERS`. Phase 3a done: the rail is 200 px and collapses to icons with ≡ or Ctrl+B (tooltips then name the sections, the choice saved at once); the admin panel's sidebar is 256 px and collapses the same way. Next: phase 3b, the Edit section as a guided path with a sequence picker. | | 9 Monetization | Not started: requires explicit approval (§22). | ## Verification (2026-10-12) diff --git a/docs/requests/2026-10-15-owner-review-1.md b/docs/requests/2026-10-15-owner-review-1.md index e077400d..d8aeb994 100644 --- a/docs/requests/2026-10-15-owner-review-1.md +++ b/docs/requests/2026-10-15-owner-review-1.md @@ -57,9 +57,10 @@ | Phase | Content | State | Commit | |---|---|---|---| -| 1 | Bugs: R10 job throughput/ETA and stuck jobs; R4 cancellation boundary, WIC decoder truth, GoPro DNG classification, decode policy (preview for analysis, native for renders) | done 2026-10-16: BRIEF §8.1, §8.2, §24; five DECISIONS rows dated 2026-10-16; all test suites, i18n check, format, package guard and xaml-lint green | phase 1 commit | -| 2 | R2 jobs one at a time, Parallelism = photos at once, priority queue with automatic pause/resume (desktop + server) | done 2026-10-16: BRIEF §12.8, §14.6, §14.8, §14.9, §24; nine DECISIONS rows dated 2026-10-16 (engine, priority queue, parallel passes and decode budget, sequential IO jobs, server settings, `i18n prune`, Jobs toolbar, atomic writes that wait for a reader, leases taken after a reader lets go); three adversarial review rounds before the commit; levels per kind rather than an ordered list (DECISIONS) | phase 2 commit | -| 3 | R1 rail and admin sidebar; R7 Edit section, picker, guided path | todo | | +| 1 | Bugs: R10 job throughput/ETA and stuck jobs; R4 cancellation boundary, WIC decoder truth, GoPro DNG classification, decode policy (preview for analysis, native for renders) | done 2026-10-16: BRIEF §8.1, §8.2, §24; five DECISIONS rows dated 2026-10-16; all test suites, i18n check, format, package guard and xaml-lint green | `34d0305` | +| 2 | R2 jobs one at a time, Parallelism = photos at once, priority queue with automatic pause/resume (desktop + server) | done 2026-10-16: BRIEF §12.8, §14.6, §14.8, §14.9, §24; nine DECISIONS rows dated 2026-10-16 (engine, priority queue, parallel passes and decode budget, sequential IO jobs, server settings, `i18n prune`, Jobs toolbar, atomic writes that wait for a reader, leases taken after a reader lets go); five adversarial review rounds before the commit; levels per kind rather than an ordered list (DECISIONS) | `43b6871` | +| 3a | R1 rail 200 px and admin sidebar 256 px, both collapsing to icons with ≡ or Ctrl+B | done 2026-10-16: BRIEF §12.1, §14.8, §24; one DECISIONS row; DESIGN and every mockup with a rail or the admin sidebar; the two new admin tooltips in all 38 languages. Six adversarial review rounds (desktop and web, each finding verified; the last found only two wording slips, fixed): buttons and labels cut at 1200 px beside the wider rail in some languages (Jobs row actions, Forget, Clear, the preview's Play, a remote job's Cancel, Merge, a year in the Archive tree), Ctrl+B behind the first-run dialog and on non-Latin keyboards, and admin tables not re-fitted after a toggle, all fixed; some older cut texts found on the way got tooltips; tests now check those rows in all 38 languages. Phase 3 lands as two commits because R1 and R7 edit the same shell files and R1 was finished and verified first | phase 3a commit | +| 3b | R7 Edit section ("Sequenza" → "Modifica"), sequence picker, guided path from analysis to export | todo | | | 4 | R5 visual crop, proportions win; R6 transforms, straighten, colour filters | todo | | | 5 | R3 export panel and Render menu; R8 export options; R9 videos library (desktop, server API, admin page, copy folder, trash) | todo | | | 6 | Docker/Unraid/deploy docs, BRIEF §24 amendments, full verification | todo | | diff --git a/docs/ui/DESIGN.md b/docs/ui/DESIGN.md index e4862668..2ad79ef2 100644 --- a/docs/ui/DESIGN.md +++ b/docs/ui/DESIGN.md @@ -42,7 +42,7 @@ Layout must survive +40 % text width (de, fi): no fixed-width labels, `MinWidth` Spacing scale 4 · 8 · 12 · 16 · 20 (`Thickness` keys `Space.1`…`Space.5`). Radii: 6 controls · 8 cards/panels · 12 pills · 12 modal dialogs. Controls 32 px tall, 44 px minimum width, 12 px horizontal padding; compact row buttons 26–28 px. -Rail 128 px (collapses to 48 px icons); title bar 34; job bar 40; toolbar 56; status bar 30; +Rail 200 px (collapses to 48 px icons with ≡ or Ctrl+B, the tooltips then naming each section; the choice is kept; owner review 1); title bar 34; job bar 40; toolbar 56; status bar 30; table rows 36–40 (52 in the web admin); side panels 320 px; settings section list 200 px. Label column left of controls: 116 px in panels, 180 px in Settings. diff --git a/docs/ui/mockups/Admin.html b/docs/ui/mockups/Admin.html index fe0ac6f5..e78102b6 100644 --- a/docs/ui/mockups/Admin.html +++ b/docs/ui/mockups/Admin.html @@ -10,7 +10,7 @@ body{margin:0;font-family:"Segoe UI Variable","Segoe UI",system-ui,sans-serif;ba a{color:#0067c0}a:hover{color:#004c8c}
-