feat(windows): add shell launcher, taskbar progress and app paths

ShellLauncher opens only http(s) and ms-windows-store URLs and reveals files
(SHOpenFolderAndSelectItems) or folders ("explore") on an STA. TaskbarProgress
wraps ITaskbarList3 and returns false for null or stale windows. KnownFolders
reads LocalAppData/Pictures via SHGetKnownFolderPath. AppPaths resolves the
data root (%LOCALAPPDATA%\Titano or .\data in portable mode) and refuses to
create it inside a OneDrive sync root (environment variables and
HKCU\Software\Microsoft\OneDrive\Accounts\*\UserFolder).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012iLMBNwBE2GnphAsu4cjaC
This commit is contained in:
Claude committed 2026-10-02 09:46:10 +00:00
1 parent 0e6c15cb13
commit 2b37f486e2
8 files changed
+508

No files matched your search

@@ -0,0 +1,75 @@
using Titano.Core.Windows.Shell;
using Titano.Testing;
namespace Titano.Core.Windows.Tests.Shell;
public sealed class AppPathsTests(TestContext context)
{
[Test]
public void PortableMarkerKeepsDataNextToTheExecutable()
{
var app = context.CreateTempDirectory("app");
var local = context.CreateTempDirectory("local");
File.WriteAllText(Path.Combine(app, PortableMode.MarkerFileName), "");
var paths = AppPaths.Resolve(app, local, []);
Assert.True(paths.IsPortable);
Assert.Equal(Path.Combine(app, "data"), paths.DataRoot);
Assert.Equal(Path.Combine(app, "data", "titano.db"), paths.DatabasePath);
Assert.False(paths.IsInSyncedFolder);
paths.CreateDirectories();
Assert.True(Directory.Exists(paths.LogsDirectory));
Assert.True(Directory.Exists(paths.CacheDirectory));
Assert.True(Directory.Exists(paths.ThumbnailsDirectory));
}
[Test]
public void InstalledModeUsesLocalAppData()
{
var app = context.CreateTempDirectory("app");
var local = context.CreateTempDirectory("local");
var paths = AppPaths.Resolve(app, local, []);
Assert.False(paths.IsPortable);
Assert.Equal(Path.Combine(local, "Titano"), paths.DataRoot);
Assert.Equal(Path.Combine(local, "Titano", "titano.db"), paths.DatabasePath);
}
[Test]
public void DataInsideOneDriveIsReportedAndRefused()
{
var oneDrive = context.CreateTempDirectory("onedrive");
var app = Directory.CreateDirectory(Path.Combine(oneDrive, "Tools", "Titano")).FullName;
File.WriteAllText(Path.Combine(app, PortableMode.MarkerFileName), "");
var paths = AppPaths.Resolve(app, context.CreateTempDirectory("local"), [oneDrive]);
Assert.True(paths.IsInSyncedFolder);
Assert.Equal<string?>(oneDrive, paths.SyncedFolder);
Assert.Throws<InvalidOperationException>(paths.CreateDirectories);
Assert.False(Directory.Exists(paths.DataRoot));
}
[Test]
public void SyncRootMatchingIsSegmentWise()
{
var root = Path.Combine(context.CreateTempDirectory(), "OneDrive");
Assert.True(OneDriveFolders.IsUnder(root, root));
Assert.True(OneDriveFolders.IsUnder(Path.Combine(root, "Pictures"), root + Path.DirectorySeparatorChar));
Assert.True(OneDriveFolders.IsUnder(Path.Combine(root, "x").ToUpperInvariant(), root));
Assert.False(OneDriveFolders.IsUnder(root + "Backup", root));
Assert.Null(OneDriveFolders.Containing(root + "Backup", [root]));
}
[Test]
[WindowsOnly]
public void ResolveChecksTheRealOneDriveRoots()
{
var app = context.CreateTempDirectory("app");
File.WriteAllText(Path.Combine(app, PortableMode.MarkerFileName), "");
var paths = AppPaths.Resolve(app, KnownFolders.LocalAppData);
Assert.True(paths.IsPortable);
Assert.Equal(OneDriveFolders.Containing(paths.DataRoot, OneDriveFolders.SyncRoots()), paths.SyncedFolder);
Assert.True(OneDriveFolders.SyncRoots().All(Path.IsPathFullyQualified));
}
}
@@ -0,0 +1,57 @@
using Titano.Core.Windows.Shell;
using Titano.Testing;
namespace Titano.Core.Windows.Tests.Shell;
public sealed class ShellTests(TestContext context)
{
private static readonly nint StaleWindow = 0x0BAD_F00D;
[Theory]
[Case("https://apps.microsoft.com/detail/9nctdw2w1bh8")]
[Case("http://nas.local:8443/admin")]
[Case("ms-windows-store://pdp/?ProductId=9NCTDW2W1BH8")]
public void WebAndStoreUrlsAreAllowed(string url) => Assert.True(ShellLauncher.IsAllowedUrl(url));
[Theory]
[Case("file:///C:/Windows/System32/cmd.exe")]
[Case(@"C:\Windows\System32\cmd.exe")]
[Case(@"\\server\share\run.bat")]
[Case("javascript:alert(1)")]
[Case("mailto:someone@example.com")]
[Case("relative/page.html")]
[Case("")]
public void OtherTargetsAreRejected(string url) => Assert.False(ShellLauncher.IsAllowedUrl(url));
[Test]
public void OpenUrlRefusesRejectedTargetsBeforeTouchingTheShell() =>
Assert.Throws<ArgumentException>(() => ShellLauncher.OpenUrl("file:///C:/Windows/System32/cmd.exe"));
[Test]
public void RevealOfAMissingPathReturnsFalse() =>
Assert.False(ShellLauncher.RevealInExplorer(Path.Combine(context.CreateTempDirectory(), "missing.jpg")));
[Test]
[WindowsOnly]
public void KnownFoldersMatchTheSystem()
{
Assert.Equal(
Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData).ToUpperInvariant(),
KnownFolders.LocalAppData.ToUpperInvariant());
Assert.True(Path.IsPathFullyQualified(KnownFolders.Pictures), KnownFolders.Pictures);
}
[Test]
[WindowsOnly]
public void TaskbarCallsWithoutAValidWindowReturnFalse()
{
using var taskbar = new TaskbarProgress();
Assert.False(taskbar.SetState(0, TaskbarProgressState.Normal));
Assert.False(taskbar.SetValue(0, 1, 2));
Assert.False(taskbar.SetState(StaleWindow, TaskbarProgressState.Indeterminate));
Assert.False(taskbar.SetValue(StaleWindow, 1, 2));
taskbar.Dispose();
Assert.False(taskbar.IsAvailable);
Assert.False(taskbar.SetValue(StaleWindow, 1, 2));
}
}