From 1be273d0e4d206ec89d9844ea3abef84822f9bf5 Mon Sep 17 00:00:00 2001 From: Alberto Balbo Date: Thu, 5 Nov 2026 04:11:02 +0100 Subject: [PATCH] fix: address the phase 5 review Video trash moves across volumes commit once the verified copy has its name and leave an undeletable source whole behind a .leftover marker that the next start settles; deletes rehash under the lease. Restores honour the names renders are writing, and encoders never overwrite an output. Routing floors at the stored settings' format, kindless stills read as stills, star trails restart per loop, and settings the encoder ignored become render warnings. The Videos section fits beside the player, plays downloaded server copies, names blocked videos and says why actions are off; the admin panel offers no download for sequences or missing files and names a filtered sequence from its record. Refs #21 Co-Authored-By: Claude Opus 5.5 --- docs/CHANGELOG.md | 8 + docs/DECISIONS.md | 5 + i18n/en/Admin.resx | 2 + i18n/en/Export.resx | 5 + i18n/en/Tooltips.resx | 4 +- i18n/en/Videos.resx | 3 +- i18n/it/Admin.it.resx | 2 + i18n/it/Export.it.resx | 5 + i18n/it/Tooltips.it.resx | 4 +- i18n/it/Videos.it.resx | 3 +- src/Chronos.App/Sections/VideosView.xaml | 85 ++++-- src/Chronos.App/Sections/VideosViewModel.cs | 97 ++++++- src/Chronos.App/Videos/VideoRows.cs | 56 +++- src/Chronos.App/Videos/VideoSources.cs | 25 +- .../MediaFoundationEncoderSession.cs | 43 ++- src/Chronos.Core/IO/AtomicFile.cs | 12 + src/Chronos.Core/Model/Entities.cs | 15 +- src/Chronos.Core/Render/OutputProgram.cs | 14 +- src/Chronos.Core/Render/RenderPipeline.cs | 44 +++- src/Chronos.Core/Video/Encoding.cs | 22 +- .../Video/Managed/ManagedSessions.cs | 3 +- src/Chronos.Data/Processing/ProcessingJobs.cs | 18 +- src/Chronos.Data/Processing/SequenceRender.cs | 6 +- .../Repositories/RenderRepository.cs | 13 +- src/Chronos.Data/Videos/IVideoLibrary.cs | 7 + .../Videos/VideoCopyJobHandler.cs | 15 +- src/Chronos.Data/Videos/VideoLibrary.cs | 6 + src/Chronos.Data/Videos/VideoTrash.cs | 248 +++++++++++++++--- src/Chronos.Data/Videos/VideosFolder.cs | 5 +- src/Chronos.Server/Admin/web/pages/videos.js | 38 ++- .../Videos/VideosSectionTests.cs | 124 ++++++++- .../Render/CapturingEncoderProvider.cs | 5 + .../Render/PlaybackRenderTests.cs | 14 + .../Render/RenderPipelineTests.cs | 15 ++ .../Videos/VideoLibraryTests.cs | 105 ++++++++ .../Videos/VideoRenderTests.cs | 8 +- .../Hosting/AdminVideosTests.cs | 14 +- .../Jobs/PlaybackRoutingTests.cs | 20 ++ 38 files changed, 958 insertions(+), 160 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 5b6b04bb..d9d31f25 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -65,6 +65,14 @@ commits follow Conventional Commits (release notes are generated from them by `C change, saying *This server's Chronos cannot read these settings; update it*. ### Fixed +- Export and Videos, found by the phase's review before any release had them: a video deleted to the trash or restored + across drives while another program holds it open is no longer lost or half-removed (the original stays whole and is + removed at the next start); a restore never lands on a name a render is writing, and a render never overwrites a + file; a video changed since it was recorded can still be restored; a playback-free export never goes to a node that + cannot read its settings; a saved frame stays a still on an older server; star trails grow again in each loop; + encoder settings Windows ignored are listed as warnings; the Videos list fits beside the player, a downloaded server + video plays from its copy, disabled actions say why, and the server panel offers no download for image sequences or + missing files. - Visual crop, transforms and looks, found by the phase's review before any release had them (one adversarial round, 30 findings, all confirmed and fixed, and a final check that fixed one more): a render whose aspect changed after it was posted is sized from its preset again, and a job no longer waits for a node that will never take it; settings diff --git a/docs/DECISIONS.md b/docs/DECISIONS.md index 4c308da4..a8ffec98 100644 --- a/docs/DECISIONS.md +++ b/docs/DECISIONS.md @@ -759,3 +759,8 @@ One line per decision: date · decision · alternative · reason. | 2026-11-05 | Owner review 1 phase 5, open questions without an answer take the plan's defaults: Q1 own section, Ctrl+4; Q2 MediaElement pane with fallback; Q3 "Render" only; Q4 preview stays forward; Q5 reverse trails in program order, boomerang disabled; Q6 loops 1–10, fades 0–30 s (slider 0–10), hold 0–60 s (slider 0–10) (`PlaybackSettings.MaxLoops/MaxFadeSeconds/MaxHoldSeconds`); Q7 PNG, JPEG, TIFF 16-bit; Q8 `