From fc5df0146ed37f30d49ab9a95d25ee19f9aa1203 Mon Sep 17 00:00:00 2001 From: Alberto Balbo Date: Wed, 11 Nov 2026 17:19:15 +0100 Subject: [PATCH] Prepare strategies before the host is ready; stop demo servers first (refs #44 #45) Loading the outcomes before "ready" was not enough: on a fresh database the strategy rows did not exist yet, so the load did nothing and CI run 220 failed the same way on PostgreSQL. The new TradingService.PrepareAsync creates accounts and strategies, then loads the outcomes; the host runs it before it is ready and logs a failure without blocking the interface. StartAsync repeats it, which changes nothing. The demo tests deleted the demo folder while the server still held its SQLite file, which Windows refuses at random. They now stop the server first. Co-Authored-By: Claude Opus 5.5 --- src/Anubis.Server/AnubisHost.cs | 10 ++- src/Anubis/Trading/TradingService.cs | 16 ++++- tests/Anubis.Tests/AccountsScreenTests.cs | 4 +- tests/Anubis.Tests/ServerTests.cs | 81 ++++++++++++---------- tests/Anubis.Tests/StrategyScreensTests.cs | 4 +- 5 files changed, 74 insertions(+), 41 deletions(-) diff --git a/src/Anubis.Server/AnubisHost.cs b/src/Anubis.Server/AnubisHost.cs index af69e07..ef1eec2 100644 --- a/src/Anubis.Server/AnubisHost.cs +++ b/src/Anubis.Server/AnubisHost.cs @@ -298,7 +298,15 @@ internal sealed partial class AnubisHost( if (_trading is not null) { // Before "ready": the Strategie page must never show a strategy without its backtest outcome (SPEC 12.3). - await _trading.LoadOutcomesAsync(cancellationToken).ConfigureAwait(false); + // A failure here is logged and left to the trading start, which repeats it: the interface still opens. + try + { + await _trading.PrepareAsync(cancellationToken).ConfigureAwait(false); + } + catch (Exception ex) when (ex is not OperationCanceledException) + { + LogTradingFailed(logger, ex); + } } // The laboratory computes on its own thread and reads only local data; the demo shows appendix F and runs none. diff --git a/src/Anubis/Trading/TradingService.cs b/src/Anubis/Trading/TradingService.cs index b3929de..bd18c80 100644 --- a/src/Anubis/Trading/TradingService.cs +++ b/src/Anubis/Trading/TradingService.cs @@ -210,13 +210,25 @@ public sealed partial class TradingService : IDisposable public OrderManager? ManagerOf(Guid accountId) => _managers.GetValueOrDefault(accountId); - /// Accounts, brokers and order managers; then the simulator catches up, keys are checked and every account reconciled. - public async Task StartAsync(CancellationToken cancellationToken) + /// + /// Accounts, strategies and their backtest outcomes, in the database only: the host runs it before it is ready, so no + /// page ever shows a strategy without its outcome. Repeating it changes nothing. + /// + public async Task> PrepareAsync(CancellationToken cancellationToken) { var alpaca = await AlpacaKeysAsync(cancellationToken).ConfigureAwait(false); var okx = await OkxKeysAsync(cancellationToken).ConfigureAwait(false); var accounts = await AccountSetup.EnsureAsync(_db, _clock, alpaca is not null, okx is not null, cancellationToken).ConfigureAwait(false); await LoadOutcomesAsync(cancellationToken).ConfigureAwait(false); + return accounts; + } + + /// Accounts, brokers and order managers; then the simulator catches up, keys are checked and every account reconciled. + public async Task StartAsync(CancellationToken cancellationToken) + { + var accounts = await PrepareAsync(cancellationToken).ConfigureAwait(false); + var alpaca = await AlpacaKeysAsync(cancellationToken).ConfigureAwait(false); + var okx = await OkxKeysAsync(cancellationToken).ConfigureAwait(false); await RefreshSpecsAsync(cancellationToken).ConfigureAwait(false); await RefreshLimitsAsync(cancellationToken).ConfigureAwait(false); foreach (var account in accounts) diff --git a/tests/Anubis.Tests/AccountsScreenTests.cs b/tests/Anubis.Tests/AccountsScreenTests.cs index 9c021b8..eafa62c 100644 --- a/tests/Anubis.Tests/AccountsScreenTests.cs +++ b/tests/Anubis.Tests/AccountsScreenTests.cs @@ -12,7 +12,7 @@ public sealed class AccountsScreenTests [TestCategory(Category.Integration)] public async Task TheDemoShowsTheFiguresOfTheMockup() { - await using var server = await ServerHarness.StartAsync("docker", ServerHarness.DockerSqlite(), extraArgs: ["--demo"]); + var server = await ServerHarness.StartAsync("docker", ServerHarness.DockerSqlite(), extraArgs: ["--demo"]); var demoRoot = server.Host.Config.Data.Root; try { @@ -58,6 +58,8 @@ public sealed class AccountsScreenTests } finally { + // The server first: on Windows a database still open cannot be deleted. + await server.DisposeAsync(); TempFolder.Delete(demoRoot); } } diff --git a/tests/Anubis.Tests/ServerTests.cs b/tests/Anubis.Tests/ServerTests.cs index c5e0c3a..a770a45 100644 --- a/tests/Anubis.Tests/ServerTests.cs +++ b/tests/Anubis.Tests/ServerTests.cs @@ -147,18 +147,23 @@ public sealed class ServerTests [TestMethod] public async Task ComputerOnlyModesRefuseForeignHostNames() { - await using var server = await ServerHarness.StartAsync("docker", ServerHarness.DockerSqlite(), extraArgs: ["--demo"]); - var demoRoot = server.Host.Config.Data.Root; - using (var mine = await server.GetAsync("/api/me")) + // The server stops before its folder is deleted: on Windows an open database cannot be deleted. + string demoRoot; { - Assert.AreEqual(HttpStatusCode.OK, mine.StatusCode); + await using var server = await ServerHarness.StartAsync("docker", ServerHarness.DockerSqlite(), extraArgs: ["--demo"]); + demoRoot = server.Host.Config.Data.Root; + using (var mine = await server.GetAsync("/api/me")) + { + Assert.AreEqual(HttpStatusCode.OK, mine.StatusCode); + } + + // DNS rebinding: a page whose name now points at 127.0.0.1 arrives from the loopback with its own Host. + using var request = new HttpRequestMessage(HttpMethod.Get, new Uri("/api/me", UriKind.Relative)); + request.Headers.Host = "evil.example:" + server.BaseAddress.Port.ToString(System.Globalization.CultureInfo.InvariantCulture); + using var foreign = await server.Http.SendAsync(request); + Assert.AreEqual(HttpStatusCode.Forbidden, foreign.StatusCode); } - // DNS rebinding: a page whose name now points at 127.0.0.1 arrives from the loopback with its own Host. - using var request = new HttpRequestMessage(HttpMethod.Get, new Uri("/api/me", UriKind.Relative)); - request.Headers.Host = "evil.example:" + server.BaseAddress.Port.ToString(System.Globalization.CultureInfo.InvariantCulture); - using var foreign = await server.Http.SendAsync(request); - Assert.AreEqual(HttpStatusCode.Forbidden, foreign.StatusCode); TempFolder.Delete(demoRoot); } @@ -368,34 +373,38 @@ public sealed class ServerTests Microsoft.Data.Sqlite.SqliteConnection.ClearAllPools(); var before = Snapshot(configured); Assert.IsTrue(before.Keys.Any(k => k.EndsWith(".sqlite3", StringComparison.Ordinal))); - await using var server = await ServerHarness.StartAsync("docker", ServerHarness.DockerSqlite(), dataDir: configured, extraArgs: ["--demo"]); - - // Its own folder under the temporary directory, the configured one untouched. - var demoRoot = server.Host.Config.Data.Root; - StringAssert.StartsWith(demoRoot, Path.Combine(Path.GetTempPath(), "anubis-demo")); - - // Appendix F on screen, frozen clock, signed in by itself, the footer says it. - var html = await server.TextAsync("/"); - StringAssert.Contains(html, "+412,46 €"); - StringAssert.Contains(html, "Venerdì 9 ottobre 2026, ore 08:21"); - StringAssert.Contains(html, "Sorveglio 10 posizioni, ognuna con il suo stop."); - StringAssert.Contains(html, "Modalità dimostrativa. Numeri, titoli e notizie sono dati di esempio."); - - // The live status arrives over the WebSocket. - using var socket = new ClientWebSocket(); - await socket.ConnectAsync(new Uri(server.BaseAddress.ToString().Replace("http", "ws", StringComparison.Ordinal) + "ws"), CancellationToken.None); - var buffer = new byte[4096]; - var received = await socket.ReceiveAsync(buffer, CancellationToken.None); - var message = Encoding.UTF8.GetString(buffer, 0, received.Count); - StringAssert.Contains(message, "\"type\":\"status\""); - StringAssert.Contains(message, "\"bot\":\"active\""); - await socket.CloseAsync(WebSocketCloseStatus.NormalClosure, null, CancellationToken.None); - - var after = Snapshot(configured); - CollectionAssert.AreEquivalent(before.Keys.ToList(), after.Keys.ToList(), "No file added or removed in the configured data folder."); - foreach (var (name, hash) in before) + // The server stops before its folder is deleted: on Windows an open database cannot be deleted. + string demoRoot; { - Assert.AreEqual(hash, after[name], name + " changed"); + await using var server = await ServerHarness.StartAsync("docker", ServerHarness.DockerSqlite(), dataDir: configured, extraArgs: ["--demo"]); + + // Its own folder under the temporary directory, the configured one untouched. + demoRoot = server.Host.Config.Data.Root; + StringAssert.StartsWith(demoRoot, Path.Combine(Path.GetTempPath(), "anubis-demo")); + + // Appendix F on screen, frozen clock, signed in by itself, the footer says it. + var html = await server.TextAsync("/"); + StringAssert.Contains(html, "+412,46 €"); + StringAssert.Contains(html, "Venerdì 9 ottobre 2026, ore 08:21"); + StringAssert.Contains(html, "Sorveglio 10 posizioni, ognuna con il suo stop."); + StringAssert.Contains(html, "Modalità dimostrativa. Numeri, titoli e notizie sono dati di esempio."); + + // The live status arrives over the WebSocket. + using var socket = new ClientWebSocket(); + await socket.ConnectAsync(new Uri(server.BaseAddress.ToString().Replace("http", "ws", StringComparison.Ordinal) + "ws"), CancellationToken.None); + var buffer = new byte[4096]; + var received = await socket.ReceiveAsync(buffer, CancellationToken.None); + var message = Encoding.UTF8.GetString(buffer, 0, received.Count); + StringAssert.Contains(message, "\"type\":\"status\""); + StringAssert.Contains(message, "\"bot\":\"active\""); + await socket.CloseAsync(WebSocketCloseStatus.NormalClosure, null, CancellationToken.None); + + var after = Snapshot(configured); + CollectionAssert.AreEquivalent(before.Keys.ToList(), after.Keys.ToList(), "No file added or removed in the configured data folder."); + foreach (var (name, hash) in before) + { + Assert.AreEqual(hash, after[name], name + " changed"); + } } TempFolder.Delete(demoRoot); diff --git a/tests/Anubis.Tests/StrategyScreensTests.cs b/tests/Anubis.Tests/StrategyScreensTests.cs index dbad209..458f4ef 100644 --- a/tests/Anubis.Tests/StrategyScreensTests.cs +++ b/tests/Anubis.Tests/StrategyScreensTests.cs @@ -17,7 +17,7 @@ public sealed class StrategyScreensTests [TestCategory(Category.Integration)] public async Task TheDemoShowsTradesStrategiesAndRiskAsInTheMockups() { - await using var server = await ServerHarness.StartAsync("docker", ServerHarness.DockerSqlite(), extraArgs: ["--demo"]); + var server = await ServerHarness.StartAsync("docker", ServerHarness.DockerSqlite(), extraArgs: ["--demo"]); var demoRoot = server.Host.Config.Data.Root; try { @@ -63,6 +63,8 @@ public sealed class StrategyScreensTests } finally { + // The server first: on Windows a database still open cannot be deleted. + await server.DisposeAsync(); TempFolder.Delete(demoRoot); } }