Files
Febe/tests/Febe.Tests/Engine/BackfillCompletedTests.cs
T
Alby96andClaude Opus 5.5 afbd0b4a1a Storico completato: una riga sola, quella del motore
Provando Febe per Windows contro il sito di prova, alla fine dello storico di
marta.prova la sezione «Avvisi» di Attività mostrava due righe per lo stesso
fatto, entrambe «storico-completato»: quella del motore («Storico di
@marta.prova completato: 18 post in libreria. Da ora lo tengo aggiornato.»)
e una della ricetta Storico («Storico di marta.prova completato.», senza @ e
senza numeri). La notifica di Windows partiva una volta sola, ma con il
testo corto, perché la riga della ricetta arrivava prima.

Resta solo la riga del motore, che è anche quella che cambia lo stato
dell'account e che usano la dimostrazione e la simulazione. La ricetta
segna lo storico come completato e lo dice al motore, senza scrivere altro.
Prova nuova con le ricette vere sul sito finto sotto il motore vero: una
riga negli Avvisi, una notifica e un messaggio Telegram, con il testo
intero. Riga in docs/decisioni.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-20 15:30:24 +02:00

142 lines
7.4 KiB
C#

using Febe.Core.Abstractions;
using Febe.Core.Alerts;
using Febe.Core.Collection;
using Febe.Core.Collection.Readers;
using Febe.Core.Collection.Recipes;
using Febe.Core.Domain;
using Febe.Core.Engine;
using Febe.Core.Storage;
using Febe.Tests.Alerts.Support;
using Febe.Tests.Collection.Support;
using Febe.Tests.Engine.Support;
using Febe.Web.Api;
namespace Febe.Tests.Engine;
/// <summary>
/// «Storico completato» is one line of Attività and one alert per history, written by the engine with its numbers:
/// the real recipes on the scripted site (no browser) under the real engine, and the runs that end otherwise right
/// after the last page.
/// </summary>
[TestClass]
public sealed class BackfillCompletedTests
{
private static readonly DateTimeOffset Morning = EngineTestBed.Local(2026, 10, 14, 6, 0);
/// <summary>Found testing Febe for Windows on the test site: two lines in «Avvisi» for one history, at 14:31.</summary>
[TestMethod]
public async Task AHistoryCompletedByTheRecipesIsOneLineOfAvvisiWithItsNumbersAndOneNotification()
{
await using var bed = await AlertBed.CreateAsync(start: Morning);
var engine = bed.Engine;
var (runner, site) = RealRecipes(engine);
var marta = site.Add(new ScriptedAccount("2002", "marta.prova") { Followed = false });
marta.Posts.AddRange(ScriptedBed.Posts(0, 18, Morning.AddDays(-30)));
var account = await AddBackfillingAsync(engine, marta, postCount: 18);
engine.Start(runner);
await engine.RunUntilAsync(Morning.AddDays(2));
await engine.StopAsync();
await bed.Alerts.FlushAsync();
const string Expected = "Storico di @marta.prova completato: 18 post in libreria. Da ora lo tengo aggiornato.";
var done = await engine.Db.Accounts.GetAsync(account.Id);
Assert.IsNotNull(done!.BackfillCompletedAt, "The history reached the beginning of the profile.");
Assert.AreEqual(AccountState.UpToDate, done.State);
Assert.HasCount(18, await engine.Db.Entries.ListByAccountAsync(account.Id, new EntryListOptions { Kind = EntryKind.Post, Limit = 100 }));
var lines = await engine.Db.Events.ListAsync(new EventQuery { Codes = [EngineEventCodes.BackfillCompleted] });
Assert.HasCount(1, lines, "One line for one history: " + string.Join(" | ", lines.Select(e => e.Message)));
Assert.AreEqual(Expected, lines[0].Message);
Assert.AreEqual(EventSeverity.Success, lines[0].Severity);
Assert.AreEqual(account.Id, lines[0].AccountId);
Assert.IsNotNull(lines[0].SessionId);
// The «Avvisi» list of Attività.
var alerts = (await ActivityApi.AlertsAsync(engine.Db, engine.Clock, CancellationToken.None)).Items.Where(i => i.Kind == "backfillDone").ToList();
Assert.HasCount(1, alerts);
Assert.AreEqual(Expected, alerts[0].Message);
// One Windows notification and one Telegram message, with the same full text.
var notification = bed.Shell.Notifications.Single(n => n.Title == AlertCatalog.Title(AlertKind.BackfillDone));
Assert.AreEqual(Expected, notification.Message);
var telegram = bed.Telegram.Requests.Where(r => r.Text.StartsWith("Febe · Storico completato\n", StringComparison.Ordinal)).ToList();
Assert.HasCount(1, telegram);
Assert.AreEqual("Febe · Storico completato\n" + Expected, telegram[0].Text);
Assert.HasCount(1, bed.Outcomes.Where(o => o.Alert.Kind == AlertKind.BackfillDone), "Nothing held back as a repeat either.");
}
/// <summary>
/// The walk reached the beginning of the profile and stored it, then a signal or a cancellation changed how the
/// run ended: the history is complete all the same and keeps its line (it would never be walked again).
/// </summary>
[TestMethod]
[DataRow(RecipeStatus.StoppedBySignal)]
[DataRow(RecipeStatus.Cancelled)]
public async Task AHistoryCompletedRightBeforeARunEndsOtherwiseKeepsItsLine(RecipeStatus status)
{
await using var bed = await AlertBed.CreateAsync(start: Morning);
var engine = bed.Engine;
var account = await engine.AddAccountAsync("luca.prova", followed: true, state: AccountState.Backfilling, postCount: 30);
await engine.Db.Accounts.UpdateAsync((await engine.Db.Accounts.GetAsync(account.Id))! with { KeepUpdated = false });
var runner = new ScriptedRunner(engine.Governor, engine.Clock);
var backfills = 0;
runner.Before = async r =>
{
if (r.Kind == RecipeKind.Backfill && r.AccountId == account.Id && ++backfills == 1)
{
// What the recipe stores when the walk meets the end of the list.
await engine.Db.Accounts.SetBackfillAsync(account.Id, null, engine.Clock.Now);
}
};
runner.Script = r => r.Kind == RecipeKind.Backfill && r.AccountId == account.Id && backfills == 1
? new RecipeOutcome(status, 1, 6) { BackfillFinished = true }
: null;
engine.Start(runner);
await engine.RunUntilAsync(Morning.AddDays(2));
await engine.StopAsync();
await bed.Alerts.FlushAsync();
Assert.AreEqual(1, backfills, "Never walked again.");
var finished = await engine.Db.Accounts.GetAsync(account.Id);
Assert.AreEqual(AccountState.Paused, finished!.State, "«Tieni aggiornato» off: one download, then paused.");
var lines = await engine.Db.Events.ListAsync(new EventQuery { Codes = [EngineEventCodes.BackfillCompleted] });
Assert.HasCount(1, lines);
Assert.AreEqual("Storico di @luca.prova completato: 0 post in libreria. «Tieni aggiornato» è spento: l'account resta in pausa.", lines[0].Message);
Assert.HasCount(1, bed.Shell.Notifications.Where(n => n.Title == AlertCatalog.Title(AlertKind.BackfillDone)));
}
/// <summary>The real recipes over the scripted site, on the engine's database, clock, Governor and breaker.</summary>
private static (RecipeRunner Runner, ScriptedSite Site) RealRecipes(EngineTestBed engine)
{
var capture = new CaptureCollector(new ShapeReader(ReaderVocabulary.LoadTestSite()), engine.Clock);
var site = new ScriptedSite(capture, engine.Clock);
var runner = new RecipeRunner(new RecipeEnvironment
{
Driver = site,
Capture = capture,
Governor = engine.Governor,
Budget = engine.Governor,
DataBudget = engine.Governor,
Signals = new SignalDetector(SignalRules.LoadTestSite(), engine.Breaker, engine.Clock),
Storage = engine.Db,
SiteMap = SiteMap.LoadTestSite(),
Clock = engine.Clock,
Random = new SeededRandom(7),
Breaker = engine.Breaker,
});
return (runner, site);
}
/// <summary>An account «Storico in corso» for a scripted account: posts only, so that a visit is the profile check.</summary>
private static Task<Account> AddBackfillingAsync(EngineTestBed engine, ScriptedAccount scripted, int postCount) =>
engine.Db.Accounts.AddAsync(Account.Create(scripted.Username, StartingPoint.EverythingAndKeepUpdated, engine.Clock.Now, EngineTestBed.Zone, engine.Runtime.Profile) with
{
InstagramId = scripted.Id,
IsFollowed = scripted.Followed,
State = AccountState.Backfilling,
ContentTypes = ContentTypes.PostPhotos | ContentTypes.PostVideos,
PostCount = postCount,
});
}