Drops forecasts, lightning, the home-screen widget and advertising. What remains is radar on a map, the official ARPA alert bulletin, and rain notifications. The base map is now OpenFreeMap's Positron style: real OpenStreetMap vector tiles with no API key, no registration, no request limits and commercial use permitted. Every other free tier — MapTiler, Stadia, Jawg, Thunderforest — needs a key, which is a secret to manage, a quota to outgrow and a signup to complete before anyone can build the project, and the map is the one thing the app cannot work without. Positron rather than Liberty or Bright because the radar overlay has to be the loudest thing on screen, and a desaturated grey base is built to sit under data. Its style JSON carries no `attribution` field, so MapLibre displays no credits by itself. The app renders them from the region config instead: the two mandatory credits, OpenStreetMap and OpenMapTiles, go in the always-visible bar, and OpenFreeMap's own credit — optional by their terms — is listed on the Sources screen with the rest. The bundled offline style is still reachable with MAP_STYLE_URL=offline, and still claims no base map attribution, because crediting OpenStreetMap while showing it would be a false claim. Radar-DPC stays the source. ARPA Piemonte's own radar remains a disabled stub for two reasons that belong to the project owner, not to the code: the real-time access link is only issued by email, and the open-data page states the data is "gratuiti" and nothing else. Free of charge is not a licence, and rendering those volumes into frames served from a CDN is redistribution. Both questions go in the same email. An earlier draft of the docs recorded ARPA radar as CC BY 4.0; the source page does not support that, so the claim is removed rather than carried forward. The documentation is updated throughout rather than annotated: CLAUDE.md gains an explicit scope boundary, data-sources drops MET Norway and ISTAT and gains the base map, licenses records that free of charge is not a licence, privacy loses the whole advertising section, and the roadmap is renumbered so the backend worker is next — until it exists, DpcRadarSource has nothing to read. licenses.md keeps Open-Meteo and Blitzortung listed as excluded even though the features that would have used them are gone: both are non-commercial-only, ads are a plausible future, and neither should be adopted on the grounds that there are none today. Verified: analyze clean, 130 tests passing, and on the emulator the radar overlay sits correctly over Piedmont on real OSM tiles with Turin, Milan and Genoa labelled, the age reads "Aggiornato 4 minuti fa", and the Sources screen lists all five credits with their licences. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
159 lines
4.9 KiB
Dart
159 lines
4.9 KiB
Dart
import 'dart:io';
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:nuvolari/core/region/region_config.dart';
|
|
import 'package:nuvolari/core/region/region_repository.dart';
|
|
import 'package:nuvolari/features/map/attribution_bar.dart';
|
|
import 'package:nuvolari/features/sources/sources_screen.dart';
|
|
import 'package:nuvolari/l10n/app_localizations.dart';
|
|
|
|
RegionConfig loadPiemonte() =>
|
|
RegionConfig.parse(File('assets/regions/piemonte.json').readAsStringSync());
|
|
|
|
Widget wrap(Widget child, RegionConfig region) => ProviderScope(
|
|
overrides: [regionConfigProvider.overrideWith((ref) async => region)],
|
|
child: MaterialApp(
|
|
locale: const Locale('it'),
|
|
localizationsDelegates: AppLocalizations.localizationsDelegates,
|
|
supportedLocales: AppLocalizations.supportedLocales,
|
|
home: child,
|
|
),
|
|
);
|
|
|
|
void main() {
|
|
late RegionConfig region;
|
|
|
|
setUpAll(() {
|
|
region = loadPiemonte();
|
|
});
|
|
|
|
group('SourcesScreen', () {
|
|
testWidgets('lists every configured source with its licence', (
|
|
tester,
|
|
) async {
|
|
await tester.pumpWidget(wrap(const SourcesScreen(), region));
|
|
await tester.pumpAndSettle();
|
|
|
|
for (final attribution in region.attributions) {
|
|
expect(
|
|
find.text(attribution.text),
|
|
findsOneWidget,
|
|
reason: '${attribution.id} is missing from the Sources screen',
|
|
);
|
|
}
|
|
|
|
expect(find.textContaining('CC BY-SA'), findsWidgets);
|
|
expect(find.textContaining('ODbL'), findsWidgets);
|
|
});
|
|
|
|
// ARPA publishes no licence for the alert bulletin. Showing an invented one
|
|
// would be worse than showing none, so the screen must say so explicitly.
|
|
testWidgets('says when a source states no licence', (tester) async {
|
|
await tester.pumpWidget(wrap(const SourcesScreen(), region));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('Nessuna licenza dichiarata dalla fonte'), findsWidgets);
|
|
});
|
|
|
|
testWidgets('shows the independence disclaimer', (tester) async {
|
|
await tester.pumpWidget(wrap(const SourcesScreen(), region));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('App non ufficiale'), findsOneWidget);
|
|
expect(find.textContaining('indipendente'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('explains the share-alike obligation', (tester) async {
|
|
await tester.pumpWidget(wrap(const SourcesScreen(), region));
|
|
await tester.pumpAndSettle();
|
|
|
|
// Below the fold in the test viewport once the base-map credits are listed.
|
|
await tester.scrollUntilVisible(
|
|
find.text('Dati derivati'),
|
|
200,
|
|
scrollable: find.byType(Scrollable).first,
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('Dati derivati'), findsOneWidget);
|
|
expect(find.textContaining('CC BY-SA'), findsWidgets);
|
|
});
|
|
|
|
testWidgets('links the official bulletin', (tester) async {
|
|
await tester.pumpWidget(wrap(const SourcesScreen(), region));
|
|
await tester.pumpAndSettle();
|
|
|
|
// The button sits below the fold in the test viewport.
|
|
await tester.scrollUntilVisible(
|
|
find.text('Bollettino ufficiale Arpa Piemonte'),
|
|
200,
|
|
scrollable: find.byType(Scrollable).first,
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('Bollettino ufficiale Arpa Piemonte'), findsOneWidget);
|
|
});
|
|
});
|
|
|
|
group('AttributionBar', () {
|
|
testWidgets('shows only the sources currently on screen', (tester) async {
|
|
await tester.pumpWidget(
|
|
wrap(
|
|
Scaffold(
|
|
body: AttributionBar(
|
|
region: region,
|
|
activeSourceIds: const {'osm'},
|
|
),
|
|
),
|
|
region,
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.textContaining('OpenStreetMap'), findsOneWidget);
|
|
expect(find.textContaining('Radar-DPC'), findsNothing);
|
|
});
|
|
|
|
testWidgets('says when no base map is configured', (tester) async {
|
|
await tester.pumpWidget(
|
|
wrap(
|
|
Scaffold(
|
|
body: AttributionBar(
|
|
region: region,
|
|
activeSourceIds: const {},
|
|
showBaseMapNotice: true,
|
|
),
|
|
),
|
|
region,
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.textContaining('Mappa base non configurata'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('opens the Sources screen when tapped', (tester) async {
|
|
await tester.pumpWidget(
|
|
wrap(
|
|
Scaffold(
|
|
body: AttributionBar(
|
|
region: region,
|
|
activeSourceIds: const {'osm', 'dpc'},
|
|
),
|
|
),
|
|
region,
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
await tester.tap(find.byType(AttributionBar));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.byType(SourcesScreen), findsOneWidget);
|
|
expect(find.text('App non ufficiale'), findsOneWidget);
|
|
});
|
|
});
|
|
}
|