Drops forecasts, lightning, the home-screen widget and advertising. What remains is radar on a map, the official ARPA alert bulletin, and rain notifications. The base map is now OpenFreeMap's Positron style: real OpenStreetMap vector tiles with no API key, no registration, no request limits and commercial use permitted. Every other free tier — MapTiler, Stadia, Jawg, Thunderforest — needs a key, which is a secret to manage, a quota to outgrow and a signup to complete before anyone can build the project, and the map is the one thing the app cannot work without. Positron rather than Liberty or Bright because the radar overlay has to be the loudest thing on screen, and a desaturated grey base is built to sit under data. Its style JSON carries no `attribution` field, so MapLibre displays no credits by itself. The app renders them from the region config instead: the two mandatory credits, OpenStreetMap and OpenMapTiles, go in the always-visible bar, and OpenFreeMap's own credit — optional by their terms — is listed on the Sources screen with the rest. The bundled offline style is still reachable with MAP_STYLE_URL=offline, and still claims no base map attribution, because crediting OpenStreetMap while showing it would be a false claim. Radar-DPC stays the source. ARPA Piemonte's own radar remains a disabled stub for two reasons that belong to the project owner, not to the code: the real-time access link is only issued by email, and the open-data page states the data is "gratuiti" and nothing else. Free of charge is not a licence, and rendering those volumes into frames served from a CDN is redistribution. Both questions go in the same email. An earlier draft of the docs recorded ARPA radar as CC BY 4.0; the source page does not support that, so the claim is removed rather than carried forward. The documentation is updated throughout rather than annotated: CLAUDE.md gains an explicit scope boundary, data-sources drops MET Norway and ISTAT and gains the base map, licenses records that free of charge is not a licence, privacy loses the whole advertising section, and the roadmap is renumbered so the backend worker is next — until it exists, DpcRadarSource has nothing to read. licenses.md keeps Open-Meteo and Blitzortung listed as excluded even though the features that would have used them are gone: both are non-commercial-only, ads are a plausible future, and neither should be adopted on the grounds that there are none today. Verified: analyze clean, 130 tests passing, and on the emulator the radar overlay sits correctly over Piedmont on real OSM tiles with Turin, Milan and Genoa labelled, the age reads "Aggiornato 4 minuti fa", and the Sources screen lists all five credits with their licences. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
143 lines
5.0 KiB
Dart
143 lines
5.0 KiB
Dart
import 'dart:convert';
|
|
import 'dart:io';
|
|
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:nuvolari/core/region/region_config.dart';
|
|
import 'package:nuvolari/features/map/map_style.dart';
|
|
|
|
void main() {
|
|
late RegionConfig region;
|
|
|
|
setUpAll(() {
|
|
region = RegionConfig.parse(
|
|
File('assets/regions/piemonte.json').readAsStringSync(),
|
|
);
|
|
});
|
|
|
|
group('MapStyle.buildFallbackStyle', () {
|
|
late Map<String, Object?> style;
|
|
|
|
setUp(() {
|
|
style = jsonDecode(
|
|
MapStyle.buildFallbackStyle(region),
|
|
) as Map<String, Object?>;
|
|
});
|
|
|
|
test('is a valid MapLibre style document', () {
|
|
expect(style['version'], 8);
|
|
expect(style['sources'], isA<Map<String, Object?>>());
|
|
expect(style['layers'], isA<List<Object?>>());
|
|
});
|
|
|
|
// The whole point of the fallback is that it works with no network at all,
|
|
// so a style that referenced a tile server would defeat it.
|
|
test('references no network sources', () {
|
|
final encoded = jsonEncode(style);
|
|
|
|
expect(encoded, isNot(contains('http://')));
|
|
expect(encoded, isNot(contains('https://')));
|
|
|
|
final sources = style['sources']! as Map<String, Object?>;
|
|
for (final source in sources.values) {
|
|
expect((source! as Map<String, Object?>)['type'], 'geojson');
|
|
}
|
|
});
|
|
|
|
test('draws the region extent as a closed ring', () {
|
|
final source =
|
|
(style['sources']! as Map<String, Object?>)['region-extent']!
|
|
as Map<String, Object?>;
|
|
final geometry =
|
|
(source['data']! as Map<String, Object?>)['geometry']!
|
|
as Map<String, Object?>;
|
|
final ring =
|
|
(geometry['coordinates']! as List<Object?>).first! as List<Object?>;
|
|
|
|
expect(geometry['type'], 'Polygon');
|
|
// Five points: four corners plus the repeated first point that closes it.
|
|
expect(ring, hasLength(5));
|
|
expect(ring.first, equals(ring.last));
|
|
});
|
|
|
|
test('the ring matches the region bounding box', () {
|
|
final source =
|
|
(style['sources']! as Map<String, Object?>)['region-extent']!
|
|
as Map<String, Object?>;
|
|
final geometry =
|
|
(source['data']! as Map<String, Object?>)['geometry']!
|
|
as Map<String, Object?>;
|
|
final ring =
|
|
(geometry['coordinates']! as List<Object?>).first! as List<Object?>;
|
|
|
|
final longitudes = <double>[];
|
|
final latitudes = <double>[];
|
|
for (final point in ring) {
|
|
final pair = point! as List<Object?>;
|
|
longitudes.add((pair[0]! as num).toDouble());
|
|
latitudes.add((pair[1]! as num).toDouble());
|
|
}
|
|
|
|
expect(longitudes.reduce((a, b) => a < b ? a : b), region.bounds.west);
|
|
expect(longitudes.reduce((a, b) => a > b ? a : b), region.bounds.east);
|
|
expect(latitudes.reduce((a, b) => a < b ? a : b), region.bounds.south);
|
|
expect(latitudes.reduce((a, b) => a > b ? a : b), region.bounds.north);
|
|
});
|
|
|
|
test('has a background layer beneath the region layers', () {
|
|
final layers = (style['layers']! as List<Object?>)
|
|
.map((layer) => (layer! as Map<String, Object?>)['id'])
|
|
.toList();
|
|
|
|
expect(layers.first, 'background');
|
|
expect(layers, contains('region-extent-fill'));
|
|
expect(layers, contains('region-extent-outline'));
|
|
});
|
|
});
|
|
|
|
group('MapStyle.forRegion', () {
|
|
// The test binary is built with no --dart-define, so MAP_STYLE_URL is empty
|
|
// and the free key-less base map is what must come back.
|
|
test('defaults to OpenFreeMap when nothing is configured', () {
|
|
final style = MapStyle.forRegion(region);
|
|
|
|
expect(style.kind, BaseMapKind.openFreeMap);
|
|
expect(style.styleString, MapStyle.openFreeMapStyleUrl);
|
|
expect(style.styleString, startsWith('https://'));
|
|
});
|
|
|
|
// OpenMapTiles and OpenStreetMap are mandatory credits for these tiles.
|
|
// OpenFreeMap's own credit is optional by their terms and lives on the
|
|
// Sources screen instead of the always-visible bar.
|
|
test('the default base map owes the OpenMapTiles and OSM credits', () {
|
|
final ids = MapStyle.forRegion(region).attributionIds;
|
|
|
|
expect(ids, containsAll(<String>['openmaptiles', 'osm']));
|
|
expect(ids, isNot(contains('openfreemap')));
|
|
});
|
|
|
|
test('a custom style URL owes the same credits', () {
|
|
const custom = MapStyle(
|
|
kind: BaseMapKind.custom,
|
|
styleString: 'https://example.invalid/style.json',
|
|
);
|
|
|
|
expect(
|
|
custom.attributionIds,
|
|
containsAll(<String>['openmaptiles', 'osm']),
|
|
);
|
|
});
|
|
|
|
// Crediting OpenStreetMap while showing a style that contains no OSM data
|
|
// would be a false attribution, so the fallback owes nothing.
|
|
test('the offline fallback claims no base map attribution', () {
|
|
final fallback = MapStyle(
|
|
kind: BaseMapKind.offlineFallback,
|
|
styleString: MapStyle.buildFallbackStyle(region),
|
|
);
|
|
|
|
expect(fallback.attributionIds, isEmpty);
|
|
expect(fallback.styleString, startsWith('{'));
|
|
});
|
|
});
|
|
}
|