A saved place is a named point the user keeps: it frames the map now, and once the worker publishes station data it is what the nearest-station readings and, later, the rain notifications will hang off. Free points rather than stations, because people think in terms of home and work, not in terms of which weather station happens to represent them. Everything stays on the device. Places live in SharedPreferences under a versioned key, and there is no account to attach them to and no server that would accept them. That is what keeps the Data safety declaration able to say no location is collected, and it must survive the notification work: the device will subscribe to the topic for the cell containing a place, so the link between a person and a place never leaves their phone. Location is coarse only, and that took enforcing. geolocator declares ACCESS_FINE_LOCATION in its own manifest and the merger pulls it in, so the system dialog offered "Precise" despite the app asking for nothing of the sort; the manifest now removes it with tools:node="remove", and the dialog reads "approximate location" with no choice offered. Requests also go through the platform LocationManager rather than the Play Services fused provider, which prompts about Location Accuracy and, when declined, returns no fix at all — an absurd outcome for an app that only ever wanted an approximate one, and one that also tied location to Play Services being present. The prominent disclosure comes before the system dialog, as Play requires, and is repeated in Settings so someone who already answered can still read what the permission is for. Declining leaves the app fully usable. Two more defects found by running it and by a test: - MapLibreMap leaves cameraPosition null unless trackCameraPosition is set, so "save the map centre" silently saved the region default rather than what the user was looking at. - Place ids came straight from the microsecond clock, so two places saved in the same microsecond shared an id and rename, remove and the duplicate-name check all acted on the wrong one. A test caught it on a fast machine. Saving refuses points outside the region rather than accepting them: a place in Rome would look like it worked and then show nothing forever. Also corrects CLAUDE.md, which still said ARPA states no licence, and records the ARPA realtime API there with the property that governs how it may be used — it lags about 4.5 hours, so it is an observation archive and must never sit next to 5-minute radar looking current. Verified: analyze clean, 158 tests passing, and on the emulator the disclosure precedes the system dialog, the dialog asks only for approximate location, a place survives restart and reinstall, and tapping one moves the map onto it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
159 lines
5.1 KiB
Dart
159 lines
5.1 KiB
Dart
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
|
|
|
import '../../core/region/geo.dart';
|
|
import '../../core/region/region_config.dart';
|
|
import '../../core/region/region_repository.dart';
|
|
import 'places_repository.dart';
|
|
import 'saved_place.dart';
|
|
|
|
final placesStoreProvider = Provider<PlacesStore>(
|
|
(ref) => const SharedPreferencesPlacesStore(),
|
|
);
|
|
|
|
/// The user's saved places, newest first.
|
|
class SavedPlaces extends AsyncNotifier<List<SavedPlace>> {
|
|
/// Beyond this the list stops being a shortcut and becomes a directory to
|
|
/// search through, which is not what it is for.
|
|
static const int maxPlaces = 20;
|
|
|
|
@override
|
|
Future<List<SavedPlace>> build() => ref.watch(placesStoreProvider).load();
|
|
|
|
/// Adds a place at [point] called [name].
|
|
///
|
|
/// Throws [SavedPlaceException] naming the rule that was broken, so the UI can
|
|
/// explain the refusal rather than swallowing it.
|
|
Future<SavedPlace> add({
|
|
required String name,
|
|
required GeoPoint point,
|
|
}) async {
|
|
final trimmed = name.trim();
|
|
_validateName(trimmed);
|
|
await _validatePoint(point);
|
|
|
|
final current = List<SavedPlace>.of(state.value ?? const []);
|
|
if (current.any((p) => p.name.toLowerCase() == trimmed.toLowerCase())) {
|
|
throw const SavedPlaceException(SavedPlaceRejection.duplicateName);
|
|
}
|
|
|
|
final place = SavedPlace(
|
|
id: _newId(current),
|
|
name: trimmed,
|
|
point: point,
|
|
createdAt: DateTime.now().toUtc(),
|
|
);
|
|
|
|
// Newest first: the place just added is the one most likely to be tapped.
|
|
final updated = <SavedPlace>[place, ...current];
|
|
if (updated.length > maxPlaces) {
|
|
updated.removeRange(maxPlaces, updated.length);
|
|
}
|
|
|
|
await _persist(updated);
|
|
return place;
|
|
}
|
|
|
|
Future<void> rename(String id, String name) async {
|
|
final trimmed = name.trim();
|
|
_validateName(trimmed);
|
|
|
|
final current = List<SavedPlace>.of(state.value ?? const []);
|
|
if (current.any(
|
|
(p) => p.id != id && p.name.toLowerCase() == trimmed.toLowerCase(),
|
|
)) {
|
|
throw const SavedPlaceException(SavedPlaceRejection.duplicateName);
|
|
}
|
|
|
|
await _persist(<SavedPlace>[
|
|
for (final place in current)
|
|
if (place.id == id) place.copyWith(name: trimmed) else place,
|
|
]);
|
|
}
|
|
|
|
Future<void> remove(String id) async {
|
|
final current = state.value ?? const <SavedPlace>[];
|
|
await _persist(
|
|
current
|
|
.where((SavedPlace place) => place.id != id)
|
|
.toList(growable: false),
|
|
);
|
|
}
|
|
|
|
Future<void> clear() => _persist(const <SavedPlace>[]);
|
|
|
|
Future<void> _persist(List<SavedPlace> places) async {
|
|
await ref.read(placesStoreProvider).save(places);
|
|
state = AsyncData<List<SavedPlace>>(List<SavedPlace>.unmodifiable(places));
|
|
}
|
|
|
|
/// An id no existing place is using.
|
|
///
|
|
/// The clock alone is not enough: two places saved in the same microsecond
|
|
/// get the same id, and everything that addresses a place by id — rename,
|
|
/// remove, the duplicate-name check — then acts on the wrong one or on both.
|
|
/// A test caught exactly that on a fast machine.
|
|
String _newId(List<SavedPlace> existing) {
|
|
final taken = existing.map((place) => place.id).toSet();
|
|
final base = 'p${DateTime.now().microsecondsSinceEpoch}';
|
|
if (!taken.contains(base)) return base;
|
|
|
|
var suffix = 1;
|
|
while (taken.contains('${base}_$suffix')) {
|
|
suffix++;
|
|
}
|
|
return '${base}_$suffix';
|
|
}
|
|
|
|
void _validateName(String name) {
|
|
if (name.isEmpty) {
|
|
throw const SavedPlaceException(SavedPlaceRejection.emptyName);
|
|
}
|
|
if (name.length > SavedPlace.maxNameLength) {
|
|
throw const SavedPlaceException(SavedPlaceRejection.nameTooLong);
|
|
}
|
|
}
|
|
|
|
/// Refuses points the app has no data for.
|
|
///
|
|
/// Saving a place in Rome would look like it worked and then show nothing
|
|
/// forever. Better to say so at the moment of saving, while the user still
|
|
/// knows what they were trying to do.
|
|
Future<void> _validatePoint(GeoPoint point) async {
|
|
final region = await ref.read(regionConfigProvider.future);
|
|
if (!region.bounds.contains(point)) {
|
|
throw const SavedPlaceException(SavedPlaceRejection.outsideRegion);
|
|
}
|
|
}
|
|
}
|
|
|
|
final savedPlacesProvider =
|
|
AsyncNotifierProvider<SavedPlaces, List<SavedPlace>>(SavedPlaces.new);
|
|
|
|
/// The place the map is currently centred on, or null for the region default.
|
|
///
|
|
/// Session state on purpose: which place you last looked at is not worth
|
|
/// persisting, and restoring it on launch would surprise someone who opened the
|
|
/// app to see the weather where they are now.
|
|
class ActivePlace extends Notifier<SavedPlace?> {
|
|
@override
|
|
SavedPlace? build() => null;
|
|
|
|
void select(SavedPlace? place) => state = place;
|
|
}
|
|
|
|
final activePlaceProvider = NotifierProvider<ActivePlace, SavedPlace?>(
|
|
ActivePlace.new,
|
|
);
|
|
|
|
/// Returns [places] ordered by distance from [point], nearest first.
|
|
List<SavedPlace> byDistanceFrom(GeoPoint point, List<SavedPlace> places) {
|
|
final sorted = List<SavedPlace>.of(places);
|
|
sorted.sort(
|
|
(a, b) => point.distanceTo(a.point).compareTo(point.distanceTo(b.point)),
|
|
);
|
|
return sorted;
|
|
}
|
|
|
|
/// Convenience for the region default when no place is active.
|
|
GeoPoint defaultCentreOf(RegionConfig region) => region.map.center;
|