Files
Europa/Nuvolari/app/lib/features/places/saved_place.dart
T
Alby96andClaude Opus 5 06ab816ebe Add saved places and optional device location
A saved place is a named point the user keeps: it frames the map now, and once
the worker publishes station data it is what the nearest-station readings and,
later, the rain notifications will hang off. Free points rather than stations,
because people think in terms of home and work, not in terms of which weather
station happens to represent them.

Everything stays on the device. Places live in SharedPreferences under a
versioned key, and there is no account to attach them to and no server that
would accept them. That is what keeps the Data safety declaration able to say
no location is collected, and it must survive the notification work: the device
will subscribe to the topic for the cell containing a place, so the link
between a person and a place never leaves their phone.

Location is coarse only, and that took enforcing. geolocator declares
ACCESS_FINE_LOCATION in its own manifest and the merger pulls it in, so the
system dialog offered "Precise" despite the app asking for nothing of the sort;
the manifest now removes it with tools:node="remove", and the dialog reads
"approximate location" with no choice offered. Requests also go through the
platform LocationManager rather than the Play Services fused provider, which
prompts about Location Accuracy and, when declined, returns no fix at all —
an absurd outcome for an app that only ever wanted an approximate one, and one
that also tied location to Play Services being present.

The prominent disclosure comes before the system dialog, as Play requires, and
is repeated in Settings so someone who already answered can still read what the
permission is for. Declining leaves the app fully usable.

Two more defects found by running it and by a test:

- MapLibreMap leaves cameraPosition null unless trackCameraPosition is set, so
  "save the map centre" silently saved the region default rather than what the
  user was looking at.
- Place ids came straight from the microsecond clock, so two places saved in
  the same microsecond shared an id and rename, remove and the duplicate-name
  check all acted on the wrong one. A test caught it on a fast machine.

Saving refuses points outside the region rather than accepting them: a place in
Rome would look like it worked and then show nothing forever.

Also corrects CLAUDE.md, which still said ARPA states no licence, and records
the ARPA realtime API there with the property that governs how it may be used —
it lags about 4.5 hours, so it is an observation archive and must never sit
next to 5-minute radar looking current.

Verified: analyze clean, 158 tests passing, and on the emulator the disclosure
precedes the system dialog, the dialog asks only for approximate location, a
place survives restart and reinstall, and tapping one moves the map onto it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-10 19:39:03 +02:00

121 lines
3.4 KiB
Dart

import '../../core/region/geo.dart';
/// A place the user has named and kept.
///
/// The anchor everything location-shaped hangs off: which part of the region the
/// radar map opens on, and — once the worker publishes them — which alert zone
/// and which rain cell the notifications for this place should follow.
///
/// A free point rather than a station: people think in terms of home and work,
/// not in terms of which weather station happens to represent them. The nearest
/// station is derived from the point when readings are shown, so the user can
/// always see how far away the measurement actually came from.
class SavedPlace {
const SavedPlace({
required this.id,
required this.name,
required this.point,
required this.createdAt,
});
factory SavedPlace.fromJson(Map<String, Object?> json) {
final id = json['id'];
final name = json['name'];
final longitude = json['lng'];
final latitude = json['lat'];
final createdAt = json['createdAt'];
if (id is! String || id.isEmpty) {
throw const FormatException('saved place id must be a non-empty string');
}
if (name is! String || name.isEmpty) {
throw const FormatException(
'saved place name must be a non-empty string',
);
}
if (longitude is! num || latitude is! num) {
throw const FormatException('saved place coordinates must be numbers');
}
if (createdAt is! int) {
throw const FormatException(
'saved place createdAt must be an epoch in ms',
);
}
return SavedPlace(
id: id,
name: name,
point: GeoPoint(longitude.toDouble(), latitude.toDouble()),
createdAt: DateTime.fromMillisecondsSinceEpoch(createdAt, isUtc: true),
);
}
/// Longest name the UI will accept.
///
/// Not a storage limit — it keeps a name readable in the one-line list and in
/// a notification title, where a long string would simply be truncated
/// somewhere unhelpful.
static const int maxNameLength = 40;
final String id;
final String name;
final GeoPoint point;
final DateTime createdAt;
Map<String, Object?> toJson() => <String, Object?>{
'id': id,
'name': name,
'lng': point.longitude,
'lat': point.latitude,
'createdAt': createdAt.millisecondsSinceEpoch,
};
SavedPlace copyWith({String? name, GeoPoint? point}) => SavedPlace(
id: id,
name: name ?? this.name,
point: point ?? this.point,
createdAt: createdAt,
);
@override
String toString() => 'SavedPlace($id, $name, $point)';
@override
bool operator ==(Object other) =>
other is SavedPlace &&
other.id == id &&
other.name == name &&
other.point == point &&
other.createdAt == createdAt;
@override
int get hashCode => Object.hash(id, name, point, createdAt);
}
/// Why a place could not be saved.
///
/// Modelled rather than returned as a bare bool so the UI can say which rule was
/// broken instead of a generic failure.
enum SavedPlaceRejection {
/// The name was empty or only whitespace.
emptyName,
/// The name exceeded [SavedPlace.maxNameLength].
nameTooLong,
/// The point lies outside the region the app has data for.
outsideRegion,
/// Another saved place already uses that name.
duplicateName,
}
class SavedPlaceException implements Exception {
const SavedPlaceException(this.rejection);
final SavedPlaceRejection rejection;
@override
String toString() => 'SavedPlaceException(${rejection.name})';
}